[01:55:20] 10Multimedia, 10CirrusSearch, 10Discovery-Search, 10SDC Engineering, and 2 others: Placeholder text prompt for a caption shouldn't be inserted into the search index - https://phabricator.wikimedia.org/T213638 (10EBernhardson) There were less than 10k results, which is the amount i can pull in a single sear... [06:22:30] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Technical-Debt: User::leaveUserMessage() still in UploadFromUrlJob.php - https://phabricator.wikimedia.org/T48592 (10MaxSem) 05Open→03Resolved Neither `leaveUserMessage()` nor `UploadFromUrlJob` exist now. [09:07:06] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Depicts (Depicts-Crawling): [Beta] Alignment of Q numbers/Primary buttons are not to spec - https://phabricator.wikimedia.org/T218707 (10matthiasmullie) Is this a *big deal*? This is a little annoying because we're deal... [09:28:53] 10Multimedia, 10UploadWizard: UploadWizard populates the date field with the date and time when the file was modified instead of the date and time the photograph was taken on. - https://phabricator.wikimedia.org/T219357 (10JeanFred) [09:39:14] 10Multimedia, 10UploadWizard: UploadWizard populates the date field with the date and time when the file was modified instead of the date and time the photograph was taken on. - https://phabricator.wikimedia.org/T219357 (10JeanFred) [09:40:18] 10Multimedia, 10UploadWizard: UploadWizard populates the date field with the date and time when the file was modified instead of the date and time the photograph was taken on. - https://phabricator.wikimedia.org/T219357 (10JeanFred) (Auditing rEUWI, there does not seem to be any changes related to this… Tentat... [09:44:24] 10Multimedia, 10UploadWizard: UploadWizard populates the date field with the date and time when the file was modified instead of the date and time the photograph was taken on. - https://phabricator.wikimedia.org/T219357 (10JeanFred) 05Open→03Stalled This needs reproduction steps. [09:55:09] (03CR) 10Matthias Mullie: [C: 04-1] "eedback on code is pretty minor - just some cleanup, probably." (039 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [10:55:55] (03PS1) 10Matthias Mullie: Optimize formatValue for synchronous calls [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499443 [10:56:51] 10Multimedia, 10Discovery-Search, 10SDC General, 10Wikidata, and 2 others: Implement searching of 'depicts' on commons - https://phabricator.wikimedia.org/T191633 (10Cparle) Searching for 'depicts' statements using `haswbstatement` is already implemented. Traversing the tree of related statements is cove... [11:00:11] (03CR) 10Matthias Mullie: "Cparle: I suspect the blank metadata page may just be caused by slowness. A couple of API calls need to be performed, and... those are pre" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/471919 (https://phabricator.wikimedia.org/T215304) (owner: 10Matthias Mullie) [11:10:12] 10Multimedia, 10SDC General, 10Wikidata, 10Epic, and 2 others: Show/edit a limited set of qualifiers in DepictsWidget.js - https://phabricator.wikimedia.org/T215934 (10Cparle) [11:11:05] (03CR) 10Esanders: "You can use [].some and break with return true." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496770 (owner: 10Matthias Mullie) [11:11:32] (03PS23) 10Matthias Mullie: Add new metadata step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/471919 (https://phabricator.wikimedia.org/T217024) [11:11:33] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Walking): Add feature flag to enable/disable metadata step - https://phabricator.wikimedia.org/T217024 (10matthiasmullie) Also added ['captions'] and ['depicts'], to allow each of them to be turned on/off individually, in ad... [11:11:42] (03PS1) 10Esanders: Fix loop break using Array.some [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499445 (https://phabricator.wikimedia.org/T219331) [11:12:42] (03PS1) 10Esanders: Break loop using Array.some and return true [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499446 [11:13:37] (03PS2) 10Esanders: Break loop using Array.some and return true [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499446 [11:26:04] 10Multimedia, 10SDC Engineering: Assess depicts support for campaigns in UploadWizard - https://phabricator.wikimedia.org/T219368 (10Cparle) [11:47:26] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Depicts (Depicts-Crawling): [Beta] Alignment of Q numbers/Primary buttons are not to spec - https://phabricator.wikimedia.org/T218707 (10Ha78na) hey @matthiasmullie this bug is address in the CSS rewrite path. I use... [11:51:55] 10Multimedia, 10SDC Engineering: Assess basic depicts support for campaigns in UploadWizard - https://phabricator.wikimedia.org/T219368 (10Cparle) [11:55:07] 10Multimedia, 10SDC Engineering: Assess basic depicts support for campaigns in UploadWizard - https://phabricator.wikimedia.org/T219368 (10Cparle) [12:23:05] (03PS1) 10Esanders: Use ActionFieldLayout on Flickr upload form [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499459 [12:23:07] (03PS1) 10Esanders: Use jquery.spinner for file upload progress [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499460 [12:23:09] (03PS1) 10Esanders: Use upstream PHP/CSS spinner on loading page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499461 [12:25:25] 10Multimedia, 10SDC Engineering: Basic depicts support for campaigns in UploadWizard - https://phabricator.wikimedia.org/T219368 (10Cparle) [12:25:29] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Depicts (Depicts-Crawling): [Beta] Alignment of Q numbers/Primary buttons are not to spec - https://phabricator.wikimedia.org/T218707 (10matthiasmullie) Doesn't seem to work for me? (The dot dividers are still the same... [12:27:20] 10Multimedia, 10SDC Engineering: Basic depicts support for campaigns in UploadWizard - https://phabricator.wikimedia.org/T219368 (10Cparle) [12:30:13] (03CR) 10jerkins-bot: [V: 04-1] Use upstream PHP/CSS spinner on loading page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499461 (owner: 10Esanders) [12:30:36] (03CR) 10jerkins-bot: [V: 04-1] Use upstream PHP/CSS spinner on loading page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499461 (owner: 10Esanders) [12:38:32] (03CR) 10Matthias Mullie: [C: 04-1] Refactor panel styles to use LESS features, Flexbox (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [12:44:27] 10Multimedia, 10MediaWiki-DjVu: retrieveMetaData() in DjVuImage.php creates knock-on error when a page has invalid text layer - https://phabricator.wikimedia.org/T219376 (10Xover) [12:50:15] (03CR) 10Matthias Mullie: [C: 03+2] Break loop using Array.some and return true [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499446 (owner: 10Esanders) [12:50:26] 10Multimedia, 10SDC Engineering: Add data type to wbsearchentities - https://phabricator.wikimedia.org/T219378 (10Cparle) [12:57:02] (03PS24) 10Matthias Mullie: Add new metadata step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/471919 (https://phabricator.wikimedia.org/T219368) [12:59:04] 10Multimedia, 10UploadWizard: UploadWizard populates the date field with the date and time when the file was modified instead of the date and time the photograph was taken on. - https://phabricator.wikimedia.org/T219357 (10JeanFred) 05Stalled→03Open User:Basile Morin has provided the following examples: |... [12:59:27] 10Multimedia, 10MediaWiki-DjVu: retrieveMetaData() in DjVuImage.php creates knock-on error when a page has invalid text layer - https://phabricator.wikimedia.org/T219376 (10Xover) [13:08:57] (03PS25) 10Matthias Mullie: Add new metadata step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/471919 (https://phabricator.wikimedia.org/T216298) [13:09:03] (03Merged) 10jenkins-bot: Break loop using Array.some and return true [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499446 (owner: 10Esanders) [13:09:13] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Depicts (Depicts-Walking): [Alpha/Labs] Note CC0 license for all structured data on the new UploadWizard "Metadata" step - https://phabricator.wikimedia.org/T216298 (10matthiasmullie) [13:10:03] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC Engineering (Depicts-Walking), 10SDC-Depicts (Depicts-Walking): Implement submitting depicts statements via UploadWizard - https://phabricator.wikimedia.org/T217021 (10matthiasmullie) [13:10:06] 10Multimedia, 10UploadWizard, 10Multimedia-Current-Work, 10SDC Engineering (Depicts-Walking), 10SDC-Depicts (Depicts-Walking): Optimize formatValue in UploadWizard - https://phabricator.wikimedia.org/T217007 (10matthiasmullie) [13:12:20] (03PS2) 10Matthias Mullie: Optimize formatValue for synchronous calls [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499443 (https://phabricator.wikimedia.org/T217007) [13:12:28] 10Multimedia, 10UploadWizard, 10Multimedia-Current-Work, 10Patch-For-Review, and 2 others: Optimize formatValue in UploadWizard - https://phabricator.wikimedia.org/T217007 (10matthiasmullie) a:03matthiasmullie [13:13:45] (03CR) 10jenkins-bot: Break loop using Array.some and return true [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499446 (owner: 10Esanders) [13:15:38] 10Multimedia, 10UploadWizard, 10Multimedia-Current-Work, 10Patch-For-Review, and 2 others: Optimize formatValue in UploadWizard - https://phabricator.wikimedia.org/T217007 (10matthiasmullie) I decided to *not* optimize this in UploadWizard. Performing them ahead of time is overhead that we may not need (in... [13:16:13] 10Multimedia, 10SDC Engineering: Handle unsupported properties - https://phabricator.wikimedia.org/T219381 (10Cparle) [13:16:22] 10Multimedia, 10SDC Engineering: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10Cparle) [13:16:41] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Basic depicts support for campaigns in UploadWizard - https://phabricator.wikimedia.org/T219368 (10matthiasmullie) [13:17:07] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Basic depicts support for campaigns in UploadWizard - https://phabricator.wikimedia.org/T219368 (10matthiasmullie) a:03matthiasmullie [13:17:40] 10Multimedia, 10SDC General, 10UploadWizard, 10Wikidata, and 3 others: "Depicts walking": Add/edit depicts statements in UploadWizard - https://phabricator.wikimedia.org/T215304 (10matthiasmullie) a:03matthiasmullie [13:32:13] 10Multimedia, 10SDC Engineering: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10matthiasmullie) JS will not do anything right now: the depicts widget will only attach to the node with the depicts property id, everything else will be left alone. So right now, other... [13:33:07] 10Multimedia, 10SDC Engineering: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10Cparle) Ok great - move this into 'needs qa' then? [13:41:09] (03CR) 10Kosta Harlan: [C: 03+1] "Nice work!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [13:44:25] (03PS11) 10Ha78na: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [13:46:00] 10Multimedia, 10SDC Engineering: Allow editing of non-depicts statement block on File page - https://phabricator.wikimedia.org/T219382 (10Cparle) [13:47:48] 10Multimedia, 10SDC Engineering: UI for adding statement block on File page (Q-items only, no qualifiers) - https://phabricator.wikimedia.org/T219383 (10Cparle) [13:50:38] 10Multimedia, 10SDC Engineering: UI for adding statement block on File page (Q-items only, no qualifiers) - https://phabricator.wikimedia.org/T219383 (10Cparle) [13:58:20] 10Multimedia, 10SDC Engineering: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10matthiasmullie) Here's an example of an additional (non-depicts) statement: https://commons.wikimedia.beta.wmflabs.org/wiki/File:Photo_on_08-02-2019_at_16.35.jpg Yeah, let's move this... [13:58:36] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10matthiasmullie) [14:05:05] 10Multimedia, 10SDC Engineering: Add data type to wbsearchentities - https://phabricator.wikimedia.org/T219378 (10matthiasmullie) I believe `wbsearchentities` does return the datatype for `type=property`, but I don't think it is possible to filter the resultset on specific datatypes yet (except on the client,... [14:06:53] 10Multimedia, 10UploadWizard, 10Patch-For-Review: UploadWizard: EXIF DateTime takes prececence over DateTimeOriginal - https://phabricator.wikimedia.org/T219331 (10matthiasmullie) [14:06:54] (03CR) 10Matthias Mullie: [C: 03+2] Fix loop break using Array.some [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499445 (https://phabricator.wikimedia.org/T219331) (owner: 10Esanders) [14:06:56] 10Multimedia, 10UploadWizard: UploadWizard populates the date field with the date and time when the file was modified instead of the date and time the photograph was taken on. - https://phabricator.wikimedia.org/T219357 (10matthiasmullie) [14:18:51] (03CR) 10Pmiazga: [C: 03+1] Refactor Filepage module with require() statements and headless testing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [14:24:00] (03CR) 10Jdlrobson: [C: 03+1] "Yeh I agree Kosta that a one line install will make this easier. Maybe the three of us can work on that together." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [14:35:30] (03PS1) 10Esanders: UploadWizard: Use OO.ui.SelectFileWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 [14:41:11] (03CR) 10jerkins-bot: [V: 04-1] UploadWizard: Use OO.ui.SelectFileWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 (owner: 10Esanders) [14:50:31] (03Merged) 10jenkins-bot: Fix loop break using Array.some [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499445 (https://phabricator.wikimedia.org/T219331) (owner: 10Esanders) [14:54:38] (03CR) 10jenkins-bot: Fix loop break using Array.some [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499445 (https://phabricator.wikimedia.org/T219331) (owner: 10Esanders) [15:10:00] 10Multimedia, 10SDC Engineering: Add data type to wbsearchentities - https://phabricator.wikimedia.org/T219378 (10Cparle) Aha, so it does. Edited ticket description [15:26:56] 10Multimedia, 10SDC Engineering: Auto-suggest widget that returns P-items limited to 1 or more data types - https://phabricator.wikimedia.org/T219378 (10Cparle) [15:33:28] (03CR) 10Jforrester: [C: 03+2] Use ActionFieldLayout on Flickr upload form [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499459 (owner: 10Esanders) [15:35:37] (03CR) 10Jforrester: [C: 03+2] "Already used elsewhere in this repo. Ha." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499460 (owner: 10Esanders) [15:41:46] (03CR) 10Jforrester: Use upstream PHP/CSS spinner on loading page (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499461 (owner: 10Esanders) [15:42:52] (03Merged) 10jenkins-bot: Use ActionFieldLayout on Flickr upload form [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499459 (owner: 10Esanders) [15:44:02] 10Multimedia, 10SDC Engineering: UI for adding statement block on File page (Q-items only, no qualifiers) - https://phabricator.wikimedia.org/T219383 (10Cparle) [15:46:12] (03CR) 10jenkins-bot: Use ActionFieldLayout on Flickr upload form [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499459 (owner: 10Esanders) [15:49:49] (03Merged) 10jenkins-bot: Use jquery.spinner for file upload progress [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499460 (owner: 10Esanders) [15:51:46] 10Multimedia, 10SDC Engineering: UI for adding statements in UploadWizard (Q-items only, no qualifiers) - https://phabricator.wikimedia.org/T219407 (10Cparle) [15:53:00] (03CR) 10Jforrester: [C: 03+2] Optimize formatValue for synchronous calls [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499443 (https://phabricator.wikimedia.org/T217007) (owner: 10Matthias Mullie) [15:54:54] (03CR) 10Esanders: Use upstream PHP/CSS spinner on loading page (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499461 (owner: 10Esanders) [15:57:08] 10Multimedia, 10SDC Engineering: Basic Q-item statements (non-depicts) for campaigns - https://phabricator.wikimedia.org/T219408 (10Cparle) [15:57:20] (03CR) 10jenkins-bot: Use jquery.spinner for file upload progress [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499460 (owner: 10Esanders) [15:57:30] 10Multimedia, 10SDC Engineering: Basic Q-item statements (non-depicts) for campaigns - https://phabricator.wikimedia.org/T219408 (10Cparle) [15:58:17] (03CR) 10Ha78na: Refactor panel styles to use LESS features, Flexbox (037 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [15:58:45] 10Multimedia, 10SDC Engineering: Basic Q-item statements (non-depicts) for campaigns - https://phabricator.wikimedia.org/T219408 (10Cparle) [15:59:34] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Basic depicts support for campaigns in UploadWizard - https://phabricator.wikimedia.org/T219368 (10Cparle) [16:00:16] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Basic depicts support for campaigns in UploadWizard - https://phabricator.wikimedia.org/T219368 (10Cparle) [16:01:32] (03PS12) 10Ha78na: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [16:13:10] (03Merged) 10jenkins-bot: Optimize formatValue for synchronous calls [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499443 (https://phabricator.wikimedia.org/T217007) (owner: 10Matthias Mullie) [16:15:09] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 2 others: SDC: The tabs end up in the wrong place in "view" non-view pages like diffs - https://phabricator.wikimedia.org/T218922 (10Cparle) [16:15:31] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 2 others: SDC: The tabs end up in the wrong place in "view" non-view pages like diffs - https://phabricator.wikimedia.org/T218922 (10Cparle) a:05Cparle→03None [16:17:47] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 2 others: [Beta Commons] Auto-suggest dropdown for statements is too short - https://phabricator.wikimedia.org/T218629 (10Cparle) [16:18:41] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 2 others: [Beta Commons] Auto-suggest dropdown for statements is too short - https://phabricator.wikimedia.org/T218629 (10Cparle) @Ramsey-WMF I removed one of your acceptance criteria here - we have... [16:19:18] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 2 others: [Beta Commons] Auto-suggest dropdown for statements is too short - https://phabricator.wikimedia.org/T218629 (10Cparle) a:05Cparle→03None [16:22:25] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10Cparle) Hmm the display of that is a bit janky ... @PDrouin-WMF any thoughts? [16:26:33] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10Cparle) Moved back into 'doing' pending feedback from @PDrouin-WMF and @Ramsey-WMF [16:30:24] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Depicts (Depicts-Walking): Add feature flag to enable/disable metadata step - https://phabricator.wikimedia.org/T217024 (10Jdforrester-WMF) Feature flag is live in production config, disabled except for Beta Cluster. [16:32:18] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 2 others: [Beta Commons] Auto-suggest dropdown for statements is too short - https://phabricator.wikimedia.org/T218629 (10Cparle) a:03Edtadros [16:32:47] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 2 others: SDC: The tabs end up in the wrong place in "view" non-view pages like diffs - https://phabricator.wikimedia.org/T218922 (10Cparle) a:03Edtadros [16:48:28] (03PS17) 10Eric Gardner: Refactor Filepage module with require() statements and headless testing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) [16:49:13] (03CR) 10Eric Gardner: "Yeah, happy to work with you all on a follow-up, or to help if you are trying to use a similar approach in another project somewhere." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [16:56:35] 10Multimedia, 10Wikidata, 10Multimedia-Current-Work, 10SDC Engineering (Depicts-Crawling), 10SDC-Depicts (Depicts-Crawling): Enable federated access to entities and properties from Wikidata to Commons - https://phabricator.wikimedia.org/T214075 (10Jdforrester-WMF) Provisionally declaring this fixed. [17:02:02] (03CR) 10Eric Gardner: "I'm going to take another pass at this, and I'll follow Matthias' suggestion about breaking out another module that both Statements and Fi" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [17:03:52] matthiasmullie: Can I get you to upgrade your C+1 on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/494890 to a C+2? :-) [17:04:16] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): Something wrong with the 'you are not logged in' warning on beta - https://phabricator.wikimedia.org/T219422 (10Cparle) [17:04:55] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): Something wrong with the 'you are not logged in' warning on beta - https://phabricator.wikimedia.org/T219422 (10Jdforrester-WMF) Yes, see the existing ticket. Needs server-side parsing. [17:04:58] (03CR) 10Matthias Mullie: [C: 03+2] Drop temporary the MediaInfoEnable flag, now that initial deployment happened [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/494890 (owner: 10Jforrester) [17:05:02] absolutely [17:05:03] die, feature flag! [17:05:05] Thank you. :-) [17:06:20] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): Something wrong with the 'you are not logged in' warning on beta - https://phabricator.wikimedia.org/T219422 (10Jdforrester-WMF) [17:06:27] 10Multimedia, 10SDC Design, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work, 10Patch-For-Review: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10Jdforrester-WMF) [17:08:18] 10Multimedia, 10SDC Design, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work, 10Patch-For-Review: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10Jdforrester-WMF) No, still doing. [17:10:40] (03CR) 10Cparle: [C: 04-1] "I think there's something odd going on with captions ... -1ing just to make sure nobody merges it while I'm investigating" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [17:18:57] (03CR) 10Eric Gardner: "I had to work through a large merge conflict yesterday on account of how much things moved upstream during the CI breakage; it's possible " [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [17:26:04] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): Captions broken - https://phabricator.wikimedia.org/T219426 (10Cparle) [17:41:54] (03CR) 10jerkins-bot: [V: 04-1] Drop temporary the MediaInfoEnable flag, now that initial deployment happened [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/494890 (owner: 10Jforrester) [17:52:02] (03CR) 10Jforrester: [C: 03+2] "Bump …" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/494890 (owner: 10Jforrester) [17:58:12] (03PS1) 10Cparle: Trigger confirm when cancel button is clicked instead of in makeReadOnly() [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499553 (https://phabricator.wikimedia.org/T219426) [18:11:06] (03PS1) 10Jforrester: Follow-up I3c037a8bd, Iaeaae3ded: Parse `anoneditwarning` server-side [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499556 (https://phabricator.wikimedia.org/T218628) [18:34:40] (03Merged) 10jenkins-bot: Drop temporary the MediaInfoEnable flag, now that initial deployment happened [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/494890 (owner: 10Jforrester) [18:35:06] (03CR) 10Eric Gardner: "Are there other places in core or extensions where something similar happens? I imagine showing a notification with some rich text must be" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499556 (https://phabricator.wikimedia.org/T218628) (owner: 10Jforrester) [19:12:33] (03CR) 10Jforrester: "> Patch Set 1:" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499556 (https://phabricator.wikimedia.org/T218628) (owner: 10Jforrester) [19:20:15] (03CR) 10Eric Gardner: [C: 04-1] "The current state of this patch fixes the original problem outlined in T219426." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499553 (https://phabricator.wikimedia.org/T219426) (owner: 10Cparle) [19:51:52] (03CR) 10Ha78na: [C: 03+2] Trigger confirm when cancel button is clicked instead of in makeReadOnly() [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499553 (https://phabricator.wikimedia.org/T219426) (owner: 10Cparle) [19:55:06] (03CR) 10Ha78na: "We should merge this change- I also confirmed it fixes the problem breaking captions." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499553 (https://phabricator.wikimedia.org/T219426) (owner: 10Cparle) [20:01:45] (03PS13) 10Ha78na: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [20:20:43] (03CR) 10jerkins-bot: [V: 04-1] Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [20:24:30] (03PS14) 10Ha78na: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [20:34:15] 10Multimedia: Revise Qualifier popover copy and layout - https://phabricator.wikimedia.org/T219447 (10PDrouin-WMF) [20:50:59] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work, 10Patch-For-Review, and 2 others: The panels should use column width (60%) instead of spanning across the entire screen - https://phabricator.wikimedia.org/T216772 (10PDrouin-WMF) @Ha78na a few more CSS adjustments need to be made regarding spacing/hei... [21:20:08] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Depicts (Depicts-Crawling): [Beta] Alignment of Q numbers/Primary buttons are not to spec - https://phabricator.wikimedia.org/T218707 (10Ha78na) @matthiasmullie Thanks for calling this out. I've implemented an initial... [21:21:12] 10Multimedia, 10Commons, 10MediaWiki-File-management: $wgForeignFileRepos' ForeignAPIRepo class fetches files from more than one foreign file repo - https://phabricator.wikimedia.org/T190165 (10Kghbln) Hmm, since the fetching of descriptions is working [[ https://sandbox.semantic-mediawiki.org/wiki/ForeignFi... [21:23:50] 10Multimedia, 10Commons, 10MediaWiki-File-management: $wgForeignFileRepos' ForeignAPIRepo class fetches files from more than one foreign file repo - https://phabricator.wikimedia.org/T190165 (10Kghbln) [21:23:54] 10Multimedia, 10Commons, 10MediaWiki-File-management: Files which come from ForeignAPIRepo and are also foreign on the upstream wiki break thumbnailing and file description pages - https://phabricator.wikimedia.org/T190168 (10Kghbln) [21:25:13] 10Multimedia, 10Commons, 10MediaWiki-File-management: Files which come from ForeignAPIRepo and are also foreign on the upstream wiki break thumbnailing and file description pages - https://phabricator.wikimedia.org/T190168 (10Kghbln) [21:25:17] 10Multimedia, 10Commons, 10MediaWiki-File-management: $wgForeignFileRepos' ForeignAPIRepo class fetches files from more than one foreign file repo - https://phabricator.wikimedia.org/T190165 (10Kghbln) [21:25:50] 10Multimedia, 10Commons, 10MediaWiki-File-management: Files which come from ForeignAPIRepo and are also foreign on the upstream wiki break thumbnailing and file description pages - https://phabricator.wikimedia.org/T190168 (10Kghbln) 05duplicate→03Open p:05Triage→03Low [21:25:58] (03CR) 10Ha78na: [C: 03+2] Trigger confirm when cancel button is clicked instead of in makeReadOnly() [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499553 (https://phabricator.wikimedia.org/T219426) (owner: 10Cparle) [21:26:50] 10Multimedia, 10Commons, 10MediaWiki-File-management: Files which come from ForeignAPIRepo and are also foreign on the upstream wiki break thumbnailing and file description pages - https://phabricator.wikimedia.org/T190168 (10Kghbln) Sorry, I obviously have no clue how Phabricator works. :( [21:42:27] (03CR) 10Eric Gardner: [C: 03+2] "I'm going to file a separate ticket for the apparent disappearance of the alert dialog in response to the `onunload` event when the user h" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499553 (https://phabricator.wikimedia.org/T219426) (owner: 10Cparle) [21:44:57] (03Merged) 10jenkins-bot: Trigger confirm when cancel button is clicked instead of in makeReadOnly() [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499553 (https://phabricator.wikimedia.org/T219426) (owner: 10Cparle) [21:49:16] 10Multimedia, 10Commons, 10MediaWiki-File-management: $wgForeignFileRepos' ForeignAPIRepo class fetches files from more than one foreign file repo - https://phabricator.wikimedia.org/T190165 (10Tgr) You can, it will just behave weirdly if the other foreign repo also uses InstantCommons. [21:51:11] 10Multimedia, 10Multimedia-Current-Work: User is not asked to confirm before leaving page with unsaved edits in Depicts or Captions fields - https://phabricator.wikimedia.org/T219458 (10egardner) [21:51:37] 10Multimedia, 10Commons, 10MediaWiki-File-management: $wgForeignFileRepos' ForeignAPIRepo class fetches files from more than one foreign file repo - https://phabricator.wikimedia.org/T190165 (10Kghbln) Ah, ok. Good to know. [21:59:44] 10Multimedia, 10SDC Design, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 3 others: Match the spacings and paddings with the design spec - https://phabricator.wikimedia.org/T216773 (10Ha78na) Another update from design. {F28489250} [22:12:21] (03PS1) 10Smalyshev: Fix import [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499668 [22:15:00] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): Captions broken - https://phabricator.wikimedia.org/T219426 (10Jdforrester-WMF) [22:15:06] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): Captions broken - https://phabricator.wikimedia.org/T219426 (10Jdforrester-WMF) a:03Cparle [22:28:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499650 (owner: 10L10n-bot) [22:35:42] (03CR) 10Jforrester: [C: 03+2] Fix import [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499668 (owner: 10Smalyshev) [22:40:18] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): SDC: The tabs end up in the wrong place in "view" non-view pages like diffs - https://phabricator.wikimedia.org/T218922 (10Jdforrester-WMF) [22:43:29] 10Multimedia, 10SDC Engineering, 10Wikidata, 10Wikidata-Campsite, and 2 others: Federated remote entities in diffs show as deleted - https://phabricator.wikimedia.org/T218921 (10Jdforrester-WMF) >>! In T218921#5057104, @WMDE-leszek wrote: >>>! In T218921#5055949, @Jdforrester-WMF wrote: >> Update: I tried... [22:55:02] (03Merged) 10jenkins-bot: Fix import [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499668 (owner: 10Smalyshev) [23:13:25] (03PS18) 10Eric Gardner: Refactor Filepage module with require() statements and headless testing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) [23:16:45] (03PS15) 10Ha78na: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [23:17:52] (03CR) 10Eric Gardner: "The bug Cormac found seems to have been unrelated to the work in this patch. Unfortunately, the same problem had already made its way onto" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [23:21:00] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): Captions broken - https://phabricator.wikimedia.org/T219426 (10Ha78na) For posterity: this bug was regression caused by T219197 which had recently merged. We luckily... [23:25:45] (03CR) 10Ha78na: Refactor panel styles to use LESS features, Flexbox (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner)