[00:01:00] (03CR) 10jerkins-bot: [V: 04-1] Drop B/C 'primary' CSS classes, cache will have expired [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499023 (owner: 10Jforrester) [00:05:49] (03CR) 10jerkins-bot: [V: 04-1] i18n: Change "Office" to "Documents" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499027 (https://phabricator.wikimedia.org/T219245) (owner: 10Jforrester) [01:25:17] (03PS2) 10Ha78na: Add close confirm alert when canceling un-saved SDC content [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499004 (https://phabricator.wikimedia.org/T219197) [01:26:09] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Show "changes you made may not be saved" alert for structured data fields - https://phabricator.wikimedia.org/T219197 (10Ha78na) Done! thanks [01:34:57] (03CR) 10jerkins-bot: [V: 04-1] Add close confirm alert when canceling un-saved SDC content [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499004 (https://phabricator.wikimedia.org/T219197) (owner: 10Ha78na) [08:57:25] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499113 (owner: 10L10n-bot) [09:36:23] (03CR) 10Cparle: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499020 (https://phabricator.wikimedia.org/T219244) (owner: 10Jforrester) [09:37:33] 10Multimedia, 10SDC Engineering, 10Wikidata, 10Wikidata-Campsite, and 2 others: Federated remote entities in diffs show as deleted - https://phabricator.wikimedia.org/T218921 (10WMDE-leszek) >>! In T218921#5055949, @Jdforrester-WMF wrote: > Update: I tried disabling "old style" federation, and it immediate... [09:45:52] (03CR) 10jerkins-bot: [V: 04-1] i18n: Change "Make primary" to "Mark as prominent" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499020 (https://phabricator.wikimedia.org/T219244) (owner: 10Jforrester) [09:52:01] (03PS2) 10Matthias Mullie: i18n: Change "Office" to "Documents" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499027 (https://phabricator.wikimedia.org/T219245) (owner: 10Jforrester) [09:52:06] (03CR) 10Matthias Mullie: [C: 03+2] i18n: Change "Office" to "Documents" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499027 (https://phabricator.wikimedia.org/T219245) (owner: 10Jforrester) [09:59:50] (03PS22) 10Matthias Mullie: Add new metadata step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/471919 (https://phabricator.wikimedia.org/T215304) [10:01:55] (03CR) 10jerkins-bot: [V: 04-1] i18n: Change "Office" to "Documents" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499027 (https://phabricator.wikimedia.org/T219245) (owner: 10Jforrester) [10:02:35] (03CR) 10jerkins-bot: [V: 04-1] i18n: Change "Office" to "Documents" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499027 (https://phabricator.wikimedia.org/T219245) (owner: 10Jforrester) [10:07:28] 10Multimedia, 10SDC Engineering, 10WikibaseMediaInfo: SDC file page rendering is broken for logged-out users on beta cluster - https://phabricator.wikimedia.org/T219221 (10Cparle) a:03Cparle [10:47:25] (03CR) 10Matthias Mullie: [C: 03+1] i18n: Change "Make primary" to "Mark as prominent" (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499020 (https://phabricator.wikimedia.org/T219244) (owner: 10Jforrester) [12:09:21] (03CR) 10D3r1ck01: [C: 03+2] "Repoking Jenkins per +2 from Matthias" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499027 (https://phabricator.wikimedia.org/T219245) (owner: 10Jforrester) [12:20:37] (03CR) 10jerkins-bot: [V: 04-1] i18n: Change "Office" to "Documents" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499027 (https://phabricator.wikimedia.org/T219245) (owner: 10Jforrester) [12:28:36] (03CR) 10D3r1ck01: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499027 (https://phabricator.wikimedia.org/T219245) (owner: 10Jforrester) [12:36:22] (03PS1) 10Matthias Mullie: Output some data to help debug T219221 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499180 (https://phabricator.wikimedia.org/T219221) [12:42:16] (03CR) 10jerkins-bot: [V: 04-1] Output some data to help debug T219221 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499180 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [12:44:11] (03CR) 10jerkins-bot: [V: 04-1] i18n: Change "Office" to "Documents" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499027 (https://phabricator.wikimedia.org/T219245) (owner: 10Jforrester) [12:49:36] (03PS2) 10Matthias Mullie: Output some data to help debug T219221 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499180 (https://phabricator.wikimedia.org/T219221) [12:54:20] (03CR) 10jerkins-bot: [V: 04-1] Output some data to help debug T219221 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499180 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [12:57:05] (03PS3) 10Matthias Mullie: Output some data to help debug T219221 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499180 (https://phabricator.wikimedia.org/T219221) [12:57:58] (03CR) 10Cparle: [C: 03+2] Output some data to help debug T219221 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499180 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [13:06:34] (03CR) 10jerkins-bot: [V: 04-1] Output some data to help debug T219221 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499180 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [13:07:30] (03CR) 10Matthias Mullie: [V: 03+2] Output some data to help debug T219221 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499180 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [13:31:33] (03PS1) 10Matthias Mullie: Revert "Output some data to help debug T219221" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499190 [13:32:14] (03CR) 10Matthias Mullie: [V: 03+2 C: 03+2] Revert "Output some data to help debug T219221" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499190 (owner: 10Matthias Mullie) [13:35:52] (03PS1) 10Matthias Mullie: Output some data to help debug T219221 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499192 (https://phabricator.wikimedia.org/T219221) [13:36:50] (03CR) 10Cparle: [V: 03+2 C: 03+2] Output some data to help debug T219221 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499192 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [14:01:42] (03CR) 10Ha78na: "This is ready for review. I think we can ship what we have now." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [14:02:26] (03PS1) 10Matthias Mullie: Revert "Output some data to help debug T219221" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499202 [14:02:34] (03CR) 10Matthias Mullie: [V: 03+2 C: 03+2] Revert "Output some data to help debug T219221" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499202 (owner: 10Matthias Mullie) [14:18:05] (03CR) 10Ha78na: Refactor Filepage module with require() statements and headless testing (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [14:31:12] (03CR) 10Ha78na: [C: 03+2] Disable adding new statements while they're being submitted [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498868 (https://phabricator.wikimedia.org/T219151) (owner: 10Matthias Mullie) [14:34:49] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Depicts (Depicts-Crawling): Change "Make primary" to "Mark as prominent" - https://phabricator.wikimedia.org/T219244 (10Ha78na) a:03Jdforrester-WMF [14:35:30] 10Multimedia, 10SDC Engineering, 10Wikidata, 10Core Platform Team (MCR), and 2 others: Make undo work with multiple slots. - https://phabricator.wikimedia.org/T189808 (10kchapman) [14:42:00] 10Multimedia, 10OOUI, 10SDC Engineering: Add new OOUI classes to php demos - https://phabricator.wikimedia.org/T217584 (10Ha78na) Is this ticket complete? seems like it could be closed. [14:43:42] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Depicts (Depicts-Crawling): Change "Make primary" to "Mark as prominent" - https://phabricator.wikimedia.org/T219244 (10PDrouin-WMF) @Jdforrester-WMF just a little note to retain the check mark when a statement is deeme... [14:44:36] (03CR) 10jerkins-bot: [V: 04-1] Disable adding new statements while they're being submitted [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498868 (https://phabricator.wikimedia.org/T219151) (owner: 10Matthias Mullie) [14:48:48] 10Multimedia, 10SDC Engineering: Improvements to the Captions mobile experience - https://phabricator.wikimedia.org/T215818 (10Ha78na) Hey! Several of these changes we got for free with the recent CSS design refactor. That work will be visible on mobile production once any of T216773, T216772, or T218707 move... [14:50:02] (03PS1) 10Matthias Mullie: More robust way of extracting nodes from DOM [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499213 (https://phabricator.wikimedia.org/T219221) [14:50:29] (03CR) 10Matthias Mullie: [C: 04-1] More robust way of extracting nodes from DOM [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499213 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [14:56:20] (03Abandoned) 10Zfilipin: WIP The first sample Selenium test in Node.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/492710 (https://phabricator.wikimedia.org/T214480) (owner: 10Zfilipin) [15:00:53] (03PS1) 10Matthias Mullie: Correct extraction of content for tabs [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499217 (https://phabricator.wikimedia.org/T219221) [15:01:41] 10Multimedia, 10SDC Engineering: Improvements to the Captions mobile experience - https://phabricator.wikimedia.org/T215818 (10PDrouin-WMF) The improvements are wonderful, but I would still like to see the trashcans above the input lines, that way the input field is lengthened a little more. (Input field shoul... [15:04:22] (03CR) 10Matthias Mullie: [C: 04-1] "Will probably abandon in favor of Ie82e6abb1b676f9dd869fb68be48e9807107951a, because this one probably extracts less than we want" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499213 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [15:06:37] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Walking): Add feature flag to enable/disable metadata step - https://phabricator.wikimedia.org/T217024 (10matthiasmullie) a:03matthiasmullie [15:07:05] 10Multimedia, 10SDC Engineering: Improvements to the Captions mobile experience - https://phabricator.wikimedia.org/T215818 (10Ha78na) [15:09:34] (03CR) 10jerkins-bot: [V: 04-1] More robust way of extracting nodes from DOM [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499213 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [15:10:05] 10Multimedia, 10SDC Engineering, 10OOUI (OOUI-0.31.0): Add new OOUI classes to php demos - https://phabricator.wikimedia.org/T217584 (10Jdforrester-WMF) 05Open→03Resolved a:03Esanders Sorry, yes. [15:10:10] 10Multimedia, 10SDC Engineering: Improvements to the Captions mobile experience - https://phabricator.wikimedia.org/T215818 (10Ha78na) Sounds good! So remaining work is to adjust the trash can. I've updated the description to reflect this. [15:17:18] (03CR) 10jerkins-bot: [V: 04-1] Correct extraction of content for tabs [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499217 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [15:20:26] cormacparle_, matthiasmullie - I see you're working on the bug on beta, how's it coming? [15:21:03] centralauth injects some stuff in output [15:21:15] Aha [15:21:22] jus verifying Matthias's fix ... [15:21:31] which causes our extract-content-for-tabs regex to trip up [15:21:47] it's been rather annoying to debug... :) [15:21:58] No kidding [15:23:10] Was it a recent change? [15:23:22] The regex for the tabs was new this week, yes. [15:23:28] 10Multimedia, 10CommRel-Specialists-Support, 10SDC General, 10Wikidata: First feature suite for Structured Data on Commons blog post - https://phabricator.wikimedia.org/T205484 (10Elitre) So... was this related to 213553 or not? :) [15:23:36] Oh, it wasn't a CA change that triggered this [15:23:53] No, we collectively didn't notice it before it was merged, I guess. [15:23:55] OK, got it. Good to know we've figured it out mostly at least [15:24:09] Of course, given CI is broken for us because of WikibaseLexeme, we can't merge any fixes right now. [15:24:18] Good to know it's not a train blocker. ;-( [15:24:24] Even our blockers have blockers! [15:24:33] * James_F waves a stick. [15:24:37] We're *that good* [15:28:00] (03PS2) 10Jforrester: Correct extraction of content for tabs [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499217 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [15:32:03] Also looks like there's a patch up to fix the CI failures [15:32:20] Maybe today *will* be a good day, after all! :D [15:34:52] (03CR) 10Jforrester: i18n: Change "Make primary" to "Mark as prominent" (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499020 (https://phabricator.wikimedia.org/T219244) (owner: 10Jforrester) [15:46:17] (03PS3) 10Matthias Mullie: Correct extraction of content for tabs [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499217 (https://phabricator.wikimedia.org/T219221) [15:47:04] (03CR) 10Matthias Mullie: [C: 03+2] "Lol alright" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499020 (https://phabricator.wikimedia.org/T219244) (owner: 10Jforrester) [15:47:07] (03CR) 10jerkins-bot: [V: 04-1] Correct extraction of content for tabs [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499217 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [15:48:01] (03PS4) 10Matthias Mullie: Correct extraction of content for tabs [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499217 (https://phabricator.wikimedia.org/T219221) [15:57:01] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Top-to-bottom order of primary/prominent depicts values should change on publish - https://phabricator.wikimedia.org/T219292 (10Ramsey-WMF) [15:57:03] (03CR) 10jerkins-bot: [V: 04-1] i18n: Change "Make primary" to "Mark as prominent" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499020 (https://phabricator.wikimedia.org/T219244) (owner: 10Jforrester) [15:58:06] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Top-to-bottom order of primary/prominent depicts values should change on publish - https://phabricator.wikimedia.org/T219292 (10Ramsey-WMF) p:05Triage→03Normal [15:59:26] 10Multimedia, 10SDC Engineering, 10WikibaseMediaInfo, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), and 2 others: SDC file page rendering is broken for logged-out users on beta cluster - https://phabricator.wikimedia.org/T219221 (10matthiasmullie) [16:03:53] (03CR) 10jerkins-bot: [V: 04-1] Correct extraction of content for tabs [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499217 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [16:23:12] 10Multimedia, 10SDC Engineering, 10SDC-Depicts (Depicts-Walking): [Alpha/Labs] Note CC0 license for all structured data on the new UploadWizard "Metadata" step - https://phabricator.wikimedia.org/T216298 (10Ramsey-WMF) [16:34:09] 10Multimedia, 10SDC Engineering: Create feature flag to hide non-depicts statements - https://phabricator.wikimedia.org/T219299 (10Cparle) [16:34:36] 10Multimedia, 10SDC Engineering, 10SDC-Depicts (Depicts-and-Other-Statements-on-a-Bicycle): Create feature flag to hide non-depicts statements - https://phabricator.wikimedia.org/T219299 (10Cparle) [16:44:50] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-File-management, 10Core Platform Team (Decoupling (CDP2)): Untangle MediaHandler, FileRepo, File, Title and Linker - https://phabricator.wikimedia.org/T208786 (10CCicalese_WMF) [16:47:37] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Decoupling (CDP2)), and 3 others: Phase out deprecated Title::isValidMoveTarget - https://phabricator.wikimedia.org/T214317 (10CCicalese_WMF) [16:48:00] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-File-management, 10Core Platform Team (Decoupling (CDP2)): Replace usage of Title with usage of LinkTarget in Linker - https://phabricator.wikimedia.org/T214318 (10CCicalese_WMF) [16:48:24] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-File-management, 10Core Platform Team (Decoupling (CDP2)): Replace usage of Title with usage of LinkTarget in File - https://phabricator.wikimedia.org/T214319 (10CCicalese_WMF) [16:48:45] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-File-management, 10Core Platform Team (Decoupling (CDP2)): Create a value-only interface alternative to the File class - https://phabricator.wikimedia.org/T214321 (10CCicalese_WMF) [16:49:50] 10Multimedia, 10SDC Engineering, 10SDC-Depicts (Depicts-and-Other-Statements-on-a-Bicycle): Create feature flag to hide non-depicts statements - https://phabricator.wikimedia.org/T219299 (10Cparle) 05Open→03Invalid [16:51:57] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Decoupling (CDP2)), and 4 others: Remove unused method Title::validateFileMoveOperation - https://phabricator.wikimedia.org/T214316 (10CCicalese_WMF) [17:19:19] (03CR) 10Cparle: [C: 03+1] "+1-ing this for now, because the code is fine and it works. Will merge whenever CI feels better" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499217 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [17:28:14] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Top-to-bottom order of primary/prominent depicts values should change on publish - https://phabricator.wikimedia.org/T219292 (10Ramsey-WMF) @Ha78na , Mark suggested you might want to take a stab at this one :) [17:28:58] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Top-to-bottom order of primary/prominent depicts values should change on publish - https://phabricator.wikimedia.org/T219292 (10Ramsey-WMF) [17:53:48] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Top-to-bottom order of primary/prominent depicts values should change on publish - https://phabricator.wikimedia.org/T219292 (10Ha78na) a:03Ha78na [18:20:56] (03CR) 10Jforrester: [V: 03+2 C: 03+2] "Let's just land this." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499217 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [18:21:02] (03PS5) 10Jforrester: Correct extraction of content for tabs [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499217 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [18:21:07] (03CR) 10Jforrester: [V: 03+2 C: 03+2] Correct extraction of content for tabs [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499217 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [18:21:27] (03Abandoned) 10Jforrester: More robust way of extracting nodes from DOM [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499213 (https://phabricator.wikimedia.org/T219221) (owner: 10Matthias Mullie) [18:21:46] 10Multimedia, 10CirrusSearch, 10Discovery-Search, 10SDC Engineering, and 2 others: Placeholder text prompt for a caption shouldn't be inserted into the search index - https://phabricator.wikimedia.org/T213638 (10Ramsey-WMF) As of today we've still got about 9800 files remaining with this problem. Do we nee... [18:21:53] (03CR) 10Jforrester: [C: 04-2] Drop B/C 'primary' CSS classes, cache will have expired [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499023 (owner: 10Jforrester) [18:22:55] (03PS3) 10Jforrester: Warn anonymous editing users that their IP will be logged [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498986 (https://phabricator.wikimedia.org/T218628) (owner: 10Eric Gardner) [18:26:58] 10Multimedia, 10SDC General, 10CommRel-Specialists-Support (Jan-Mar-2019): Community Relations support for the depicts statement SDC release - https://phabricator.wikimedia.org/T213764 (10Keegan) Testing page https://commons.wikimedia.org/wiki/Commons:Structured_data/Get_involved/Feedback_requests/Depicts_t... [18:39:10] (03CR) 10jerkins-bot: [V: 04-1] Warn anonymous editing users that their IP will be logged [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498986 (https://phabricator.wikimedia.org/T218628) (owner: 10Eric Gardner) [19:01:56] (03CR) 10Eric Gardner: [C: 03+1] "Looks good to me – I like that you pulled out the logic of determining whether or not something has changes into a new method. Would be go" (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499004 (https://phabricator.wikimedia.org/T219197) (owner: 10Ha78na) [19:15:00] (03PS14) 10Eric Gardner: Refactor Filepage module with require() statements and headless testing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) [19:15:48] (03CR) 10Eric Gardner: Refactor Filepage module with require() statements and headless testing (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [19:25:32] (03CR) 10jerkins-bot: [V: 04-1] Refactor Filepage module with require() statements and headless testing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [19:26:00] (03CR) 10Ha78na: [C: 03+1] "Thanks for adding further documentation. Excited to start writing (much much much easier) tests." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [19:33:17] (03CR) 10Jdlrobson: "Let me know if you need help with getting those Special:JavaScript tests passing. Am happy to help you work those out and they will block " [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [19:36:16] (03CR) 10Eric Gardner: "Thanks, Jon – I think the problem is coming from this: https://phabricator.wikimedia.org/T219134" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [19:39:04] 10Multimedia, 10CirrusSearch, 10Discovery-Search, 10SDC Engineering, and 2 others: Placeholder text prompt for a caption shouldn't be inserted into the search index - https://phabricator.wikimedia.org/T213638 (10Jdforrester-WMF) Well, the first one I found actually is that text – the user must have copy-pa... [19:44:17] (03PS3) 10Ha78na: Add close confirm alert when canceling un-saved SDC content [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499004 (https://phabricator.wikimedia.org/T219197) [19:52:57] 10Multimedia, 10SDC Engineering, 10WikibaseMediaInfo, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work: SDC file page rendering is broken for logged-out users on beta cluster - https://phabricator.wikimedia.org/T219221 (10Jdforrester-WMF) 05Open→03Resolved This is confirmed fixe... [19:53:51] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499020 (https://phabricator.wikimedia.org/T219244) (owner: 10Jforrester) [19:54:24] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499027 (https://phabricator.wikimedia.org/T219245) (owner: 10Jforrester) [19:54:31] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498868 (https://phabricator.wikimedia.org/T219151) (owner: 10Matthias Mullie) [19:54:38] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498986 (https://phabricator.wikimedia.org/T218628) (owner: 10Eric Gardner) [19:55:17] (03CR) 10Jforrester: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [19:56:20] (03CR) 10Eric Gardner: [C: 03+2] Add close confirm alert when canceling un-saved SDC content [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499004 (https://phabricator.wikimedia.org/T219197) (owner: 10Ha78na) [20:04:53] (03CR) 10Eric Gardner: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [20:15:27] (03CR) 10jerkins-bot: [V: 04-1] Refactor Filepage module with require() statements and headless testing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [20:19:38] (03CR) 10Eric Gardner: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498986 (https://phabricator.wikimedia.org/T218628) (owner: 10Eric Gardner) [20:33:34] (03CR) 10jerkins-bot: [V: 04-1] i18n: Change "Make primary" to "Mark as prominent" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499020 (https://phabricator.wikimedia.org/T219244) (owner: 10Jforrester) [20:38:42] (03CR) 10Jforrester: [C: 03+2] "*sighs*" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499020 (https://phabricator.wikimedia.org/T219244) (owner: 10Jforrester) [20:51:12] (03Merged) 10jenkins-bot: i18n: Change "Office" to "Documents" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499027 (https://phabricator.wikimedia.org/T219245) (owner: 10Jforrester) [20:52:04] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Change "Office" in the new Commons search bar drop down to "Documents" - https://phabricator.wikimedia.org/T219245 (10Jdforrester-WMF) a:05matthiasmullie→03Jdforrester-WMF [21:00:26] (03CR) 10jerkins-bot: [V: 04-1] Disable adding new statements while they're being submitted [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498868 (https://phabricator.wikimedia.org/T219151) (owner: 10Matthias Mullie) [21:00:55] 10Multimedia, 10CirrusSearch, 10Discovery-Search, 10SDC Engineering, and 2 others: Placeholder text prompt for a caption shouldn't be inserted into the search index - https://phabricator.wikimedia.org/T213638 (10EBernhardson) The process that reindexes all pages was broken initially, it was fixed in https:... [21:02:34] 10Multimedia, 10CirrusSearch, 10Discovery-Search, 10SDC Engineering, and 2 others: Placeholder text prompt for a caption shouldn't be inserted into the search index - https://phabricator.wikimedia.org/T213638 (10EBernhardson) >>! In T213638#5059697, @Jdforrester-WMF wrote: > Well, the first one I found act... [21:22:54] (03Merged) 10jenkins-bot: Warn anonymous editing users that their IP will be logged [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498986 (https://phabricator.wikimedia.org/T218628) (owner: 10Eric Gardner) [21:22:57] (03Merged) 10jenkins-bot: Add close confirm alert when canceling un-saved SDC content [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499004 (https://phabricator.wikimedia.org/T219197) (owner: 10Ha78na) [21:25:22] 10Multimedia, 10Commons, 10MediaWiki-extensions-MultimediaViewer, 10SDC General, and 4 others: License in Gallery view does not account for multiple (and sometime conflicting) licenses e.g. {{Licensed-PD-Art}} or {{Licensed-PD}} - https://phabricator.wikimedia.org/T156370 (10LGoto) 05Open→03Resolved a:... [21:43:10] (03CR) 10Bartosz Dziewoński: "-1" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496459 (owner: 10Esanders) [21:43:39] (03Merged) 10jenkins-bot: i18n: Change "Make primary" to "Mark as prominent" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499020 (https://phabricator.wikimedia.org/T219244) (owner: 10Jforrester) [21:45:36] 10Multimedia, 10UploadWizard: UploadWizard: EXIF DateTime takes prececence over DateTimeOriginal - https://phabricator.wikimedia.org/T219331 (10matmarex) [21:45:43] (03CR) 10Bartosz Dziewoński: "Filed T219331" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496459 (owner: 10Esanders) [22:12:10] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): Change "Make primary" to "Mark as prominent" - https://phabricator.wikimedia.org/T219244 (10Jdforrester-WMF) Done, on Beta Cluster. Will roll out next week. {F284758... [22:12:52] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498868 (https://phabricator.wikimedia.org/T219151) (owner: 10Matthias Mullie) [22:17:03] (03PS1) 10Jforrester: Follow-up I3c037a8bd: Parse `anoneditwarning`; it contains rich content [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499342 (https://phabricator.wikimedia.org/T218628) [22:20:24] (03CR) 10Eric Gardner: [C: 03+2] "It's funny, I tried adding `parse()` locally and the message didn't load; when I removed the parse call things loaded properly. Not sure w" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499342 (https://phabricator.wikimedia.org/T218628) (owner: 10Jforrester) [22:21:43] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work: Show "changes you made may not be saved" alert for structured data fields - https://phabricator.wikimedia.org/T219197 (10Jdforrester-WMF) Yup, working as expected (uses the browser native control, we ca... [22:22:38] (03CR) 10Jforrester: "We may need to get it fully rendered server-side, sadly; MW's messages system is complicated to deal with a lot of edge cases." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499342 (https://phabricator.wikimedia.org/T218628) (owner: 10Jforrester) [22:23:33] (03CR) 10Jforrester: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499021 (owner: 10Jforrester) [22:23:45] (03CR) 10Jforrester: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499022 (owner: 10Jforrester) [22:27:23] (03Abandoned) 10Jforrester: HACK: EntityLookupElement: Have the dropdown use the whole content div as overlay [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498291 (https://phabricator.wikimedia.org/T218629) (owner: 10Jforrester) [22:32:14] 10Multimedia, 10MediaWiki-Uploading, 10Patch-For-Review, 10Wikimedia-production-error: Upload failed with fatal error: Call to load() on a non-object in UploadBase.php - https://phabricator.wikimedia.org/T208539 (10Umherirrender) ` // Check if the uploaded file is sane if ( $this->mParams['chunk'] ) {... [22:34:21] (03PS15) 10Eric Gardner: Refactor Filepage module with require() statements and headless testing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) [22:36:45] (03CR) 10Eric Gardner: [C: 03+1] Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [22:42:26] (03Merged) 10jenkins-bot: Disable adding new statements while they're being submitted [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498868 (https://phabricator.wikimedia.org/T219151) (owner: 10Matthias Mullie) [22:45:07] (03Merged) 10jenkins-bot: Follow-up I3c037a8bd: Parse `anoneditwarning`; it contains rich content [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499342 (https://phabricator.wikimedia.org/T218628) (owner: 10Jforrester) [23:10:24] (03PS16) 10Eric Gardner: Refactor Filepage module with require() statements and headless testing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) [23:23:51] (03CR) 10Jdlrobson: [C: 03+1] "Am excited to see how you find this! Thanks for taking the lead here!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [23:35:59] (03CR) 10Jforrester: "Eurgh, yeah, we're going to have to farm the render off to server-side MW." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499342 (https://phabricator.wikimedia.org/T218628) (owner: 10Jforrester) [23:40:07] (03CR) 10Jforrester: [C: 03+1] "Couple of minor issues, but let's get this landed." (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [23:48:23] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): Depicts form incorrect state - https://phabricator.wikimedia.org/T219151 (10Jdforrester-WMF) LGTM.