[00:43:00] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 2 others: [Beta Commons] Auto-suggest dropdown for statements is too short - https://phabricator.wikimedia.org/T218629 (10Ramsey-WMF) @Cparle I looked at this on Test Commons and found the following... [01:12:47] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 2 others: [Beta Commons] Auto-suggest dropdown for statements is too short - https://phabricator.wikimedia.org/T218629 (10Jdforrester-WMF) This is happening because the drop-down is trying to fit it... [01:14:18] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 2 others: [Beta Commons] Auto-suggest dropdown for statements is too short - https://phabricator.wikimedia.org/T218629 (10Jdforrester-WMF) //e.g.// when the container is tall enough (because it has... [01:21:02] (03PS1) 10Jforrester: EntityLookupElement: Separate alias from label with a word separator [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498285 [01:47:59] 10Multimedia, 10UploadWizard: Add API action to get UploadWizard campaign info - https://phabricator.wikimedia.org/T38915 (10Liuxinyu970226) [01:48:14] 10Multimedia, 10GlobalUsage, 10MediaWiki-API: add wiki filter to prop=globalusage - https://phabricator.wikimedia.org/T34776 (10Liuxinyu970226) [01:48:19] 10Multimedia, 10GlobalUsage, 10MediaWiki-API: Implement 'dir' for prop=globalusage - https://phabricator.wikimedia.org/T34402 (10Liuxinyu970226) [01:58:35] (03PS1) 10Jforrester: HACK: EntityLookupElement: Have the dropdown use the whole content div as overlay [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498291 (https://phabricator.wikimedia.org/T218629) [11:28:13] (03PS1) 10Cparle: Deal with cached pages with newer placeholder tags missing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498349 [11:48:34] (03PS2) 10Cparle: Deal with cached pages with newer placeholder tags missing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498349 [12:11:26] (03CR) 10Matthias Mullie: [C: 03+2] Deal with cached pages with newer placeholder tags missing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498349 (owner: 10Cparle) [12:13:40] (03CR) 10Matthias Mullie: [C: 03+2] Deal with cached pages with newer placeholder tags missing (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498349 (owner: 10Cparle) [12:26:03] (03PS1) 10Matthias Mullie: Remove $wgMediaInfoEnableFilePageDepicts and code for its false path [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498361 [12:26:33] (03CR) 10Matthias Mullie: [C: 04-1] Remove $wgMediaInfoEnableFilePageDepicts and code for its false path [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498361 (owner: 10Matthias Mullie) [12:31:38] (03CR) 10jerkins-bot: [V: 04-1] Remove $wgMediaInfoEnableFilePageDepicts and code for its false path [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498361 (owner: 10Matthias Mullie) [12:34:16] (03PS2) 10Matthias Mullie: Remove $wgMediaInfoEnableFilePageDepicts and code for its false path [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498361 [12:34:39] (03CR) 10Matthias Mullie: [C: 04-1] Remove $wgMediaInfoEnableFilePageDepicts and code for its false path [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498361 (owner: 10Matthias Mullie) [12:38:33] (03Merged) 10jenkins-bot: Deal with cached pages with newer placeholder tags missing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498349 (owner: 10Cparle) [12:39:57] (03CR) 10jerkins-bot: [V: 04-1] Remove $wgMediaInfoEnableFilePageDepicts and code for its false path [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498361 (owner: 10Matthias Mullie) [13:02:00] (03CR) 10Matthias Mullie: [C: 03+2] EntityLookupElement: Separate alias from label with a word separator [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498285 (owner: 10Jforrester) [13:16:12] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 2 others: [Beta Commons] Auto-suggest dropdown for statements is too short - https://phabricator.wikimedia.org/T218629 (10matthiasmullie) @Ramsey: this is not yet fixed on testcommons because that h... [13:23:26] (03Merged) 10jenkins-bot: EntityLookupElement: Separate alias from label with a word separator [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498285 (owner: 10Jforrester) [13:27:20] (03PS3) 10Matthias Mullie: Remove $wgMediaInfoEnableFilePageDepicts and code for its false path [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498361 [13:41:11] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 2 others: [Beta Commons] Auto-suggest dropdown for statements is too short - https://phabricator.wikimedia.org/T218629 (10Cparle) erm ... @Jdforrester-WMF not sure we really need your patch, unless... [14:27:24] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work, 10Patch-For-Review, and 2 others: The panels should use column width (60%) instead of spanning across the entire screen - https://phabricator.wikimedia.org/T216772 (10Ha78na) @PDrouin-WMF I'm going to now combine my work onto this patchset as well - I... [14:30:05] (03CR) 10Cparle: [C: 03+1] "Looks good to me (once Stephen's comments are addressed)" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [14:35:10] (03Abandoned) 10Ha78na: Styling adjustments on captions and statements tabs [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/497835 (https://phabricator.wikimedia.org/T216773) (owner: 10Ha78na) [14:38:27] (03CR) 10Matthias Mullie: [C: 04-1] Remove $wgMediaInfoEnableFilePageDepicts and code for its false path [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498361 (owner: 10Matthias Mullie) [14:42:32] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 2 others: [Beta Commons] Auto-suggest dropdown for statements is too short - https://phabricator.wikimedia.org/T218629 (10egardner) If more work needs to be done here beyond what is already in the p... [15:14:29] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): SDC: The tabs end up in the wrong place in "view" non-view pages like diffs - https://phabricator.wikimedia.org/T218922 (10Cparle) Note also that the tabs don't work properly on old versions of the page ... [16:11:04] (03PS1) 10Cparle: Adjust display to cater for diff and historical pages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498415 (https://phabricator.wikimedia.org/T218922) [16:12:03] (03CR) 10Cparle: "Patchset 1 moves the tabs to the right place, but clicking on them doesn't work. Still working on it" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498415 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [16:26:08] (03PS2) 10Cparle: Adjust display to cater for diff and historical pages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498415 (https://phabricator.wikimedia.org/T218922) [16:27:04] (03CR) 10Cparle: "should work properly now ..." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498415 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [16:28:09] (03PS3) 10Cparle: Adjust display to cater for diff and historical pages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498415 (https://phabricator.wikimedia.org/T218922) [16:41:14] (03CR) 10Jforrester: [C: 03+2] Adjust display to cater for diff and historical pages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498415 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [16:44:20] (03PS5) 10Jforrester: Drop temporary the MediaInfoEnable flag, now that initial deployment happened [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/494890 [16:48:59] (03CR) 10jerkins-bot: [V: 04-1] Adjust display to cater for diff and historical pages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498415 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [16:52:09] 10Multimedia, 10SDC Engineering, 10Wikidata, 10Wikidata-Campsite, 10SDC-Depicts (Depicts-Crawling): Federated remote entities in diffs show as deleted - https://phabricator.wikimedia.org/T218921 (10Addshore) I am suspect that this was caused by enabling the OLD style of federation on commons in https://g... [16:54:57] 10Multimedia, 10SDC Engineering, 10Wikidata, 10Wikidata-Campsite, 10SDC-Depicts (Depicts-Crawling): Federated remote entities in diffs show as deleted - https://phabricator.wikimedia.org/T218921 (10Addshore) Wait, i think I was hitting an in browser cache.... [16:56:10] 10Multimedia, 10SDC Engineering, 10UploadWizard: Use OOUI SelectFileWidget on UploadWizard - https://phabricator.wikimedia.org/T218407 (10Jdforrester-WMF) [16:57:54] 10Multimedia, 10SDC Engineering, 10Wikidata, 10Wikidata-Campsite, 10SDC-Depicts (Depicts-Crawling): Federated remote entities in diffs show as deleted - https://phabricator.wikimedia.org/T218921 (10Addshore) Yes, I was getting 304s without realizing it. So I dont think this should happen when we move to... [16:59:18] (03CR) 10jerkins-bot: [V: 04-1] Adjust display to cater for diff and historical pages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498415 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [17:02:57] (03PS4) 10Jforrester: Adjust display to cater for diff and historical pages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498415 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [17:03:11] (03CR) 10Jforrester: [C: 03+2] Adjust display to cater for diff and historical pages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498415 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [17:21:34] (03Merged) 10jenkins-bot: Adjust display to cater for diff and historical pages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498415 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [18:22:39] 10Multimedia, 10CommRel-Specialists-Support, 10SDC General, 10Wikidata: First feature suite for Structured Data on Commons blog post - https://phabricator.wikimedia.org/T205484 (10Keegan) [18:24:13] 10Multimedia, 10SDC General, 10CommRel-Specialists-Support (Jan-Mar-2019): Community Relations support for the depicts statement SDC release - https://phabricator.wikimedia.org/T213764 (10Keegan) Help page is started here: https://www.mediawiki.org/wiki/Help:File_statements Glossary is started here: https:/... [19:08:46] (03PS2) 10Ha78na: WIP: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [19:20:31] 10Multimedia, 10MediaWiki-Uploading, 10UI-Standardization, 10Patch-For-Review: Convert Special:Upload to OOUI - https://phabricator.wikimedia.org/T213040 (10Jdforrester-WMF) [19:26:52] (03CR) 10jerkins-bot: [V: 04-1] WIP: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [19:41:59] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Make button placement for Captions consistent with Depicts/statements - https://phabricator.wikimedia.org/T218951 (10Ramsey-WMF) p:05Triage→03Low [20:05:54] (03PS1) 10Jayprakash12345: User getText() instead of getNativeData() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/498471 [20:07:52] (03Abandoned) 10Jayprakash12345: User getText() instead of getNativeData() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/498471 (owner: 10Jayprakash12345) [21:10:53] (03PS3) 10Eric Gardner: WIP: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) [21:20:04] (03CR) 10jerkins-bot: [V: 04-1] WIP: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [21:37:05] (03PS4) 10Eric Gardner: WIP: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) [21:46:22] (03CR) 10jerkins-bot: [V: 04-1] WIP: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [21:53:19] (03PS5) 10Eric Gardner: WIP: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) [22:03:27] (03CR) 10jerkins-bot: [V: 04-1] WIP: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [22:21:48] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Make button placement for Captions consistent with Depicts/statements - https://phabricator.wikimedia.org/T218951 (10egardner) In order to make this change, the JS code which controls this UI element in the Captions panel will need to be split up –... [22:47:56] (03CR) 10Eric Gardner: Refactor Filepage module with require() statements and headless testing (0310 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [22:50:05] (03PS12) 10Eric Gardner: Refactor Filepage module with require() statements and headless testing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) [22:52:53] (03CR) 10Eric Gardner: "Uploaded the (hopefully) final version of this patch. I tried to address all lingering comments and I've updated the modules inside of Fil" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [23:00:41] (03CR) 10jerkins-bot: [V: 04-1] Refactor Filepage module with require() statements and headless testing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [23:01:34] (03CR) 10Eric Gardner: "Recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [23:12:13] (03CR) 10jerkins-bot: [V: 04-1] Refactor Filepage module with require() statements and headless testing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner)