[00:15:13] (03CR) 10Jforrester: Basic node setup for front-end unit testing (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [01:58:33] 10Multimedia, 10Wikidata, 10Wikidata-Campsite, 10Multimedia-Current-Work, and 3 others: Make sure federation works on beta - https://phabricator.wikimedia.org/T217157 (10Ramsey-WMF) @Cparle could use some test steps/acceptance criteria on this one, as it isn't immediately obvious :) [02:16:53] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC Engineering (Depicts-Crawling), 10SDC-Depicts (Depicts-Crawling): [Alpha/Labs] Add descriptive text used for depicts on UW to FP also - https://phabricator.wikimedia.org/T216757 (10Ramsey-WMF) [02:18:53] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC Engineering (Depicts-Crawling), 10SDC-Depicts (Depicts-Crawling): Add descriptive text used for depicts on UW to FP also - https://phabricator.wikimedia.org/T216757 (10Ramsey-WMF) [02:20:56] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC Engineering (Depicts-Crawling), 10SDC-Depicts (Depicts-Crawling): Add descriptive text used for depicts on UW to FP also - https://phabricator.wikimedia.org/T216757 (10Ramsey-WMF) Moving this **for now**, should check again when tabs are... [09:55:51] (03CR) 10Matthias Mullie: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/441040 (https://phabricator.wikimedia.org/T215936) (owner: 10Matthias Mullie) [09:55:57] (03CR) 10jerkins-bot: [V: 04-1] Search prototype [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/441040 (https://phabricator.wikimedia.org/T215936) (owner: 10Matthias Mullie) [09:59:21] (03PS62) 10Matthias Mullie: Search prototype [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/441040 (https://phabricator.wikimedia.org/T215936) [10:17:03] (03CR) 10jerkins-bot: [V: 04-1] Search prototype [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/441040 (https://phabricator.wikimedia.org/T215936) (owner: 10Matthias Mullie) [10:20:58] (03CR) 10Matthias Mullie: Tabify file information and structured data (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215645) (owner: 10Cparle) [10:21:05] (03PS7) 10Matthias Mullie: Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) (owner: 10Cparle) [10:21:33] (03CR) 10Matthias Mullie: "PS7 is just a rebase, and addresses 2 points of feedback - no other changes" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) (owner: 10Cparle) [10:38:42] (03CR) 10jerkins-bot: [V: 04-1] Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) (owner: 10Cparle) [10:48:23] (03PS8) 10Cparle: Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) [11:06:40] (03CR) 10jerkins-bot: [V: 04-1] Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) (owner: 10Cparle) [11:56:31] 10Multimedia, 10Wikidata, 10Wikidata-Campsite, 10Multimedia-Current-Work, and 3 others: Make sure federation works on beta - https://phabricator.wikimedia.org/T217157 (10Cparle) [11:58:56] (03CR) 10Cparle: [C: 03+2] "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495685 (https://phabricator.wikimedia.org/T217552) (owner: 10Ha78na) [11:59:03] (03CR) 10jerkins-bot: [V: 04-1] CC0 License acceptance uses single 'I agree' button [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495685 (https://phabricator.wikimedia.org/T217552) (owner: 10Ha78na) [12:02:13] (03PS4) 10Cparle: CC0 License acceptance uses single 'I agree' button [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495685 (https://phabricator.wikimedia.org/T217552) (owner: 10Ha78na) [12:16:57] (03PS5) 10Tchanders: Allow partially blocked users to access Special:UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494934 (https://phabricator.wikimedia.org/T217255) [12:20:04] (03CR) 10jerkins-bot: [V: 04-1] CC0 License acceptance uses single 'I agree' button [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495685 (https://phabricator.wikimedia.org/T217552) (owner: 10Ha78na) [12:21:32] (03CR) 10Cparle: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495685 (https://phabricator.wikimedia.org/T217552) (owner: 10Ha78na) [12:22:56] (03CR) 10jerkins-bot: [V: 04-1] Allow partially blocked users to access Special:UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494934 (https://phabricator.wikimedia.org/T217255) (owner: 10Tchanders) [12:40:35] (03CR) 10jerkins-bot: [V: 04-1] CC0 License acceptance uses single 'I agree' button [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495685 (https://phabricator.wikimedia.org/T217552) (owner: 10Ha78na) [12:42:16] (03PS9) 10Matthias Mullie: Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) (owner: 10Cparle) [12:47:04] (03CR) 10Cparle: Tabify file information and structured data (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) (owner: 10Cparle) [12:48:01] (03PS63) 10Matthias Mullie: Search prototype [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/441040 (https://phabricator.wikimedia.org/T215936) [12:49:10] (03PS10) 10Cparle: Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) [12:49:25] (03CR) 10Cparle: Tabify file information and structured data (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) (owner: 10Cparle) [12:51:13] (03CR) 10Matthias Mullie: "Note to self: during review, see how cached output may affect this" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) (owner: 10Cparle) [12:52:35] (03PS11) 10Cparle: Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) [13:05:28] (03CR) 10Matthias Mullie: [C: 03+2] Drop old wikibase.mediainfo.filepagestyles module [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/491472 (owner: 10Jforrester) [13:05:56] (03CR) 10Matthias Mullie: [C: 03+2] Stop setting a default value for MediaInfoProperties [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/494983 (owner: 10Jforrester) [13:10:24] (03CR) 10jerkins-bot: [V: 04-1] Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) (owner: 10Cparle) [13:11:57] 10Multimedia, 10Multimedia-Current-Work: CC0 licensing is duplicated in the UploadWizard when using a mobile browser - https://phabricator.wikimedia.org/T218156 (10matthiasmullie) a:03matthiasmullie [13:13:22] 10Multimedia, 10Multimedia-Current-Work: CC0 licensing is duplicated in the UploadWizard when using a mobile browser - https://phabricator.wikimedia.org/T218156 (10matthiasmullie) Might be incomplete cleanup in the details step, where some leftover html from the previous upload is not cleared out. I'll look in... [13:14:35] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC Engineering (Depicts-Crawling), 10SDC-Depicts (Depicts-Crawling): Add install/setup instructions to mw.org Extension:WikibaseMediaInfo - https://phabricator.wikimedia.org/T216678 (10matthiasmullie) 05Open→03Resolved LGTM! [13:15:14] (03CR) 10Matthias Mullie: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/495730 (https://phabricator.wikimedia.org/T217870) (owner: 10Ha78na) [13:21:27] (03CR) 10jerkins-bot: [V: 04-1] Update header text on UploadWizard CC0 notice [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/495730 (https://phabricator.wikimedia.org/T217870) (owner: 10Ha78na) [13:25:25] (03Merged) 10jenkins-bot: Drop old wikibase.mediainfo.filepagestyles module [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/491472 (owner: 10Jforrester) [13:27:16] (03CR) 10Matthias Mullie: Tabify file information and structured data (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) (owner: 10Cparle) [13:27:48] (03PS12) 10Matthias Mullie: Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) (owner: 10Cparle) [13:27:58] (03PS13) 10Matthias Mullie: Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) (owner: 10Cparle) [13:36:04] (03CR) 10jerkins-bot: [V: 04-1] Stop setting a default value for MediaInfoProperties [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/494983 (owner: 10Jforrester) [13:47:53] (03CR) 10jerkins-bot: [V: 04-1] Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) (owner: 10Cparle) [13:54:55] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC Engineering (Depicts-Crawling), 10SDC-Depicts (Depicts-Crawling): Add descriptive text used for depicts on UW to FP also - https://phabricator.wikimedia.org/T216757 (10PDrouin-WMF) 👍 [14:04:20] (03PS14) 10Matthias Mullie: Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215642) (owner: 10Cparle) [14:06:09] (03CR) 10Matthias Mullie: [C: 03+2] "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/494983 (owner: 10Jforrester) [14:10:48] (03CR) 10jerkins-bot: [V: 04-1] Stop setting a default value for MediaInfoProperties [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/494983 (owner: 10Jforrester) [14:26:09] (03Merged) 10jenkins-bot: Stop setting a default value for MediaInfoProperties [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/494983 (owner: 10Jforrester) [14:40:59] (03PS3) 10Esanders: eslint: Enable reportUnusedDisableDirectives & cache [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494043 [14:44:11] 10Multimedia, 10MobileFrontend, 10SDC Engineering, 10UploadWizard, 10Wikimedia-production-error (Shared Build Failure): Can't merge in master of UploadWizard; error thrown by MobileFrontend NearbyGateway.js _distanceMessage() test - https://phabricator.wikimedia.org/T218172 (10Tchanders) There's a simila... [14:47:15] (03CR) 10jerkins-bot: [V: 04-1] eslint: Enable reportUnusedDisableDirectives & cache [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494043 (owner: 10Esanders) [15:02:09] 10Multimedia, 10Commons, 10MediaWiki-Decoupling, 10MediaWiki-File-management, and 5 others: Remove unused method Title::validateFileMoveOperation - https://phabricator.wikimedia.org/T214316 (10CCicalese_WMF) [15:07:17] (03PS1) 10Esanders: build: Update eslint-config-wikimedia to 0.11.0 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496459 [15:08:46] (03CR) 10Ha78na: Search prototype (034 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/441040 (https://phabricator.wikimedia.org/T215936) (owner: 10Matthias Mullie) [15:13:48] (03CR) 10jerkins-bot: [V: 04-1] build: Update eslint-config-wikimedia to 0.11.0 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496459 (owner: 10Esanders) [15:17:58] 10Multimedia, 10MobileFrontend, 10SDC Engineering, 10UploadWizard, and 2 others: Can't merge in master of UploadWizard; error thrown by MobileFrontend NearbyGateway.js _distanceMessage() test - https://phabricator.wikimedia.org/T218172 (10Jdlrobson) [15:18:21] 10Multimedia, 10OOUI, 10SDC Engineering: Add new OOUI classes to php demos - https://phabricator.wikimedia.org/T217584 (10Jdforrester-WMF) [15:19:46] 10Multimedia, 10OOUI, 10MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), 10Multimedia-Current-Work, and 2 others: Factor out the hard-coded magic for knitting together the PHP and JS side of TabLayout as built for Special:Preferences so others can use it - https://phabricator.wikimedia.org/T215645 (10Jdforrester-... [15:21:09] (03PS64) 10Matthias Mullie: Search prototype [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/441040 (https://phabricator.wikimedia.org/T215936) [15:21:37] (03CR) 10Dbarratt: [C: 03+1] "I haven't tested this, but it looks good to me." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494934 (https://phabricator.wikimedia.org/T217255) (owner: 10Tchanders) [15:25:08] 10Multimedia, 10MobileFrontend, 10SDC Engineering, 10UploadWizard, and 2 others: Can't merge in master of UploadWizard; error thrown by MobileFrontend NearbyGateway.js _distanceMessage() test - https://phabricator.wikimedia.org/T218172 (10Jdlrobson) a:03Jdlrobson I'll see if I can replicate this. [15:26:32] (03CR) 10Matthias Mullie: Search prototype (033 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/441040 (https://phabricator.wikimedia.org/T215936) (owner: 10Matthias Mullie) [15:30:16] 10Multimedia, 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): Clicking on file page tab focuses first element in the tab content area - https://phabricator.wikimedia.org/T218312 (10PDrouin-WMF) [15:38:10] (03PS1) 10Esanders: Fix select file buttons alignment [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496466 [15:43:24] (03PS2) 10Jdlrobson: build: Update eslint-config-wikimedia to 0.11.0 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496459 (owner: 10Esanders) [15:43:45] (03PS6) 10Jdlrobson: Allow partially blocked users to access Special:UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494934 (https://phabricator.wikimedia.org/T217255) (owner: 10Tchanders) [15:45:24] (03CR) 10jerkins-bot: [V: 04-1] Fix select file buttons alignment [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496466 (owner: 10Esanders) [15:49:55] (03PS1) 10Esanders: Use lowercase for Flickr 'or' separator [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496470 [15:52:37] (03PS1) 10Esanders: Center drop shadow on thumbnails [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496471 [15:56:55] (03CR) 10jerkins-bot: [V: 04-1] Use lowercase for Flickr 'or' separator [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496470 (owner: 10Esanders) [15:57:56] (03CR) 10jerkins-bot: [V: 04-1] Allow partially blocked users to access Special:UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494934 (https://phabricator.wikimedia.org/T217255) (owner: 10Tchanders) [15:58:55] (03CR) 10Ha78na: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495685 (https://phabricator.wikimedia.org/T217552) (owner: 10Ha78na) [16:00:35] (03CR) 10Jdlrobson: [C: 04-1] "Looks like there's a legit phpunit test failure on this one." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494934 (https://phabricator.wikimedia.org/T217255) (owner: 10Tchanders) [16:03:59] (03CR) 10Cparle: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/495730 (https://phabricator.wikimedia.org/T217870) (owner: 10Ha78na) [16:05:10] (03CR) 10jerkins-bot: [V: 04-1] Center drop shadow on thumbnails [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496471 (owner: 10Esanders) [16:09:48] (03CR) 10Jforrester: [C: 03+2] build: Update eslint-config-wikimedia to 0.11.0 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496459 (owner: 10Esanders) [16:10:23] (03CR) 10Jforrester: [C: 03+2] Use lowercase for Flickr 'or' separator [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496470 (owner: 10Esanders) [16:11:18] (03CR) 10jerkins-bot: [V: 04-1] Allow partially blocked users to access Special:UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494934 (https://phabricator.wikimedia.org/T217255) (owner: 10Tchanders) [16:11:31] (03CR) 10Jforrester: [C: 03+2] Fix select file buttons alignment [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496466 (owner: 10Esanders) [16:11:47] (03CR) 10Jforrester: [C: 03+2] Center drop shadow on thumbnails [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496471 (owner: 10Esanders) [16:12:05] (03CR) 10jerkins-bot: [V: 04-1] Update header text on UploadWizard CC0 notice [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/495730 (https://phabricator.wikimedia.org/T217870) (owner: 10Ha78na) [16:12:08] (03CR) 10jerkins-bot: [V: 04-1] CC0 License acceptance uses single 'I agree' button [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495685 (https://phabricator.wikimedia.org/T217552) (owner: 10Ha78na) [16:15:09] :) [16:30:20] (03CR) 10Niedzielski: Basic node setup for front-end unit testing (0314 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [16:31:52] (03CR) 10Jdlrobson: Basic node setup for front-end unit testing (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [16:32:43] (03Merged) 10jenkins-bot: build: Update eslint-config-wikimedia to 0.11.0 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496459 (owner: 10Esanders) [16:33:54] 10Multimedia: Can't save after deleting a statement (and not doing anything else) - https://phabricator.wikimedia.org/T218318 (10Cparle) [16:34:48] (03PS2) 10Jdlrobson: Update header text on UploadWizard CC0 notice [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/495730 (https://phabricator.wikimedia.org/T217870) (owner: 10Ha78na) [16:35:10] (03PS4) 10Jdlrobson: eslint: Enable reportUnusedDisableDirectives & cache [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494043 (owner: 10Esanders) [16:36:20] (03CR) 10jenkins-bot: build: Update eslint-config-wikimedia to 0.11.0 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496459 (owner: 10Esanders) [16:41:33] (03Merged) 10jenkins-bot: Fix select file buttons alignment [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496466 (owner: 10Esanders) [16:42:06] (03Merged) 10jenkins-bot: Use lowercase for Flickr 'or' separator [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496470 (owner: 10Esanders) [16:45:23] (03CR) 10jenkins-bot: Fix select file buttons alignment [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496466 (owner: 10Esanders) [16:48:22] (03CR) 10jenkins-bot: Use lowercase for Flickr 'or' separator [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496470 (owner: 10Esanders) [16:52:06] (03CR) 10Jforrester: [C: 03+2] eslint: Enable reportUnusedDisableDirectives & cache [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494043 (owner: 10Esanders) [16:52:10] 10Multimedia, 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Patch-For-Review: Update docs for WikibaseMediaInfo - https://phabricator.wikimedia.org/T207289 (10Ha78na) 05Open→03Resolved This was completed awhile ago [16:52:39] (03Merged) 10jenkins-bot: Center drop shadow on thumbnails [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496471 (owner: 10Esanders) [16:55:55] (03CR) 10jenkins-bot: Center drop shadow on thumbnails [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496471 (owner: 10Esanders) [17:06:08] 10Multimedia, 10Multimedia-Current-Work: Can't save after deleting a statement (and not doing anything else) - https://phabricator.wikimedia.org/T218318 (10Ramsey-WMF) p:05Triage→03High Ooh this is a juicy one. Perhaps related to the "Publish Changes" work that @matthiasmullie did a while ago? (T216454) [17:09:37] (03Merged) 10jenkins-bot: eslint: Enable reportUnusedDisableDirectives & cache [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494043 (owner: 10Esanders) [17:13:01] 10Multimedia, 10Multimedia-Current-Work: Can't save after deleting a statement (and not doing anything else) - https://phabricator.wikimedia.org/T218318 (10matthiasmullie) Yeah, probably. Looks like just a simple typo at first sight. DepictsPanel.js has: `if ( changes.length > 0 || removals().length > 0 ) {`... [17:19:35] (03CR) 10jenkins-bot: eslint: Enable reportUnusedDisableDirectives & cache [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494043 (owner: 10Esanders) [17:45:20] 10Multimedia, 10MobileFrontend, 10SDC Engineering, 10UploadWizard, and 2 others: Can't merge in master of UploadWizard; error thrown by MobileFrontend NearbyGateway.js _distanceMessage() test - https://phabricator.wikimedia.org/T218172 (10Jdforrester-WMF) 05Open→03Resolved [17:52:20] 10Multimedia, 10Multimedia-Current-Work: Can't save after deleting a statement (and not doing anything else) - https://phabricator.wikimedia.org/T218318 (10Aklapper) Which software project is this about? Something SDC'ish? Tags welcome. :) [17:53:20] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Can't save after deleting a statement (and not doing anything else) - https://phabricator.wikimedia.org/T218318 (10Ramsey-WMF) Yup, I was just doing that :) >>! In T218318#5024932, @Aklapper wrote: > Which software project is this about? Something... [17:56:11] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): Clicking on file page tab focuses first element in the tab content area - https://phabricator.wikimedia.org/T218312 (10Ramsey-WMF) p:05Triage→03Normal [18:02:00] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC Engineering (Depicts-Crawling), 10SDC-Depicts (Depicts-Crawling): Change file pages to display content in tabs, with captions and the wikitext block in the first and statements in the second - https://phabricator.wikimedia.org/T215642 (10P... [18:15:33] 10Multimedia, 10Commons, 10Epic: Provide download statistics of files on Wikimedia Commons - https://phabricator.wikimedia.org/T218076 (10Ramsey-WMF) This is a tough one to solve and we've had some very preliminary discussions with Analytics on how to reasonably approximate this, but there's a lot of fundame... [18:16:35] (03CR) 10Cparle: [C: 03+2] Update header text on UploadWizard CC0 notice [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/495730 (https://phabricator.wikimedia.org/T217870) (owner: 10Ha78na) [18:30:48] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: CC0 licensing is duplicated in the UploadWizard when using a mobile browser - https://phabricator.wikimedia.org/T218156 (10Ramsey-WMF) [18:40:22] (03Merged) 10jenkins-bot: Update header text on UploadWizard CC0 notice [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/495730 (https://phabricator.wikimedia.org/T217870) (owner: 10Ha78na) [18:44:01] (03CR) 10jenkins-bot: Update header text on UploadWizard CC0 notice [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/495730 (https://phabricator.wikimedia.org/T217870) (owner: 10Ha78na) [18:45:48] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Can't save after deleting a statement (and not doing anything else) - https://phabricator.wikimedia.org/T218318 (10Ha78na) a:03Ha78na I can grab this -- I was just looking at this code actually since its the model for the captions button work i w... [18:51:38] (03PS7) 10Tchanders: Allow partially blocked users to access Special:UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494934 (https://phabricator.wikimedia.org/T217255) [18:52:03] (03PS5) 10Ha78na: CC0 License acceptance uses single 'I agree' button [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495685 (https://phabricator.wikimedia.org/T217552) [18:58:12] (03CR) 10jerkins-bot: [V: 04-1] Allow partially blocked users to access Special:UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494934 (https://phabricator.wikimedia.org/T217255) (owner: 10Tchanders) [19:18:12] (03PS8) 10Tchanders: Allow partially blocked users to access Special:UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494934 (https://phabricator.wikimedia.org/T217255) [19:28:21] (03CR) 10jerkins-bot: [V: 04-1] Allow partially blocked users to access Special:UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/494934 (https://phabricator.wikimedia.org/T217255) (owner: 10Tchanders) [19:29:56] (03PS1) 10Ha78na: Can't save after deleting a statement [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/496561 (https://phabricator.wikimedia.org/T218318) [20:04:12] (03CR) 10Eric Gardner: "I see that the search widget works by constructing a search URL with various params based on the selections the user makes in the UI, and " [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/441040 (https://phabricator.wikimedia.org/T215936) (owner: 10Matthias Mullie) [20:14:35] (03CR) 10Jforrester: "That'd do it. :-)" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/496561 (https://phabricator.wikimedia.org/T218318) (owner: 10Ha78na) [20:15:05] (03PS2) 10Jforrester: Let statements be still saved after deleting a statement [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/496561 (https://phabricator.wikimedia.org/T218318) (owner: 10Ha78na) [20:15:11] (03CR) 10Jforrester: [C: 03+2] Let statements be still saved after deleting a statement [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/496561 (https://phabricator.wikimedia.org/T218318) (owner: 10Ha78na) [20:17:16] (03CR) 10jerkins-bot: [V: 04-1] Let statements be still saved after deleting a statement [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/496561 (https://phabricator.wikimedia.org/T218318) (owner: 10Ha78na) [20:53:03] (03PS1) 10Umherirrender: Fix type of $tutorial in class UploadWizardTutorial [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496618 [22:07:12] (03CR) 10Jforrester: [C: 03+2] Fix type of $tutorial in class UploadWizardTutorial [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496618 (owner: 10Umherirrender) [23:07:07] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/496561 (https://phabricator.wikimedia.org/T218318) (owner: 10Ha78na) [23:57:06] (03Merged) 10jenkins-bot: Fix type of $tutorial in class UploadWizardTutorial [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/496618 (owner: 10Umherirrender)