[00:50:54] 10Multimedia, 10UploadWizard: UploadWizard: Detail screen stays empty, publishing not possible - https://phabricator.wikimedia.org/T202760 (10Ramsey-WMF) a:03matthiasmullie Assigning to Matthias for now unless @MarkTraceur wants to take it. [00:51:20] 10Multimedia, 10UploadWizard, 10Multimedia-Team-Working-Board: UploadWizard: Detail screen stays empty, publishing not possible - https://phabricator.wikimedia.org/T202760 (10Ramsey-WMF) [01:08:59] (03CR) 10Krinkle: [C: 031] "I've reviewed all the access changes, and confirmed that it seems save to remove the methods that were removed in MwEmbedSupport.js. The o" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454344 (owner: 10Jforrester) [03:43:07] (03PS43) 10Brion VIBBER: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [03:46:52] (03CR) 10jerkins-bot: [V: 04-1] Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [08:33:04] 10Multimedia, 10UploadWizard, 10Multimedia-Team-Working-Board: UploadWizard: Detail screen stays empty, publishing not possible - https://phabricator.wikimedia.org/T202760 (10Zache) Confirmed in fiwiki's WLM campaing too. [10:04:02] (03PS1) 10Matthias Mullie: Fix category multiwidget with default entries [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/455532 (https://phabricator.wikimedia.org/T202760) [12:17:38] 10Multimedia, 10TimedMediaHandler, 10VisualEditor, 10VisualEditor-MediaWiki, 10User-Ryasmeen: After adding a video using VE and save the page, the Play button is in the middle of the page - https://phabricator.wikimedia.org/T150978 (10Deskana) 05Open>03Resolved a:03Deskana I tried inserting a video... [13:47:21] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Thumbor, and 2 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10Gilles) p:05Triage>03Normal a:03Gilles [14:10:12] (03CR) 10Matthias Mullie: Fix Flickr uploads (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/449735 (https://phabricator.wikimedia.org/T183075) (owner: 10MarkTraceur) [14:14:38] (03PS2) 10Matthias Mullie: Fix category multiwidget with default entries [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/455532 (https://phabricator.wikimedia.org/T202760) [14:54:21] 10Multimedia, 10Structured-Data-Commons, 10Wikidata, 10Epic, 10Multimedia-Team-Working-Board: Display multi-lingual captions on File page using php - https://phabricator.wikimedia.org/T202896 (10Cparle) [14:56:40] 10Multimedia, 10Structured-Data-Commons, 10Wikidata, 10Epic, 10Multimedia-Team-Working-Board: Make multi-lingual captions on the File page editable using javascript - https://phabricator.wikimedia.org/T202897 (10Cparle) [15:18:27] (03CR) 10Jforrester: Move all ResourceLoader vars into the TMH namespace (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454344 (owner: 10Jforrester) [15:19:59] (03CR) 10Jforrester: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454345 (https://phabricator.wikimedia.org/T60082) (owner: 10Jforrester) [15:20:08] (03CR) 10Jforrester: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 (owner: 10Jforrester) [15:20:15] (03CR) 10Jforrester: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454921 (owner: 10Jforrester) [15:20:25] (03CR) 10Jforrester: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453172 (owner: 10Jforrester) [15:20:34] (03CR) 10jerkins-bot: [V: 04-1] Drop or inline some pointless config options [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454345 (https://phabricator.wikimedia.org/T60082) (owner: 10Jforrester) [15:20:38] (03CR) 10jerkins-bot: [V: 04-1] Scrap last remnants of NewMwEmbedResourceManager [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 (owner: 10Jforrester) [15:20:47] (03CR) 10jerkins-bot: [V: 04-1] ext.tmh.transcodetable: Fix deprecated dependency on mediawiki.api.edit [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454921 (owner: 10Jforrester) [15:20:50] (03CR) 10jerkins-bot: [V: 04-1] Drop secondary 'Mvpcf' skin for EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453172 (owner: 10Jforrester) [15:21:03] Hmm. [15:23:23] (03PS10) 10Jforrester: Move all ResourceLoader vars into the TMH namespace [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454344 [15:23:26] (03PS4) 10Jforrester: Kill mw.load pointless accessor [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454893 [15:23:29] (03PS9) 10Jforrester: Drop or inline some pointless config options [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454345 (https://phabricator.wikimedia.org/T60082) [15:23:32] (03PS9) 10Jforrester: Scrap last remnants of NewMwEmbedResourceManager [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 [15:23:35] (03PS4) 10Jforrester: ext.tmh.transcodetable: Fix deprecated dependency on mediawiki.api.edit [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454921 [15:23:38] (03PS4) 10Jforrester: Drop secondary 'Mvpcf' skin for EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453172 [16:03:03] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Thumbor, and 2 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10PhilipTerryGraham) p:05Normal>03High This is a fundamental flaw in the image system. It still hasn't been fixed, and in... [16:16:08] "cat, clowder" omg, it's true! with references from 2013 and 2015 [16:16:24] also glaring, pounce, or destruction [16:16:40] https://en.wikipedia.org/wiki/List_of_English_terms_of_venery,_by_animal#C [16:17:48] cats are typically solitary [16:18:14] so a collective noun for cats is even more bullshit than your usual collective noun [16:24:29] 10Multimedia, 10UploadWizard, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Multimedia-Team-Working-Board, 10Patch-For-Review: Selecting 'U.S. Federal Government' license erroneously also selects a Flickr license - https://phabricator.wikimedia.org/T201800 (10matthiasmullie) 05Open... [16:31:11] 10Multimedia, 10Structured-Data-Commons, 10Wikidata, 10Multimedia-Team-Working-Board: Metrics for search success on commons - https://phabricator.wikimedia.org/T196085 (10Cparle) See here for prior art on the subject https://meta.wikimedia.org/wiki/Research:Baseline_Metrics_for_Structured_Data_on_Wikimedia... [16:51:05] 10Multimedia, 10Structured-Data-Commons, 10Wikidata, 10Epic, and 2 others: Implement new File page design using OOUI - https://phabricator.wikimedia.org/T202287 (10Cparle) Note that the captions are expected to appear first on the page, see https://www.dropbox.com/s/kuv5d2gu3y7x430/Display%20caption%20on%2... [18:14:13] 10Multimedia, 10UploadWizard, 10Multimedia-Team-Working-Board, 10Patch-For-Review: UploadWizard: Detail screen stays empty, publishing not possible - https://phabricator.wikimedia.org/T202760 (10Ramsey-WMF) Great work so far. Any chance we can expedite releasing this fix, @MarkTraceur or @matthiasmullie ? [18:32:20] (03PS44) 10Brion VIBBER: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [18:37:59] brion: You could always just merge https://gerrit.wikimedia.org/r/454344 – what's the worst that could happen? ;-) [18:38:29] soon :D [18:39:20] * James_F grins. [18:44:28] (03CR) 10Brion VIBBER: [C: 032] Move all ResourceLoader vars into the TMH namespace [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454344 (owner: 10Jforrester) [18:44:34] loooooks good :D [18:57:35] c'mon jenkins! run those tests [18:57:43] run like the wind [19:06:22] * James_F grins. [19:06:45] Gate-and-submit is now down to "only" 13 patches. Half an hour ago it had 20. [19:06:52] uuuggggghhhhhh [19:07:00] Yeah. :-( [19:07:12] Not enough docker executor nodes. [19:07:25] * brion wanders off to make coffee while jenkins remains in holding pattern [19:43:53] if i'm reading correctly it might take another hour to reach the top of the queue? whafu [19:46:11] That's based on progress so far. Now there's no queue-jumping SWAT merges, it should move it a bit faster. [19:46:29] So I'd guess 45 minutes. [19:54:32] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Thumbor, and 2 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10Trlkly) It appears that "High" has been redefined to "currently working on." So then I must ask, how is one supposed to ind... [19:55:05] oh man remember those old titanium & aluminum G4 PowerBooks? https://www.flickr.com/photos/brionv/310032911 [19:55:30] i used to run mediawiki on that thing [19:55:39] 1 gigahertz [19:56:15] (03PS12) 10Zoranzoki21: Fix typos in code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) [20:08:03] Aww. [20:08:28] I have my father's old TiBook most disassembled in a box at his house. [20:09:28] :) [20:10:04] i kinda wish i'd kept them for nostalgia instead of ebaying them, but they probably helped somebody out while they still weren't quite obsolete that way :) [20:32:48] There we go. Merged after "only" 1.5 hours. [20:42:35] 10Multimedia, 10Commons, 10MediaWiki-Uploading, 10UploadWizard, 10media-storage: UploadWizard makes browsers stall - https://phabricator.wikimedia.org/T202366 (10C.Suthorn) does still not work. also with iOS. also with old upload form. [20:51:54] 10Multimedia, 10Commons, 10MediaWiki-File-management: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10Ahecht) Once this is resolved, is there any way to programmatically regenerate all PNG thumbnails created since the change to python-thumbor-wikimedia... [20:53:07] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Thumbor, and 2 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10Ahecht) Oops, I don't know how those projects got removed... [21:23:16] James_F: ha! found the breaks-your-login bug [21:23:20] hook was missing a return value [21:24:10] I thought we made that hook not require a return? [21:24:17] * James_F sighs. [21:25:13] (My vagrant test wiki is currently broken whilst I try to install Wikibase, sorry!) [21:28:35] hrm [21:28:50] the return value is discarded. so wwwwwhhhhhaaaaaaaaat is going on there and how does this fix work :D [21:30:18] brion: Let's not pull on that thread… ;-) [21:30:58] (…says the guy three hours into trying to get his Vagrant instance to have WikibaseMediaInfo.) [21:31:55] ugggh no that wasn't it, it's failing again for me [21:31:57] whatttttttt [21:32:12] maybe i just have a transient problem [21:32:29] i guess.... that's the problem with vagrant *ba-BUM* [21:32:37] I didn't try logging in, it might be a problem for me too. [21:43:57] brion: OK, finally got my vagrant box up enough to log in, and I managed to log in. [21:44:02] With PS10, that is. [21:46:14] James_F: do you have BetaFeatures enabled? [21:46:29] poking around I think it's the check for the user option that's spawning an extra session setup [21:46:47] Hmm. I do… [21:47:10] But I don't have videojs enabled, obviously. :-) Would make testing mwembed hard. [21:48:39] Moving all the RL modules to extension.json isn't possible until we land https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TimedMediaHandler/+/453172/ (only non-static one left), but it also feels a bit icky. [21:48:52] I suppose if we have to do that, then so be it. [21:49:41] also if you have a session cookie already you may have to delete it to get the bug :D [21:50:05] I cleared all cookies to test. [21:50:18] * James_F logs out and in again just in case. [21:52:26] Hmm, yeah, OK, this time I get it. [21:53:01] We're not doing anything differently here – the hook has moved file and lost a level of indirection, but it's still the same hook operating in the same way. [21:53:32] Was it previously only working by chance, and is actually causing a race condition? [21:56:02] no, it's definitely from the moved hook [21:56:56] I could do 453172 (drop second skin) first, then re-write this to be directly in extension.json, I suppose? [21:57:33] if we're ok with registering mwembed modules even when in non-mwembed mode that should be fine [21:57:48] yeah if i manually move the activePlayerMode() check back to register() it works again [21:58:08] order of operations in hook world is fun [21:58:19] It's not ideal (wikis we switch to videojs-only will have to pay the penalty of several dozen RL modules on every page load until we've converted all of prod) but it's not the end of the world. [21:58:30] heh [21:58:37] yeah and we'll kill it entirely soon enough [21:58:37] We could move it to be an extension registration function? [21:58:40] (Ewwwww.) [21:58:52] mwahahaha [22:01:32] (03CR) 10Brion VIBBER: "Ok, the RL module reg function is actually happening late, during output, and I think it's reinitializing the default empty session on top" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 (owner: 10Jforrester) [22:06:02] (03CR) 10Legoktm: "It's not possible to conditionally register modules depending upon the current user, because load.php, which obviously needs to know about" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 (owner: 10Jforrester) [22:07:30] (03CR) 10Brion VIBBER: "Ah, then we should definitely avoid being clever here, and just register all modules. The previous beta code may have been broken on produ" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 (owner: 10Jforrester) [22:40:16] (03CR) 10Legoktm: [C: 04-1] Fix typos in code (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [22:43:24] (03PS5) 10Jforrester: ext.tmh.transcodetable: Fix deprecated dependency on mediawiki.api.edit [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454921 [22:43:28] (03PS5) 10Jforrester: Drop secondary 'Mvpcf' skin for EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453172 [22:43:31] (03PS12) 10Jforrester: Scrap last remnants of NewMwEmbedResourceManager [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 [22:43:34] (03PS1) 10Jforrester: Drop ResourceLoaderRegisterModules, register all MwEmbed modules unconditionally [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455738 [22:43:57] brion: OK, so if https://gerrit.wikimedia.org/r/455738 works for you I can squash the last two together. [22:46:38] (03CR) 10Jforrester: "> Patch Set 11:" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 (owner: 10Jforrester) [22:51:07] (03PS13) 10Zoranzoki21: Fix typos in code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) [22:51:11] (03PS14) 10Zoranzoki21: Fix typos in code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) [22:51:27] (03CR) 10Zoranzoki21: Fix typos in code (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [22:57:37] (03PS13) 10Jforrester: Drop ResourceLoaderRegisterModules, scrap NewMwEmbedResourceManager [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 [22:58:00] (03Abandoned) 10Jforrester: Drop ResourceLoaderRegisterModules, register all MwEmbed modules unconditionally [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455738 (owner: 10Jforrester) [23:18:44] (03CR) 10Brion VIBBER: "TypeError: embedPlayer.skinName is undefined" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 (owner: 10Jforrester) [23:28:03] (03CR) 10jerkins-bot: [V: 04-1] Drop ResourceLoaderRegisterModules, scrap NewMwEmbedResourceManager [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 (owner: 10Jforrester)