[13:20:59] (03PS4) 10Reedy: Move simple module registration from hooks to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452965 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [13:21:17] (03CR) 10Reedy: [C: 031] "Definitely a lot more hooks that can be moved too in the future" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452965 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [15:40:28] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, 10Readers-Web-Backlog, and 3 others: Consolidate code for MediaViewer across desktop and mobile (tracking) - https://phabricator.wikimedia.org/T65504 (10Jdlrobson) a:05Jdlrobson>03None [15:51:29] 10Multimedia, 10Structured-Data-Commons, 10Wikidata, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Deploy WikibaseMediaInfo extension to production - https://phabricator.wikimedia.org/T159708 (10Addshore) [15:59:35] (03CR) 10Jforrester: [C: 032] Move simple module registration from hooks to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452965 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:00:53] (03PS5) 10Jforrester: NewMwEmbedResourceManager: Remove unused 'messageFile' option [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452973 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:00:57] (03CR) 10Jforrester: [C: 032] NewMwEmbedResourceManager: Remove unused 'messageFile' option [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452973 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:01:15] (03PS3) 10Jforrester: NewMwEmbedResourceManager: Remove indirection around module directories [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452974 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:02:10] (03CR) 10Jforrester: [C: 032] NewMwEmbedResourceManager: Remove indirection around module directories [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452974 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:02:23] (03PS3) 10Jforrester: NewMwEmbedResourceManager: Register 'mw.TimedText.loader' explicitly [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452978 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:02:50] (03CR) 10Jforrester: [C: 032] NewMwEmbedResourceManager: Register 'mw.TimedText.loader' explicitly [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452978 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:03:12] (03PS3) 10Jforrester: NewMwEmbedResourceManager: Remove discovery of '*.config.php' files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452987 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:03:20] (03CR) 10Jforrester: [C: 032] NewMwEmbedResourceManager: Remove discovery of '*.config.php' files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452987 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:03:27] (03PS4) 10Jforrester: NewMwEmbedResourceManager: Remove non-standard 'messageDir' option [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452993 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:05:16] (03CR) 10Jforrester: "Why not just do this statically, like we do for every other extension? It's "neat" but the indirection (even after your patch) doesn't rea" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452993 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:30:06] (03Merged) 10jenkins-bot: Move simple module registration from hooks to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452965 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:30:08] (03Merged) 10jenkins-bot: NewMwEmbedResourceManager: Remove unused 'messageFile' option [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452973 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:30:11] (03CR) 10jerkins-bot: [V: 04-1] NewMwEmbedResourceManager: Remove indirection around module directories [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452974 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:30:14] (03CR) 10jerkins-bot: [V: 04-1] NewMwEmbedResourceManager: Register 'mw.TimedText.loader' explicitly [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452978 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:30:17] (03CR) 10jerkins-bot: [V: 04-1] NewMwEmbedResourceManager: Remove discovery of '*.config.php' files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452987 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:35:55] (03CR) 10Jforrester: [C: 032] "…" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452974 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:42:01] (03CR) 10Krinkle: "Filed T202073" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452974 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:43:50] (03CR) 10Krinkle: "Yeah, I suppose that could be the next step. There's a few other references to globals in these files as well, so fully static won't be ea" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452993 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:53:39] (03Merged) 10jenkins-bot: NewMwEmbedResourceManager: Remove indirection around module directories [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452974 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [16:53:57] (03Merged) 10jenkins-bot: NewMwEmbedResourceManager: Register 'mw.TimedText.loader' explicitly [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452978 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [17:10:18] (03Merged) 10jenkins-bot: NewMwEmbedResourceManager: Remove discovery of '*.config.php' files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452987 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [17:21:04] (03PS1) 10Jforrester: Explicitly list modules' message keys, rather than compute them [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453167 [17:21:49] (03CR) 10Jforrester: [C: 032] NewMwEmbedResourceManager: Remove non-standard 'messageDir' option [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452993 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [17:23:04] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, 10Mobile, and 3 others: Consolidate code for MediaViewer across desktop and mobile (tracking) - https://phabricator.wikimedia.org/T65504 (10Jdlrobson) [17:24:20] (03PS2) 10Jforrester: Explicitly list modules' message keys, rather than compute them [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453167 [17:24:56] (03CR) 10Jforrester: Explicitly list modules' message keys, rather than compute them (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453167 (owner: 10Jforrester) [17:26:28] (03CR) 10Jforrester: "With this change, all of the MwEmbedModules/*/*.php files are static, I think. Still can't move them to extension.json without bloating pr" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453167 (owner: 10Jforrester) [17:29:00] 10Multimedia, 10Commons, 10MediaWiki-Database, 10MediaWiki-File-management: Searching on Special:Listfiles fails on MySQL due to invalid "LOWER(img_name)" query for binary field - https://phabricator.wikimedia.org/T29300 (10Krinkle) [17:31:17] 10Multimedia, 10Commons, 10MediaWiki-Database, 10MediaWiki-File-management: Searching on Special:Listfiles fails on MySQL due to invalid "LOWER(img_name)" query for binary field - https://phabricator.wikimedia.org/T29300 (10Krinkle) Note that the "search" feature of Special:ListFiles is disabled on wikis h... [17:31:49] 10Multimedia, 10Commons, 10MediaWiki-Database, 10MediaWiki-File-management: Searching on Special:Listfiles fails on MySQL due to invalid "LOWER(img_name)" query for binary field - https://phabricator.wikimedia.org/T29300 (10Krinkle) [17:35:39] (03CR) 10Krinkle: "I believe there's at least one $wg var used in one of the definitions still. But yeah, this change should remove the vast majority of star" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453167 (owner: 10Jforrester) [17:35:51] (03PS3) 10Krinkle: Explicitly list modules' message keys, rather than compute them [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453167 (https://phabricator.wikimedia.org/T202017) (owner: 10Jforrester) [17:41:20] (03Merged) 10jenkins-bot: NewMwEmbedResourceManager: Remove non-standard 'messageDir' option [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452993 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [17:55:40] (03PS1) 10Jforrester: Drop secondary 'Mvpcf' skin for EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453172 [17:56:11] (03CR) 10Jforrester: "> Patch Set 2:" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453167 (https://phabricator.wikimedia.org/T202017) (owner: 10Jforrester) [18:06:47] (03CR) 10Krinkle: "I was unable to verify with certainty that it isn't used. The config variable indeed is not used, which means the dependency is always on " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453172 (owner: 10Jforrester) [18:07:13] (03CR) 10Krinkle: "I'd opt to keep the files and registry, but only remove the confguration for the default dependency. Achieves the same goal, but keeps it " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453172 (owner: 10Jforrester) [18:07:53] (03CR) 10Jforrester: "> Patch Set 1:" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453172 (owner: 10Jforrester) [18:11:58] (03CR) 10Jforrester: [C: 04-1] Drop secondary 'Mvpcf' skin for EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453172 (owner: 10Jforrester) [18:26:43] (03CR) 10Krinkle: [C: 032] Explicitly list modules' message keys, rather than compute them [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453167 (https://phabricator.wikimedia.org/T202017) (owner: 10Jforrester) [18:43:22] (03Merged) 10jenkins-bot: Explicitly list modules' message keys, rather than compute them [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453167 (https://phabricator.wikimedia.org/T202017) (owner: 10Jforrester)