[13:26:12] (03PS17) 10Matthias Mullie: OOUIify license selection [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/433382 (https://phabricator.wikimedia.org/T193623) [21:48:18] (03PS4) 10Brion VIBBER: [BREAKING CHANGE] Convert to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/442220 (https://phabricator.wikimedia.org/T87981) (owner: 10Jforrester) [21:48:20] (03PS6) 10Brion VIBBER: Adjust VP9 encoding for speed, quality [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/445794 [21:52:49] (03CR) 10Brion VIBBER: "There's something odd about how $wgEnabledTranscodeSet works compared to prior behavior; if I set it manually in my LocalSettings.php to a" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/442220 (https://phabricator.wikimedia.org/T87981) (owner: 10Jforrester) [22:01:56] (03CR) 10Jforrester: "> Patch Set 4:" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/442220 (https://phabricator.wikimedia.org/T87981) (owner: 10Jforrester) [22:09:21] (03CR) 10Jforrester: [C: 031] "Reads sanely." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/445794 (owner: 10Brion VIBBER) [22:10:39] (03CR) 10Brion VIBBER: "Yeah, I'm just trying the change now to see how hard it is and it looks like "not too hard" so :D" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/442220 (https://phabricator.wikimedia.org/T87981) (owner: 10Jforrester) [22:11:21] * James_F grins at brion. [22:24:01] (03PS5) 10Brion VIBBER: [BREAKING CHANGE] Convert to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/442220 (https://phabricator.wikimedia.org/T87981) (owner: 10Jforrester) [22:24:03] (03PS7) 10Brion VIBBER: Adjust VP9 encoding for speed, quality [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/445794 [22:24:06] (03PS1) 10Brion VIBBER: [BREAKING CHANGE] Use maps for wgEnabledTranscodeSet [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/448163 (https://phabricator.wikimedia.org/T118080) [22:27:34] (03CR) 10jerkins-bot: [V: 04-1] Adjust VP9 encoding for speed, quality [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/445794 (owner: 10Brion VIBBER) [22:28:14] (03CR) 10jerkins-bot: [V: 04-1] [BREAKING CHANGE] Use maps for wgEnabledTranscodeSet [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/448163 (https://phabricator.wikimedia.org/T118080) (owner: 10Brion VIBBER) [22:34:24] (03CR) 10jerkins-bot: [V: 04-1] [BREAKING CHANGE] Convert to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/442220 (https://phabricator.wikimedia.org/T87981) (owner: 10Jforrester) [22:39:14] (03PS6) 10Brion VIBBER: [BREAKING CHANGE] Convert to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/442220 (https://phabricator.wikimedia.org/T87981) (owner: 10Jforrester) [22:41:01] (03PS2) 10Brion VIBBER: [BREAKING CHANGE] Use maps for wgEnabledTranscodeSet [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/448163 (https://phabricator.wikimedia.org/T118080) [22:41:03] (03PS8) 10Brion VIBBER: Adjust VP9 encoding for speed, quality [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/445794 [22:41:15] there i think i re-rebased it correctly [22:41:16] bah [22:43:22] (03CR) 10jerkins-bot: [V: 04-1] [BREAKING CHANGE] Use maps for wgEnabledTranscodeSet [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/448163 (https://phabricator.wikimedia.org/T118080) (owner: 10Brion VIBBER) [22:43:27] (03CR) 10Jforrester: [BREAKING CHANGE] Use maps for wgEnabledTranscodeSet (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/448163 (https://phabricator.wikimedia.org/T118080) (owner: 10Brion VIBBER) [22:43:29] (03CR) 10jerkins-bot: [V: 04-1] Adjust VP9 encoding for speed, quality [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/445794 (owner: 10Brion VIBBER) [22:43:58] brion: ^^ Otherwise looks good. [22:44:37] "Line exceeds 100 characters; contains 116 characters" sighhhhhh [23:02:16] (03PS3) 10Brion VIBBER: [BREAKING CHANGE] Use maps for wgEnabledTranscodeSet [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/448163 (https://phabricator.wikimedia.org/T118080) [23:02:18] (03PS9) 10Brion VIBBER: Adjust VP9 encoding for speed, quality [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/445794 [23:02:46] when ur code is too long, make it a function [23:04:36] (03CR) 10jerkins-bot: [V: 04-1] [BREAKING CHANGE] Use maps for wgEnabledTranscodeSet [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/448163 (https://phabricator.wikimedia.org/T118080) (owner: 10Brion VIBBER) [23:05:14] (03CR) 10jerkins-bot: [V: 04-1] Adjust VP9 encoding for speed, quality [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/445794 (owner: 10Brion VIBBER) [23:09:30] (03PS4) 10Brion VIBBER: [BREAKING CHANGE] Use maps for wgEnabledTranscodeSet [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/448163 (https://phabricator.wikimedia.org/T118080) [23:09:32] (03PS10) 10Brion VIBBER: Adjust VP9 encoding for speed, quality [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/445794 [23:11:46] (03CR) 10jerkins-bot: [V: 04-1] Adjust VP9 encoding for speed, quality [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/445794 (owner: 10Brion VIBBER) [23:12:03] (03CR) 10jerkins-bot: [V: 04-1] [BREAKING CHANGE] Use maps for wgEnabledTranscodeSet [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/448163 (https://phabricator.wikimedia.org/T118080) (owner: 10Brion VIBBER) [23:12:38] (03CR) 10Jforrester: [BREAKING CHANGE] Use maps for wgEnabledTranscodeSet (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/448163 (https://phabricator.wikimedia.org/T118080) (owner: 10Brion VIBBER) [23:14:50] (03PS5) 10Brion VIBBER: [BREAKING CHANGE] Use maps for wgEnabledTranscodeSet [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/448163 (https://phabricator.wikimedia.org/T118080) [23:14:52] (03PS11) 10Brion VIBBER: Adjust VP9 encoding for speed, quality [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/445794 [23:15:00] i hate it when one file doesn't make it into the commit [23:15:28] (03CR) 10Jforrester: [BREAKING CHANGE] Use maps for wgEnabledTranscodeSet (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/448163 (https://phabricator.wikimedia.org/T118080) (owner: 10Brion VIBBER) [23:16:18] * James_F grins. [23:17:59] brion: Theoretically we should use ExtensionRegistry::getInstance()->getAttribute( 'EnabledTranscodeSet' ) rather than globals to avoid killing kittens, but we can leave that for $FUTURE. [23:19:06] $FUTURE->brion can deal with it yeah [23:29:38] * James_F grins. [23:34:39] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Use maps for wgEnabledTranscodeSet [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/448163 (https://phabricator.wikimedia.org/T118080) (owner: 10Brion VIBBER) [23:35:15] brion: Let's do this. [23:36:18] * brion puts on shades [23:36:23] yeeeeaaaaaaahhhhhhhhhhh [23:36:57] (03CR) 10Brion VIBBER: [C: 032] [BREAKING CHANGE] Convert to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/442220 (https://phabricator.wikimedia.org/T87981) (owner: 10Jforrester) [23:52:17] Gosh. [23:53:09] brion: BTW, FWICT Atom and other Electron-based apps get stuck in loops when doing some file access operations on Mac OS X 10.14 beta… It's quite annoying. :-( [23:53:19] ugh [23:53:28] Inorite. [23:53:32] i haven't tried the beta yet (it doesn't run on the old machine i used to use for betas) [23:53:36] so that'll be a fun upgrade [23:54:16] i juggle between atom and vs code, which are both electron