[00:28:53] 10Multimedia, 10Structured-Data-Commons, 10Wikidata, 10Easy, 10Multimedia-Team-Working-Board: Make semantic choices for clarity between Commons items and Wikidata items ("labels" vs. "captions", etc.) - https://phabricator.wikimedia.org/T178447#3692583 (10Ramsey-WMF) [13:13:18] 10Multimedia, 10Structured-Data-Commons, 10Wikidata, 10Multimedia-Team-Working-Board: Make semantic choices for clarity between Commons items and Wikidata items ("labels" vs. "captions", etc.) - https://phabricator.wikimedia.org/T178447#3693723 (10matthiasmullie) [14:04:53] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer: No images can be loaded - https://phabricator.wikimedia.org/T178358#3693983 (10Val_B_1988) It seems I solved the problem. Error was caused by µBlock extension. I disabled the blocking of large media elements. [16:02:23] 10Multimedia, 10MediaWiki-Gallery: Perrow doesn't work on galleries for packed models - https://phabricator.wikimedia.org/T178511#3694331 (10Stryn) [16:17:19] marktraceur feel free to take another look at the interface text stuff - just in case I overlooked something obvious :p [16:17:33] let me go back and see what I had found [16:18:47] matthiasmullie: Will do as soon as I finish catching up with WMDE folk [16:19:32] the "language - label - description" renderer is class TermsListView::getListViewHtml, where the i18n messages (e.g. wikibase-entitytermsforlanguagelistview-label) are assigned to the template [16:20:03] so the quick thing: override wikibase-entitytermsforlanguagelistview-label text on commons specifically [16:20:15] the not so quick thing: [16:22:13] TermsListView::getListViewHtml could be extended to provide different i18n messages [16:22:51] TermsListView is constructed inside EntityParserOutputGenerator::addHtmlToParserOutput, a private function (can't extend from it to override with a different class) [16:23:12] and that one is also constructed from somewhere else, etc etc [16:23:44] "quick" "refactorings" could be: [16:24:23] - make the private methods protected, then we can create all our custom classes in between to eventually instantiate a render object with different i18n keys [16:25:52] - keep them private, but inject the class through the stack, instead of creating it inside a private method (DI) - I like this a little better, but don't want to start doing this now, or we'll soon end up with injecting 7 billion different classes for random minor UI (or whatever) differences [16:26:02] matthiasmullie: If we used the wikibase client to pull stuff from Wikidata, would wikibase-entitytermsforlanguagelistview-label be used to display it anywhere? [16:26:38] Because I think there will still be stuff stored on Wikidata about Commons, and we'll want to link to Wikidata items from MediaInfo (like portrays = Q1298398 or whatever) [16:27:01] and do all the rendering ourselves? [16:28:00] Uhm [16:28:17] matthiasmullie: I guess I'm overthinking that, but let me check something real quick. [16:28:50] equally likely that there's another possibility I haven't yet thought about ;) [16:29:51] anyway - I currently see no quick wins, which is why I'd start with other, beefier things where we need to do more custom interface (or anything) anyway [16:31:03] but if you do find something, that'd be great :) [16:31:20] I've seen a lot of code I've never seen before today, very likely that I overlooked things :D [16:32:17] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer: No images can be loaded in MultimediaViewer due to µBlock browser extension - https://phabricator.wikimedia.org/T178358#3694407 (10Aklapper) [16:32:28] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer: No images can be loaded in MultimediaViewer due to µBlock browser extension - https://phabricator.wikimedia.org/T178358#3689804 (10Aklapper) 05Open>03Invalid Glad you found the reason! [16:32:37] anyway - didn't want to keep you from your other conversations - we can talk about this later! [16:32:55] matthiasmullie: No, I finished talking to addshore a minute ago [16:33:35] matthiasmullie: I'm wondering if we can just create a MediaInfoTermsListView or something and have a TermsListView::factory that looks up the matching TermsListView for an entity's content type [16:34:15] possibly [16:34:17] I was hoping we could do it a little more linearly but it looks like TermsListView gets called in a weird enough place that we can't just change one of the existing MediaInfoEntity view classes [16:34:25] I'm just not sure something like that is the right approach [16:34:30] At least not after looking at it for two minutes [16:34:35] Yeah probably not. [16:34:53] I'm going to think on it a sec, BRB [16:35:00] there are a lot of similar things, and we probably shouldn't go making many factories for all the different elements we may (or not) have [16:35:48] I have a few ideas on how we could do it now, if we really need it [16:36:02] but none of them seem like *good* solutions :p [16:36:23] not until I have a better idea of how many things we may have to extend [16:41:49] (03PS2) 10Umherirrender: Remove dead code with DB_SLAVE [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/384317 [16:45:11] (03CR) 10Brian Wolff: [C: 032] Remove dead code with DB_SLAVE [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/384317 (owner: 10Umherirrender) [16:46:27] matthiasmullie: Yeah, I think we need to put a pin in this [16:47:01] matthiasmullie: I agree, it looks like the assumptions are a little too baked-in at the moment, and screwing with them won't help that much [16:57:50] 10Multimedia, 103D, 10UploadWizard, 10Multimedia-Team-Working-Board: Update UploadWizard with legal language/UI for 3D files - https://phabricator.wikimedia.org/T178513#3694469 (10Ramsey-WMF) [17:02:35] (03Merged) 10jenkins-bot: Remove dead code with DB_SLAVE [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/384317 (owner: 10Umherirrender) [20:23:53] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer: No images can be loaded in MultimediaViewer due to µBlock browser extension - https://phabricator.wikimedia.org/T178358#3695033 (10Tgr) Was this the default setting for uBlock? Maybe we should add a warning about that. [20:24:50] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer: No images can be loaded in MultimediaViewer due to µBlock browser extension - https://phabricator.wikimedia.org/T178358#3695034 (10Tgr) Also, did the behavior of uBlock change or you just did not have it enabled for the other browser version?