[08:04:32] <wikibugs>	 10Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10Browser-Support-Google-Chrome, 10JavaScript, 10Patch-For-Review: MultimediaViewer uses an old version of jquery.scrollTop which is broken for Chrome 61 - https://phabricator.wikimedia.org/T173618#3606994 (10Krinkle) >>! In T173618#3606444, @Tgr wro...
[09:23:43] <wikibugs>	 10Multimedia, 10MediaWiki-extensions-MultimediaViewer: Image won't load - https://phabricator.wikimedia.org/T175631#3607166 (10Aklapper) 05Open>03stalled
[10:40:05] <wikibugs>	 10Multimedia, 10MediaWiki-Gallery, 10OCG-PDFRenderer: <gallery> images are skipped, leaving captions behind - https://phabricator.wikimedia.org/T74386#3607413 (10Aklapper) As already announced in [[ https://meta.wikimedia.org/wiki/Tech/News/2017/37 | Tech News ]], OfflineContentGenerator (OCG) will not be us...
[13:06:19] <cormacparle>	 marktraceur: matthiasmullie  ... I've addressed most of your comments in that patch, except for this one
[13:06:32] <cormacparle>	 I'm not 100% sure this is the property we want to use for this...it seems to be the equivalent of a label, and it's not a documented property in OOJS UI. Can we dump the entire dropdown element and replace it with ULS on an empty <span> or something?
[13:06:39] <cormacparle>	 (from Mark)
[13:07:19] <cormacparle>	 fiddled about for a good while with this, and $handle is the only property of the dropdown that I can bind the uls to and actually get it to work 
[13:07:50] <cormacparle>	 ... and now I find that it doesn't actually work if you tab into the field as opposed to clicking on it, so I supposed it doesn't really *work* work anyway
[13:07:58] <cormacparle>	 so I'm going to try your @empty span@ idea
[13:08:09] <cormacparle>	 does that sound like a reasonable plan?
[13:10:38] <cormacparle>	 (btw the $handle property of a dropdown is the thing you click/keydown to show the menu options - it contains label, icon and indicator)
[13:11:17] <cormacparle>	 (also gonna chase Amir up for an example of someplace else the uls is used inside a form)
[13:13:12] <cormacparle>	 ... unless you guys already know of someplace?
[13:39:11] <wikibugs>	 10Multimedia, 10MediaWiki-extensions-UniversalLanguageSelector, 10UploadWizard, 10Easy, 10Patch-For-Review: Use Universal Language Selector (ULS) for selecting languages in the UploadWizard - https://phabricator.wikimedia.org/T148275#3607923 (10Cparle) @Amire80 do you have any examples of where the uls i...
[13:53:38] <wikibugs>	 (03PS2) 10Cparle: Add ULS for language dropdown in file description [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/377425 (https://phabricator.wikimedia.org/T148275)
[13:54:16] <cormacparle>	 pushed those updates for your comments, working on the "empty span" thing now
[13:55:02] <matthiasmullie>	 sorry - only just saw your messages here :p
[13:55:26] <matthiasmullie>	 I didn't even know what $handle was exactly, and if it's undocumented, it's probably best not to use it
[13:56:01] <matthiasmullie>	 I wouldn't necessarily not merge it, but if we can come up with something else, all the better (esp. with the keyboard tab not working properly)
[13:56:14] <cormacparle>	 yeah ... or to document it :)
[13:56:29] <cormacparle>	 but yeah, I'll have a look at a different approach
[14:09:51] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Add ULS for language dropdown in file description [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/377425 (https://phabricator.wikimedia.org/T148275) (owner: 10Cparle)
[14:13:26] <wikibugs>	 (03PS3) 10Cparle: Add ULS for language dropdown in file description [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/377425 (https://phabricator.wikimedia.org/T148275)
[14:32:12] <wikibugs>	 (03CR) 10Cparle: Add ULS for language dropdown in file description (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/377425 (https://phabricator.wikimedia.org/T148275) (owner: 10Cparle)
[14:51:28] <wikibugs>	 (03CR) 10Matthias Mullie: Add ULS for language dropdown in file description (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/377425 (https://phabricator.wikimedia.org/T148275) (owner: 10Cparle)
[14:58:30] <wikibugs>	 (03CR) 10Cparle: Add ULS for language dropdown in file description (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/377425 (https://phabricator.wikimedia.org/T148275) (owner: 10Cparle)
[15:03:05] <wikibugs>	 (03PS4) 10Cparle: Add ULS for language dropdown in file description [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/377425 (https://phabricator.wikimedia.org/T148275)
[15:03:55] <wikibugs>	 (03CR) 10Cparle: Add ULS for language dropdown in file description (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/377425 (https://phabricator.wikimedia.org/T148275) (owner: 10Cparle)
[19:04:50] <James_F>	 Hey all, is it OK for me to merge https://gerrit.wikimedia.org/r/#/c/377808/ ?
[19:12:49] <marktraceur>	 James_F: Krinkle seems to think it's okay, why didn't he merge?
[19:14:31] <James_F>	 marktraceur: Because Krinkle +1s for one of three reasons (Nice idea, keep going / I'll test this then merge / I'm not the owner of this code and someone else should). In this case my psychic Timo-sense says it's #3.
[19:17:13] <marktraceur>	 Ah.
[19:17:45] <marktraceur>	 James_F: In general, if Timo is okay with code, I don't feel the need to argue with him
[19:18:01] <James_F>	 :-)
[19:18:11] <James_F>	 Merging then.
[19:40:05] <wikibugs>	 10Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10Browser-Support-Google-Chrome, 10JavaScript, 10MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)): MultimediaViewer uses an old version of jquery.scrollTop which is broken for Chrome 61 - https://phabricator.wikimedia.org/T173618#3608991 (...