[01:17:17] <wikibugs>	 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-extensions-VipsScaler, and 3 others: $wgMaxAnimatedGifArea is not honored by Thumbor - https://phabricator.wikimedia.org/T173580#3599233 (10Dispenser) >>! In T173580#3595987, @Gilles wrote: > ``` > SELECT img_name, img_width * img_height * S...
[10:30:20] <cormacparle>	 matthiasmullie:  having a bit of trouble with authentication in gerrit
[10:30:48] <cormacparle>	 git review -R keeps asking me for my username/pwd, even thought I have a key pair setup
[10:32:38] <matthiasmullie>	 what's the gerrit remote?
[10:32:58] <matthiasmullie>	 I always end up having to change it to ssh
[10:34:22] <matthiasmullie>	 git remote remove origin && git remote add origin ssh://<user>@gerrit.wikimedia.org:29418/<repo>
[10:34:56] <matthiasmullie>	 what's the git* remote, I meant
[10:37:04] <cormacparle>	 ah maybe that's it
[10:39:24] <cormacparle>	 yeah that was it, thanks!
[10:39:48] <cormacparle>	 now I have a new error
[10:40:11] <cormacparle>	 https://www.irccloud.com/pastebin/g63vLcmq/
[10:40:25] <cormacparle>	 should I just follow the instructions and put in the hook?
[10:43:30] <cormacparle>	 I thought get-review would just add the commit id :/
[10:43:35] <cormacparle>	 git-review I mean
[10:48:12] <matthiasmullie>	 can you try git commit --amend?
[10:48:48] <matthiasmullie>	 I think git-review installs that hook automatically once it's been setup
[10:48:57] <matthiasmullie>	 so now that you got it to run, I'd expect it to just add it :p
[10:49:07] <cormacparle>	 hmm weird
[10:50:15] <cormacparle>	 ah
[10:50:22] <cormacparle>	 I reset git and re-did the commit
[10:50:24] <cormacparle>	 and there it is
[10:50:40] <wikibugs>	 (03PS1) 10Cparle: Add ULS for language dropdown in file description [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/377425 (https://phabricator.wikimedia.org/T148275)
[10:55:13] <cormacparle>	 so it's now awaiting review - do I need to add reviewers manually?
[10:59:29] <matthiasmullie>	 in an active project, it'll likely get reviewed anyway (or people might automatically get added to certain commits based on project or certain characteristics of a commit)
[11:00:04] <cormacparle>	 ca I see in gerrit who's assigned to review it? or is that through phabricator?
[11:00:10] <matthiasmullie>	 but yes, if there's anyone in particular you'd like to review the patch (or it takes forever until someone gets around to it), adding them manually is ok
[11:00:24] <matthiasmullie>	 it's somewhere in the middle, up top
[11:00:29] <matthiasmullie>	 "Reviewers"
[11:00:36] <matthiasmullie>	 right now, there's only 'jenkins-bot'
[11:00:50] <matthiasmullie>	 on the right is an icon to add others - feel free to add me
[11:02:00] <cormacparle>	 aha I see it
[11:02:02] <cormacparle>	 added you and Mark
[11:02:15] <cormacparle>	 so now I've another question :)
[11:02:21] <cormacparle>	 there are 19 failing unit tests
[11:02:30] <cormacparle>	 (not caused by my patch, they're failing in master too)
[11:03:34] <matthiasmullie>	 not in that patch, it seems (jenkins-bot already reviewed your thing & these 4 builds were ok, as you can see at the bottom under jenkins-bot's comment)
[11:03:54] <cormacparle>	 ah ok - so jenkins checks the unit test output?
[11:04:03] <matthiasmullie>	 what tests are you running - only that repo, phpunit or qunit?
[11:04:05] <cormacparle>	 I see the failures if I run them via the browser
[11:04:10] <cormacparle>	 qunit
[11:04:18] <cormacparle>	 ah
[11:04:21] <matthiasmullie>	 yeah, though the test suite depends on the repo
[11:04:42] <matthiasmullie>	 what kind of failures do you get?
[11:04:57] <matthiasmullie>	 (I'll try it out myself as well, but don't currently have ULS provisioned)
[11:05:03] <cormacparle>	 ah ok - so if I run them via the browser I'm getting all tests for qunit, and not just the uploadwizard extension?
[11:06:45] <matthiasmullie>	 you can either run all, or specific tests
[11:07:14] <matthiasmullie>	 the whole suite also has a bunch of failures for me (from other extensions, where I guess some features are not properly set up on my machine)
[11:07:53] <cormacparle>	 I see errors for ext.eventLogging, ext.wikiEditor and ext.uploadWizard
[11:08:17] <cormacparle>	 the uploadWizard ones are to do with FlickrChecker
[11:09:11] <matthiasmullie>	 top right is a "module" dropdown, where you can select only uploadwizard tests (which I think are all uw.* thingies + mw.UploadWizard + ext.UploadWizard*)
[11:09:56] <matthiasmullie>	 yeah, I get the same kind of failures
[11:10:54] <matthiasmullie>	 looks like it's not an issue with your code, but someone should probably take a quick look into why this fails (at least for these flickr thingies) :p
[11:11:26] <cormacparle>	 yeah
[11:12:00] <cormacparle>	 what's the procedure for that? should I put in a phab ticket saying something like "Investigate unit test failures in upload wizard"?
[11:12:28] <matthiasmullie>	 yeah, that depends
[11:12:35] <matthiasmullie>	 that would probably be the right way to do it
[11:13:09] <matthiasmullie>	 although I have a hard time staring at things that I know are broken, so I'm usually tempted to do some quick investigation already :p
[11:15:01] <cormacparle>	 haha yeah - my experience has been that failing tests always need to be fixed right away cos otherwise they're just noise (or deleted if the test isn't useful)
[11:15:15] <cormacparle>	 maybe I'll dive in and see if I can figure out what's going on
[11:15:27] <matthiasmullie>	 yeah, I agree
[12:59:44] <wikibugs>	 10Multimedia, 10MediaWiki-extensions-MultimediaViewer: Image won't load - https://phabricator.wikimedia.org/T175631#3600132 (10Aklapper) Hi @Andrew_Davidson. thanks for taking the time to report this! If you click on the first link directly, can you access the image and is the image displayed in your web brows...
[14:44:36] <cormacparle>	 Any tips for running qunit via grunt? I've done `npm install grunt` but  my terminal says `grunt: command not found`
[16:24:35] <cormacparle>	 have made some progress, but still having issues
[16:24:38] <cormacparle>	 https://www.irccloud.com/pastebin/IcnHDv6N/
[16:28:07] <cormacparle>	 ah never mind, found this https://gruntjs.com/configuring-tasks
[22:49:27] <wikibugs>	 10Multimedia, 10MediaWiki-Gallery: Possible race condition in gallery javascript code - https://phabricator.wikimedia.org/T175760#3602514 (10FO-nTTaX)
[22:50:02] <wikibugs>	 10Multimedia, 10MediaWiki-Gallery: Possible race condition in gallery javascript code - https://phabricator.wikimedia.org/T175760#3602527 (10FO-nTTaX)