[06:45:48] 10Multimedia, 10MediaWiki-extensions-UniversalLanguageSelector, 10UploadWizard, 10Easy: Use Universal Language Selector (ULS) for selecting languages in the UploadWizard - https://phabricator.wikimedia.org/T148275#3590540 (10Amire80) Ugh. That's because the ULS extension's JS code is not fully loaded when... [07:08:48] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-extensions-VipsScaler, 10Thumbor: $wgMaxAnimatedGifArea is not honored - https://phabricator.wikimedia.org/T173580#3533758 (10Gilles) Indeed, I wasn't aware of that limit and it hasn't been ported over to Thumbor. Seems simple enough to re... [07:09:04] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-extensions-VipsScaler, and 2 others: $wgMaxAnimatedGifArea is not honored - https://phabricator.wikimedia.org/T173580#3590550 (10Gilles) p:05Triage>03Normal a:03Gilles [07:09:16] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-extensions-VipsScaler, and 2 others: $wgMaxAnimatedGifArea is not honored by Thumbor - https://phabricator.wikimedia.org/T173580#3533758 (10Gilles) [07:21:12] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Thumbor: PNG thumbnail of a specific SVG file uploaded to Commons is clipped / cut at some sides - https://phabricator.wikimedia.org/T162263#3157287 (10Gilles) Looking at the diff between the most recent glitched version and the fixed version, the wid... [08:17:23] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-extensions-VipsScaler, and 2 others: $wgMaxAnimatedGifArea is not honored by Thumbor - https://phabricator.wikimedia.org/T173580#3590647 (10Gilles) [09:04:46] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-extensions-VipsScaler, and 2 others: $wgMaxAnimatedGifArea is not honored by Thumbor - https://phabricator.wikimedia.org/T173580#3590729 (10Gilles) [09:07:30] 10Multimedia, 10MediaWiki-extensions-UniversalLanguageSelector, 10UploadWizard, 10Easy: Use Universal Language Selector (ULS) for selecting languages in the UploadWizard - https://phabricator.wikimedia.org/T148275#3590731 (10Cparle) Thanks @Amire80 [09:13:03] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-extensions-VipsScaler, and 2 others: $wgMaxAnimatedGifArea is not honored by Thumbor - https://phabricator.wikimedia.org/T173580#3590737 (10Gilles) [10:30:32] * cormacparle waves [10:30:38] it's me, with more questions :) [10:32:02] what does this do? [10:32:04] this.languageDropdown.connect( this, { change: [ 'emit', 'change' ] } ); [10:32:25] langugeDropdown is a OO.ui.DropdownWidget [10:37:01] it looks to me like it calls EventEmitter.emit() with 'change' when the dropdown value is changed [10:37:37] but what does *that* do is my real question :) [10:48:34] I'm presuming there's an event listener someplace ... but where? [16:46:46] cormacparle: So, whatever class that's in has a language dropdown, and when the language dropdown changes, the class wants to signal that it changed [16:46:53] cormacparle: I assume this is the description widget in UploadWizard [16:47:07] cormacparle: So since the language changed, the description has changed, and we signal that up the ladder [16:48:13] cormacparle: I believe the parent with the listener would be in the Descriptions class. I can check for you if you can't find it. [16:49:42] ah ok - so we emit a "change" event whether it's the language or the description that has changed [16:49:44] makes sense [16:50:11] less mysterious than I imagined :) [16:53:16] Yeah [16:53:27] And hopefully the listener isn't something you need to mess with :) [16:54:10] yeah, pretty sure it's not [16:54:47] I think I might actually finally have this nearly figured out [16:55:24] just trying to adjust the default position of the uls [16:57:54] what's the state of unit testing in the upload wizard? [16:58:39] Never did unit tests for js before, just php [19:16:06] Oh my, late reply [19:16:25] cormacparle: There are unit tests, but they're not very unit-y (more like integration tests), and then there are browser tests that are usually more helpful [19:16:34] I believe both are run automatically by Jenkins on every patch [19:39:05] 10Multimedia, 10Commons, 10Reading-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017): Conduct MP3 patrol discussion - https://phabricator.wikimedia.org/T167815#3592732 (10Dispenser) @CKoerner_WMF The discussion has been kicked [[https://commons.wikimedia.org/wiki/Commons:Village_pump/Archive/2017/0... [22:56:01] (03CR) 10Jforrester: [C: 032] Remove dead isAndroid2() code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/375862 (owner: 10Krinkle) [23:02:16] (03Merged) 10jenkins-bot: Remove dead isAndroid2() code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/375862 (owner: 10Krinkle)