[13:10:58] 10Multimedia, 10MediaWiki-extensions-UniversalLanguageSelector, 10UploadWizard, 10Easy: Use Universal Language Selector (ULS) for selecting languages in the UploadWizard - https://phabricator.wikimedia.org/T148275#3588069 (10Cparle) @Amire80 would you have any insight into the following? On this page http... [13:12:17] Anyone have any idea what's going on here? https://phabricator.wikimedia.org/T148275#3588069 [13:55:42] cormacparle looks like the uls javascript is not loaded on Special:UploadWizard [13:57:25] (vagrant issues prevent me from doublechecking that - fail to provision uls) [13:58:30] JS/CSS is typically only added where needed [13:59:03] Special:UploadWizard will probably just have some default js (stuff like jquery & mw core thingies) and code specific to UploadWizard extension [14:03:16] including UploadWizard (or any extension) is usually just a matter of `include( 'extensions/UploadWizard.php' );` (in MW's LocalSetting.php) [14:03:31] that one will load the extension.json and figure it out from there [14:04:16] in extension.json, there's a "SpecialPages" key [14:05:05] that maps Special: to some class [14:05:58] (actually, because can be i18n-ized, it will use UploadWizard.alias.php (loaded from UploadWizard.php) to translate to the in extension.json, but whatever) [14:06:14] Is ULS loaded on every page or do you have to set it as a dependency? [14:06:55] I'm guessing it's a dependency, since $().uls() from console won't work [14:08:04] so in extension.json, you have something that maps Special:UploadWizard to class "SpecialUploadWizard" (the autoload map is also in extension.json: "SpecialUploadWizard" is "includes/specials/SpecialUploadWizard.php") [14:08:39] in SpecialUploadWizard, there will be a few $out->addModules() thingies [14:08:51] these reference modules that are also defined in extension.json [14:09:17] (under "ResourceModules") [14:10:12] "ext.uploadWizard.page", for example, is just 1 JS file, no CSS files, and 1 dependency: "ext.uploadWizard" [14:10:25] "ext.uploadWizard", in turn, has a whole lot of script & dependencies that are loaded [14:11:36] I assume you'll either need to add a dependency on uls in there as well (that would then be a hard dependency, however - if uls files don't exist, this thing will fail to load at all) [14:13:03] if all we're looking for is "just enhance UploadWizard if ULS is already available, otherwise just keep it working another way", you'll probably just want to attempt to load that module from JS [14:14:02] (or from PHP, but not by explicitly listing it as a dependency in extension.json) [14:15:13] What you say makes sense [14:16:03] but on https://commons.wikimedia.org/wiki/Special:UploadWizard up at the top if you click on "English" you get a uls appearing [14:16:12] so that suggests to me that it *is* loaded [14:16:23] maybe I'm misinterpreting though? [14:19:58] looks like it is; let's see where that comes from [14:22:50] so, I don't know much about ULS, but it looks like the one up top is module 'ext.uls.interface' [14:23:30] which is basically extensions/UniversalLanguageSelector/resources/js/ext.uls.interface.js, and a few dependencies (but not the jquery thingy) [14:25:09] aaaah [14:25:11] that makes sense! [14:25:23] so it has the interface, but not the jquery plugin [14:26:02] apparently [14:39:54] 10Multimedia, 103d, 10Easy, 10Patch-For-Review: When debug=true on the beta cluster, ext.3d.js fails to load - https://phabricator.wikimedia.org/T173975#3588512 (10matthiasmullie) a:03matthiasmullie [14:57:16] hmmm [14:57:35] so is there a way to figure out what extensions are installed in php? [15:15:06] Yes! [15:15:08] Hello I'm back. [15:15:54] * cormacparle waves [15:18:10] cormacparle: Looking back into it, I can't remember what the function is for extension checks [15:18:25] heh ok [15:18:39] I'm wondering if I should use mw.loader() in js instead [15:20:31] That's usually a good way to do things [15:20:35] Cheap, simple [15:20:45] And also it checks for what you really want [15:21:04] cormacparle: Alternatively, ExtensionRegistry::getInstance()->isLoaded( 'UniversalLanguageSelector' ); [15:21:30] :) awesome [15:21:41] (found after a frantic search of doc.wikimedia.org and grep -rn isLoaded in extensions/) [15:21:49] haha [15:33:24] brion: Is T174477 something you can do? Would be nice for Beta Cluster and prod to be as close as possible. ;-) [15:37:04] James_F: the actual reimaging is not in my wheelhouse but it should be good to go :) [15:37:20] brion: OK, should I whine at opsen? ;-) [15:37:48] Sounds about right [15:38:03] Right-o. :-) [15:38:18] :) [15:43:31] Do we ever *not* whine at opsen? [15:55:54] Sometimes we sleep. [15:56:33] Fair [16:12:54] 10Multimedia, 10UploadWizard, 10Technical-Debt: Refactor UploadWizard to be maintainable - https://phabricator.wikimedia.org/T96906#3588820 (10MarkTraceur) p:05Low>03Triage [16:13:11] 10Multimedia, 10UploadWizard: Increase the limit of 50 uploads at once (maxUploads) - https://phabricator.wikimedia.org/T135085#3588823 (10MarkTraceur) p:05Low>03Normal [16:14:03] 10Multimedia, 10MediaWiki-General-or-Unknown, 10Design: Improve the license selection and upload process in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115867#3588827 (10MarkTraceur) p:05Low>03Normal [16:15:49] 10Multimedia, 10Commons, 10Contributors-Team, 10MediaWiki-File-management, and 6 others: Allow uploading of 3D files to Wikimedia Commons - https://phabricator.wikimedia.org/T3790#3588862 (10MarkTraceur) p:05Normal>03Triage [16:16:30] 10Multimedia, 10Beta-Cluster-Infrastructure, 10Thumbor: On beta commons, thumbnailing of 3D files is broken still - https://phabricator.wikimedia.org/T170444#3588869 (10MarkTraceur) [16:17:07] 10Multimedia, 10UploadWizard: Increase the limit of 50 uploads at once (maxUploads) - https://phabricator.wikimedia.org/T135085#3588872 (10Jarekt) >>! In T135085#3313866, @kaldari wrote: > @Jarekt: What browser are you using? Chrome. I explained the process I was using at [[ https://commons.wikimedia.org/wiki...