[04:32:03] <prtksxna>	 James_F marktraceur: See https://phabricator.wikimedia.org/T154893 soon :)
[04:33:35] <James_F>	 prtksxna: Saw it earlier. I think it looks good. Was going to chat with marktraceur but…
[04:38:32] <prtksxna>	 James_F: Cool. Keep some homebrew in the CQ lounge, I am sure marktraceur and matthiasmullie will appear :P
[04:50:06] <James_F>	 Ha.
[05:25:21] <marktraceur>	 Uhhhh
[05:32:52] <marktraceur>	 prtksxna: lgtm
[05:33:18] <marktraceur>	 I'm a bit confused over some of the heuristics. But it's good.
[06:58:58] <wikibugs>	 06Multimedia, 10UploadWizard, 07Performance, 05WMF-deploy-2017-01-17_(1.29.0-wmf.8): Thumbnails are being re-generated every time - https://phabricator.wikimedia.org/T153758#2929973 (10Aklapper)
[08:15:55] <wikibugs>	 10FileAnnotations, 06Multimedia, 07Design: FileAnnotations prototype: The wikitext button doesn't explain what its for - https://phabricator.wikimedia.org/T154757#2930023 (10Prtksxna) The search integrated option sounds great. Unlike VE though we'll have to show this option even when there are non-zero searc...
[13:44:28] <wikibugs>	 06Multimedia, 06Commons, 06Support-and-Safety, 10Wikimedia-General-or-Unknown, 06Zero: Commons and testwiki used as video hoster by Wikipedia Zero - https://phabricator.wikimedia.org/T129845#2930495 (10Dispenser)
[15:28:23] <wikibugs>	 06Multimedia, 06Commons, 10Commons-Datasets, 10MediaWiki-File-management, and 2 others: Media, Visualizations, and Layout at Wikidev'17 - https://phabricator.wikimedia.org/T151952#2833116 (10MelodyKramer) Notes from this session: https://etherpad.wikimedia.org/p/devsummit17-media-visualization-layout
[16:31:13] <wikibugs>	 06Multimedia, 10AbuseFilter: Add more variables for file metadata when uploading - https://phabricator.wikimedia.org/T154987#2930949 (10matmarex)
[18:34:05] <wikibugs>	 06Multimedia, 10AbuseFilter: Add more variables for file metadata when uploading: Number of color channels; Number of pages/frames; Animation loop; Duration - https://phabricator.wikimedia.org/T154987#2931358 (10Aklapper)
[19:35:00] <wikibugs>	 06Multimedia, 10UploadWizard: Files named with cyrillic characters rejected with "The filename is too short." on Upload step - https://phabricator.wikimedia.org/T155039#2931655 (10matmarex)
[19:36:44] <wikibugs>	 06Multimedia, 10UploadWizard: Files named with cyrillic characters rejected with "The filename is too short." on Upload step - https://phabricator.wikimedia.org/T155039#2931677 (10matmarex) p:05Triage>03Unbreak! This is very similar to T154779. We "sanitize" the cyrillic and end up with a filename like "__...
[19:37:09] <wikibugs>	 06Multimedia, 10UploadWizard: Files named with cyrillic characters rejected with "The filename is too short." on Upload step - https://phabricator.wikimedia.org/T155039#2931695 (10matmarex)
[19:38:08] <wikibugs>	 06Multimedia, 10UploadWizard: Files named with cyrillic characters rejected with "The filename is too short." on Upload step - https://phabricator.wikimedia.org/T155039#2931655 (10Jdforrester-WMF) Meh.
[19:48:34] <wikibugs>	 (03PS1) 10Bartosz Dziewoński: mw.FormDataTransport: Don't remove Unicode characters from temp filename [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/331529 (https://phabricator.wikimedia.org/T155039)
[19:49:14] <MatmaRex_mobile>	 James_F: meh indeed.
[19:49:28] <MatmaRex_mobile>	 wanna merge it?
[19:49:38] <MatmaRex_mobile>	 maybe i could still have it swatted now. :)
[19:49:50] <James_F>	 Can you write a unit test for this area (later)?
[19:50:10] <wikibugs>	 (03CR) 10Jforrester: [C: 032] mw.FormDataTransport: Don't remove Unicode characters from temp filename [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/331529 (https://phabricator.wikimedia.org/T155039) (owner: 10Bartosz Dziewoński)
[19:50:23] <MatmaRex_mobile>	 we should be performing no transformations here
[19:50:35] <MatmaRex_mobile>	 this is stupid bad code written in 2008
[19:50:40] <James_F>	 Ah.
[19:50:42] <James_F>	 OK.
[19:50:45] <marktraceur>	 Hm, I think I was under the impression that our temporary filenames were totally random strings
[19:50:54] <MatmaRex_mobile>	 perhaps back then this was necessary
[19:50:55] <marktraceur>	 Clearly wrong.
[19:51:00] <MatmaRex_mobile>	 but it definitely isn't now
[19:51:02] <James_F>	 Maybe they should be?
[19:51:13] <MatmaRex_mobile>	 marktraceur: they were semi-random, but they have to be deterministic
[19:51:20] <MatmaRex_mobile>	 i changed this recently
[19:51:21] <marktraceur>	 Ah.
[19:51:24] <MatmaRex_mobile>	 and things are breaking now :/
[19:51:43] <MatmaRex_mobile>	 (we need it to be deterministic so that abusefilter's warning can be overridden by the user)
[19:51:56] <James_F>	 Fun.
[19:52:08] <MatmaRex_mobile>	 marktraceur: we could do a sha1 hash of the actual filename, or something. but we might as well just use the filename.
[19:52:16] <marktraceur>	 Yeah, I guess
[19:52:49] <wikibugs>	 (03Merged) 10jenkins-bot: mw.FormDataTransport: Don't remove Unicode characters from temp filename [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/331529 (https://phabricator.wikimedia.org/T155039) (owner: 10Bartosz Dziewoński)
[19:53:22] <wikibugs>	 (03PS1) 10Jforrester: mw.FormDataTransport: Don't remove Unicode characters from temp filename [extensions/UploadWizard] (wmf/1.29.0-wmf.7) - 10https://gerrit.wikimedia.org/r/331531 (https://phabricator.wikimedia.org/T155039)
[19:55:52] <wikibugs>	 (03CR) 10Reedy: [C: 032] mw.FormDataTransport: Don't remove Unicode characters from temp filename [extensions/UploadWizard] (wmf/1.29.0-wmf.7) - 10https://gerrit.wikimedia.org/r/331531 (https://phabricator.wikimedia.org/T155039) (owner: 10Jforrester)
[19:55:57] <wikibugs>	 (03CR) 10Dereckson: [C: 032] "SWAT" [extensions/UploadWizard] (wmf/1.29.0-wmf.7) - 10https://gerrit.wikimedia.org/r/331531 (https://phabricator.wikimedia.org/T155039) (owner: 10Jforrester)
[19:58:52] <wikibugs>	 (03Merged) 10jenkins-bot: mw.FormDataTransport: Don't remove Unicode characters from temp filename [extensions/UploadWizard] (wmf/1.29.0-wmf.7) - 10https://gerrit.wikimedia.org/r/331531 (https://phabricator.wikimedia.org/T155039) (owner: 10Jforrester)
[20:15:15] <wikibugs>	 06Multimedia, 10UploadWizard, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7), 05WMF-deploy-2017-01-17_(1.29.0-wmf.8): Files named with cyrillic characters rejected with "The filename is too short." on Upload step - https://phabricator.wikimedia.org/T155039#2931815 (10matmarex) 05Open>03Resolved Fixed and deplo...
[23:19:57] <wikibugs>	 06Multimedia, 06Commons, 10MediaWiki-File-management, 05MW-1.28-release-notes: File does not thumbnail, doesn't have extracted metadata, has reported zero width/height (due to garbage bytes between JPEG sections) - https://phabricator.wikimedia.org/T148606#2932513 (10matmarex) @MoritzMuehlenhoff Do you kno...