[07:18:29] 06Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading, 05MW-1.29-release-notes, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Non transcluded variable in stashfailed error message - https://phabricator.wikimedia.org/T147720#2871785 (10matmarex) 05Open>03Resolved a:03matmarex This should fix the error mess... [07:33:57] 06Multimedia, 06Commons, 10MediaWiki-File-management: img_auth.php: How to implement access checks using a custom file backend / repo? - https://phabricator.wikimedia.org/T140334#2871796 (10Osnard) Status update: The "hacky way" was not a good one. I've now decided to create a new entry point (based on `img_... [07:57:45] 06Multimedia, 06Commons, 10MediaWiki-File-management: img_auth.php: How to implement access checks using a custom file backend / repo? - https://phabricator.wikimedia.org/T140334#2871825 (10Osnard) [13:38:39] (03PS2) 10Bartosz Dziewoński: Remove mw.confirmCloseWindow from mw.UploadWizard.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325788 (owner: 10Matthias Mullie) [13:45:46] (03CR) 10Bartosz Dziewoński: [C: 032] "Rebased, conflicts were trivial." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325788 (owner: 10Matthias Mullie) [13:49:07] (03Merged) 10jenkins-bot: Remove mw.confirmCloseWindow from mw.UploadWizard.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325788 (owner: 10Matthias Mullie) [13:57:30] (03PS1) 10Esanders: Use normalised contraints [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327188 [14:37:44] (03PS1) 10Esanders: Replace jshint/jscs with eslint [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327198 [14:37:46] (03PS1) 10Esanders: eslint: Enable valid-jsdoc [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327199 [14:37:57] (03CR) 10jenkins-bot: [V: 04-1] eslint: Enable valid-jsdoc [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327199 (owner: 10Esanders) [14:38:25] (03CR) 10Esanders: [] "Don't really know what this code does, but the variable is unused otherwise..." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327188 (owner: 10Esanders) [14:40:25] (03PS2) 10Esanders: Use normalised contraints [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327188 [14:40:27] (03PS2) 10Esanders: Replace jshint/jscs with eslint [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327198 [14:40:29] (03PS2) 10Esanders: eslint: Enable valid-jsdoc [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327199 [14:43:39] (03CR) 10Esanders: [] Replace jshint/jscs with eslint (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327198 (owner: 10Esanders) [14:48:49] Looks like MMV unit tests have been failing on jenkins for a few weeks due to a locale issue: https://integration.wikimedia.org/ci/job/mwext-qunit-jessie/6571/console [14:49:10] expected "44.44" actual "44,44" [14:54:51] (03PS3) 10Matthias Mullie: Simplify error handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326134 (https://phabricator.wikimedia.org/T152607) [14:57:18] (03CR) 10jenkins-bot: [V: 04-1] Simplify error handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326134 (https://phabricator.wikimedia.org/T152607) (owner: 10Matthias Mullie) [14:58:11] 06Multimedia: Update mediawiki.Upload.BookletLayout.js for recent API error message changes - https://phabricator.wikimedia.org/T153200#2872589 (10matthiasmullie) [15:04:11] (03PS4) 10Matthias Mullie: Simplify error handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326134 (https://phabricator.wikimedia.org/T152607) [15:05:49] (03CR) 10Matthias Mullie: [] "Test failure is about missing abusefilter & spamblacklist messages." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326134 (https://phabricator.wikimedia.org/T152607) (owner: 10Matthias Mullie) [15:07:13] (03CR) 10jenkins-bot: [V: 04-1] Simplify error handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326134 (https://phabricator.wikimedia.org/T152607) (owner: 10Matthias Mullie) [15:53:30] 06Multimedia, 10MediaWiki-Uploading: Update mediawiki.Upload.BookletLayout.js for recent API error message changes - https://phabricator.wikimedia.org/T153200#2872726 (10matmarex) [16:03:37] (03PS2) 10Matthias Mullie: [WIP] Use mw.Api instead of XMLHttpRequest [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326937 [16:07:29] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use mw.Api instead of XMLHttpRequest [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326937 (owner: 10Matthias Mullie) [16:11:17] (03PS3) 10Matthias Mullie: [WIP] Use mw.Api instead of XMLHttpRequest [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326937 [16:13:45] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use mw.Api instead of XMLHttpRequest [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326937 (owner: 10Matthias Mullie) [16:15:01] (03PS4) 10Matthias Mullie: [WIP] Use mw.Api instead of XMLHttpRequest [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326937 [16:17:37] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use mw.Api instead of XMLHttpRequest [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326937 (owner: 10Matthias Mullie) [16:20:38] James_F: Can you flesh out your request at https://phabricator.wikimedia.org/T140040 so we have a clear path? [16:21:32] Also MatmaRex and James_F is there any more discussion to have at https://phabricator.wikimedia.org/T135085 ? [16:30:10] marktraceur: not much to discuss, i think, but there's probably work to be done to look into the performance [16:32:05] MatmaRex: I think we did some off-the-cuff testing and noticed some very slow UI updates, but otherwise the server could handle it? [16:32:35] 06Multimedia, 10UploadWizard: Increase the limit of 50 uploads at once (maxUploads) - https://phabricator.wikimedia.org/T135085#2872897 (10matmarex) I think they are deal-breakers. We should find out why it's slow, and make it faster. Or if that's impossible, we should make things be lazy-loaded. [16:32:36] brion: Can you respond to what MatmaRex mentioned at https://phabricator.wikimedia.org/T116516 ? [16:32:47] no, the server is fine [16:33:05] Cool. [16:33:11] but generating all these interfaces is taking a long time, and the browser appears to be hung while that's happening [16:33:51] either it needs to be made faster, or if we can't, we should generate them incrementally, or when the user scrolls to them, or something [16:34:10] sorry for not replying earlier, that email is probably still in my inbox [16:34:34] That could work [16:34:42] MatmaRex: Don't worry, I blacklist phab emails, I'm no better [16:34:47] Anyway [16:34:57] (my inbox is a double-ended queue; if i don't reply the day i see the message, i'll probably only reply like a month later when going through the oldest ones) [16:35:14] (and i currenty have 137 unread) [16:35:18] Maybe I'll look into what we could do about interface changes [16:39:11] 06Multimedia, 10UploadWizard: Make upload interface changes a little snappier - https://phabricator.wikimedia.org/T153210#2872908 (10MarkTraceur) [16:39:50] 06Multimedia, 10UploadWizard: Make upload interface changes a little snappier - https://phabricator.wikimedia.org/T153210#2872923 (10MarkTraceur) [16:39:54] 06Multimedia, 10UploadWizard: Increase the limit of 50 uploads at once (maxUploads) - https://phabricator.wikimedia.org/T135085#2872922 (10MarkTraceur) [16:46:17] (03CR) 10Bartosz Dziewoński: [C: 032] "It looks like constraints.width and constraints.height are always equal in practice, so this never caused any bugs (and it mostly dead cod" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327188 (owner: 10Esanders) [16:49:01] (03Merged) 10jenkins-bot: Use normalised contraints [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327188 (owner: 10Esanders) [17:01:34] (03PS5) 10Matthias Mullie: [WIP] Use mw.Api instead of XMLHttpRequest [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326937 [17:06:07] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use mw.Api instead of XMLHttpRequest [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326937 (owner: 10Matthias Mullie) [17:17:17] (03PS6) 10Matthias Mullie: [WIP] Use mw.Api instead of XMLHttpRequest [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326937 [17:17:47] (03PS1) 10MarkTraceur: [WIP] Load details divs on scroll [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327233 (https://phabricator.wikimedia.org/T153210) [17:19:57] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use mw.Api instead of XMLHttpRequest [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326937 (owner: 10Matthias Mullie) [18:07:26] hey marktraceur [18:10:42] marktraceur: Do you want to get on a quick call to talk about the search stuff? [18:10:43] also https://prtksxna.github.io/wikimedia-prototypes/fileannotations/needs_annotation_category/category/category.html [18:47:40] (03PS1) 10Bartosz Dziewoński: mw.UploadWizardUpload: Actually allow overriding AbuseFilter warnings [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327263 [18:48:18] (03CR) 10Bartosz Dziewoński: [] Replace jshint/jscs with eslint (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327198 (owner: 10Esanders) [18:48:19] prtksxna: Sorry, was lunching [18:49:56] marktraceur: Ha. Oh dear. [18:50:08] Err. MatmaRex: … [18:50:24] is there something else horribly broken? [18:50:36] i've already discovered several horribly broken things today [18:50:58] oh. i see [18:51:02] oh dear indeed. [18:51:45] (03CR) 10jenkins-bot: [V: 04-1] mw.UploadWizardUpload: Actually allow overriding AbuseFilter warnings [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327263 (owner: 10Bartosz Dziewoński) [18:53:55] (03PS2) 10Bartosz Dziewoński: mw.UploadWizardUpload: Actually allow overriding AbuseFilter warnings [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327263 [18:57:07] (03CR) 10jenkins-bot: [V: 04-1] mw.UploadWizardUpload: Actually allow overriding AbuseFilter warnings [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327263 (owner: 10Bartosz Dziewoński) [19:00:53] argh [19:01:19] that's not even a real failure [19:01:30] we make requests to the real flickr.com api in our test suite? gods [19:01:38] (03CR) 10Bartosz Dziewoński: [] "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327263 (owner: 10Bartosz Dziewoński) [19:16:03] 06Multimedia, 06Project-Admins: Track transcoding-related tasks - https://phabricator.wikimedia.org/T109994#2873454 (10Aklapper) Any proposal on the name and the description of this project? Do we have any page to link to, explaining "transcoding" functionality on Wikimedia servers? [19:27:11] Hey marktraceur [19:27:28] HI prtksxna, a few minutes from now good? [19:29:36] Sure [19:29:41] Cool. [19:33:55] 06Multimedia, 10UploadWizard: Incorrect error message shown for chunked uploads blocked by AbuseFilter - https://phabricator.wikimedia.org/T153231#2873563 (10matmarex) [19:36:01] marktraceur: see calendar [19:36:17] prtksxna: OK, be there soon [19:36:47] 06Multimedia, 10UploadWizard: Incorrect error message shown for chunked uploads blocked by AbuseFilter - https://phabricator.wikimedia.org/T153231#2873644 (10matmarex) p:05Triage>03High a:03matmarex This is caused by 4e6810e4a2c1d821d8d108c7974ac16917561764. The output in this case has no machine-readabl... [19:36:51] (03PS1) 10Bartosz Dziewoński: mw.FormDataTransport: Update check for already completed chunked uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327273 (https://phabricator.wikimedia.org/T153231) [19:37:16] marktraceur: can you review this? ^ i'd like to have it swatted today [19:37:26] MatmaRex: You're second in line :) [19:38:04] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I've not reviewed it yet, but this sounds like a great improvement. But I noticed an issue when comparing this to https://gerrit.wikimedia" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326134 (https://phabricator.wikimedia.org/T152607) (owner: 10Matthias Mullie) [19:42:23] prtksxna: Sorry, getting held up a bit. [19:43:03] (in the evening swat, so you have a couple hours :) ) [19:43:13] np marktraceur [19:45:18] * prtksxna eats cake [19:47:39] marktraceur: https://prtksxna.github.io/wikimedia-prototypes/fileannotations/needs_annotation_category/category/category.html [19:55:15] marktraceur: https://prtksxna.github.io/wikimedia-prototypes/fileannotations/las_meninas_view/view/view.html [20:04:22] OK MatmaRex, you're up, one sec [20:14:24] MatmaRex: Hah, right by my favourite UW comment of all time [20:14:48] I guess you could say, one of the most prophetic as well [20:16:02] 06Multimedia, 10AbuseFilter, 10MediaWiki-Uploading, 05Security: Upload abuse filters can be occasionally bypassed somehow - https://phabricator.wikimedia.org/T153217#2873849 (10matmarex) 05Open>03Resolved p:05Triage>03High [20:16:22] heh [20:16:58] (03PS2) 10MarkTraceur: [WIP] Load details divs on scroll [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327233 (https://phabricator.wikimedia.org/T153210) [20:17:19] (03CR) 10MarkTraceur: [C: 032] mw.FormDataTransport: Update check for already completed chunked uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327273 (https://phabricator.wikimedia.org/T153231) (owner: 10Bartosz Dziewoński) [20:17:32] 06Multimedia, 10AbuseFilter, 10MediaWiki-Uploading, 10Wikimedia-General-or-Unknown, 05Security: Upload abuse filters can be occasionally bypassed somehow - https://phabricator.wikimedia.org/T153217#2873156 (10matmarex) [20:19:42] (03Merged) 10jenkins-bot: mw.FormDataTransport: Update check for already completed chunked uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/327273 (https://phabricator.wikimedia.org/T153231) (owner: 10Bartosz Dziewoński) [20:24:41] MatmaRex: All set :) thanks for figuring that out [20:25:37] MatmaRex: Was that perhaps causing some of the other issues for chunks? [20:27:05] marktraceur: probably not, unless you first encountered any particular ones last week [20:27:16] MatmaRex: Ah, nope. [20:29:42] 06Multimedia, 10AbuseFilter, 10MediaWiki-Uploading, 10Wikimedia-General-or-Unknown, 05Security: Upload abuse filters can be occasionally bypassed somehow - https://phabricator.wikimedia.org/T153217#2873156 (10Legoktm) Can you file a separate task about the bug in AbuseFilterCachingParser? [20:48:40] (03CR) 10Gergő Tisza: [] Simplify error handling (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/326134 (https://phabricator.wikimedia.org/T152607) (owner: 10Matthias Mullie) [20:55:08] 06Multimedia, 10AbuseFilter, 10MediaWiki-Uploading, 10Wikimedia-General-or-Unknown, 05Security: Some abuse filters can be bypassed (never match any actions) - https://phabricator.wikimedia.org/T153217#2873996 (10matmarex) [21:02:46] 06Multimedia, 10AbuseFilter, 10MediaWiki-Uploading, 10Wikimedia-General-or-Unknown, and 2 others: Some abuse filters can be bypassed (never match any actions) - https://phabricator.wikimedia.org/T153217#2874064 (10matmarex) All production wikis were affected by this issue, in the following periods. But oth... [21:06:52] 06Multimedia, 06Commons, 10Wikimedia-General-or-Unknown, 05Security, 07User-notice: Some abuse filters can be bypassed (never match any actions) - https://phabricator.wikimedia.org/T153217#2873156 (10matmarex) >>! In T153217#2873920, @Legoktm wrote: > Can you file a separate task about the bug in AbuseFi... [21:34:53] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10Tabular-Data, and 3 others: Audio/Video/Media/Viz/Layout Session at Wikidev'17 - https://phabricator.wikimedia.org/T151952#2833116 (10Qgil) Should these subtasks be merged? [21:43:25] 06Multimedia, 06Commons, 10Wikimedia-General-or-Unknown, 05Security, 07User-notice: Some abuse filters can be bypassed (never match any actions) - https://phabricator.wikimedia.org/T153217#2873156 (10Tgr) Filters can be hand-tested on recent changes, maybe just ask admins to do that? [21:47:53] 06Multimedia, 06Commons, 10Wikimedia-General-or-Unknown, 05Security, 07User-notice: Some abuse filters can be bypassed (never match any actions) - https://phabricator.wikimedia.org/T153217#2874363 (10Jdforrester-WMF) I don't think it's worth trying to retrospectively re-run AbuseFilters (especially as it... [22:07:12] 06Multimedia, 10UploadWizard, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Incorrect error message shown for chunked uploads blocked by AbuseFilter - https://phabricator.wikimedia.org/T153231#2873563 (10Jdforrester-WMF) I don't think this is worth back-porting? [22:10:21] James_F: our favorite community loves to casually hate on uploadwizard. if anyone sees that error message, i'll be hearing about how terribly unreliable the "new" upload wizard is again. [22:10:50] Joke's on them, the new uploadwizard is just as reliable as the old one [22:10:50] It's "new" now? [22:11:42] As new as nupedia. [22:22:10] yes, it's still "new" [22:50:31] As opposed to… Special:Upload? scp? ;-) [22:50:57] Do we have an scp/ftp or similar interface? Maybe we could partner with IA? [22:51:14] Why look to the future when you can look to the past!!!! [23:01:34] * marktraceur pings lindseyanne James_F and MatmaRex [23:01:58] oh huh, it's meeting time already. [23:01:59] Sorry, busy being eaten. [23:02:10] That sucks. [23:02:18] My update is trying not to be.