[00:27:53] 06Multimedia, 06Commons, 10MediaWiki-File-management, 06Performance-Team, 05MW-1.28-release-notes: ThumbnailRender job spam due to HTTP 500s - https://phabricator.wikimedia.org/T106740#2849478 (10Gilles) 05Open>03Resolved [02:57:04] 06Multimedia, 06Commons, 06Support-and-Safety, 10Wikimedia-General-or-Unknown, 06Zero: Commons and testwiki used as video hoster by Wikipedia Zero - https://phabricator.wikimedia.org/T129845#2849644 (10zhuyifei1999) The AF only marked uploads for ease of review, and may have indirectly discouraged the co... [12:11:29] 06Multimedia, 10ArchCom-RfC, 06Commons, 10MediaWiki-File-management, and 14 others: Define an official thumb API - https://phabricator.wikimedia.org/T66214#2850204 (10Ciencia_Al_Poder) >>! In T66214#2827486, @GWicke wrote: > Since the need for explicit control should be rare, I think using the Accept heade... [14:17:20] (03PS1) 10Matthias Mullie: Get rid of upload.providedFile [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325558 [14:17:22] (03PS1) 10Matthias Mullie: Move checkFile out of mw.UploadWizardUpload, into controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325559 (https://phabricator.wikimedia.org/T96916) [14:21:17] (03CR) 10jenkins-bot: [V: 04-1] Move checkFile out of mw.UploadWizardUpload, into controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325559 (https://phabricator.wikimedia.org/T96916) (owner: 10Matthias Mullie) [14:27:39] (03PS2) 10Matthias Mullie: Move checkFile out of mw.UploadWizardUpload, into controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325559 (https://phabricator.wikimedia.org/T96916) [14:29:28] (03CR) 10jenkins-bot: [V: 04-1] Move checkFile out of mw.UploadWizardUpload, into controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325559 (https://phabricator.wikimedia.org/T96916) (owner: 10Matthias Mullie) [14:30:07] (03PS3) 10Matthias Mullie: Move checkFile out of mw.UploadWizardUpload, into controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325559 (https://phabricator.wikimedia.org/T96916) [14:34:19] 06Multimedia, 10UploadWizard, 13Patch-For-Review, 07Technical-Debt: Move checkFile out of the Upload object and into the upload step controller - https://phabricator.wikimedia.org/T96916#2850550 (10matthiasmullie) a:03matthiasmullie [14:37:52] (03CR) 10jenkins-bot: [V: 04-1] Move checkFile out of mw.UploadWizardUpload, into controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325559 (https://phabricator.wikimedia.org/T96916) (owner: 10Matthias Mullie) [14:38:41] (03PS4) 10Matthias Mullie: Move checkFile out of mw.UploadWizardUpload, into controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325559 (https://phabricator.wikimedia.org/T96916) [15:10:43] 06Multimedia, 10ArchCom-RfC, 06Commons, 10MediaWiki-File-management, and 14 others: Define an official thumb API - https://phabricator.wikimedia.org/T66214#2850639 (10Fjalapeno) Not sure if it is helpful to examine, but here is a commercial image service API: https://docs.imgix.com/setup/serving-images ht... [15:58:10] 06Multimedia, 10UploadWizard, 07Technical-Debt: Remove IE8 workarounds from UploadWizard - https://phabricator.wikimedia.org/T123220#2850835 (10MarkTraceur) p:05Low>03Normal This should be relatively fast, and not cause any issues...I believe UW removed support for 06Multimedia, 06Commons, 10UploadWizard: UploadWizard enforces mandatory creation date field - https://phabricator.wikimedia.org/T115318#2850891 (10MarkTraceur) FWIW: I think {{upload date}} would be a good compromise if the user doesn't fill out the form, and ignores a warning (similar to empty categories f... [16:25:43] 06Multimedia, 10UploadWizard: enlargement of thumbs in UW does not work any more - https://phabricator.wikimedia.org/T121202#2850896 (10MarkTraceur) 05Open>03declined [16:46:44] MatmaRex: Did you ever get a chance to check https://phabricator.wikimedia.org/T150016 ? CC matthiasmullie ? [16:50:23] 10FileAnnotations, 06Multimedia, 10MediaWiki-Vagrant, 13Patch-For-Review: MediaWiki-Vagrant role for FileAnnotations extension - https://phabricator.wikimedia.org/T148597#2850986 (10MarkTraceur) a:03Prtksxna [16:52:21] 06Multimedia, 10TimedMediaHandler-Player, 07Design, 13Patch-For-Review: Investigate increasing the contrast for arrows in the multimedia video player - https://phabricator.wikimedia.org/T117344#2850993 (10MarkTraceur) a:03Tgr [16:53:56] 06Multimedia, 06Language-Team, 10VisualEditor, 13Patch-For-Review: "A file with name "$1" already exists in the shared file repository, and cannot be overwritten" shows up while trying to rename a file with single letter which is different from standard fo... - https://phabricator.wikimedia.org/T115946#2850995 [16:59:43] gilles: You seem to have been involved in https://phabricator.wikimedia.org/T134498, do you care to merge it? I think I understand that it's ready to go but I don't want to overstep you. [17:03:50] 06Multimedia, 10UploadWizard, 07Technical-Debt: Remove IE8 workarounds from UploadWizard - https://phabricator.wikimedia.org/T123220#1923873 (10MarkTraceur) a:03MarkTraceur [17:06:52] (03PS1) 10MarkTraceur: Remove ES3/IE8 hackaround for reserved word [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325584 (https://phabricator.wikimedia.org/T123220) [17:22:22] (03PS1) 10MarkTraceur: Sanitize Firefogg errors so filepaths don't leak [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325590 (https://phabricator.wikimedia.org/T136851) [17:24:38] (03CR) 10Bartosz Dziewoński: [C: 032] Remove ES3/IE8 hackaround for reserved word [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325584 (https://phabricator.wikimedia.org/T123220) (owner: 10MarkTraceur) [17:26:28] (03CR) 10MarkTraceur: [C: 04-1] "Minor issues, will fix myself if tests work fine" (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325558 (owner: 10Matthias Mullie) [17:27:52] (03Merged) 10jenkins-bot: Remove ES3/IE8 hackaround for reserved word [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325584 (https://phabricator.wikimedia.org/T123220) (owner: 10MarkTraceur) [17:30:30] (03PS2) 10MarkTraceur: Get rid of upload.providedFile [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325558 (owner: 10Matthias Mullie) [17:30:48] 06Multimedia, 10UploadWizard, 07Technical-Debt: Remove IE8 workarounds from UploadWizard - https://phabricator.wikimedia.org/T123220#2851083 (10matmarex) 05Open>03Resolved [17:31:22] (03CR) 10MarkTraceur: [C: 032] "+2 minor edit to code, tests went fine, thanks for refactors :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325558 (owner: 10Matthias Mullie) [17:36:43] (03Merged) 10jenkins-bot: Get rid of upload.providedFile [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325558 (owner: 10Matthias Mullie) [17:38:08] 06Multimedia, 10MediaWiki-Gallery: 360 Photo support - https://phabricator.wikimedia.org/T151749#2851125 (10Ahm_masum) [17:41:25] (03CR) 10MarkTraceur: [C: 032] Move checkFile out of mw.UploadWizardUpload, into controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325559 (https://phabricator.wikimedia.org/T96916) (owner: 10Matthias Mullie) [17:52:32] (03CR) 10MarkTraceur: [C: 032] Cleanup upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 (owner: 10Matthias Mullie) [17:55:09] 06Multimedia, 10ImageTweaks, 10Security-Reviews, 06Security-Team: Security review of the ImageTweaks extension ahead of production deployment - https://phabricator.wikimedia.org/T123594#2851157 (10MarkTraceur) p:05High>03Triage [17:55:18] Oh FFS [17:55:31] 06Multimedia, 10ImageTweaks, 10Security-Reviews, 06Security-Team: Security review of the ImageTweaks extension ahead of production deployment - https://phabricator.wikimedia.org/T123594#1933387 (10MarkTraceur) p:05Triage>03Normal [18:09:38] (03CR) 10jenkins-bot: [V: 04-1] Cleanup upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 (owner: 10Matthias Mullie) [18:13:21] (03CR) 10Bartosz Dziewoński: "An apostrophe ' is a valid character in file names and may appear here. The regexes should just use .*" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325590 (https://phabricator.wikimedia.org/T136851) (owner: 10MarkTraceur) [18:17:45] marktraceur: haven't checked that tutorial logging yet - will do so tomorrow [18:18:08] and I'll rebase those patches you were trying to merge now [18:19:09] (03PS5) 10Matthias Mullie: Move checkFile out of mw.UploadWizardUpload, into controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325559 (https://phabricator.wikimedia.org/T96916) [18:25:52] (03PS2) 10Bartosz Dziewoński: Sanitize Firefogg errors so filepaths don't leak [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325590 (https://phabricator.wikimedia.org/T136851) (owner: 10MarkTraceur) [18:25:55] (03CR) 10Bartosz Dziewoński: [C: 032] Sanitize Firefogg errors so filepaths don't leak [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325590 (https://phabricator.wikimedia.org/T136851) (owner: 10MarkTraceur) [18:27:37] (03CR) 10Matthias Mullie: [C: 032] "Trigger merge" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325559 (https://phabricator.wikimedia.org/T96916) (owner: 10Matthias Mullie) [18:31:47] (03Merged) 10jenkins-bot: Sanitize Firefogg errors so filepaths don't leak [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325590 (https://phabricator.wikimedia.org/T136851) (owner: 10MarkTraceur) [18:32:25] (03Merged) 10jenkins-bot: Move checkFile out of mw.UploadWizardUpload, into controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325559 (https://phabricator.wikimedia.org/T96916) (owner: 10Matthias Mullie) [18:34:07] We are so goddamned productive [18:35:48] (03PS9) 10Matthias Mullie: Cleanup upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 [18:44:20] (03CR) 10jenkins-bot: [V: 04-1] Cleanup upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 (owner: 10Matthias Mullie) [19:22:51] (03CR) 10Bartosz Dziewoński: "FIXME: Removing the .fromURL property broke automatic licensing for Flickr uploads. It's checked for in a bunch of places, including uw.co" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325558 (owner: 10Matthias Mullie) [19:27:20] (03CR) 10Bartosz Dziewoński: "(I'm fixing that. This made it into wmf.5, so it'll need a backport.)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325558 (owner: 10Matthias Mullie) [19:30:42] (03PS1) 10Bartosz Dziewoński: Update checks for .fromURL for Flickr upload to fix automatic deeds [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325614 [19:30:48] (03CR) 10Bartosz Dziewoński: "https://gerrit.wikimedia.org/r/325614" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325558 (owner: 10Matthias Mullie) [20:00:48] marktraceur: https://gerrit.wikimedia.org/r/#/c/325614/ should be merged today [20:00:52] 06Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 07Technical-Debt, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Upstream VisualEditor's media search tool into mw.widgets so other extensions/core can use it - https://phabricator.wikimedia.org/T140166#2851884 (10Jdforrester-WMF) [20:01:39] MatmaRex: Hm, yup [20:01:58] (03CR) 10MarkTraceur: [C: 032] Update checks for .fromURL for Flickr upload to fix automatic deeds [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325614 (owner: 10Bartosz Dziewoński) [20:02:29] I can never figure out what the eff Gerrit is thinking when it decides whether I get a +2 button. [20:04:13] there's a one-click button if the patch is already Verified+2. [20:11:44] Ah. [20:12:12] (03CR) 10jenkins-bot: [V: 04-1] Update checks for .fromURL for Flickr upload to fix automatic deeds [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325614 (owner: 10Bartosz Dziewoński) [20:17:31] (03PS2) 10Bartosz Dziewoński: Update checks for .fromURL for Flickr upload to fix automatic deeds [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325614 [20:40:34] marktraceur: can you bonk the button on https://gerrit.wikimedia.org/r/#/c/325614/ again, because i forgot a test? [20:42:18] (03CR) 10MarkTraceur: [C: 032] Update checks for .fromURL for Flickr upload to fix automatic deeds [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325614 (owner: 10Bartosz Dziewoński) [20:42:32] MatmaRex: Senior Button Bonker, duty done [20:43:53] thanks :D [20:45:34] (03Merged) 10jenkins-bot: Update checks for .fromURL for Flickr upload to fix automatic deeds [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/325614 (owner: 10Bartosz Dziewoński) [20:46:31] (03PS1) 10Bartosz Dziewoński: Update checks for .fromURL for Flickr upload to fix automatic deeds [extensions/UploadWizard] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/325625 [21:12:52] 06Multimedia, 06Commons, 07Performance: Large image https://commons.wikimedia.org/wiki/File:Map_of_Hindoostan,_1788,_by_Rennell.jpg can't create thumbs - https://phabricator.wikimedia.org/T147992#2852274 (10MarkTraceur) One of the suggested solutions was to increase $maxImageArea, and if that solution won't... [22:28:47] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think the code in uw.controller.Step can be greatly simplified, OOjs UI is able to do the bookkeeping of handlers by itself if you use t" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 (owner: 10Matthias Mullie) [22:29:01] (03CR) 10Bartosz Dziewoński: "(Also, needs rebase again. Sorry for late review.)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 (owner: 10Matthias Mullie)