[00:07:21] (03CR) 10Jforrester: [C: 032] Fix comment blocks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322608 (owner: 10Reedy) [00:15:34] (03Merged) 10jenkins-bot: Fix comment blocks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322608 (owner: 10Reedy) [09:36:26] 06Multimedia, 10ArchCom-RfC, 06Commons, 10MediaWiki-File-management, and 14 others: Define an official thumb API - https://phabricator.wikimedia.org/T66214#2813526 (10Gilles) The client doesn't necessarily have to advertise what it wants, but then if it doesn't tell us anything, we would have to be conserv... [10:02:45] marktraceur: thumbor has been shadow-serving all traffic on beta and production since september. as in, it processes every request the same way image scalers do, just doesn't save the result in swift in the same place and doesn't serve the result back to the client via varnish [10:03:33] marktraceur: and since then we've fixed a bunch of bugs and stability issues that appeared when dealing with the full blown production traffic. essentially the same problems we would find if thumbor really served all thumbnail requests [10:04:10] marktraceur: and right now we're down to a few missing features that revealed themselves when comparing http status code output between mediawiki and thumbor in production [10:05:42] marktraceur: namely, 3 different forms of rate limiting that mediawiki has (poolcounter, failure counter, IP/user rate limiter). honoring page redirects on thumbnail URLs. and the fact that thumbor shouldn't serve thumbnails bigger than the original [10:06:55] marktraceur: which means that thumbor will have to talk to poolcounter, memcache and the mediawiki api to reimplement those features. ultimately I think these 5 features should be in a proxy service in front of thumbor, but right now it make the most sense to add it to thumbor which has a clean architecture rather than make the rewrite.py swift plugin more complex [10:07:42] marktraceur: with ori leaving and my taking over his team lead/manager duties for now, I don't think I'll have that finished before the holidays [10:08:32] marktraceur: the upside of all this is that I'm fixing all the issues that would have appeared if we started serving the traffic for real, before we do. the launch itself should be a non-event [10:11:25] marktraceur: that being said, the thumbor instances should be usable for manipulating images without saving the results, so we can work on exposing that for your purpose if you want [10:14:26] marktraceur: this change I have pending review would actually separate that use case more cleanly: https://phabricator.wikimedia.org/D465 as soon as that's merged I think we should be able to add your filters to the configuration, both on beta and production, and you would be able to construct URLs to hit thumbor and have an original transformed on demand without side-effects [10:15:31] marktraceur: so my stuff needs significantly more work, but I think we could get thumbor working for your needs in a couple of days of work [10:17:47] marktraceur: an open question, though, is whether the memory/disk limits we've put in place for thumbnailing would work when rotating originals and such. but I guess we'll find out when we try [10:28:59] (03Abandoned) 10Matthias Mullie: Rip reset routine out of controllers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322124 (owner: 10Matthias Mullie) [13:05:15] (03PS4) 10Matthias Mullie: Cleanup upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 [13:08:01] (03CR) 10jenkins-bot: [V: 04-1] Cleanup upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 (owner: 10Matthias Mullie) [13:22:04] (03PS5) 10Matthias Mullie: Cleanup upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 [13:24:18] (03CR) 10jenkins-bot: [V: 04-1] Cleanup upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 (owner: 10Matthias Mullie) [13:45:15] (03PS6) 10Matthias Mullie: Cleanup upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 [13:47:48] (03CR) 10jenkins-bot: [V: 04-1] Cleanup upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 (owner: 10Matthias Mullie) [13:49:14] (03PS7) 10Matthias Mullie: Cleanup upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 [13:51:14] (03CR) 10jenkins-bot: [V: 04-1] Cleanup upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 (owner: 10Matthias Mullie) [13:52:42] (03PS8) 10Matthias Mullie: Cleanup upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 [14:24:45] (03PS1) 10Bartosz Dziewoński: mw.UploadWizardLicenseInput: Correct unguarded for...in [extensions/UploadWizard] (wmf/1.29.0-wmf.3) - 10https://gerrit.wikimedia.org/r/322892 (https://phabricator.wikimedia.org/T151220) [14:37:25] (03CR) 10Hashar: [C: 032] mw.UploadWizardLicenseInput: Correct unguarded for...in [extensions/UploadWizard] (wmf/1.29.0-wmf.3) - 10https://gerrit.wikimedia.org/r/322892 (https://phabricator.wikimedia.org/T151220) (owner: 10Bartosz Dziewoński) [14:40:37] (03Merged) 10jenkins-bot: mw.UploadWizardLicenseInput: Correct unguarded for...in [extensions/UploadWizard] (wmf/1.29.0-wmf.3) - 10https://gerrit.wikimedia.org/r/322892 (https://phabricator.wikimedia.org/T151220) (owner: 10Bartosz Dziewoński) [14:42:55] (03CR) 10Hashar: "Deployed!" [extensions/UploadWizard] (wmf/1.29.0-wmf.3) - 10https://gerrit.wikimedia.org/r/322892 (https://phabricator.wikimedia.org/T151220) (owner: 10Bartosz Dziewoński) [14:45:22] gilles: Great! Do you want to do it between the holidays, or should we maybe hack this out at the dev summit? [14:45:33] Get the band back together [14:48:31] 06Multimedia, 10UploadWizard: TypeError: undefined is not an object (evaluating title.replace) between Deed and Details steps - https://phabricator.wikimedia.org/T151220#2814318 (10matmarex) 05Open>03Resolved Fixed and deployed. [15:13:02] 10FileAnnotations, 06Multimedia: Explore designs for FileAnnotations - https://phabricator.wikimedia.org/T151327#2814426 (10Prtksxna) [15:31:12] i'm having a hard time getting anything done today, i think i'll just take the rest of the day off. [15:31:47] MatmaRex: o/ [15:35:23] 10FileAnnotations, 06Multimedia, 07Design: Discovery of annotations - https://phabricator.wikimedia.org/T151330#2814524 (10Prtksxna) [15:36:01] 10FileAnnotations, 06Multimedia: Explore designs for FileAnnotations - https://phabricator.wikimedia.org/T151327#2814540 (10Prtksxna) [15:36:41] 10FileAnnotations, 06Multimedia, 07Design: Encouraging users to annotate - https://phabricator.wikimedia.org/T151330#2814542 (10Prtksxna) [15:37:10] 10FileAnnotations, 06Multimedia: Explore designs for FileAnnotations - https://phabricator.wikimedia.org/T151327#2814426 (10Prtksxna) [15:42:11] (03CR) 10Matthias Mullie: [C: 032] .jshintrc: Disallow unguarded for...in [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322711 (https://phabricator.wikimedia.org/T151220) (owner: 10Bartosz Dziewoński) [15:44:48] (03Merged) 10jenkins-bot: .jshintrc: Disallow unguarded for...in [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322711 (https://phabricator.wikimedia.org/T151220) (owner: 10Bartosz Dziewoński) [15:57:38] 10FileAnnotations, 06Multimedia, 07Design: Discovery of annotations - https://phabricator.wikimedia.org/T151335#2814636 (10Prtksxna) [15:58:06] 10FileAnnotations, 06Multimedia, 07Design: Explore designs for FileAnnotations - https://phabricator.wikimedia.org/T151327#2814426 (10Prtksxna) [16:00:12] Browser acting up, trying to join [16:02:12] hangouts not working for me - I'll keep trying [16:03:19] Hey prtksxna should we wait for you? [16:03:32] marktraceur: Yes please [16:08:32] marktraceur: Exited hangouts, it was acting up again. Did I/Am I missing anything? [16:08:42] prtksxna: No, we ended after I went [16:08:59] prtksxna: You may have missed the reminder about Thanksgiving. Thursday/Friday will be very desolate in the US. [16:09:12] marktraceur: Ah! Cool (y) [16:26:35] marktraceur: I don't have a preference. I can't come to the dev summit/all hands this year, however [16:34:41] gilles: Oh, that's a shame. Well, whenever you're available to help, then, or maybe if you'd like to send me an e-mail with an idea of what needs doing so I can get the ball rolling [16:35:21] marktraceur: I'll make a phabricator task. Is there one for your stuff to make it a dependency for? [16:35:37] I believe there's an ImageTweaks task, let me find it [16:35:42] I guess maybe the one that's currently a parent of my thumbor stuff? [16:35:47] Heh, probably! [16:36:05] marktraceur: this? https://phabricator.wikimedia.org/T141317 [16:36:19] That's the one [16:36:37] ok, I'll make a new child for it, then, with only the things needed for your use case to work [16:36:42] Great [16:44:57] 06Multimedia, 10ImageTweaks, 06Performance-Team, 10Thumbor, 07Beta-Feature: Expose Thumbor internally for ImageTweaks and similar use cases - https://phabricator.wikimedia.org/T151339#2814746 (10Gilles) [16:45:15] 06Multimedia, 10ImageTweaks, 07Beta-Feature: Provide a beta feature of ImageTweaks - https://phabricator.wikimedia.org/T141317#2494153 (10Gilles) [16:47:31] 06Multimedia, 10ImageTweaks, 06Performance-Team, 10Thumbor, 07Beta-Feature: Expose Thumbor internally for ImageTweaks and similar use cases - https://phabricator.wikimedia.org/T151339#2814778 (10Gilles) [20:23:41] 06Multimedia, 10TimedMediaHandler, 10VisualEditor, 10VisualEditor-MediaWiki: After adding a video using VE and save the page, the Play button is in the middle of the page - https://phabricator.wikimedia.org/T150978#2815826 (10Jdforrester-WMF) p:05Triage>03Low Sounds like the TimedMediaHandler can't fin... [21:26:28] 06Multimedia, 10ArchCom-RfC, 06Commons, 10MediaWiki-File-management, and 14 others: Define an official thumb API - https://phabricator.wikimedia.org/T66214#2816123 (10GWicke) We do have some information about format support from Accept & User-Agent headers in regular image requests. Chrome for example send... [21:58:27] 06Multimedia, 10MediaWiki-Gallery, 07Easy, 03Google-Code-In-2016: Add showThumbnails attribute to slideshow galleries - https://phabricator.wikimedia.org/T147913#2816306 (10Prtksxna) >>! In T147913#2800282, @MarkTraceur wrote: > Just a 2¢ here - should this be an option to keep the thumbnails open, or just... [21:59:11] 06Multimedia, 10MediaWiki-Gallery, 07Easy, 03Google-Code-In-2016: Add showThumbnails attribute to slideshow galleries - https://phabricator.wikimedia.org/T147913#2816307 (10Prtksxna) [22:00:56] 10FileAnnotations, 06Multimedia, 06Community-Liaisons (Oct-Dec-2016): Liaison support for FileAnnotations - https://phabricator.wikimedia.org/T149626#2816311 (10Prtksxna) >>! In T149626#2790998, @Aklapper wrote: > @Prtksxna: I assume you've the [[ https://www.mediawiki.org/wiki/Technical_Collaboration_Guidel... [22:47:49] (03PS1) 10Krinkle: Remove use of deprecated "json" module [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/323064 [22:55:17] (03CR) 10Bartosz Dziewoński: [C: 032] Remove use of deprecated "json" module [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/323064 (owner: 10Krinkle)