[01:45:26] (03Abandoned) 10Reedy: Add extensions.json, empty PHP entry point [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210176 (https://phabricator.wikimedia.org/T87981) (owner: 10Paladox) [01:58:47] (03PS1) 10Reedy: Fix comment blocks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322608 [01:58:50] (03PS1) 10Reedy: Convert to extension registration [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) [01:59:33] (03PS2) 10Reedy: Remove minified videojs-responsive-layout.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/320092 [01:59:37] (03CR) 10Reedy: [C: 032] Remove minified videojs-responsive-layout.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/320092 (owner: 10Reedy) [02:04:25] (03CR) 10jenkins-bot: [V: 04-1] Fix comment blocks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322608 (owner: 10Reedy) [02:05:24] (03CR) 10jenkins-bot: [V: 04-1] Convert to extension registration [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) (owner: 10Reedy) [02:12:29] (03Merged) 10jenkins-bot: Remove minified videojs-responsive-layout.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/320092 (owner: 10Reedy) [02:13:32] (03PS2) 10Reedy: Convert to extension registration [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) [02:13:35] (03PS2) 10Reedy: Fix comment blocks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322608 [02:19:04] (03CR) 10jenkins-bot: [V: 04-1] Convert to extension registration [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) (owner: 10Reedy) [02:21:57] (03PS3) 10Reedy: Convert to extension registration [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) [02:29:02] (03CR) 10jenkins-bot: [V: 04-1] Convert to extension registration [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) (owner: 10Reedy) [02:32:14] (03PS4) 10Reedy: Convert to extension registration [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) [02:34:48] (03CR) 10jenkins-bot: [V: 04-1] Convert to extension registration [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) (owner: 10Reedy) [02:40:56] (03CR) 10Reedy: Convert to extension registration (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) (owner: 10Reedy) [02:45:46] (03PS5) 10Reedy: Convert to extension registration [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) [02:48:00] (03CR) 10jenkins-bot: [V: 04-1] Convert to extension registration [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) (owner: 10Reedy) [02:48:15] (03CR) 10Reedy: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) (owner: 10Reedy) [02:56:57] (03PS6) 10Reedy: Convert to extension registration [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) [07:25:13] (03CR) 10Paladox: "Thanks for doing this, but the config that decides which resolution to use doesn't seem to be configurable since it looks like you enable " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) (owner: 10Reedy) [10:50:45] 06Multimedia, 10ArchCom-RfC, 06Commons, 10MediaWiki-File-management, and 14 others: Define an official thumb API - https://phabricator.wikimedia.org/T66214#2810289 (10Gilles) There is contradiction here. You want to serve what's best for the client "automatically", but you want the client to retain some co... [12:39:14] (03CR) 10Bartosz Dziewoński: "There's a typo in the method "bailAndloadFile" (should be uppercase L, bad search-and-replace?), but we're removing it later in https://ge" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322122 (owner: 10Matthias Mullie) [12:43:54] (03CR) 10Bartosz Dziewoński: "I think countEmpties is from back in the day, when removing an upload did not remove it from the this.uploads array (splice), but instead " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 (owner: 10Matthias Mullie) [12:47:00] (03CR) 10Reedy: "If you just set what you want in LocalSettings, none of these will be set, so it's as configurable as you need." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) (owner: 10Reedy) [12:49:03] (03CR) 10Bartosz Dziewoński: [C: 032] Refactor some more dead code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322276 (owner: 10Matthias Mullie) [12:49:08] (03CR) 10Bartosz Dziewoński: [C: 032] Move flickr interface to upload step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/318240 (owner: 10Matthias Mullie) [12:49:12] (03CR) 10Bartosz Dziewoński: [C: 032] Remove useless empty() methods [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322123 (owner: 10Matthias Mullie) [12:49:16] (03CR) 10Bartosz Dziewoński: [C: 032] Have clear load/unload methods [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322122 (owner: 10Matthias Mullie) [12:52:46] (03Merged) 10jenkins-bot: Have clear load/unload methods [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322122 (owner: 10Matthias Mullie) [12:54:31] (03Merged) 10jenkins-bot: Remove useless empty() methods [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322123 (owner: 10Matthias Mullie) [12:54:36] (03Merged) 10jenkins-bot: Move flickr interface to upload step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/318240 (owner: 10Matthias Mullie) [12:54:56] (03CR) 10Bartosz Dziewoński: [C: 031] "This sounds like a good approach, but needs rebase/changes now, after some of the other patches." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322124 (owner: 10Matthias Mullie) [12:57:49] (03Merged) 10jenkins-bot: Refactor some more dead code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322276 (owner: 10Matthias Mullie) [13:04:24] (03PS1) 10Bartosz Dziewoński: mw.GroupProgressBar: Don't display "0 of 0 files uploaded" when starting [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322642 [13:16:21] (03CR) 10Matthias Mullie: [C: 032] mw.GroupProgressBar: Don't display "0 of 0 files uploaded" when starting [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322642 (owner: 10Bartosz Dziewoński) [13:18:41] (03Merged) 10jenkins-bot: mw.GroupProgressBar: Don't display "0 of 0 files uploaded" when starting [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322642 (owner: 10Bartosz Dziewoński) [14:31:30] 06Multimedia, 06Commons, 10Wikimedia-Site-requests, 13Patch-For-Review: Disable "cross-wiki upload" from zhwiki to commons - https://phabricator.wikimedia.org/T139257#2810640 (10matmarex) 05Open>03Resolved Configuration change deployed. While testing, I noticed that an incorrect error message is displ... [14:53:17] Good morning [15:07:18] (03PS1) 10Bartosz Dziewoński: Update authorship information [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322659 [15:08:14] hello [15:25:54] (03CR) 10MarkTraceur: [C: 032] Update authorship information [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322659 (owner: 10Bartosz Dziewoński) [15:29:29] (03Merged) 10jenkins-bot: Update authorship information [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322659 (owner: 10Bartosz Dziewoński) [15:51:36] 06Multimedia, 10ArchCom-RfC, 06Commons, 10MediaWiki-File-management, and 14 others: Define an official thumb API - https://phabricator.wikimedia.org/T66214#2810806 (10GWicke) I don't see the search for the right granularity as a contradiction, but more as a search for the best set of trade-offs along a con... [16:05:26] (03PS3) 10Bartosz Dziewoński: uw.EventFlowLogger: Ignore noise from module store failures [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/310675 [16:45:13] gilles: Re-ping, I'm looking for a status report on Thumbor if you have a second [17:07:05] MatmaRex: https://usercontent.irccloud-cdn.com/file/1GuKGk61/image.PNG <-- known issue? I don't see any title.replace in master. [17:07:22] Reported in -commons [17:07:50] I guess it may be a core function failing... [17:08:28] marktraceur: sounds like mw.Title [17:08:48] (03PS3) 10Matthias Mullie: Cleaner upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 [17:09:01] hmm [17:09:18] marktraceur: i guess we call mw.Title.newFromUserInput() with undefined rather than string somewhere [17:09:23] Ugh [17:10:13] MatmaRex: Revi says it was between license and details steps. [17:10:32] I don't see any newFromUserInput calls. [17:10:32] marktraceur: when was this reported? looking at the logs, i see a spike in these on 17th november [17:10:37] wanna file a task? [17:10:40] Just now, in -commons [17:10:41] Sure! [17:11:03] (03CR) 10jenkins-bot: [V: 04-1] Cleaner upload handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 (owner: 10Matthias Mullie) [17:11:55] (03CR) 10Matthias Mullie: [C: 04-1] "WIP" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322277 (owner: 10Matthias Mullie) [17:13:14] 06Multimedia, 10UploadWizard: TypeError: undefined is not an object (evaluating title.replace) between Deed and Details steps - https://phabricator.wikimedia.org/T151220#2811103 (10MarkTraceur) [17:14:04] marktraceur: argh, my grep has failed me. this can also happen for mw.Title.newFromText() and new mw.Title() [17:14:10] OK [17:14:15] which we call in a bunch of places [17:17:19] 06Multimedia, 10UploadWizard: TypeError: undefined is not an object (evaluating title.replace) between Deed and Details steps - https://phabricator.wikimedia.org/T151220#2811135 (10matmarex) [17:23:56] 06Multimedia, 10UploadWizard: TypeError: undefined is not an object (evaluating title.replace) between Deed and Details steps - https://phabricator.wikimedia.org/T151220#2811154 (10revi) For your information, I was trying to upload 2 files. (Also said on wikimedia-commons@freenode but relaying here so it doesn... [17:40:58] 06Multimedia, 10UploadWizard: TypeError: undefined is not an object (evaluating title.replace) between Deed and Details steps - https://phabricator.wikimedia.org/T151220#2811244 (10matmarex) @revi If you try to upload the same files again, does the same problem happen? If yes, can you upload them here, so that... [17:46:19] 06Multimedia, 10UploadWizard: TypeError: undefined is not an object (evaluating title.replace) between Deed and Details steps - https://phabricator.wikimedia.org/T151220#2811257 (10revi) F4819065 and F4819064. [17:47:34] 06Multimedia, 10UploadWizard: TypeError: undefined is not an object (evaluating title.replace) between Deed and Details steps - https://phabricator.wikimedia.org/T151220#2811264 (10revi) And yes, it does occur across the browsers. (Tried on Safari first, then Chrome for iOS.) [18:24:42] 06Multimedia, 10UploadWizard: TypeError: undefined is not an object (evaluating title.replace) between Deed and Details steps - https://phabricator.wikimedia.org/T151220#2811445 (10matmarex) a:03matmarex My crystal ball told me that you're selecting the "The license is described by the following wikitext" op... [18:29:36] (03PS1) 10Bartosz Dziewoński: mw.UploadWizardLicenseInput: Correct unguarded for...in [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322709 (https://phabricator.wikimedia.org/T151220) [18:31:03] (03CR) 10MarkTraceur: [C: 032] mw.UploadWizardLicenseInput: Correct unguarded for...in [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322709 (https://phabricator.wikimedia.org/T151220) (owner: 10Bartosz Dziewoński) [18:32:58] (03Merged) 10jenkins-bot: mw.UploadWizardLicenseInput: Correct unguarded for...in [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322709 (https://phabricator.wikimedia.org/T151220) (owner: 10Bartosz Dziewoński) [18:34:36] (03PS1) 10Bartosz Dziewoński: .jshintrc: Disallow unguarded for...in [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322711 (https://phabricator.wikimedia.org/T151220) [18:35:06] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This is actually failing in several places right now." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322711 (https://phabricator.wikimedia.org/T151220) (owner: 10Bartosz Dziewoński) [18:35:23] 06Multimedia, 10ArchCom-RfC, 06Commons, 10MediaWiki-File-management, and 14 others: Define an official thumb API - https://phabricator.wikimedia.org/T66214#2811471 (10Gilles) If you're looking for hardware acceleration/battery saving, JPG is probably your best bet. If you want the most lightweight file, th... [18:36:58] (03CR) 10jenkins-bot: [V: 04-1] .jshintrc: Disallow unguarded for...in [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322711 (https://phabricator.wikimedia.org/T151220) (owner: 10Bartosz Dziewoński) [18:47:56] (03PS2) 10Bartosz Dziewoński: .jshintrc: Disallow unguarded for...in [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322711 (https://phabricator.wikimedia.org/T151220) [18:50:47] (03CR) 10jenkins-bot: [V: 04-1] .jshintrc: Disallow unguarded for...in [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322711 (https://phabricator.wikimedia.org/T151220) (owner: 10Bartosz Dziewoński) [18:55:34] (03PS3) 10Bartosz Dziewoński: .jshintrc: Disallow unguarded for...in [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/322711 (https://phabricator.wikimedia.org/T151220)