[11:43:36] (03PS6) 10Matthias Mullie: Get rid of some event handlers in mw.UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/318020 (https://phabricator.wikimedia.org/T93895) [12:01:32] (03PS1) 10Matthias Mullie: Make failed uploads resumable (after having gone back to tutorial) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/321636 [14:58:22] (03PS1) 10Matthias Mullie: Add "copy all fields" feature again after having failed to submit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/321663 (https://phabricator.wikimedia.org/T150523) [16:59:54] MatmaRex: Jinx, you owe me a soda. :P [17:00:17] marktraceur: twinsies! :D [19:15:26] (03CR) 10Bartosz Dziewoński: [C: 032] "Whoops, didn't notice this fail yesterday. False failure, this is good to go." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/315263 (owner: 10Matthias Mullie) [19:19:32] (03Merged) 10jenkins-bot: Move logic to display uploads to uw.ui.Upload [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/315263 (owner: 10Matthias Mullie) [19:41:30] (03CR) 10Bartosz Dziewoński: [C: 04-1] ""this.allowCloseWindow = mw.confirmCloseWindow( … )" is not unused, this displays the warning message if the user tried to close the brows" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/318019 (https://phabricator.wikimedia.org/T93895) (owner: 10Matthias Mullie) [19:42:29] (03PS5) 10Bartosz Dziewoński: Move this.uploads, addUpload & removeUpload to controllers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/318019 (https://phabricator.wikimedia.org/T93895) (owner: 10Matthias Mullie) [19:42:59] (03CR) 10Bartosz Dziewoński: [C: 032] "(I just restored that.)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/318019 (https://phabricator.wikimedia.org/T93895) (owner: 10Matthias Mullie) [19:45:46] (03CR) 10Bartosz Dziewoński: "https://gerrit.wikimedia.org/r/#/c/259320/ no longer needs this. Most of the changes here have been also made in Matthias's recent patches" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/254913 (owner: 10MarkTraceur) [19:46:16] (03Abandoned) 10Bartosz Dziewoński: Remove upload handling from UploadWizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/254913 (owner: 10MarkTraceur) [19:48:09] (03CR) 10jenkins-bot: [V: 04-1] Move this.uploads, addUpload & removeUpload to controllers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/318019 (https://phabricator.wikimedia.org/T93895) (owner: 10Matthias Mullie) [19:50:45] (03CR) 10Bartosz Dziewoński: [C: 032] "This seems to have started failing much more often than it used to… :/" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/318019 (https://phabricator.wikimedia.org/T93895) (owner: 10Matthias Mullie) [19:54:16] (03PS2) 10Jforrester: uw.EventFlowLogger: Ignore noise from module store failures [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/310675 (owner: 10Bartosz Dziewoński) [19:58:59] (03CR) 10jenkins-bot: [V: 04-1] Move this.uploads, addUpload & removeUpload to controllers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/318019 (https://phabricator.wikimedia.org/T93895) (owner: 10Matthias Mullie) [20:01:32] (03CR) 10Bartosz Dziewoński: [C: 032] "If this fails one more time, I'm going to comment out this junk." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/318019 (https://phabricator.wikimedia.org/T93895) (owner: 10Matthias Mullie) [20:05:03] (03Merged) 10jenkins-bot: Move this.uploads, addUpload & removeUpload to controllers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/318019 (https://phabricator.wikimedia.org/T93895) (owner: 10Matthias Mullie) [20:48:48] MatmaRex: prtksxna https://gerrit.wikimedia.org/r/#/c/247513/9/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.BookletLayout.js [20:48:56] can I delete fileStr? [21:00:47] acutally looks like you meant to use fileStr on line 584... [21:30:59] edsanders: hmm, yeah [21:33:21] MatmaRex: Fixed in https://gerrit.wikimedia.org/r/#/c/321731/1