[08:50:30] <wikibugs>	 06Multimedia, 10MediaWiki-extensions-UniversalLanguageSelector, 10UploadWizard: Use Universal Language Selector (ULS) for selecting languages in the UploadWizard - https://phabricator.wikimedia.org/T148275#2718937 (10Amire80)
[08:59:04] <wikibugs>	 06Multimedia, 10MediaWiki-extensions-UniversalLanguageSelector, 10UploadWizard, 07Easy: Use Universal Language Selector (ULS) for selecting languages in the UploadWizard - https://phabricator.wikimedia.org/T148275#2718956 (10Amire80)
[09:01:22] <wikibugs>	 06Multimedia, 10MediaWiki-extensions-UniversalLanguageSelector, 10UploadWizard, 07Easy: Use Universal Language Selector (ULS) for selecting languages in the UploadWizard - https://phabricator.wikimedia.org/T148275#2718958 (10Amire80)
[13:53:18] <wikibugs>	 06Multimedia, 10MediaWiki-extensions-UniversalLanguageSelector, 10UploadWizard, 07Easy: Use Universal Language Selector (ULS) for selecting languages in the UploadWizard - https://phabricator.wikimedia.org/T148275#2718937 (10MarkTraceur) A couple notes:  * I couldn't find documentation quickly, so on an Ea...
[14:03:42] <thedj>	 brion: i noted that MediaWikiPlayerSupport no longer seems to be loaded/included... I think this is the important difference that breaks the Timedtext
[14:04:18] <thedj>	 this contains TimedText_LoadTextSource, which loads subtitles from json using the content api.
[14:27:35] <thedj>	 Right. so track used to have mwtitle and mwprovider properties, and somehow, i broke those and they now return title and provider.
[14:28:17] <thedj>	 And now the logic in MediaWikiPlayerSupport, skips the api call to bet the parsed content, and fallsback to the info in the src.
[14:45:58] <wikibugs>	 06Multimedia, 10MediaWiki-Uploading, 06Security-Team, 10Wikimedia-SVG-rendering: SVG Upload should (optionally) allow the xhtml namespace - https://phabricator.wikimedia.org/T138783#2410070 (10MothsART) I'm not a draw.io user but i have the same limitation to upload svg files with foreign objects.  I sugge...
[15:00:54] <wikibugs>	 06Multimedia, 10MediaWiki-extensions-UniversalLanguageSelector, 10UploadWizard: Use Universal Language Selector (ULS) for selecting languages in the UploadWizard - https://phabricator.wikimedia.org/T148275#2719202 (10Aklapper) (Removing #easy until sufficient info has been provided for a new contributor)
[15:15:35] <grrrit-wm>	 (03PS1) 10Reedy: [WIP] Bring in getid3 from composer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316066 (https://phabricator.wikimedia.org/T148285) 
[15:21:45] <grrrit-wm>	 (03PS2) 10Reedy: Bring in getid3 from composer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316066 (https://phabricator.wikimedia.org/T148285) 
[15:22:46] <Reedy>	 thedj: brion ^^
[15:28:59] <grrrit-wm>	 (03PS1) 10TheDJ: Repair text track attributes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316068 
[15:29:33] <thedj>	 brion: ^ think that might be the cause.. 
[15:34:32] <Reedy>	 tests!!
[15:34:42] <thedj>	 brion: this also matches the timeframe at which people started reporting this on en.wp etc.
[15:35:10] <thedj>	 yeah this should really get some parsertests
[15:39:33] <grrrit-wm>	 (03CR) 10Reedy: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316066 (https://phabricator.wikimedia.org/T148285) (owner: 10Reedy)
[15:40:47] <Reedy>	 yay, librarisation
[15:41:47] * thedj just hopes no one ever committed fixes to our local copy of getid3 :)
[15:43:09] <Reedy>	 I saw a security fix...
[15:43:33] <Reedy>	 Suggesting it was adapted from upstream
[15:43:39] <Reedy>	 Hopefully adapted as we're using an old verson
[15:43:50] <Reedy>	 https://github.com/wikimedia/mediawiki-extensions-TimedMediaHandler/commits/master/libs/getid3
[15:44:26] <Reedy>	 As far as I can tell, all the fixes come from/went to upstream
[15:44:50] <Reedy>	 https://github.com/wikimedia/mediawiki-extensions-TimedMediaHandler/commit/e2d8a494998d5189b0fa1733ae29b69033edd0d5
[15:45:47] <Reedy>	 thedj: perfect
[15:45:59] <Reedy>	 It looks like upstream adopted csteipps version :)
[15:46:24] <Reedy>	 https://github.com/JamesHeinrich/getID3/blob/master/getid3/getid3.lib.php#L535-L546
[15:46:36] <Reedy>	 WFM :)
[15:47:33] <grrrit-wm>	 (03CR) 10Reedy: "FWIW, all local modifications came from, or went back to upstream, including the security fix by csteipp" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316066 (https://phabricator.wikimedia.org/T148285) (owner: 10Reedy)
[16:00:13] <brion>	 thedj: ah nice. Lemme test
[16:15:39] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] "Confirmed working over remote repo with "commons" role in MediaWiki-Vagrant -- with this in, the frontend switches from pulling the action" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316068 (owner: 10TheDJ)
[16:19:54] <brion>	 thedj: good catch! what a pile of hacks we've had ;)
[16:22:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Repair text track attributes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316068 (owner: 10TheDJ)
[16:28:48] <grrrit-wm>	 (03PS1) 10Brion VIBBER: Repair text track attributes [extensions/TimedMediaHandler] (wmf/1.28.0-wmf.22) - 10https://gerrit.wikimedia.org/r/316069 (https://phabricator.wikimedia.org/T122737) 
[16:38:03] <grrrit-wm>	 (03PS1) 10Reedy: Remove erroneous break [extensions/TimedMediaHandler] (REL1_27) - 10https://gerrit.wikimedia.org/r/316070 (https://phabricator.wikimedia.org/T148284) 
[16:55:33] <thedj>	 brion: yeah, basically this whole dance we do is a result of the fact that we didn't have a clean subtitle serving API
[16:56:23] <thedj>	 brion: what's your opinion about wikitext based SRT ?
[16:56:30] <thedj>	 with the links and such.
[17:15:53] <brion>	 Hate it ;)
[17:16:12] <brion>	 But it might actually be useful ;)
[17:59:14] <grrrit-wm>	 (03CR) 10TheDJ: [C: 032] Remove erroneous break [extensions/TimedMediaHandler] (REL1_27) - 10https://gerrit.wikimedia.org/r/316070 (https://phabricator.wikimedia.org/T148284) (owner: 10Reedy)
[18:03:31] <grrrit-wm>	 (03PS1) 10TheDJ: Move videojs-replay dependecy to devDependencies [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316078 
[18:05:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove erroneous break [extensions/TimedMediaHandler] (REL1_27) - 10https://gerrit.wikimedia.org/r/316070 (https://phabricator.wikimedia.org/T148284) (owner: 10Reedy)
[18:26:38] <wikibugs>	 06Multimedia, 10MediaWiki-extensions-UniversalLanguageSelector, 10UploadWizard: Use Universal Language Selector (ULS) for selecting languages in the UploadWizard - https://phabricator.wikimedia.org/T148275#2719428 (10Amire80) >>! In T148275#2719161, @MarkTraceur wrote: > A couple notes: >  > * I couldn't fin...
[19:27:45] <Reedy>	 brion: thedj: Surely this is what ContentHandler was made to fix? So you don't have to do wikitext ;)
[19:43:23] <grrrit-wm>	 (03CR) 10Legoktm: "This is a library upgrade too right? Can we pull in the same version first, and then upgrade in a separate patch?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316066 (https://phabricator.wikimedia.org/T148285) (owner: 10Reedy)
[19:44:46] <grrrit-wm>	 (03CR) 10Reedy: "We could, but it's more difficult. 1.9.6 was never tagged/branched on the github repo... And not obvious which hash was brought across ori" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316066 (https://phabricator.wikimedia.org/T148285) (owner: 10Reedy)
[19:46:32] <grrrit-wm>	 (03CR) 10Legoktm: [C: 031] "ok, someone else will have to test this then :)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316066 (https://phabricator.wikimedia.org/T148285) (owner: 10Reedy)
[19:49:17] <grrrit-wm>	 (03CR) 10Reedy: "Unless we try and use the hash of https://github.com/JamesHeinrich/getID3/commit/a5d37485ce7d58286c1cc920994b062a45f62043" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316066 (https://phabricator.wikimedia.org/T148285) (owner: 10Reedy)
[20:59:02] <Reedy>	 brion: Any chance you could give my getid3 patches a quick test? :)
[22:03:52] <brion>	 I'll test em later yeah, running errands atm
[23:00:17] <wikibugs>	 06Multimedia, 10MediaWiki-Uploading, 06Security-Team, 10Wikimedia-SVG-rendering: SVG Upload should (optionally) allow the xhtml namespace - https://phabricator.wikimedia.org/T138783#2719723 (10RobLa-WMF) >>! In T138783#2719191, @MothsART wrote: > I'm not a draw.io user but i have the same limitation to upl...