[00:04:51] 06Multimedia, 10UploadWizard, 13Patch-For-Review, 07Technical-Debt: UploadWizard uses deprecated EditFilterMerged hook - https://phabricator.wikimedia.org/T147566#2698347 (10Reedy) a:03Reedy [00:06:48] (03Merged) 10jenkins-bot: Replace EditFilterMerged hook usage [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314625 (https://phabricator.wikimedia.org/T147566) (owner: 10Reedy) [00:07:06] 06Multimedia, 10UploadWizard, 13Patch-For-Review, 07Technical-Debt: UploadWizard uses deprecated EditFilterMerged hook - https://phabricator.wikimedia.org/T147566#2698361 (10Reedy) 05Open>03Resolved [07:52:09] 06Multimedia, 10Wikimedia-Site-requests: Run refreshImageMetadata.php --force - https://phabricator.wikimedia.org/T32961#2698805 (10MoritzMuehlenhoff) [07:52:12] 06Multimedia, 06Commons, 06Operations: Deploy a PHP and HHVM patch (Exif values retrieved incorrectly if they appear before IFD) - https://phabricator.wikimedia.org/T140419#2698802 (10MoritzMuehlenhoff) 05Open>03Resolved @matmarex : I'm currently preparing the next HHVM update, but when having a closer l... [08:57:56] (03CR) 10Matthias Mullie: "By itself, not so much." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314023 (owner: 10Matthias Mullie) [08:59:46] (03CR) 10Matthias Mullie: Only paint the elements once we move into a step, instead of on construct (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314022 (owner: 10Matthias Mullie) [09:14:31] (03CR) 10Matthias Mullie: Inject the button in a less hacky way (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314020 (owner: 10Matthias Mullie) [09:14:36] (03PS4) 10Matthias Mullie: Inject the button in a less hacky way [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314020 [09:18:07] (03PS3) 10Matthias Mullie: Add 'back' button throughout UW workflow [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314024 (https://phabricator.wikimedia.org/T122923) [09:19:22] (03CR) 10Matthias Mullie: Add 'back' button throughout UW workflow (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314024 (https://phabricator.wikimedia.org/T122923) (owner: 10Matthias Mullie) [12:09:54] brion: i updated the videojs-ogvjs plugin to support the supportsFullScreen check for iOS. [12:13:48] it's because the element has a fixed width... [13:03:55] gilles: before i start digging in: perhaps you know an obvious and trivial solution to https://phabricator.wikimedia.org/T141739 (bad thumbnails for CMYK JPGs)? [13:05:22] MatmaRex: nope, I'll try that file with thumbor out of curiosity to see if it fares any better [13:06:55] there are a couple more examples in the comments that may or may not be the same problem (but all are CMYK files with broken thumbnails) [13:08:33] the Youngstone one works fine with Thumbor, I'll try the other one [13:08:54] if Thumbor handles all of them fine, I wouldn't make fixing that a priority since I plan to have thumbor serve all thumbnail traffic at some point this quarter [13:09:37] it could be as simple as an imagemagick bug and a different version of IM between the imagescalers and the thumbor boxes [13:12:20] I'll report back on the ticket once I've checked all the images [13:18:21] 06Multimedia, 06Commons, 10MediaWiki-File-management: Issue with displaying thumbnail for a progressive CMYK-JPG image - https://phabricator.wikimedia.org/T141739#2510108 (10Gilles) Our current version of Thumbor+plugins in production handles those fine: {F4572091} {F4572090} {F4572089} Since the plan is... [13:31:02] (03CR) 10Bartosz Dziewoński: [C: 032] Inject the button in a less hacky way [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314020 (owner: 10Matthias Mullie) [13:31:11] (03CR) 10Bartosz Dziewoński: [C: 032] Use same 'next' button classes in upload & details step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314021 (owner: 10Matthias Mullie) [13:32:50] (03Merged) 10jenkins-bot: Inject the button in a less hacky way [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314020 (owner: 10Matthias Mullie) [13:32:58] gilles: thanks. i'll spend some time looking into this, but not too much ;) [13:40:39] (03PS3) 10Bartosz Dziewoński: Use same 'next' button classes in upload & details step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314021 (owner: 10Matthias Mullie) [13:40:49] MatmaRex: hi, could u help me with a small oojs ui issue ? [13:41:02] thedj: sure, what's up? [13:41:19] https://en.wikipedia.org/wiki/MediaWiki:Gadget-PrintOptions.js [13:41:24] dialog.close() [13:41:39] but that stuff seems to execute during the animation. [13:41:46] (03CR) 10Bartosz Dziewoński: [C: 032] Use same 'next' button classes in upload & details step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314021 (owner: 10Matthias Mullie) [13:42:22] am i doing it wrong, or is the animation always after close, is there another promise i should use ? [13:43:16] i don't use this stuff often enough :( [13:43:36] hmm. no, your code looks right [13:43:53] maybe i just need to setTimeout it.... [13:44:13] move it to the next draw cycle. [13:46:32] thedj: it seems to work correctly for me though? [13:47:07] MatmaRex: for me sometimes it work, and sometimes, my PDF print has half transparent overlay of the dialog [13:48:12] huh [13:49:35] (03Merged) 10jenkins-bot: Use same 'next' button classes in upload & details step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314021 (owner: 10Matthias Mullie) [13:50:31] https://phabricator.wikimedia.org/F4572180 [13:50:34] MatmaRex: ^ [13:50:58] that was with Chrome [13:51:20] thedj: this is not impossible, i think we just use setTimeout() with a delay that should fire after the animation finishes, so if the browser doesn't synchronise them this could happen. there's some event for CSS animation finishing, but IIRC it was too unreliable [13:51:54] MatmaRex: right, so i'll probably just further delay with a setTimeout of my own then. [13:52:38] MatmaRex: thx for the help, i feared i was just doing somethig wrong/stupid [13:53:19] but one dependency less on jquery.ui now at least ! [13:55:42] thedj: yeah, that makes sense [14:20:16] (03PS3) 10Bartosz Dziewoński: Only paint the elements once we move into a step, instead of on construct [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314022 (owner: 10Matthias Mullie) [14:20:25] (03CR) 10Bartosz Dziewoński: [C: 032] "Rebased." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314022 (owner: 10Matthias Mullie) [14:22:32] (03Merged) 10jenkins-bot: Only paint the elements once we move into a step, instead of on construct [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314022 (owner: 10Matthias Mullie) [14:40:26] (03PS3) 10Bartosz Dziewoński: Make displaying next button configurable/conditional [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314023 (owner: 10Matthias Mullie) [14:44:25] 06Multimedia, 06Commons, 10MediaWiki-File-management, 07HHVM, 07Upstream: Exif values retrieved incorrectly if they appear before IFD - https://phabricator.wikimedia.org/T97253#2699512 (10matmarex) (The patch was also backported to HHVM 3.12.8.) [14:44:27] 06Multimedia, 06Commons, 06Operations: Deploy a PHP and HHVM patch (Exif values retrieved incorrectly if they appear before IFD) - https://phabricator.wikimedia.org/T140419#2699513 (10matmarex) Nice surprise. Thanks! [16:26:18] (03CR) 10Bartosz Dziewoński: [C: 032] Make displaying next button configurable/conditional [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314023 (owner: 10Matthias Mullie) [16:28:06] (03Merged) 10jenkins-bot: Make displaying next button configurable/conditional [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314023 (owner: 10Matthias Mullie) [16:41:13] 06Multimedia, 06Commons, 10MediaWiki-File-management, 05MW-1.28-release-notes, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): Exif orientation problem (no metadata extracted due to empty JPEG segment) - https://phabricator.wikimedia.org/T147015#2699708 (10matmarex) To manually purge the cached bad metadata for... [16:42:45] 06Multimedia, 06Commons, 10MediaWiki-File-management: File displaying invalid metadata in Commons, when the original Exif seems fine. - https://phabricator.wikimedia.org/T145953#2699713 (10matmarex) [16:52:52] (03PS4) 10Bartosz Dziewoński: Add 'back' button throughout UW workflow [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314024 (https://phabricator.wikimedia.org/T122923) (owner: 10Matthias Mullie) [16:52:58] (03PS3) 10Bartosz Dziewoński: Remove useless empty() methods [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314025 (owner: 10Matthias Mullie) [16:54:55] 06Multimedia, 06Commons, 10MediaWiki-File-management, 05MW-1.28-release-notes, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): Exif orientation problem (no metadata extracted due to empty JPEG segment) - https://phabricator.wikimedia.org/T147015#2699773 (10jcrespo) ``` MariaDB MARIADB s4-master commonswiki > UP... [16:55:28] 06Multimedia, 06Commons, 10MediaWiki-File-management: File displaying invalid metadata in Commons, when the original Exif seems fine. - https://phabricator.wikimedia.org/T145953#2699774 (10jcrespo) ``` MariaDB MARIADB s4-master commonswiki > UPDATE image SET img_metadata='' WHERE img_name = 'Jena_-_Hummelsbe... [17:07:11] 06Multimedia, 06Commons, 10MediaWiki-File-management, 05MW-1.28-release-notes, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): Exif orientation problem (no metadata extracted due to empty JPEG segment) - https://phabricator.wikimedia.org/T147015#2699824 (10matmarex) The metadata got re-generated as expected (an... [17:08:16] 06Multimedia, 06Commons, 10MediaWiki-File-management: File displaying invalid metadata in Commons, when the original Exif seems fine. - https://phabricator.wikimedia.org/T145953#2699826 (10matmarex) 05Open>03Resolved a:03matmarex The metadata got re-generated as expected (and with correct data) after @... [17:34:08] 06Multimedia, 06Commons, 10MediaWiki-File-management: File displaying invalid metadata in Commons, when the original Exif seems fine. - https://phabricator.wikimedia.org/T145953#2646078 (10Bawolff) For reference, purging stopped updating image metadata as of 9120ee007ae32 [17:34:58] (03PS1) 10Paladox: Update videojs-ogvjs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314728 [17:53:48] (03PS1) 10Paladox: Update videojs to 5.12.3 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314731 [18:05:34] (03PS5) 10Bartosz Dziewoński: Add 'back' button throughout UW workflow [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314024 (https://phabricator.wikimedia.org/T122923) (owner: 10Matthias Mullie) [18:05:44] (03CR) 10Bartosz Dziewoński: "Fixed merge conflict." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314024 (https://phabricator.wikimedia.org/T122923) (owner: 10Matthias Mullie) [18:06:14] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Some quick testing:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314024 (https://phabricator.wikimedia.org/T122923) (owner: 10Matthias Mullie) [18:06:23] (03PS4) 10Bartosz Dziewoński: Remove useless empty() methods [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314025 (owner: 10Matthias Mullie) [18:09:23] 06Multimedia, 10UploadWizard: Warning dialog ("We recommend that you properly fill in all the fields.") is displayed even if there are no warnings in the form - https://phabricator.wikimedia.org/T147659#2699994 (10matmarex) [18:14:12] 06Multimedia, 10UploadWizard: Warning dialog ("We recommend that you properly fill in all the fields.") is displayed even if there are no warnings in the form - https://phabricator.wikimedia.org/T147659#2700029 (10matmarex) p:05Triage>03High a:03matthiasmullie This is probably a regression from f5349bb9e... [22:30:09] 06Multimedia, 06Commons, 10MediaWiki-File-management, 06Wikisource: Store DjVu, PDF extracted text in a structured table instead of img_metadata - https://phabricator.wikimedia.org/T32906#2700749 (10brion) [23:45:51] 06Multimedia, 06Commons, 10MediaWiki-File-management: File displaying invalid metadata in Commons, when the original Exif seems fine. - https://phabricator.wikimedia.org/T145953#2701010 (10Ghouston) Thanks for fixing that file, but there are many others in https://commons.wikimedia.org/wiki/Category:Invalid_...