[10:25:22] I am going to take yuvi's example and try to keep a devlog [13:20:07] prtksxna: Cool :) [13:20:22] prtksxna: Did my response on your patch help? [13:43:17] marktraceur: Yes! [13:43:32] Eeeeexcellent [13:43:45] marktraceur: Very much indeed. The only one that I am not able to re-create is the session expired one [13:44:06] Do I need to clear cookies/localStorage while editing annotations to get that one? [13:44:13] Hm, yeah, you'll probably need to...hm [13:44:34] I think cookies is all you need to clear, but I'm not sure [13:45:06] Logging out from another tab just gives me permissiondenied (when edits are blocked) [13:45:30] prtksxna: Hm. That might be sufficient, then. [13:45:36] Cool [13:46:13] prtksxna: You miiiight want to double-check that the edit token is for the same user as displayed by the page load, but that's probably a feature ahead of anything else in MW. [13:46:53] marktraceur: I don't follow. [13:47:17] Let me make sure I'm making sense. [13:48:58] prtksxna: So, I don't think this should be a FA thing, ignore me [13:49:17] * prtksxna /ignore marktraceur [13:49:29] I think maybe if you're logged out in the middle of a session, mw.Api should give you a warning when you try to get a token [13:49:58] Like, it requests action=query&meta=tokens|userinfo&type=csrf and checks query.userinfo.name against wgUser [13:50:20] marktraceur: I have a clear understanding of how each error that you mentioned in that list likes to return an error. Still going through the api-error messages to find something that might be relevant to FA. [13:50:34] OK! [13:51:03] marktraceur: Hm, I think when I tested I had already added an annotation before logging out in a different tab. [13:51:16] I'm going to file a drive-by feature request against mw.Api but it's really not a big deal [13:51:26] marktraceur: And the second one failed with permissiondenied. [13:51:37] I'll try one without adding an annotation first too. [13:51:39] prtksxna: That's if IP edits are disallowed [13:51:44] Yes. [13:51:57] Which I had done. [13:52:00] prtksxna: I'm saying, if you log out in another window, and are an IP, and the API tells you that when you get your token...maybe a warning is necessary [13:52:13] prtksxna: Or, for that matter, if you log out then log in to a different account. [13:52:42] ahh. I'll add that to the list of tests! [13:53:08] prtksxna: It's not going to behave intelligently right now, I think. [13:53:33] Who isn't FA, or mw.Api? I just need to see what error messages we get. [13:53:41] Either [13:53:54] prtksxna: FA has no error handling yet, you're creating it, so of course this is no different [13:53:55] console.log ALLTHETHINGS [13:54:05] yep yep [13:54:19] prtksxna: But I think mw.Api won't complain either, and maybe it should. [13:59:55] I'll test a bunch of cases that you mentioned and I have in mind [14:07:41] marktraceur mlitn: I might not be attending the standup. Looking at the calenedar it might be just the two of you. [14:09:10] alright! [14:09:42] 06Multimedia, 06Commons, 10MediaWiki-File-management, 07Easy, 13Patch-For-Review: $wgImageLimits filter not correct - https://phabricator.wikimedia.org/T67158#2670667 (10Aklapper) One-liner patch needs to be rewritten as file location has changed in the repository, after that https://gerrit.wikimedia.org... [14:28:45] Cool cool [14:29:08] mlitn: I actually don't have anything to say really, maybe we can skip it unless you have something to talk about [14:29:57] not really, but I do have a question [14:30:21] I’m working on https://phabricator.wikimedia.org/T141907, and as MatmaRex noted: there already is a “Remove” button in the details step [14:30:47] was there ever (and is there still) any reason it isn’t just always available? [14:31:08] (I’m going to make it so, unless there’s a good reason to hide it :p) [14:35:36] mlitn: I think once upon a time it would mess up the universe if uploads disappeared halfway through the process [14:36:17] ok, then I’ll take care not to mes up the universe when making it available :D [14:37:02] mlitn: Notably, on the deed step, the interface representing one upload is very small...and on the thanks step, removing an upload wouldn't make much sense [14:39:24] yeah, it’s probably only useful in the details step, where people are prompted for more details and are most likely to reconsider uploading a file [16:18:02] (03PS18) 10Paladox: Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (https://phabricator.wikimedia.org/T100106) [16:20:41] (03PS19) 10Paladox: Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (https://phabricator.wikimedia.org/T100106) [16:22:06] (03CR) 10Paladox: Add a new beta feature to enable Videojs (036 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (https://phabricator.wikimedia.org/T100106) (owner: 10Paladox) [16:23:03] (03PS20) 10Paladox: Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (https://phabricator.wikimedia.org/T100106) [16:24:11] (03CR) 10Paladox: Add a new beta feature to enable Videojs (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (https://phabricator.wikimedia.org/T100106) (owner: 10Paladox) [17:34:28] marktraceur: Should we add a timeout? Currently the client waits forever (it felt like forever) if the server is unreachable? [17:38:02] prtksxna: Maybe, but I don't know what that timeout should be [17:38:16] I was wondering the same thing [17:38:25] prtksxna: Especially for slow connections combined with slow computers, it might take a while to get the data, process it, and submit the edit [17:39:21] Oh, and I just realized I hadn't thought about edit conflicts for a while. I'm going to file a separate bug for thaat... [17:40:07] marktraceur: We could use the amount of time it took to load the page (either with Navigation Timing, or ready/load events) and multiply it by a magic number. [17:40:54] Probably a good idea [17:41:05] I might ask James_F|Away if he weren't |Away [17:41:20] marktraceur: I'll create a separate bug for that? [17:42:41] prtksxna: Sure! [17:46:53] (03CR) 10Bartosz Dziewoński: [C: 032] Display warnings in confirmation window [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/311982 (https://phabricator.wikimedia.org/T146155) (owner: 10Matthias Mullie) [17:47:19] 06Multimedia, 10FileAnnotations: FileAnnotations should timeout the request sent to save/delete annotations - https://phabricator.wikimedia.org/T146794#2671312 (10Prtksxna) [17:47:59] 06Multimedia, 10FileAnnotations: FileAnnotations should timeout the request sent to save/delete annotations - https://phabricator.wikimedia.org/T146794#2671330 (10Prtksxna) We could use the amount of time it took to load the page (either with Navigation Timing, or ready/load events) and multiply it by a magic... [17:53:36] 06Multimedia, 10UploadWizard, 13Patch-For-Review: UploadWizard warns of properly filling gin all the fields; isn't clear which fields it wants - https://phabricator.wikimedia.org/T146155#2671337 (10matmarex) > If I fill out the required fields the form should submit. Having a 3rd state (recommended) adds an... [17:54:34] 06Multimedia, 10UploadWizard: UploadWizard warns of properly filling gin all the fields; isn't clear which fields it wants - https://phabricator.wikimedia.org/T146155#2671340 (10matmarex) 05Open>03Resolved After the change: {F4530255} I'll mark this as resolved. See T145674 for discussion about the design... [18:53:42] (03CR) 10Paladox: "@Brion VIBBER or @TheDJ would you be able to re review please?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (https://phabricator.wikimedia.org/T100106) (owner: 10Paladox) [19:36:53] (03PS9) 10Matthias Mullie: Warn/error when date is (likely) incompatible with license [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308177 (https://phabricator.wikimedia.org/T140902) [19:37:04] (03CR) 10Bartosz Dziewoński: "It definitely did not work. (Now it does.)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308177 (https://phabricator.wikimedia.org/T140902) (owner: 10Matthias Mullie) [19:38:31] (03CR) 10Bartosz Dziewoński: [C: 04-1] "There's also an exception if you select e.g. "Original work of NASA", leave the date field empty and try to proceed with "Next" (calling ." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308177 (https://phabricator.wikimedia.org/T140902) (owner: 10Matthias Mullie) [20:27:56] 06Multimedia, 10CirrusSearch, 06Discovery, 06Discovery-Search, and 2 others: Running Cirrus extension unit tests on vagrant produces exception on shutdown - https://phabricator.wikimedia.org/T146811#2671834 (10Smalyshev) [21:07:32] MatmaRex: What was that thing in oojs that lets me do x === undefined || x.y === undefined ... ? [21:08:20] getProp! [21:14:10] (03PS2) 10Prtksxna: [wip] Handle API failures when editing [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/312823 (https://phabricator.wikimedia.org/T145455) [21:14:58] (03CR) 10jenkins-bot: [V: 04-1] [wip] Handle API failures when editing [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/312823 (https://phabricator.wikimedia.org/T145455) (owner: 10Prtksxna) [22:16:31] (03PS21) 10Paladox: Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (https://phabricator.wikimedia.org/T100106) [22:19:13] (03CR) 10Paladox: Add a new beta feature to enable Videojs (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (https://phabricator.wikimedia.org/T100106) (owner: 10Paladox)