[04:09:32] Good morning! [06:38:54] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10Possible-Tech-Projects, and 2 others: Embed image author, description, and copyright data in file metadata fields - https://phabricator.wikimedia.org/T5361#2627520 (10Sumit) Could this project be a good candidate for the current Outreachy-13 internshi... [09:00:09] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10Possible-Tech-Projects, and 2 others: Embed image author, description, and copyright data in file metadata fields - https://phabricator.wikimedia.org/T5361#2627738 (10Bawolff) >>! In T5361#2627520, @Sumit wrote: > Could this project be a good candi... [09:08:08] 06Multimedia, 06Commons, 06Discovery, 10GLAM-Tech, and 2 others: Dark archive for Commons - https://phabricator.wikimedia.org/T120454#1854127 (10Bawolff) I agree with legoktm's assessment above that this task would be rather ambitious for an outreachy project. As an aside it should be noted, that commons... [09:16:51] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10Possible-Tech-Projects, and 2 others: Embed image author, description, and copyright data in file metadata fields - https://phabricator.wikimedia.org/T5361#2627783 (10Qgil) CCing @Gilles to weigh in ref Thumbor. [09:25:51] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10Possible-Tech-Projects, and 2 others: Embed image author, description, and copyright data in file metadata fields - https://phabricator.wikimedia.org/T5361#2627793 (10Gilles) The current Thumbor implementation, due to roll out for all thumbnail traffi... [11:43:03] (03CR) 10Matthias Mullie: Warn/error when date is (likely) incompatible with license (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308177 (https://phabricator.wikimedia.org/T140902) (owner: 10Matthias Mullie) [11:43:08] (03PS5) 10Matthias Mullie: Warn/error when date is (likely) incompatible with license [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308177 (https://phabricator.wikimedia.org/T140902) [11:44:56] (03CR) 10jenkins-bot: [V: 04-1] Warn/error when date is (likely) incompatible with license [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308177 (https://phabricator.wikimedia.org/T140902) (owner: 10Matthias Mullie) [11:47:53] (03PS6) 10Matthias Mullie: Warn/error when date is (likely) incompatible with license [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308177 (https://phabricator.wikimedia.org/T140902) [11:49:53] (03CR) 10jenkins-bot: [V: 04-1] Warn/error when date is (likely) incompatible with license [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308177 (https://phabricator.wikimedia.org/T140902) (owner: 10Matthias Mullie) [12:26:09] (03PS1) 10Matthias Mullie: Get rid of call to no longer existing method [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/309977 [12:58:55] 06Multimedia: New Phabricator tasks and new Gerrit changesets about FileAnnotations should be reported in #wikimedia-multimedia IRC channel - https://phabricator.wikimedia.org/T144997#2628367 (10matmarex) >>! In T144997#2619423, @Aklapper wrote: >> should be reported in #wikimedia-multimedia IRC channel > > by... [13:00:25] (03PS11) 10Matthias Mullie: Replace pipes in input before feeding them into a template [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/307115 (https://phabricator.wikimedia.org/T140901) [13:00:34] (03CR) 10Matthias Mullie: Replace pipes in input before feeding them into a template (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/307115 (https://phabricator.wikimedia.org/T140901) (owner: 10Matthias Mullie) [13:02:14] (03CR) 10jenkins-bot: [V: 04-1] Replace pipes in input before feeding them into a template [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/307115 (https://phabricator.wikimedia.org/T140901) (owner: 10Matthias Mullie) [13:03:57] 06Multimedia, 10MediaWiki-Uploading, 07JavaScript: Exception in module-execute in module mediawiki.Upload.BookletLayout - https://phabricator.wikimedia.org/T145315#2628381 (10matmarex) p:05Triage>03High a:03matmarex [13:25:50] 06Multimedia, 10MediaWiki-Uploading, 07JavaScript, 13Patch-For-Review: Exception in module-execute in module mediawiki.Upload.BookletLayout - https://phabricator.wikimedia.org/T145315#2628486 (10matmarex) 05stalled>03Open [13:43:35] 06Multimedia, 10MediaWiki-Uploading, 05MW-1.28-release-notes, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18), and 2 others: Typehint issue in UploadStash::__construct() (causes uploads from stash via Special:Upload to fatal) - https://phabricator.wikimedia.org/T145228#2628549 (10matmarex) 05Open>03Resolved Fi... [13:46:49] 06Multimedia, 06Commons, 06Discovery, 10GLAM-Tech, and 2 others: Dark archive for Commons - https://phabricator.wikimedia.org/T120454#1854127 (10Mvolz) There might be an automated way to do this with wikidata. But I'm not sure how metadata is stored on commons, I vaguely remember some discussion that these... [14:04:19] 06Multimedia, 06Commons, 06Discovery, 10GLAM-Tech, and 2 others: Dark archive for Commons - https://phabricator.wikimedia.org/T120454#2628651 (10Sadads) Theoretically, this could be done rather robustly per @Mvolz , once we start sharing structured metadata described per T68108 . @Lydia_Pintscher & the #wi... [15:12:01] marktraceur: I guess we could just cancel those for now. I should be able to attend at this time. [15:12:16] those = fish [15:12:56] I can have a saner sleep schedule without the fish standups :D [15:13:17] And how. [15:13:24] I deleted them. [[WP:BOLD]] [15:29:56] marktraceur: Could you reply on https://www.mediawiki.org/wiki/Topic:Tbds4n13hytett3z to make sure I've answered correctly and be specific about the middle bits, as I'm currently hazy. [15:31:46] {{done}} [15:43:33] 06Multimedia, 10Wikibugs, 10grrrit-wm: New Phabricator tasks and new Gerrit changesets about FileAnnotations should be reported in #wikimedia-multimedia IRC channel - https://phabricator.wikimedia.org/T144997#2629044 (10Aklapper) [15:50:54] 06Multimedia, 10Wikibugs, 10grrrit-wm, 13Patch-For-Review: New Phabricator tasks and new Gerrit changesets about FileAnnotations should be reported in #wikimedia-multimedia IRC channel - https://phabricator.wikimedia.org/T144997#2616436 (10Paladox) I can deploy this one https://gerrit.wikimedia.org/r/31002... [16:17:49] (03CR) 10MarkTraceur: [C: 032] Delete 'sourcefiles' directory [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308757 (owner: 10Bartosz Dziewoński) [16:18:24] (03CR) 10MarkTraceur: [C: 032] uw.EventFlowLogger: Fix 'NS_ERROR_NOT_AVAILABLE' debug logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/309364 (https://phabricator.wikimedia.org/T136831) (owner: 10Bartosz Dziewoński) [16:19:56] (03CR) 10jenkins-bot: [V: 04-1] Delete 'sourcefiles' directory [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308757 (owner: 10Bartosz Dziewoński) [16:20:12] (03CR) 10MarkTraceur: [C: 032] Further improve handling of silly canvas #drawImage exceptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/309909 (https://phabricator.wikimedia.org/T136831) (owner: 10Bartosz Dziewoński) [16:20:44] (03CR) 10jenkins-bot: [V: 04-1] uw.EventFlowLogger: Fix 'NS_ERROR_NOT_AVAILABLE' debug logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/309364 (https://phabricator.wikimedia.org/T136831) (owner: 10Bartosz Dziewoński) [16:20:46] (03CR) 10jenkins-bot: [V: 04-1] Further improve handling of silly canvas #drawImage exceptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/309909 (https://phabricator.wikimedia.org/T136831) (owner: 10Bartosz Dziewoński) [16:20:48] No way that's an issue with UW. [16:20:50] marktraceur: uh, someone broke our PHP tests, i think mlitn has a patch for it [16:20:59] OK, I'll review his patches next! [16:21:13] probably https://gerrit.wikimedia.org/r/309977 [16:22:07] (03CR) 10MarkTraceur: [C: 032] Get rid of call to no longer existing method [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/309977 (owner: 10Matthias Mullie) [16:22:21] (03CR) 10MarkTraceur: Further improve handling of silly canvas #drawImage exceptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/309909 (https://phabricator.wikimedia.org/T136831) (owner: 10Bartosz Dziewoński) [16:22:39] Right, gotta wait for the merge. [16:22:49] (03CR) 10MarkTraceur: uw.EventFlowLogger: Fix 'NS_ERROR_NOT_AVAILABLE' debug logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/309364 (https://phabricator.wikimedia.org/T136831) (owner: 10Bartosz Dziewoński) [16:22:52] (03CR) 10MarkTraceur: Delete 'sourcefiles' directory [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308757 (owner: 10Bartosz Dziewoński) [16:23:59] (03Merged) 10jenkins-bot: Get rid of call to no longer existing method [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/309977 (owner: 10Matthias Mullie) [16:27:22] 06Multimedia, 10Wikibugs, 10grrrit-wm, 13Patch-For-Review: New Phabricator tasks and new Gerrit changesets about FileAnnotations should be reported in #wikimedia-multimedia IRC channel - https://phabricator.wikimedia.org/T144997#2629297 (10Paladox) I've deployed https://gerrit.wikimedia.org/r/#/c/310027/ n... [16:27:42] (03PS2) 10MarkTraceur: Delete 'sourcefiles' directory [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308757 (owner: 10Bartosz Dziewoński) [16:27:51] (03CR) 10MarkTraceur: [C: 032] Delete 'sourcefiles' directory [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308757 (owner: 10Bartosz Dziewoński) [16:28:17] (03CR) 10MarkTraceur: [C: 032] uw.EventFlowLogger: Fix 'NS_ERROR_NOT_AVAILABLE' debug logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/309364 (https://phabricator.wikimedia.org/T136831) (owner: 10Bartosz Dziewoński) [16:28:21] (03CR) 10MarkTraceur: [C: 032] Further improve handling of silly canvas #drawImage exceptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/309909 (https://phabricator.wikimedia.org/T136831) (owner: 10Bartosz Dziewoński) [16:28:42] I think it'll try to rebase automatically? It wouldn't let me do it in the interface, maybe I need to run it locally [16:29:39] (03Merged) 10jenkins-bot: Delete 'sourcefiles' directory [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308757 (owner: 10Bartosz Dziewoński) [16:30:31] (03Merged) 10jenkins-bot: uw.EventFlowLogger: Fix 'NS_ERROR_NOT_AVAILABLE' debug logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/309364 (https://phabricator.wikimedia.org/T136831) (owner: 10Bartosz Dziewoński) [16:30:54] (03Merged) 10jenkins-bot: Further improve handling of silly canvas #drawImage exceptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/309909 (https://phabricator.wikimedia.org/T136831) (owner: 10Bartosz Dziewoński) [16:33:53] (03CR) 10Paladox: "testing grrrit-wm" [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/309412 (owner: 10Aaron Schulz) [16:35:45] marktraceur: are you working on https://phabricator.wikimedia.org/T142069 ? i'll take it if not. [16:36:07] MatmaRex: Go for it [16:40:05] (03PS12) 10MarkTraceur: Replace pipes in input before feeding them into a template [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/307115 (https://phabricator.wikimedia.org/T140901) (owner: 10Matthias Mullie) [16:43:06] 06Multimedia, 10FileAnnotations: Make message keys consistent - https://phabricator.wikimedia.org/T142069#2629413 (10matmarex) p:05Triage>03Normal a:03matmarex [16:43:59] (03CR) 10MarkTraceur: [C: 032] Replace pipes in input before feeding them into a template [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/307115 (https://phabricator.wikimedia.org/T140901) (owner: 10Matthias Mullie) [16:44:17] 06Multimedia, 06Commons, 10UploadWizard: Upload Wizard field input validation - https://phabricator.wikimedia.org/T123127#2629425 (10MarkTraceur) [16:44:20] 06Multimedia, 06Commons, 10UploadWizard, 13Patch-For-Review: "|" (pipe) character in any field breaks {{Information}} template and should be replaced with "{{!}}" - https://phabricator.wikimedia.org/T140901#2629424 (10MarkTraceur) 05Open>03Resolved [16:45:54] (03Merged) 10jenkins-bot: Replace pipes in input before feeding them into a template [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/307115 (https://phabricator.wikimedia.org/T140901) (owner: 10Matthias Mullie) [17:06:28] (03CR) 10MarkTraceur: [C: 04-1] "As far as I can tell, this is woefully inadequate unless there are only 10 license templates on a wiki (which is maybe why it worked local" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/309384 (https://phabricator.wikimedia.org/T140903) (owner: 10Matthias Mullie) [17:14:21] (03CR) 10MarkTraceur: [C: 04-1] Warn/error when date is (likely) incompatible with license (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308177 (https://phabricator.wikimedia.org/T140902) (owner: 10Matthias Mullie) [17:21:30] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10Possible-Tech-Projects, and 2 others: Embed image author, description, and copyright data in file metadata fields - https://phabricator.wikimedia.org/T5361#2629622 (10Tgr) >>! In T5361#2627793, @Gilles wrote: > The idea of population EXIF fields based... [18:23:04] 06Multimedia, 06Commons, 06Discovery, 10GLAM-Tech, and 2 others: Dark archive for Commons - https://phabricator.wikimedia.org/T120454#2629879 (10Molgreen) A semi-automatic function would be perfectly adequate. No one knows the legal conditions at the time of automatic release. [18:23:53] MatmaRex: BTW, you're awesome. Thank you! [18:25:12] 06Multimedia, 10MediaWiki-Uploading, 07JavaScript, 05MW-1.28-release-notes, and 2 others: Exception in module-execute in module mediawiki.Upload.BookletLayout - https://phabricator.wikimedia.org/T145315#2629888 (10matmarex) 05Open>03Resolved Fixed and deployed. [18:25:18] :o [19:52:49] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10Possible-Tech-Projects, and 2 others: Embed image author, description, and copyright data in file metadata fields - https://phabricator.wikimedia.org/T5361#2630287 (10Gilles) I don't think that making thumbnail generation dependent on a mediawiki API... [20:06:03] 06Multimedia, 10Wikibugs, 10grrrit-wm, 13Patch-For-Review: New Phabricator tasks and new Gerrit changesets about FileAnnotations should be reported in #wikimedia-multimedia IRC channel - https://phabricator.wikimedia.org/T144997#2630336 (10matmarex) 05Open>03Resolved Thanks folks! [20:06:10] (03PS1) 10Bartosz Dziewoński: Localisation message tweaks [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/310073 (https://phabricator.wikimedia.org/T142069) [20:06:12] (03PS1) 10Bartosz Dziewoński: Minor code conventions and code quality changes all over [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/310074 [20:35:14] (03PS1) 10Bartosz Dziewoński: Make namespace names lowercase, except for first-letter [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/310080 [20:38:12] 06Multimedia, 10FileAnnotations: Missing i18n in API: 'See more images' - https://phabricator.wikimedia.org/T145448#2630458 (10matmarex) [20:43:20] 06Multimedia, 10FileAnnotations: Missing i18n in JS: edit summaries for editing annotations - https://phabricator.wikimedia.org/T145449#2630499 (10matmarex) [20:45:33] 06Multimedia, 10FileAnnotations: Separate FileAnnotator class from code in fileannotations.js that should run on page load - https://phabricator.wikimedia.org/T145450#2630530 (10matmarex) [20:48:33] 06Multimedia, 10FileAnnotations: FileAnnotator should not append itself to - https://phabricator.wikimedia.org/T145453#2630590 (10matmarex) [20:51:17] 06Multimedia, 10FileAnnotations: API queries in FileAnnotations should use formatversion: 2 rather than indexpageids: true - https://phabricator.wikimedia.org/T145454#2630618 (10matmarex) [20:52:31] 06Multimedia, 10FileAnnotations: FileAnnotator should handle edit API failures (simple way to reproduce: disallow a URL with SpamBlacklist) - https://phabricator.wikimedia.org/T145455#2630638 (10matmarex) [20:54:54] UNLEASH THE LIONS [20:55:06] Mark's code is ready to be sacrificed at the altar of code quality [20:55:45] D: [20:55:59] that's almost the last one. [21:00:48] Cool. [21:02:37] 06Multimedia, 10FileAnnotations: Editing a file annotation requires very careful mouse movement - https://phabricator.wikimedia.org/T145458#2630704 (10matmarex) [21:03:33] That's an almost psychopathically good bug report [21:04:33] 06Multimedia, 10FileAnnotations: Editing a file annotation requires very careful mouse movement - https://phabricator.wikimedia.org/T145458#2630720 (10matmarex) I can think of a few ways to fix this, but the easiest one would probably be to display the annotation popup just below the yellow frame, rather than... [21:06:56] marktraceur: i kind of had a thought that we should just redo everything about the popups to look like the ones in VE. https://i.imgur.com/Muf2uyH.png https://i.imgur.com/IwjL0ML.png [21:07:30] if i remember correctly, that's a ProcessDialog inside a PopupWidget [21:07:50] MatmaRex: prtksxna's popups look a little more like that than what I have. [21:08:53] oh, one more thing! [21:09:26] 06Multimedia, 10FileAnnotations: Multi-page media support for annotations - https://phabricator.wikimedia.org/T145459#2630731 (10matmarex) [21:09:50] if nothing else, that would be a good trial to see how extensible this thing is before we try to do this for audio/video ;) [21:10:08] Fair point [21:20:59] MatmaRex: Are you suggesting that the pop-ups in VE are nice?! ;-) [21:22:18] they're not bad, and it'd probably be good to be consistent [21:30:20] (03PS4) 10Paladox: Add jquery.arrowSteps from mw core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/309852 (https://phabricator.wikimedia.org/T144974) [21:54:54] * James_F nods.