[01:25:16] <wikibugs>	 06Multimedia, 10MediaWiki-Uploading, 06Performance-Team: Profile single and multi-chunk upload time for end-users - https://phabricator.wikimedia.org/T130659#2525500 (10Krinkle)
[07:28:38] <grrrit-wm>	 (03PS1) 10Prtksxna: Remove 'UnitTestList' hook [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/303129 (https://phabricator.wikimedia.org/T142120) 
[14:28:59] <prtksxna>	 Is it just me or has Gerrit taken over Ctrl+C and Ctrl+T?
[14:45:02] <MatmaRex>	 prtksxna: it has, in firefox. it's fixed in the next release, to which we're supposed to upgrade soon.
[14:45:14] <MatmaRex>	 there's a bug somewhere.
[14:45:29] <prtksxna>	 marktraceur: Why don't we have a for the birds meeting on Fridays? Is it Saturday somewhere?
[14:45:49] <marktraceur>	 prtksxna: We decided early in the standup process that Fridays would not have meetings
[14:46:01] <marktraceur>	 I think once upon a time it was Wednesday for some reason, but we changed it
[14:46:26] <prtksxna>	 marktraceur: Ah! But I have a fish meeting on fridays.
[14:46:46] <marktraceur>	 prtksxna: Right, there is a certain level of SF-centrism that we have yet to evade :)
[14:47:09] <prtksxna>	 marktraceur: I guess we broke that rule once we started having 2 meetings. My Mondays used to be free, but now there is a bird. Not that I mind, just pointing out.
[14:47:17] <prtksxna>	 marktraceur: (y)
[14:47:30] <marktraceur>	 Mmmkay
[14:48:25] <prtksxna>	 MatmaRex: Good to know! :)
[15:43:31] <wikibugs>	 06Multimedia, 10UploadWizard: Sort files in UploadWizard - https://phabricator.wikimedia.org/T140480#2527570 (10MarkTraceur) Ugh, so, I forgot the perennial problem: Copying metadata.  We expect the first upload in the program's array of uploads to be at the top, so we can copy all of its metadata to the other...
[15:59:04] <grrrit-wm>	 (03PS1) 10MarkTraceur: Give up, put copy metadata widgets on every upload [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/303180 (https://phabricator.wikimedia.org/T90741) 
[15:59:34] <marktraceur>	 MatmaRex: Tell me what you think of that. prtksxna if you're around you should look too
[15:59:44] <marktraceur>	 I think the change to a proper widget has made this change basically trivial and worthwhile.
[16:04:23] <MatmaRex>	 marktraceur: eh, hm, that sounds like it would be a wee bit confusing. (i just read the code, didn't test how it works)
[16:05:55] <marktraceur>	 MatmaRex: I don't think so...I mean, a little weird to copy from the last upload to the first, but it works and it seems clear to me in the interface
[16:05:55] <MatmaRex>	 marktraceur: couldn't we just destroy the this.copyMetadataWidget whenever sort order changes, and re-create it below the now-topmost upload, with that upload passed as 'copyFrom'?
[16:05:55] <marktraceur>	 MatmaRex: No, because that would alter the order of the uploads in the array, which is needless
[16:05:55] <marktraceur>	 MatmaRex: For sorting we only need to alter the order in the interface
[16:05:55] <marktraceur>	 Oh, wait, I see what you mean
[16:06:09] <marktraceur>	 Damn, that was a good refactor. Good work MatmaRex
[16:06:22] <MatmaRex>	 :o
[16:06:34] <marktraceur>	 MatmaRex: That said, I'm not sure this isn't worthwhile on its own merits
[16:06:53] <MatmaRex>	 marktraceur: hm, we can't re-order the uploads array?
[16:07:05] <MatmaRex>	 hmmm
[16:07:07] <marktraceur>	 MatmaRex: We could, I think...but I'm not sure it's necessary
[16:07:15] <MatmaRex>	 even if we can, there's still the queue
[16:07:23] <marktraceur>	 Yuck
[16:07:27] <MatmaRex>	 it'll look silly if we uploda the files in "random" order
[16:07:35] <marktraceur>	 We already do
[16:07:40] <marktraceur>	 But yeah I see your point
[16:07:58] <marktraceur>	 I don't think we need to offer a sort on the uploads step, just details
[16:08:07] <MatmaRex>	 marktraceur: there's some old task with a different design the the copy metadata feature by Pau
[16:08:20] <marktraceur>	 Yeah, we had talked about it but it's a lot of work for a simple bug
[16:08:30] <marktraceur>	 I mentioned that in https://phabricator.wikimedia.org/T140480
[16:08:43] <MatmaRex>	 https://phabricator.wikimedia.org/T90741
[16:08:56] <marktraceur>	 That's the bug I misappropriated for this patch
[16:19:36] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] "tests are already in tests/phpunit" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/303129 (https://phabricator.wikimedia.org/T142120) (owner: 10Prtksxna)
[16:26:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove 'UnitTestList' hook [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/303129 (https://phabricator.wikimedia.org/T142120) (owner: 10Prtksxna)
[17:16:37] <grrrit-wm>	 (03PS1) 10Reedy: Remove 'UnitTestList' hook [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/303215 (https://phabricator.wikimedia.org/T142120) 
[17:58:07] <grrrit-wm>	 (03PS1) 10Jforrester: build: Fix stylelint devDependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/303230 
[18:13:42] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Remove 'UnitTestList' hook [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/303215 (https://phabricator.wikimedia.org/T142120) (owner: 10Reedy)
[18:14:47] <MatmaRex>	 James_F: "fix" what about them?
[18:15:29] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] build: Fix stylelint devDependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/303230 (owner: 10Jforrester)
[18:16:00] <James_F>	 MatmaRex: Unpinned dependency + upstream silent breaking change == sadness.
[18:16:19] <James_F>	 MatmaRex: They previously read the "supported browsers" string in order, so later bits over-rode previous ones; they now don't.
[18:16:25] <MatmaRex>	 James_F: looks pinned to me in UW…
[18:16:29] <MatmaRex>	 or is it upstream's upstream
[18:16:36] <James_F>	 MatmaRex: In US/US.
[18:17:22] <MatmaRex>	 oh, you run grunt-stylelint.
[18:17:28] <MatmaRex>	 but 0.6.0 was a week ago?
[18:17:31] <MatmaRex>	 i am lost. whatever.
[18:17:32] <MatmaRex>	 :P
[18:21:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove 'UnitTestList' hook [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/303215 (https://phabricator.wikimedia.org/T142120) (owner: 10Reedy)
[18:22:15] <James_F>	 MatmaRex: Can you +2 several of the rest of https://gerrit.wikimedia.org/r/#/q/topic:fix-stylelint+status:open ? ;-)
[18:24:26] <MatmaRex>	 James_F: for stuff where it's not my responsibility if it breaks, i'd prefer to know what exactly this is doing, so i'd rather not
[18:24:35] <James_F>	 MatmaRex: No worries.
[18:27:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Fix stylelint devDependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/303230 (owner: 10Jforrester)
[19:50:03] <marktraceur>	 James_F: Would it be too much of a troll to solve https://phabricator.wikimedia.org/T85111 by making the description field a mini-VE surface?
[19:51:06] <James_F>	 marktraceur: Quite the reverse, I think that'd be great. It'd also fix the "users don't remember they can't write '|' in the field" issue.
[19:51:17] <marktraceur>	 Maybe
[19:51:18] <James_F>	 (And probably a few others.)
[19:52:32] <MatmaRex>	 marktraceur: James_F: see also https://phabricator.wikimedia.org/T140901
[19:52:46] <marktraceur>	 Yeah that one is what James_F said
[19:52:47] <James_F>	 Yeah, that one.
[19:52:56] <marktraceur>	 </psychic>
[19:52:58] <James_F>	 It's a bit of a cheat though.
[19:55:18] <wikibugs>	 06Multimedia, 06Commons, 10UploadWizard: UploadWizard lacks path from it to other sister projects - https://phabricator.wikimedia.org/T78524#847438 (10MarkTraceur) I really don't see how this is viable.  While you could maybe, *maybe*, invoke an edit form on the user's "home" wiki with some convoluted cross-...
[19:56:04] <James_F>	 marktraceur: You going to Decline that?
[19:56:17] <marktraceur>	 Ugh, yeah, sorry, I got so excited writing the comment I forgot
[19:56:33] <wikibugs>	 06Multimedia, 10UploadWizard, 07Tracking: Improve UploadWizard UX (tracking) - https://phabricator.wikimedia.org/T96911#2528730 (10MarkTraceur)
[19:56:35] <wikibugs>	 06Multimedia, 06Commons, 10UploadWizard: UploadWizard lacks path from it to other sister projects - https://phabricator.wikimedia.org/T78524#2528729 (10MarkTraceur) 05stalled>03declined
[20:01:47] <marktraceur>	 It might be somewhat inaccurate to claim the dialog solved that problem though
[20:01:50] <marktraceur>	 Anyway
[20:06:43] <marktraceur>	 James_F: Do you know if we still have graphs for UW flow events? MatmaRex?
[20:08:36] <MatmaRex>	 marktraceur: i have a few SQL queries, a batch script to run them on stat1003, and a LibreOffice spreadsheet to analyze the results. also, it's only for errors and JS exceptions. is that what you're looking for? :P
[20:08:54] <marktraceur>	 MatmaRex: Similar. Can you tell me if https://phabricator.wikimedia.org/T77782 still applies to the data you have?
[20:09:13] <marktraceur>	 I suspect it was just not logging skipped steps as expected but I also suspect that might have been fixed sometime in the past two years
[20:09:23] <MatmaRex>	 marktraceur: i don't, but i can run a query or two and find out
[20:09:27] <marktraceur>	 Mmkay
[20:15:52] <MatmaRex>	 marktraceur: from a simple check, it looks still true.
[20:15:57] <MatmaRex>	 select event_step, count(*) from UploadWizardStep_11772724 group by event_step;
[20:15:57] <MatmaRex>	 +------------+----------+
[20:15:57] <MatmaRex>	 | event_step | count(*) |
[20:15:57] <MatmaRex>	 +------------+----------+
[20:15:57] <MatmaRex>	 | deeds      |  1187344 |
[20:15:57] <marktraceur>	 Weird
[20:15:57] <MatmaRex>	 | details    |  1148763 |
[20:15:57] <MatmaRex>	 | file       |  1673516 |
[20:15:58] <MatmaRex>	 | thanks     |  1057632 |
[20:15:59] <MatmaRex>	 | tutorial   |  1574461 |
[20:15:59] <MatmaRex>	 +------------+----------+
[20:16:31] <MatmaRex>	 marktraceur: we allow users to go back to the first step after completing their upload. maybe it's just this?
[20:16:37] <marktraceur>	 That's what I was just typing
[20:16:41] <MatmaRex>	 marktraceur: or maybe we don't log the step if we skip it
[20:16:54] <marktraceur>	 And I think we expect that to be a pretty high number based on newish numbers
[20:16:59] <MatmaRex>	 we could probably check both of those things
[20:17:08] <marktraceur>	 Are those numbers all-time?
[20:17:20] <MatmaRex>	 all-time-ish
[20:17:26] <marktraceur>	 Ish, fair enough
[20:17:32] <MatmaRex>	 starting 2015-04
[20:17:44] <marktraceur>	 Can you try since 2016?
[20:17:56] <MatmaRex>	 one month:
[20:17:57] <MatmaRex>	 | 201607             | deeds      |    66992 |
[20:17:57] <MatmaRex>	 | 201607             | details    |    64850 |
[20:17:57] <MatmaRex>	 | 201607             | file       |    89299 |
[20:17:57] <MatmaRex>	 | 201607             | thanks     |    62199 |
[20:17:57] <MatmaRex>	 | 201607             | tutorial   |    80376 |
[20:18:09] <MatmaRex>	 so still holds for recent data
[20:18:15] <marktraceur>	 OK
[20:18:38] <marktraceur>	 But 9000 doesn't seem like an unreasonable number for people who restart after finishing a session
[20:18:58] <MatmaRex>	 we can totally find out if it's this, we have the data. i juts need to write the query
[20:19:10] <marktraceur>	 An average of 1.111 upload processes per session
[20:19:19] <marktraceur>	 Fair enough
[20:19:30] <MatmaRex>	 we have a unique id for every session, and we log all events with it
[20:19:31] <marktraceur>	 If "skipped" ones aren't getting logged it should be clear from the data
[20:19:35] <MatmaRex>	 so
[20:19:39] * MatmaRex writes queries
[20:19:39] <marktraceur>	 There is a field for that
[20:23:09] <MatmaRex>	 marktraceur: hm, so.
[20:23:12] <MatmaRex>	 select count(*) from UploadWizardStep_11772724 where timestamp like '201607%' and event_step='file';
[20:23:14] <MatmaRex>	 89299
[20:23:17] <MatmaRex>	 select count(distinct event_flowId) from UploadWizardStep_11772724 where timestamp like '201607%' and event_step='file';
[20:23:20] <MatmaRex>	 70093
[20:23:25] <marktraceur>	 Wow
[20:23:29] <marktraceur>	 That's...more
[20:23:35] <marktraceur>	 What about tutorial?
[20:24:16] <MatmaRex>	 so we had 89299 visits to the 'file' step, over 70093 sessions
[20:25:02] <marktraceur>	 Yes, but the numbers above said 80k sessions
[20:25:03] <MatmaRex>	 select count(*) from UploadWizardStep_11772724 where timestamp like '201607%' and event_step='tutorial';
[20:25:05] <MatmaRex>	 80376
[20:25:09] <MatmaRex>	 select count(distinct event_flowId) from UploadWizardStep_11772724 wheretimestamp like '201607%' and event_step='tutorial';
[20:25:12] <MatmaRex>	 80368
[20:25:18] * marktraceur throws hands in air
[20:25:29] <MatmaRex>	 i'm… not sure why these two numbers don't match
[20:25:30] <marktraceur>	 Oh, wait, no, that makes perfect sense
[20:25:45] <marktraceur>	 I mean, not that the numbers don't match
[20:25:52] <marktraceur>	 That's ridiculous
[20:26:05] <marktraceur>	 But it's fine that people saw the tutorial and didn't see the file page
[20:26:11] <marktraceur>	 So that part of the world still makes sense
[20:26:58] <marktraceur>	 So 8 people managed to see the tutorial twice...or one person 9 times or something
[20:27:15] <marktraceur>	 Maybe if someone opened two UW tabs at once the session ID would be the same?
[20:27:25] <marktraceur>	 You'd have to get, like, astronomically lucky to do that
[20:27:35] <MatmaRex>	 it shouldn't be. but i guess it's possible
[20:27:37] <wikibugs>	 06Multimedia, 06Commons, 10UploadWizard: UploadWizard lacks path from it to other sister projects - https://phabricator.wikimedia.org/T78524#2528791 (10Tgr) > We have a path for writing an article with an image, now: Edit the article, and use the in-editor upload dialog to add an image.  Well, except that Co...
[20:27:42] <MatmaRex>	 it's a timestamp plus random plus something
[20:27:57] <marktraceur>	 Well, the random would be based on the timestamp unless JS does something I don't remember
[20:30:51] <MatmaRex>	 i think we need to look at this differently. give me 20 minutes to think, i'll respond on the task :)
[20:35:52] <marktraceur>	 OK
[20:50:43] <marktraceur>	 God wikibugs, the one time I need you
[20:54:07] <MatmaRex>	 :o
[21:00:02] <marktraceur>	 Ooh, James_F, https://phabricator.wikimedia.org/T135085 would be a nice easy win (for MatmaRex too)
[21:00:18] <marktraceur>	 I concur with his estimate of the greatness of his performance fixes
[21:02:00] <James_F>	 Would we want to limit mass-uploads to a class of user?
[21:02:06] <James_F>	 (Mass-beyond-50.)
[21:02:15] <James_F>	 Should we ask on the VP?
[21:03:10] <marktraceur>	 Maybe
[21:03:24] <marktraceur>	 I'm going to try 500 now because I enjoy pain
[21:04:39] <marktraceur>	 Technically it looks fine!
[21:04:44] * James_F grins.
[21:05:08] <marktraceur>	 Oops, the details step is long
[21:16:32] <marktraceur>	 FYI I just requested next week off, I'll be available but not very excited to respond to things ;)
[21:17:11] <wikibugs>	 06Multimedia, 10UploadWizard: Figure out why there are more file steps logged for UW than tutorial steps - https://phabricator.wikimedia.org/T77782#2529311 (10matmarex) 05Open>03Resolved a:03matmarex This is still the case for recent data:  ``` select event_step, count(*) from UploadWizardStep_11772724 w...
[21:17:18] <MatmaRex>	 marktraceur: ^ case closed! ;)
[21:18:32] <marktraceur>	 MatmaRex: Oh, so 8 people started a session in July and got to the file step in August? That's some seriously crazy shit
[21:18:34] <MatmaRex>	 (group_concat with order by is wonderful.)
[21:18:59] <MatmaRex>	 marktraceur: possibly. or the packets just got lost somewhere. :P
[21:19:01] <marktraceur>	 Or...started in June and got to the file step in July, whichever
[21:19:03] <marktraceur>	 Oh, sure
[21:19:46] <marktraceur>	 I guess to get to The Bottom Of This we'd need to query for sessions that started in July, then follow those sessions to the end, and make sure the numbers make sense for those data
[21:19:58] <marktraceur>	 But that's not a problem we need to solve now, I agree
[21:20:33] <wikibugs>	 06Multimedia, 10UploadWizard: Figure out why there are more file steps logged for UW than tutorial steps - https://phabricator.wikimedia.org/T77782#830677 (10MarkTraceur) Yup! Brilliant explanation and some fascinating thoughts.
[21:21:15] <marktraceur>	 And I should probably get home now anyway, so I'll see you all in a week!
[21:21:23] <marktraceur>	 Unless something, like, catastrophic happens
[21:23:03] <MatmaRex>	 enjoy the time off :)
[21:53:50] <wikibugs>	 06Multimedia, 10UploadWizard, 07Browser-Support-Internet-Explorer, 07Browser-Support-Microsoft-Edge: Not enough storage is available to complete this operation - https://phabricator.wikimedia.org/T136239#2529425 (10matmarex) Also happens on IE 10 and mobile IE 11.  ``` select userAgent, count(*) as n from...
[21:55:42] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: mw.UploadWizardUpload: Catch IE's "Not enough storage is available" exceptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/303311 (https://phabricator.wikimedia.org/T136235) 
[21:56:28] <MatmaRex>	 anybody wants to +2 that? ^ this is the last issue i see as blocking T136230
[21:57:28] <wikibugs>	 06Multimedia, 10UploadWizard: Increase the limit of 50 uploads at once (maxUploads) - https://phabricator.wikimedia.org/T135085#2287810 (10Jdforrester-WMF) @Josve05a (or other community Commoners), do you think that this higher limit should be available to all or should it be restricted in some way?
[22:05:38] <wikibugs>	 06Multimedia, 10UploadWizard: Increase the limit of 50 uploads at once (maxUploads) - https://phabricator.wikimedia.org/T135085#2529448 (10Josve05a) >>! In T135085#2529430, @Jdforrester-WMF wrote: > @Josve05a (or other community Commoners), do you think that this higher limit should be available to all or shou...
[22:09:48] <wikibugs>	 06Multimedia, 10UploadWizard: Increase the limit of 50 uploads at once (maxUploads) - https://phabricator.wikimedia.org/T135085#2529450 (10Jdforrester-WMF) >>! In T135085#2529448, @Josve05a wrote: >>>! In T135085#2529430, @Jdforrester-WMF wrote: >> @Josve05a (or other community Commoners), do you think that th...