[08:21:14] 06Multimedia, 10MediaWiki-Gallery: Add a tooltip on the centered icon to the rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T140593#2469847 (10Trizek-WMF) [08:23:14] 06Multimedia, 10MediaWiki-Gallery: Add a tooltip on the centered icon to the rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T140593#2469876 (10Trizek-WMF) [08:24:17] 06Multimedia, 10MediaWiki-Gallery, 07Design, 05MW-1.28-release-notes, and 2 others: Consider not to open MediaViewer when a user clicks on a thumbnail on the rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T140595#2469881 (10Trizek-WMF) [08:24:33] 06Multimedia, 10MediaWiki-Gallery: Consider not to open MediaViewer when a user clicks on a thumbnail on the rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T140595#2469896 (10Trizek-WMF) [08:26:36] 06Multimedia, 10MediaWiki-Gallery: Have a constant height between images would be appreciated in rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T140596#2469903 (10Trizek-WMF) [08:27:30] 06Multimedia, 10MediaWiki-Gallery, 07Design, 05MW-1.28-release-notes, and 3 others: Provide an rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T128429#2074517 (10Trizek-WMF) >>! In T128429#2467303, @Jdforrester-WMF wrote: >>>! In T128429#2465270, @Trizek-WMF wrote: >>>... [10:58:50] 06Multimedia, 10UploadWizard: When using UploadWizard, thumbnails fail to appear or files are missing on the "Release rights" webpage - https://phabricator.wikimedia.org/T97770#1251848 (10matthiasmullie) @Jacklee: how do experiencing this issue? Is there a specific image that consistently fails? Or some specif... [11:04:44] 06Multimedia, 10UploadWizard: When using UploadWizard, thumbnails fail to appear or files are missing on the "Release rights" webpage - https://phabricator.wikimedia.org/T97770#2470170 (10Jacklee) I think it was a transient problem. I have not experienced it for some time. [12:13:08] 06Multimedia, 10MediaWiki-Gallery, 07Design, 05MW-1.28-release-notes, and 3 others: Provide an rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T128429#2470310 (10Amire80) Ow, sorry, only noticed this now. >>! In T128429#2357019, @Prtksxna wrote: > @Amire80, should a n... [12:53:40] 06Multimedia, 10MediaWiki-Parser: Exclude redundant srcset attribute values (e.g. same url) - https://phabricator.wikimedia.org/T135550#2470417 (10matthiasmullie) a:03matthiasmullie [13:17:50] OK, good morning everyone! [13:18:02] I imagine I have a lot of MatmaRex code review to do today [14:25:10] in the foreign db setup for commons, does commons count as 'local' ? It shouldn't right ? [14:32:56] 06Multimedia, 10UploadWizard: Category/description warnings mandatory without clear instructions - https://phabricator.wikimedia.org/T139919#2470962 (10Nemo_bis) I confirm the workaround (creating the categories before adding them in the wizard) worked in the next upload. [15:15:14] 06Multimedia, 10Wikimedia-Site-requests: Run refreshImageMetadata.php --force - https://phabricator.wikimedia.org/T32961#2471162 (10matmarex) I'd say start the script, let it run for a day or two while watching its memory usage with `top` or something, and verify that it doesn't grow indefinitely? Anyway, ther... [15:40:44] marktraceur: Hey, sorry to ask but there's a UBN in MediaViewer that edsanders has patches to fix – could you review so we can back-port? https://phabricator.wikimedia.org/T140574 [15:40:58] James_F: Looking! [15:41:03] Ta. [15:41:58] James_F: So the last one is what you prefer? [15:43:10] marktraceur: I like any of them. The Title.newFromImg one seems simplest. [15:43:18] Sure [15:43:26] marktraceur: (They all should be merged, but only one of them is needed to be backported.) [15:43:36] {{done}} [15:43:56] Ta. [15:43:59] James_F: Unless you want me to look at more of them, I assume the UBN is done and I can refocus [15:44:08] marktraceur: That's fine, thanks! [15:47:09] i'll look at the others. saw them in my inbox, didn't realize this was UBN. [17:37:44] 06Multimedia, 06Commons, 10GLAM-Tech, 10MediaWiki-Uploading: Allow +sysop (and other?) users to upload from any URL, not limited to the whitelist - https://phabricator.wikimedia.org/T140040#2450740 (10Tgr) IIRC GWToolset also uses `$wgCopyUploadsDomains` as a whitelist. [17:43:45] (03CR) 10MarkTraceur: [C: 032] Copy .ui-helper-clearfix CSS class from jQuery UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299488 (https://phabricator.wikimedia.org/T140582) (owner: 10Bartosz Dziewoński) [17:44:35] (03CR) 10MarkTraceur: [C: 032] Remove unnecessary jQuery UI classes from #mwe-upwiz-steps [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299351 (https://phabricator.wikimedia.org/T140582) (owner: 10Bartosz Dziewoński) [17:45:19] (03CR) 10MarkTraceur: [C: 032] Remove a weird CSS class that was only used once [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299490 (owner: 10Bartosz Dziewoński) [17:47:00] (03CR) 10MarkTraceur: [C: 032] Simplify styles for .ui-corner-* [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299491 (owner: 10Bartosz Dziewoński) [17:47:25] (03Merged) 10jenkins-bot: Copy .ui-helper-clearfix CSS class from jQuery UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299488 (https://phabricator.wikimedia.org/T140582) (owner: 10Bartosz Dziewoński) [17:49:04] (03Merged) 10jenkins-bot: Remove unnecessary jQuery UI classes from #mwe-upwiz-steps [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299351 (https://phabricator.wikimedia.org/T140582) (owner: 10Bartosz Dziewoński) [17:49:45] (03Merged) 10jenkins-bot: Remove a weird CSS class that was only used once [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299490 (owner: 10Bartosz Dziewoński) [17:51:14] (03CR) 10Jdlrobson: [C: 031] "With respect to your concerns in the commit, sometimes you have to move backwards to go forwards. I agree that moving away from jQuery UI " (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299492 (https://phabricator.wikimedia.org/T140581) (owner: 10Bartosz Dziewoński) [17:52:29] (03Merged) 10jenkins-bot: Simplify styles for .ui-corner-* [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299491 (owner: 10Bartosz Dziewoński) [17:52:55] (03CR) 10Jdlrobson: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/296832 (https://phabricator.wikimedia.org/T97169) (owner: 10Bartosz Dziewoński) [17:55:40] (03CR) 10Jdlrobson: [C: 031] "Looks good but you may want to consider introducing a kill switch given the historic issues that Wikimedia Commons editors have had with t" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/296832 (https://phabricator.wikimedia.org/T97169) (owner: 10Bartosz Dziewoński) [17:59:26] 06Multimedia, 10UploadWizard, 13Patch-For-Review: Stop using jQuery UI Selectable for Flickr uploads - https://phabricator.wikimedia.org/T140581#2471905 (10matmarex) [17:59:28] 06Multimedia, 06Editing-Department, 10UploadWizard, 07Epic, 13Patch-For-Review: [EPIC] Enable UploadWizard on mobile - https://phabricator.wikimedia.org/T97169#2471906 (10matmarex) [17:59:30] 06Multimedia, 10UploadWizard: Stop relying on jQuery UI styles in UploadWizard - https://phabricator.wikimedia.org/T140582#2471903 (10matmarex) 05Open>03Resolved [18:16:54] (03CR) 10Bartosz Dziewoński: "Yeah, I know. I think that was mostly an issue with the interface being too simple, and not mobile-vs-desktop; we at the latest incarnatio" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/296832 (https://phabricator.wikimedia.org/T97169) (owner: 10Bartosz Dziewoński) [18:19:05] James_F: Do you have an opinion on the checkbox implementation of the Flickr integration? I have very little problem with it especially since only admins on Commons even use the tool, but I figured I'd check. [18:21:02] marktraceur: Fine by me. As you say, change for a handful of Commons sysops only. [18:21:22] (03CR) 10Jforrester: [C: 031] "Product +1" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299492 (https://phabricator.wikimedia.org/T140581) (owner: 10Bartosz Dziewoński) [18:21:48] (03CR) 10Bartosz Dziewoński: mw.FlickrChecker: Replace jQuery UI Selectable with CheckboxMultiselectWidget (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299492 (https://phabricator.wikimedia.org/T140581) (owner: 10Bartosz Dziewoński) [18:23:19] MatmaRex: Do you want to mess with the message name or should I just steamroll over that? [18:23:51] marktraceur: i like the current one [18:24:07] Mmmkay [18:24:12] (03CR) 10MarkTraceur: [C: 032] mw.FlickrChecker: Replace jQuery UI Selectable with CheckboxMultiselectWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299492 (https://phabricator.wikimedia.org/T140581) (owner: 10Bartosz Dziewoński) [18:25:54] (03Merged) 10jenkins-bot: mw.FlickrChecker: Replace jQuery UI Selectable with CheckboxMultiselectWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299492 (https://phabricator.wikimedia.org/T140581) (owner: 10Bartosz Dziewoński) [18:32:19] 06Multimedia, 06Editing-Department, 10UploadWizard, 07Epic, 13Patch-For-Review: [EPIC] Enable UploadWizard on mobile - https://phabricator.wikimedia.org/T97169#2471978 (10matmarex) [18:32:21] 06Multimedia, 10UploadWizard: Stop using jQuery UI Selectable for Flickr uploads - https://phabricator.wikimedia.org/T140581#2471976 (10matmarex) 05Open>03Resolved [18:37:29] 06Multimedia, 10UploadWizard: Stop using jQuery UI Selectable for Flickr uploads - https://phabricator.wikimedia.org/T140581#2471990 (10matmarex) | Before | After | | -- | -- | |{F4286132} | {F4286139} | [19:05:07] (03Abandoned) 10Bartosz Dziewoński: Mark UploadWizard uploads with a change tag (and Flickr uploads separately) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/292284 (https://phabricator.wikimedia.org/T121872) (owner: 10Bartosz Dziewoński) [19:09:30] 06Multimedia, 10UploadWizard, 13Patch-For-Review: Mark UploadWizard Flickr uploads with a separate change tag - https://phabricator.wikimedia.org/T121880#1890758 (10matmarex) [19:09:32] 06Multimedia, 06Commons, 10MediaWiki-Change-tagging, 10MediaWiki-Uploading: Allow various uploading tools on Commons to mark their uploads with change tags - https://phabricator.wikimedia.org/T121864#2472181 (10matmarex) [19:09:35] 06Multimedia, 10UploadWizard, 13Patch-For-Review: Mark UploadWizard uploads with a change tag - https://phabricator.wikimedia.org/T121872#2472176 (10matmarex) 05Open>03declined I actually don't think this would be very useful, since UploadWizard is the most popular uploading tool on Commons (by the numbe... [19:10:23] 06Multimedia, 10MediaWiki-Special-pages: Special:NewFiles is lame - https://phabricator.wikimedia.org/T121870#2472191 (10matmarex) [19:10:25] 06Multimedia, 06Commons, 10MediaWiki-Change-tagging, 10MediaWiki-Uploading: Allow various uploading tools on Commons to mark their uploads with change tags - https://phabricator.wikimedia.org/T121864#2472189 (10matmarex) 05Open>03Resolved I think this is sufficiently complete. [19:15:37] (03CR) 10Jforrester: [C: 031] uw.DateDetailsWidget: Treat date input as UTC+14 rather than UTC to avoid false warnings [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/298983 (https://phabricator.wikimedia.org/T139808) (owner: 10Bartosz Dziewoński) [19:21:17] (03CR) 10MarkTraceur: [C: 032] "This strikes me as vaguely nasty, but it should be okay for now. I do wish we had a better solution." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/298983 (https://phabricator.wikimedia.org/T139808) (owner: 10Bartosz Dziewoński) [19:24:15] (03Merged) 10jenkins-bot: uw.DateDetailsWidget: Treat date input as UTC+14 rather than UTC to avoid false warnings [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/298983 (https://phabricator.wikimedia.org/T139808) (owner: 10Bartosz Dziewoński) [19:58:18] 06Multimedia, 06Commons, 10MediaWiki-API, 10MediaWiki-File-management, and 2 others: misleading error about thumbnails for OGG audio files - https://phabricator.wikimedia.org/T137632#2472511 (10matmarex) I'm very sorry for my late response, I was dealing with other things and this fell to the second page o... [19:58:41] (03PS1) 10Bartosz Dziewoński: Unbreak audio thumbnail width [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/299616 (https://phabricator.wikimedia.org/T137632) [19:59:29] marktraceur: I rebased https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/FileAnnotations,dashboards/default and everything is complaining for jshint/jscs issues, sorry. Not sure if they're half-finished thoughts or actual issues. [19:59:40] Hm. [20:00:40] James_F: parseInt warnings, a few variables that got deleted [20:00:54] Will fix [20:01:13] marktraceur: Yeah, I wasn't sure if the variables got intentionally deleted or just mislaid. :-) [20:03:54] (03CR) 10Bartosz Dziewoński: "Follow-up: I4404b56fb49b851146f94b0ea3e9fca02785dbaa" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/294121 (https://phabricator.wikimedia.org/T137632) (owner: 10Bartosz Dziewoński) [20:04:15] 06Multimedia, 10UploadWizard, 13Patch-For-Review, 05WMF-deploy-2016-07-19_(1.28.0-wmf.11): UploadWizard ignores time zones in creation date, warns about its own suggested "today" - https://phabricator.wikimedia.org/T139808#2472540 (10matmarex) p:05Triage>03Normal [20:13:25] 06Multimedia, 10MediaWiki-Uploading: The UploadVerifyFile hook should say whether the upload is going to be immediately published, so consumers of UploadVerifyUpload hook can skip duplicate checks - https://phabricator.wikimedia.org/T140521#2472576 (10matmarex) p:05Triage>03High a:03matmarex [20:20:00] 06Multimedia, 10UploadWizard, 05WMF-deploy-2016-07-19_(1.28.0-wmf.11): UploadWizard ignores time zones in creation date, warns about its own suggested "today" - https://phabricator.wikimedia.org/T139808#2472621 (10matmarex) 05Open>03Resolved [20:43:34] Ugh, missing API documentation. What a shitty way to fail the tests. [20:45:12] (03CR) 10Jdlrobson: "WFM but note there is a task to remove `targets` at some point so you may want to build something in for the longer term - e.g. a config v" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/296832 (https://phabricator.wikimedia.org/T97169) (owner: 10Bartosz Dziewoński) [21:19:58] 06Multimedia, 06Commons, 10MediaWiki-File-management: img_auth.php: How to implement access checks using a custom file backend / repo? - https://phabricator.wikimedia.org/T140334#2460989 (10Tgr) One option would be to add some new `FileBackend::canView( $user, $path )` method and call that instead of `Reques... [21:43:09] (03CR) 10Jforrester: [C: 031] Unbreak audio thumbnail width [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/299616 (https://phabricator.wikimedia.org/T137632) (owner: 10Bartosz Dziewoński) [22:02:25] 06Multimedia, 10UploadWizard: Sort files in UploadWizard - https://phabricator.wikimedia.org/T140480#2473145 (10matmarex) p:05Triage>03Low Hmm. That would be a much bigger patch. [22:07:53] 06Multimedia, 10UploadWizard, 07Technical-Debt: Refactor UploadWizard to be maintainable - https://phabricator.wikimedia.org/T96906#2473182 (10Jdforrester-WMF) [22:07:55] 06Multimedia, 06Editing-Department, 10UploadWizard, 07Epic, 13Patch-For-Review: [EPIC] Enable UploadWizard on mobile - https://phabricator.wikimedia.org/T97169#2473183 (10Jdforrester-WMF) [22:16:58] 06Multimedia, 06Commons, 10UploadWizard: Upload Wizard: Error fails indicating "undesirable characters" but does not indicate which characters this might be - https://phabricator.wikimedia.org/T140222#2473229 (10matmarex) p:05Triage>03Normal a:03matmarex > The user does not know which characters are un... [22:18:01] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10MediaWiki-Maintenance-scripts: refreshImageMetadata.php maintenance script should handle oldimage.oi_metadata and filearchive.fa_metadata (in addition to image.img_metadata) - https://phabricator.wikimedia.org/T140543#2473236 (10matmarex) p:05Triage... [22:59:26] I have no audio, sorry. [23:01:07] James_F: Not attending, then? [23:01:13] No. [23:01:19] OK! Standup is cancelled. Thanks! [23:01:27] That works well but I wish I'd known it earlier. :P [23:01:36] marktraceur: But if you have a little time https://gerrit.wikimedia.org/r/299616 could do with a merge. [23:01:44] marktraceur: Sorry. [23:01:46] I have zero time, sorry, I have to catch a bus [23:01:54] Kk. Enjoy bus. [23:02:04] I feel bad because I told someone I wouldn't be able to get to the meeting 30 minutes early, and now it looks like I could have [23:20:14] 06Multimedia, 06Commons, 10MediaWiki-Gallery, 13Patch-For-Review: Replace fixed length filename truncation in galleries with CSS solution - https://phabricator.wikimedia.org/T139766#2473510 (10matmarex) From the Gerrit task: >>! @Esanders wrote: > The following CSS can be added to replace the long filenam... [23:34:55] 06Multimedia, 06Commons, 10MediaWiki-Gallery, 13Patch-For-Review: Replace fixed length filename truncation in galleries with CSS solution - https://phabricator.wikimedia.org/T139766#2473538 (10matmarex) I added the CSS to the gadget: * https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadget-Long-I... [23:39:58] 06Multimedia, 06Commons, 10MediaWiki-Gallery, 13Patch-For-Review: Replace fixed length filename truncation in galleries with CSS solution - https://phabricator.wikimedia.org/T139766#2473549 (10matmarex) 05Open>03Resolved