[13:44:29] <marktraceur>	 Good morning!
[13:59:22] <wikibugs>	 06Multimedia, 10UploadWizard, 13Patch-For-Review: Uncaught TypeError: Cannot read property 'resolve' of undefined - https://phabricator.wikimedia.org/T139130#2420437 (10Jdforrester-WMF) Should this now be Resolved?
[14:00:45] <wikibugs>	 06Multimedia, 10UploadWizard: Uncaught TypeError: Cannot read property 'resolve' of undefined - https://phabricator.wikimedia.org/T139130#2437513 (10matmarex) No, I'm still debugging it. The patch above is supposed to help.
[14:03:40] <wikibugs>	 06Multimedia, 10UploadWizard: Move setUploadFilled to the file step controller - https://phabricator.wikimedia.org/T93888#2437521 (10Jdforrester-WMF)
[14:07:13] <marktraceur>	 prtksxna: I owe you review on the gallery patch, James_F brought to my attention just now that it was our quarterly goal, and the quarter is over.
[14:07:45] <James_F>	 marktraceur: See "needs code review" on https://phabricator.wikimedia.org/project/board/48/ ;-)
[14:08:57] <wikibugs>	 06Multimedia, 10UploadWizard: Parse wikicode-categories in the Categories-field - https://phabricator.wikimedia.org/T119246#2437553 (10Jdforrester-WMF) p:05Normal>03Low
[14:09:30] <wikibugs>	 06Multimedia, 10UploadWizard, 07Technical-Debt: Remove this.uploads from the UploadWizard class - https://phabricator.wikimedia.org/T93895#2437556 (10Jdforrester-WMF)
[14:39:42] <MatmaRex>	 marktraceur: prtksxna: so, AbuseFilter stuff… it looks like everything on https://phabricator.wikimedia.org/T138273#2410743 that needed review from anyone else got reviewed, but some things didn't get merged. want to test them one more time and merge?
[14:47:45] <MatmaRex>	 James_F: do you actually use the workboard? or do you know anyone else who does?
[14:48:54] <marktraceur>	 I certainly don't.
[14:49:21] <marktraceur>	 I wish I did, but I don't
[15:25:32] <marktraceur>	 OK, James_F, I'm ready to merge the gallery, sound OK to you? Should I let someone else take a crack at it?
[15:25:55] <James_F>	 marktraceur: Do it.
[15:25:58] <marktraceur>	 Woot
[15:26:13] <James_F>	 MatmaRex: I think Matthias is hoping to use it
[15:26:26] <marktraceur>	 Where is mlitn anyway
[15:27:20] <marktraceur>	 Hooray
[15:27:30] <James_F>	 Hey mlitn. ;-)
[15:27:43] <mlitn>	 lol
[15:27:46] <mlitn>	 thanks for the invite
[15:27:57] <marktraceur>	 My pleasure, we were just talking about Phabricator
[15:28:17] <mlitn>	 I had added this channel to my autojoin list, but hadn’t restarterd yet :p
[15:28:27] <mlitn>	 -r
[15:28:41] <marktraceur>	 Oh noes, prtksxna, it needs a rebase
[16:03:31] <James_F>	 marktraceur: Want me to do so?
[16:03:45] <marktraceur>	 James_F: If you've got a sec, yeah, then I can merge again
[16:03:48] <James_F>	 Kk.
[16:04:29] <James_F>	 It's, unsurprisingly, just the RELEASE-NOTES.
[16:07:22] <James_F>	 marktraceur: (Done, go go go.)
[16:07:52] <marktraceur>	 James_F: Looks like still no, but I'll try anyway
[16:08:19] <marktraceur>	 James_F: I think it's saying something about cross-repo dependencies.
[16:08:27] <James_F>	 marktraceur: That's just gerrit being gerrit.
[16:08:31] <marktraceur>	 Sigh
[16:10:23] <James_F>	 Oh, wait, no. Did someone touch RELEASE-NOTES again in the last 10 minutes?
[16:11:39] * James_F cheats.
[16:11:46] <James_F>	 marktraceur: Try now. :-)
[16:12:53] <marktraceur>	 God
[16:26:36] <marktraceur>	 Merged!
[16:26:39] <marktraceur>	 Thanks prtksxna and James_F
[16:52:12] <marktraceur>	 James_F: Anything you need from us for communication?
[16:52:48] <James_F>	 Nope, I'll handle it.
[16:53:23] <MatmaRex>	 James_F: marktraceur: can we give it a week or two before we announce? just to let it settle. so that if someone reverts it or something, we don't end up announcing a removed feature
[16:53:47] <marktraceur>	 MatmaRex: I mean, we can, it won't show up unless someone explicitly uses it
[16:53:54] <MatmaRex>	 (not that i'm expecting it, but reverts happen)
[16:54:10] <James_F>	 Soundsgood.
[16:54:22] <MatmaRex>	 marktraceur: people will try to use it as soon as you announce it, even if it's not deployed yet, or undeployed, or buggy, or whatever
[16:54:29] <MatmaRex>	 and then they'll file bugs and grumble
[16:54:31] <MatmaRex>	 ;)
[16:54:53] <marktraceur>	 Right
[16:55:01] <marktraceur>	 MatmaRex, James_F, http://en.wikipedia.beta.wmflabs.org/wiki/A_gallery_page
[16:55:11] <marktraceur>	 It's a gallery of only one image, but whatever
[16:55:18] <MatmaRex>	 pretty.
[16:55:25] <James_F>	 Yes, I know, I tested it before you merged. See the screenshot in the slides for Monday.
[17:00:48] <wikibugs>	 06Multimedia, 10MediaWiki-Gallery, 07Design, 05MW-1.28-release-notes, and 3 others: Provide an rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T128429#2438078 (10Jdforrester-WMF) 05Open>03Resolved a:03Prtksxna
[17:10:45] <marktraceur>	 James_F: Yeah, but now it's on the beta cluster! That's more different.
[17:12:20] <James_F>	 :-)
[17:12:47] <James_F>	 Oh, also, need to do a follow-up patch for VE's <gallery> editor adding it.
[17:17:48] <marktraceur>	 Good point
[17:17:57] <marktraceur>	 James_F: Is that "our job"?
[17:39:50] <James_F>	 marktraceur: Sort-of.
[17:40:25] <James_F>	 If we extension-ified the <gallery> code from MW the VE code would move there.
[17:46:49] <James_F>	 marktraceur: https://gerrit.wikimedia.org/r/#/c/297828/ I think.
[18:31:46] <marktraceur>	 Well!
[18:32:21] <marktraceur>	 I'll let a VE-y person deal with that but it looks okay
[19:20:53] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: [WIP] Resume stashed uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/259320 (https://phabricator.wikimedia.org/T85561) (owner: 10MarkTraceur)
[19:20:55] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Consistently pass api in uw.controller.Step subclasses [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/297848 
[19:20:57] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Various small code cleanups [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/297849 
[19:20:59] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: [WIP] mw.FlickrChecker tweaks [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/297850 
[19:22:35] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Yay, this merges again! Well, assuming all the dependencies I made get in… This is mostly the same code as Mark's PS1 (with some small fix" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/259320 (https://phabricator.wikimedia.org/T85561) (owner: 10MarkTraceur)
[19:22:55] <marktraceur>	 Whoa
[19:26:49] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Review:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/259320 (https://phabricator.wikimedia.org/T85561) (owner: 10MarkTraceur)
[19:27:07] <MatmaRex>	 marktraceur: that took all day, heh
[19:27:19] <marktraceur>	 I believe that!
[19:29:25] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "This patch actually does some rather nice things and I think it has future. But the linked list things needs to go. (I'm not saying that a" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/254913 (owner: 10MarkTraceur)
[19:30:47] <MatmaRex>	 marktraceur: also… would you want to work on saving and restoring the upload details data, too? :D the stashed files would be much more useful if we could restore their file names, at least
[19:31:52] <marktraceur>	 MatmaRex: Yeah, I don't know how to do that without breaking, like...mediawiki
[19:31:59] <MatmaRex>	 marktraceur: it's possible to do mw.UploadWizardDetails#getSerialized to dump all details to a nice JS object, and mw.UploadWizardDetails#setSerialized to restore them. (that took a few months :D) so it's probably doable
[19:32:21] <marktraceur>	 MatmaRex: But not across sessions, I guess? localStorage, but not on the server
[19:32:26] <MatmaRex>	 marktraceur: yeah… if we wanted it server-side, that would probably be a biggish piece of work
[19:32:46] <MatmaRex>	 i was also thinking if localStorage would be enough. i don't really want to get into upload stash db schema changes and stuff
[19:33:18] <MatmaRex>	 (that would probably be an easy schema change, as far as they go. there's probably like a couple hundreds rows in that table at most. but still, it's a schema change, ew, scary.)
[19:36:29] <marktraceur>	 Yeah, localStorage would at least be a good start
[20:53:22] <wikibugs>	 06Multimedia: Epic saga: immersive hypermedia (Myst for Wikipedia) - https://phabricator.wikimedia.org/T133526#2439198 (10dr0ptp4kt)
[21:04:59] <wikibugs>	 06Multimedia, 10MediaWiki-Uploading, 06Security-Team, 10Wikimedia-SVG-rendering: SVG Upload should (optionally) allow the xhtml namespace - https://phabricator.wikimedia.org/T138783#2439259 (10RobLa-WMF)
[21:11:40] <wikibugs>	 06Multimedia, 10UploadWizard, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9), 07Wikimedia-log-errors: Duplicate get(): "commonswiki:sitestatsupdate:pendingdelta:ss_good_articles:+" fetched 2 times - https://phabricator.wikimedia.org/T139663#2439306 (10mmodell)
[21:12:21] <wikibugs>	 06Multimedia, 10UploadWizard, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9), 07Wikimedia-log-errors: Duplicate get(): "commonswiki:sitestatsupdate:pendingdelta:ss_good_articles:+" fetched 2 times - https://phabricator.wikimedia.org/T139663#2439330 (10mmodell)
[21:18:17] <marktraceur>	 mhurd: What's up?
[21:18:26] <mhurd>	 marktraceur: so a user can upload an image to commons which already has "XXXpx-" in the filename... like so...  //upload.wikimedia.org/wikipedia/commons/0/0b/300px-Geothermgradients.png
[21:19:06] <mhurd>	 marktraceur: in these cases it looks like you can't ask for a size variant
[21:19:24] <mhurd>	 like so: //upload.wikimedia.org/wikipedia/commons/thumb/0/0b/120px-Geothermgradients.png
[21:19:39] <mhurd>	 marktraceur: does this sound correct?
[21:20:31] <marktraceur>	 mhurd: Hm, that sounds like something we handle but I might be wrong. I know we throw warnings when a filename like that is uploaded.
[21:21:32] <mhurd>	 marktraceur: ya it's a bit of an edge case, but i noticed that i get an error if i try ask for a different size if the file name has a size prefix already *and* there is no "/thumb/" already in the path
[21:23:00] <mhurd>	 marktraceur: i double-checked that i was asking for a size smaller than the original :)
[21:23:34] <marktraceur>	 mhurd: So I think the problem is with how you're requesting the thumb
[21:23:59] <marktraceur>	 mhurd: Including the file on mw.org gave me this: https://upload.wikimedia.org/wikipedia/commons/thumb/0/0b/300px-Geothermgradients.png/100px-300px-Geothermgradients.png
[21:24:10] <marktraceur>	 I think you forgot to include the original filename
[21:24:12] <mhurd>	 marktraceur: OOOHHH!
[21:24:20] <mhurd>	 marktraceur: lol
[21:24:43] <marktraceur>	 I was almost sure there was no way we could mess that one up :)
[21:24:45] <mhurd>	 marktraceur: now it makes sense!
[21:25:07] <mhurd>	 marktraceur: haha thanks so much - it makes sense now :)
[21:38:57] <mhurd>	 haha got distracted ^ and typed the same things twice
[23:18:47] <prtksxna>	 marktraceur: Yay! Slider!