[09:52:37] 06Multimedia, 10MediaWiki-Uploading: SVG validation should allow relative urls in links in uploaded SVG files - https://phabricator.wikimedia.org/T122653#2408900 (10Bawolff) [10:59:15] 06Multimedia, 06Commons, 06Editing-Department, 10MediaWiki-File-management, and 5 others: Allow uploading of 3D files to Wikimedia Commons - https://phabricator.wikimedia.org/T3790#2408991 (10Gilles) The security review is scheduled for this week according to the task @Jdforrester-WMF just linked to. [16:10:19] (03CR) 10Brion VIBBER: [C: 04-1] "Some iframe-specific logic seems to be loaded on every view, should probably take that out. I'm also not sure why we would both use RL (bu" (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/296156 (https://phabricator.wikimedia.org/T138713) (owner: 10TheDJ) [16:18:32] (03CR) 10Brion VIBBER: "A few inline comments, also noticed:" (034 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288122 (https://phabricator.wikimedia.org/T132493) (owner: 10TheDJ) [16:19:43] (03CR) 10Brion VIBBER: [C: 032] "let's merge this for now them improve" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288122 (https://phabricator.wikimedia.org/T132493) (owner: 10TheDJ) [16:26:06] (03Merged) 10jenkins-bot: Very simple info button for video.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288122 (https://phabricator.wikimedia.org/T132493) (owner: 10TheDJ) [16:29:42] (03CR) 10Brion VIBBER: "Additional issues:" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/296156 (https://phabricator.wikimedia.org/T138713) (owner: 10TheDJ) [16:33:27] (03CR) 10Brion VIBBER: "Poster image not displaying seems to be an existing problem (?) whereby no image is actually generated when no width/height is requested, " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/296156 (https://phabricator.wikimedia.org/T138713) (owner: 10TheDJ) [16:38:09] (03CR) 10Brion VIBBER: "Broke poster out to https://phabricator.wikimedia.org/T138771" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/296156 (https://phabricator.wikimedia.org/T138713) (owner: 10TheDJ) [16:38:36] (03CR) 10Brion VIBBER: [C: 032] "Merging for now, filing bugs for followups" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/296156 (https://phabricator.wikimedia.org/T138713) (owner: 10TheDJ) [16:45:04] (03CR) 10jenkins-bot: [V: 04-1] iframe embed: Allow videojs inside iframe mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/296156 (https://phabricator.wikimedia.org/T138713) (owner: 10TheDJ) [17:03:10] (03PS5) 10Brion VIBBER: Update ogv.js to 1.1.2-alpha.7 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/292114 (owner: 10Paladox) [17:05:49] (03PS6) 10Brion VIBBER: Update ogv.js to 1.1.2 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/292114 (owner: 10Paladox) [17:09:18] (03CR) 10Brion VIBBER: [C: 04-1] "I'm having some kind of problem with seeking; I suspect an order of events problem. While seeking in my regular test harness works fine, i" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/292114 (owner: 10Paladox) [17:10:29] thedj: when you have a chance can you take a peek at ogvjs 1.1.2 vs videojs seeking? https://gerrit.wikimedia.org/r/#/c/292114/ something to do with the order of seeking-related events i think. i'll try and work it out [17:12:19] (03CR) 10Brion VIBBER: "Specifically: if I just click to a spot on the bar, or quickly click-drag-release the thumb, then I get a spinner and a partial visual ref" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/292114 (owner: 10Paladox) [18:00:18] (03CR) 10Brion VIBBER: "videojs seems to be sneaking a 'pause' and 'play' call in the middle of things, and somewhere in this order of operations it's getting mon" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/292114 (owner: 10Paladox) [18:12:32] (03PS7) 10Brion VIBBER: Update ogv.js to 1.1.3 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/292114 (owner: 10Paladox) [18:16:27] (03CR) 10Brion VIBBER: [C: 032] "Ok this is resolved in ogv.js 1.1.3. Merging..." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/292114 (owner: 10Paladox) [18:24:00] (03Merged) 10jenkins-bot: Update ogv.js to 1.1.3 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/292114 (owner: 10Paladox) [18:37:53] thedj: i fixed that bug and merged it :D please shout if i broke anything else ;) [18:48:57] 06Multimedia, 06Release-Engineering-Team, 10Wikimedia-General-or-Unknown: Spike of "unknown" errors experienced by users of UploadWizard after wmf.7 deployment - https://phabricator.wikimedia.org/T138585#2404518 (10greg) @Anomie @matmarex should this block further wmf.7 rollout? [19:11:17] 06Multimedia, 06Release-Engineering-Team, 10Wikimedia-General-or-Unknown: Spike of "unknown" errors experienced by users of UploadWizard after wmf.7 deployment - https://phabricator.wikimedia.org/T138585#2409896 (10Anomie) Ideally we'd add logging and redeploy it at least long enough to get backtraces. [19:19:40] 06Multimedia, 06Release-Engineering-Team, 10Wikimedia-General-or-Unknown: Spike of "unknown" errors experienced by users of UploadWizard after wmf.7 deployment - https://phabricator.wikimedia.org/T138585#2409930 (10greg) >>! In T138585#2409896, @Anomie wrote: > Ideally we'd add logging and redeploy it at lea... [19:45:32] 06Multimedia, 06Release-Engineering-Team, 10UploadWizard, 10Wikimedia-General-or-Unknown: Spike of "unknown" errors experienced by users of UploadWizard after wmf.7 deployment - https://phabricator.wikimedia.org/T138585#2410005 (10greg) p:05Triage>03Unbreak! For the record, this now blocks further roll... [19:46:17] MatmaRex: You're on notice! [19:46:20] Do you need help with it? [20:08:11] (03CR) 10Paladox: "Thanks." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/292114 (owner: 10Paladox) [20:11:32] grumble [20:11:51] i was going to look into that later. i didn't expect anyone to care [20:12:39] Evidently we were both wrong about that [20:12:49] MatmaRex: You could also potentially say it's unimportant and unblock? [20:13:59] Hm, no, rereading the bug it looks like that's not an option [20:14:07] (greg-g fyi we're talking in here) [20:14:13] 06Multimedia, 06Release-Engineering-Team, 10UploadWizard, 10Wikimedia-General-or-Unknown: Spike of "unknown" errors experienced by users of UploadWizard after wmf.7 deployment - https://phabricator.wikimedia.org/T138585#2410069 (10matmarex) For the record, this is not a UBN for #multimedia, and I don't con... [20:14:29] Oh, I guess you disagreed [20:14:51] marktraceur: if you want to look into it, please go ahead [20:15:10] I guess it makes sense not to block core rollout because of an UW bug [20:15:11] 06Multimedia, 10MediaWiki-Uploading: SVG Upload should (optionally) allow the xhtml namespace - https://phabricator.wikimedia.org/T138783#2410070 (10mgebert) [20:15:13] marktraceur: i'm doing cross-wiki upload and abusefilter stuff, and i want to finish that first [20:15:23] OK, I'll fire up my UW [20:15:24] i don't think that's a UW bug… [20:15:31] something is crapping out in the [20:15:34] API [20:33:16] No real API changes from 6 to 7, so I guess I'm not sure what to think [20:34:30] yeah. there doesn't seem to be anything that could have caused this [20:35:13] i think we're going to need more logging, somewhere [20:39:40] Maybe the API query that caused the error, at least the action [20:49:24] MatmaRex: Can you give me a timestamp for a recent instance of the error? [20:50:01] Or just remind me where the data is stored [20:50:12] marktraceur: yeah. 1 sec [20:51:57] marktraceur: ssh stat1003.eqiad.wmnet [20:52:00] mysql --defaults-extra-file=/etc/mysql/conf.d/research-client.cnf --host dbstore1002.eqiad.wmnet -D log -A [20:52:06] and in the mysql shell, run: [20:52:18] select * from UploadWizardErrorFlowEvent_11772725 where event_code='api/error/undefined' order by timestamp desc limit 1; [20:52:22] select * from UploadWizardErrorFlowEvent_11772725 where event_code='unknownerror' order by timestamp desc limit 1; [20:52:41] (we effectively log every instanced twice, with those two error codes) [20:52:52] most recent timestamp as of now is 20160614231558 [20:53:26] ugh, lies. 20160627204159 [20:54:14] the right query is: select * from UploadWizardErrorFlowEvent_11772725 where event_code='unknown' order by timestamp desc limit 1; [20:54:34] Looking for it in the api log now [20:56:45] The api log is crazy [21:03:15] (sorry, I had to go afk then a meeting, reading this conversation and the other private one with matma now) [21:07:01] 06Multimedia, 06Release-Engineering-Team, 10UploadWizard, 10Wikimedia-General-or-Unknown: Spike of "unknown" errors experienced by users of UploadWizard after wmf.7 deployment - https://phabricator.wikimedia.org/T138585#2410263 (10greg) p:05Unbreak!>03High >>! In T138585#2410069, @matmarex wrote: > For... [21:07:07] replied ^ [21:07:43] I'm trying to track down the problem API requests now [21:14:48] 06Multimedia, 10UploadWizard, 10Wikimedia-General-or-Unknown: Spike of "unknown" errors experienced by users of UploadWizard after wmf.7 deployment - https://phabricator.wikimedia.org/T138585#2410306 (10greg) [21:31:59] 06Multimedia, 10UploadWizard, 10Wikimedia-General-or-Unknown: Spike of "unknown" errors experienced by users of UploadWizard after wmf.7 deployment - https://phabricator.wikimedia.org/T138585#2410396 (10dr0ptp4kt) @greg, feel free to rescind. [21:57:40] Ugh, no luck on grepping the logs, I'll look again tomorrow, I have to run to a dinner thing [21:57:52] Still don't think it's a blocker. [22:32:03] 06Multimedia, 10UploadWizard, 10Wikimedia-General-or-Unknown: Spike of "unknown" errors experienced by users of UploadWizard after wmf.7 deployment - https://phabricator.wikimedia.org/T138585#2410577 (10greg) [22:32:21] (03PS1) 10Bartosz Dziewoński: mw.UploadWizardDetails: Fix handling for 'titleblacklist-forbidden' error [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/296347 [22:32:23] (03PS1) 10Bartosz Dziewoński: Correctly report uploads blocked by AbuseFilter [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/296348 (https://phabricator.wikimedia.org/T132866) [23:12:28] 06Multimedia, 10MediaWiki-Uploading: SVG Upload should (optionally) allow the xhtml namespace - https://phabricator.wikimedia.org/T138783#2410633 (10matmarex) An example problematic file, copied from https://github.com/mgeb/mediawiki-drawio-editor/issues/1: F4207037 [23:12:45] 06Multimedia, 10MediaWiki-Uploading, 05Security: SVG Upload should (optionally) allow the xhtml namespace - https://phabricator.wikimedia.org/T138783#2410636 (10matmarex)