[07:30:11] (03CR) 10Aaron Schulz: [C: 04-1] Shut down database connections during transcode shell-outs (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/286381 (https://phabricator.wikimedia.org/T97641) (owner: 10Brion VIBBER) [14:22:06] 06Multimedia, 06Commons, 10MediaWiki-File-management: Some PNG thumbnails have a yellow tint (color profile changed and then dropped by conversion) - https://phabricator.wikimedia.org/T135862#2322908 (10Anomie) >>! In T135862#2321044, @Gilles wrote: > @Anomie it's not merely ignoring it, though, it's strippi... [14:56:46] Hey, James_F, got a MW message you might want to check out: https://phabricator.wikimedia.org/T3790 [14:56:51] Errr [14:56:56] https://www.mediawiki.org/wiki/User_talk:MarkTraceur#3D_viewer_needed_.3F [15:00:49] Kk. [15:01:38] marktraceur: Gah, why is your talkpage not enflowed? [15:02:15] Because I never look at it anyway [15:29:02] (03CR) 10Brion VIBBER: Shut down database connections during transcode shell-outs (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/286381 (https://phabricator.wikimedia.org/T97641) (owner: 10Brion VIBBER) [15:30:26] marktraceur: I can of course just do it to you… [15:30:37] James_F: Gopher it [15:31:38] Well, given we just had a conversation on your talk page it'd probably be nice to, you know, give them time to see it. [15:37:36] (03PS2) 10Brion VIBBER: Shut down database connections during transcode shell-outs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/286381 (https://phabricator.wikimedia.org/T97641) [17:17:51] marktraceur: James_F: wanna see something really cool? here are the counts of uncaught JS exceptions in uploadwizard, according to our logging, from a few months ago. [17:17:53] | 20151002 | 10927 | [17:17:53] | 20151003 | 11431 | [17:17:53] | 20151004 | 15274 | [17:17:53] | 20151005 | 18870 | [17:17:53] | 20151006 | 12872 | [17:18:10] and here are from a few days ago. [17:18:13] | 20160519 | 1366 | [17:18:13] | 20160520 | 634 | [17:18:13] | 20160521 | 419 | [17:18:13] | 20160522 | 716 | [17:18:13] | 20160523 | 517 | [17:18:41] it's still not quite zero, but i like how we have two orders of magnitude fewer exceptions being thrown. [17:19:27] the query is: select left(timestamp,8), count(*) from UploadWizardExceptionFlowEvent_11772722 where timestamp>'201509' and event_url not like 'jqueryMsg%' group by left(timestamp,8); [17:19:43] MatmaRex: Nice! [17:20:03] The 50% fall from 19th -> 20th is curious too. [17:20:40] it might have been just one person repeatedly doing something that craps out [17:21:08] but it's fairly consistently 3 or 4 digits so far, rather than 5 [17:21:14] That'd be the wmf.2 deployment. [17:21:36] James_F: i think wmf.2 deployment is when we started logging this data again. :) [17:21:47] Oh, hah. [17:21:51] OK, ignore me then. :-) [17:22:09] there's no data between 20151007 and 20160518 [17:22:13] Whoops. [17:22:21] well, we intentionally did that [17:22:31] because we were supposed to have the new and shinier system in a couple weeks [17:22:38] but it's shelved. so. [17:23:01] Sentry? [17:23:18] (there are actually 2 events on 20151011 and 9 on 20151014, for some reason, i'm guessing someone just kept the tab with UW open for a few days) [17:23:20] yeah [17:23:41] * James_F sighs. [17:55:40] MatmaRex: good work ! [17:55:51] rest of the team too of course. [19:04:58] thedj: Nah, it was MatmaRex. :) [19:14:57] Well I have a functional extension...sort of [19:15:01] Gotta style it now [19:15:16] But it shows annotations on the image on hover [19:42:24] MatmaRex: Don't we have a popup-on-hover widget somewhere in OOUI or MWOOUI or whatever? [19:43:03] Tooltip [19:43:07] Whatever you want to call it [19:44:26] marktraceur: no, there's a bug for it somewhere. we have PopupButtonWidget (popup-on-click), you can add hover behavior to it with a little bit of glue code [19:44:34] Hm [19:44:39] basically, just [19:45:07] popupButton.$element.on('mouseover', function(){ popupButton.popup.toggle( true ); }) [19:45:16] popupButton.$element.on('mouseout', function(){ popupButton.popup.toggle( false ); }) [19:45:27] I could just do it in CSS. [19:45:28] or something [19:45:49] OK, I'll give it a shot [19:45:52] I hate CSS anyway [19:46:32] MatmaRex: I guess I can just use PopupWidget since I don't have a button. [19:46:35] CSS would probably also work, but if you try that for OOUI PopupWidget, you might run into difficulties. it has some ridiculous styling to position it. so if you do that, just use plain HTML for the popup [19:47:00] (you also might not run into difficulties. ymmv) [19:47:23] FFS OOUI WTFBBQ [19:47:54] Here's where I say something like "how hard can it be to position an element absolutely" and Roan comes in to tell me exactly how fucking hard it can be [19:48:41] I thought the popups we had in MMV once upon a time were using relative positioning [19:48:57] But I also think that my current attempts at doing so are causing me consternation. [19:54:21] Somehow I didn't notice that the current image annotations spawn wherever your cursor enters the annotation box [19:54:32] So basically anything I do that isn't that will be better [20:02:27] 06Multimedia, 06Commons, 10MediaWiki-File-management: Some PNG thumbnails have a yellow tint (color profile changed and then dropped by conversion) - https://phabricator.wikimedia.org/T135862#2324225 (10Gilles) Interesting, TIL! Thanks for the pointers. "iCCp", however isn't standard, only iCCP is. I tried s... [20:10:31] 06Multimedia, 06Commons, 10MediaWiki-File-management: Some PNG thumbnails have a yellow tint (color profile changed and then dropped by conversion) - https://phabricator.wikimedia.org/T135862#2324252 (10Anomie) Yeah, "iCCp" doesn't exist. That's just the name it would have were it safe-to-copy. Another work... [20:26:42] FYI all, I won't be at the standup today because I'm not at home (working from a few different places today...) but I'll talk to you all after my uber-long weekend [21:18:10] 06Multimedia, 06Commons, 10MediaWiki-File-management: Some PNG thumbnails have a yellow tint (color profile changed and then dropped by conversion) - https://phabricator.wikimedia.org/T135862#2324560 (10Gilles) Thumbor is affected as well. However I have logic in place for JPGs that have non-sRGB color profi... [22:00:25] (03PS1) 10Jforrester: build: Replace csslint with stylelint [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/290593 [22:01:28] (03PS1) 10Jforrester: build: Bump devDependencies to latest [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/290594 [22:04:14] (03CR) 10jenkins-bot: [V: 04-1] build: Bump devDependencies to latest [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/290594 (owner: 10Jforrester) [22:16:15] (03PS2) 10Jforrester: build: Bump devDependencies to latest [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/290594 [22:26:15] James_F: ha, see, that's why i was confused. i was certain that the styles we had wouldn't pass any lint. :D [22:28:07] James_F: huh, we enforce /**/ comments in LESS? that's silly. [22:32:17] (03CR) 10Bartosz Dziewoński: [C: 04-1] build: Replace csslint with stylelint (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/290593 (owner: 10Jforrester) [22:39:02] MatmaRex: // isn't valid… [22:39:22] James_F: it sure is in LESS [22:39:32] (but not in CSS) [22:39:56] (03CR) 10Jforrester: build: Replace csslint with stylelint (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/290593 (owner: 10Jforrester) [22:44:39] (03CR) 10Bartosz Dziewoński: build: Replace csslint with stylelint (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/290593 (owner: 10Jforrester) [22:47:57] MatmaRex: Meh. I was trying to make the fewest changes. :-P [22:48:06] For rebase-ability. [22:50:20] pretty sure we have nothing pending touching that [22:50:31] Kk. [22:50:46] and i mean, you touched some thirty other lines, so… ;) [22:50:54] Also, the reason it objected to the //s is because there were two in one block, so it saw them as duplicate definitions. [22:51:25] (03PS2) 10Jforrester: build: Replace csslint with stylelint [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/290593 [22:51:27] duplicate… wut? [22:51:58] that makes no sense at all [22:52:13] there is the same thing in /resources/details/uw.DateDetailsWidget.less [22:52:17] Duplicate definitions – color: red;\ncolor: blue; – are invalid. [22:52:55] okay [22:53:00] but what does that have to do with comments [22:53:13] It seemed to think that // foo \n // bar was a duplicate definition. [22:53:35] * James_F shrugs. [22:53:35] that makes absolutely no sense at all whatsoever [22:53:47] i like my //-comments and don't want to give them up [22:54:01] LESS files are meant to be mostly-valid CSS. [22:54:04] / comments aren't. [22:54:31] bullshit [22:54:35] //-comments are valid in LESS [22:54:41] LESS is not meant to be mostly-valid CSS [22:54:45] it is very much invalid CSS [22:54:53] Really? 'Cos that was the justification for picking LESS over SASS. [22:55:06] it is syntactically similar to some degree [22:55:09] (Not mine, I don't care.) [22:55:28] but the second you start using any LESS features, it becomes invalid CSS [22:55:42] But backwards-compatible, right? [22:55:45] (Ish.) [23:03:40] (03CR) 10Jforrester: build: Replace csslint with stylelint (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/290593 (owner: 10Jforrester) [23:23:58] 06Multimedia, 10WikiEditor, 07Design: "Insert media" dialog offers confusing insert/upload alternative buttons - https://phabricator.wikimedia.org/T135917#2324926 (10matmarex) Not a #regression, as that button was never placed anywhere else. This dialog is part of #wikieditor. > The "upload" button should... [23:30:27] (03CR) 10Aaron Schulz: [C: 04-1] Shut down database connections during transcode shell-outs (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/286381 (https://phabricator.wikimedia.org/T97641) (owner: 10Brion VIBBER) [23:40:59] 06Multimedia, 10GeoData, 10UploadWizard: Accept degrees-minutes-seconds (DMS) coordinates in the Location field, not just decimal coordinates - https://phabricator.wikimedia.org/T135599#2325005 (10matmarex) [23:42:53] James_F: i tried your stylelint patch locally: [23:42:54] Running "stylelint:all" (stylelint) task [23:42:54] Warning: Set is not defined Use --force to continue. [23:43:06] (then it dies) [23:43:30] MatmaRex: You need to upgrade your node to a post-0.x version. :-) [23:43:45] ughhhhh [23:44:39] ughhhhhhhhh. then went from 0.12 to 4.0? okayyy… [23:44:39] MatmaRex: 20 months ago called and wants its node version back. [23:44:58] (It was messy. They forked and then unforked.) [23:45:01] i think that's the weirdest version bump i've ever seen [23:45:11] and i've seen a project go from 4.8 to 50.0 [23:45:12] https://nodejs.org/en/download/releases/ [23:45:17] * James_F grins. [23:45:36] If you want a real giggle, read NODE_MODULE_VERSION [23:46:14] null -> 1 -> 0x000A -> 0x000B -> 11 -> 0x000C -> 13 -> 14 -> 42 -> … [23:47:56] so, how much stuff is going to break when i upgrade? [23:48:04] Theoretically, nothing. [23:48:24] Unless you're using very (a) old and (b) odd things that hooked into node internals.