[02:33:47] 06Multimedia, 10UploadWizard, 13Patch-For-Review, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1), 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Upload Wizard for Wikimedia Commons does not complete process, freezes after last click, if only one file was selected - https://phabricator.wikimedia.org/T135200#2299745 (10ma... [02:36:14] 06Multimedia, 10UploadWizard, 05WMF-deploy-2016-05-10_(1.28.0-wmf.1), 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Upload Wizard for Wikimedia Commons does not complete process, freezes after last click, if only one file was selected - https://phabricator.wikimedia.org/T135200#2299751 (10matmarex) 05Open>03R... [03:19:31] 06Multimedia, 10UploadWizard: UploadWizard rejects uploads with file names that are prefixes of existing file name, treating them as if they were duplicates - https://phabricator.wikimedia.org/T135394#2299776 (10matmarex) p:05Triage>03Normal [03:31:14] (03PS1) 10Bartosz Dziewoński: mw.DestinationChecker: Don't generate false positives for matching prefixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289133 (https://phabricator.wikimedia.org/T135394) [03:38:11] (03PS1) 10Bartosz Dziewoński: Normalize file extension for uploaded files [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289136 (https://phabricator.wikimedia.org/T36703) [03:41:10] (03CR) 10jenkins-bot: [V: 04-1] Normalize file extension for uploaded files [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289136 (https://phabricator.wikimedia.org/T36703) (owner: 10Bartosz Dziewoński) [03:46:26] (03CR) 10Bartosz Dziewoński: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289136 (https://phabricator.wikimedia.org/T36703) (owner: 10Bartosz Dziewoński) [03:46:41] 06Multimedia, 10UploadWizard, 07Regression: UploadWizard's "Copy title (with automatic numbering)" generates weird numbers instead of sequential ones - https://phabricator.wikimedia.org/T135396#2299801 (10matmarex) p:05Triage>03High [03:46:52] 06Multimedia, 06Commons, 10UploadWizard: Commons's message 'mwe-upwiz-license-cc-subhead' is broken - https://phabricator.wikimedia.org/T134049#2299806 (10matmarex) p:05Triage>03High [03:47:37] (03PS1) 10Bartosz Dziewoński: uw.CopyMetadataWidget: Correct sequential numbering [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289139 (https://phabricator.wikimedia.org/T135396) [03:51:23] 06Multimedia, 10MediaWiki-Uploading: Add EventLogging instrumentation to the upload dialog - https://phabricator.wikimedia.org/T133306#2299812 (10matmarex) p:05High>03Normal [04:36:11] (03CR) 10Bartosz Dziewoński: [C: 032] Add TMH modules to the upload page. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248711 (https://phabricator.wikimedia.org/T51751) (owner: 10TheDJ) [04:42:29] (03Merged) 10jenkins-bot: Add TMH modules to the upload page. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248711 (https://phabricator.wikimedia.org/T51751) (owner: 10TheDJ) [04:54:59] 06Multimedia, 10MediaWiki-Uploading, 10TimedMediaHandler, 10TimedMediaHandler-Player, and 3 others: Ajax "This file already exists" doesn't load image related js (e.g. from TMH) - https://phabricator.wikimedia.org/T51751#2299891 (10matmarex) 05Open>03Resolved Fixed. :) [05:42:30] (03PS5) 10Brion VIBBER: [WIP] Update ogv.js to 1.1.1-alpha.5 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288345 (https://phabricator.wikimedia.org/T135098) [06:07:26] Oh dear. PHP fatal on a page with TMH on it in master… http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/sandbox [06:08:03] http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/sandbox?action=edit&veswitched=1 works, but preview also fatals. [10:00:33] 06Multimedia, 10MediaWiki-extensions-Score, 10TimedMediaHandler, 07Beta-Cluster-reproducible: Score/TMH PHP fatal on page view in master - https://phabricator.wikimedia.org/T135491#2300601 (10Jdforrester-WMF) [12:00:51] 06Multimedia, 10MediaWiki-extensions-Score, 10TimedMediaHandler, 07Beta-Cluster-reproducible: Score/TMH PHP fatal on page view in master - https://phabricator.wikimedia.org/T135491#2300858 (10TheDJ) Possibly this.. https://gerrit.wikimedia.org/r/#/c/287406/4/TimedMediaTransformOutput.php,cm I had not cons... [12:04:29] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10TimedMediaHandler, and 3 others: Improve interface for MediaHandlers to add JavaScript - https://phabricator.wikimedia.org/T60478#2300861 (10TheDJ) Should keep an eye on {T469}. [13:07:15] (03PS1) 10TheDJ: Fix fatal for TimedMediaHandler previews without files. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/289197 (https://phabricator.wikimedia.org/T135491) [13:08:02] (03PS2) 10TheDJ: Fix fatal for TimedMediaHandler previews without files. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/289197 (https://phabricator.wikimedia.org/T135491) [13:11:36] (03CR) 10TheDJ: [V: 04-1] "i have not tested this code yet, someone should double check." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/289197 (https://phabricator.wikimedia.org/T135491) (owner: 10TheDJ) [13:17:45] (03PS6) 10Brion VIBBER: [WIP] Update ogv.js to 1.1.1-alpha.6 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288345 (https://phabricator.wikimedia.org/T135098) [13:18:06] (03PS7) 10Brion VIBBER: [WIP] Update ogv.js to 1.1.1-alpha.6 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288345 (https://phabricator.wikimedia.org/T135098) [14:23:38] Good morning all [14:24:55] Is it? IS IT? [14:28:36] No. [14:28:42] But I put on a brave face [14:34:31] (03CR) 10MarkTraceur: [C: 032] uw.CopyMetadataWidget: Correct sequential numbering [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289139 (https://phabricator.wikimedia.org/T135396) (owner: 10Bartosz Dziewoński) [14:35:14] hello. [14:35:41] most of the UW stuff i've been working on recently are regressions from the previous UW stuff i've been working on. :/ [14:36:58] Yup! [14:37:18] (03CR) 10jenkins-bot: [V: 04-1] uw.CopyMetadataWidget: Correct sequential numbering [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289139 (https://phabricator.wikimedia.org/T135396) (owner: 10Bartosz Dziewoński) [14:37:24] (03CR) 10MarkTraceur: [C: 032] Normalize file extension for uploaded files [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289136 (https://phabricator.wikimedia.org/T36703) (owner: 10Bartosz Dziewoński) [14:37:31] Should have been caught by the reviewer ;) [14:38:05] Hm, looks like flappy CQ tests are flapping again? [14:38:42] yeahhhh. more regressions from my stuff [14:38:50] feel free to kill the broken tests when they flap too much [14:39:18] and i'll look into it the next time i need to change anything in CQ, which hopefully won't be that soon [14:40:41] (03CR) 10jenkins-bot: [V: 04-1] Normalize file extension for uploaded files [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289136 (https://phabricator.wikimedia.org/T36703) (owner: 10Bartosz Dziewoński) [15:22:45] i also introduced regressions so, you are not on your own MatmaRex :) [15:23:29] although I would argue that undocumented features are invitations for regressions [15:35:35] brion: i was considering flipping mediawiki.org to make use of videojs... [15:36:48] or test2.wikipedia.org or something. [15:37:00] i dunno if we're ready to flip mw.o but at least a beta site :D [15:37:20] even though we break the dom structure, it probably won't matter much on either of those. [15:37:45] brion: Could you look at https://gerrit.wikimedia.org/r/#/c/289197/ if you've not already? It's holding up the train right now. :-) [15:38:02] sure, peeking [15:38:19] Ta. [15:38:45] i wrote the patch at work, without an instance to test anything, but it seems pretty logical [15:39:39] (03CR) 10TheDJ: "This introduced T135491" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/287406 (https://phabricator.wikimedia.org/T122736) (owner: 10TheDJ) [15:39:45] (03CR) 10Bartosz Dziewoński: [C: 032] "Just transient, I hope." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289139 (https://phabricator.wikimedia.org/T135396) (owner: 10Bartosz Dziewoński) [15:39:51] (03CR) 10Bartosz Dziewoński: uw.CopyMetadataWidget: Correct sequential numbering [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289139 (https://phabricator.wikimedia.org/T135396) (owner: 10Bartosz Dziewoński) [15:40:08] (03CR) 10Bartosz Dziewoński: [C: 032] "Just transient, I hope." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289136 (https://phabricator.wikimedia.org/T36703) (owner: 10Bartosz Dziewoński) [15:40:09] hmm TiMidity++ could not be executed: /usr/bin/timidity is not an executable file. Make sure $wgScoreTimidity is set correctly. [15:40:16] (03CR) 10Bartosz Dziewoński: Normalize file extension for uploaded files [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289136 (https://phabricator.wikimedia.org/T36703) (owner: 10Bartosz Dziewoński) [15:40:18] the vagrant role for score must not be installing timidity [15:40:32] This is a renderer for a file, but we also use it without a file... [15:40:35] i'll do it manually for now [15:40:50] and then file a bug for the vagrant role fix [15:41:38] ffs [15:41:43] /etc/timidity/freepats.cfg: No such file or directory timidity: Error reading configuration file. Please check /etc/timidity/timidity.cfg [15:41:51] (03Merged) 10jenkins-bot: uw.CopyMetadataWidget: Correct sequential numbering [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289139 (https://phabricator.wikimedia.org/T135396) (owner: 10Bartosz Dziewoński) [15:42:36] (03Merged) 10jenkins-bot: Normalize file extension for uploaded files [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289136 (https://phabricator.wikimedia.org/T36703) (owner: 10Bartosz Dziewoński) [15:43:04] ok can confirm the fatal, now to test the fix [15:43:43] thedj: ideally we could change score to use an appropriate File class to wrap the actual ogg file generated [15:43:50] but this should do as a quick fix [15:44:06] brion: i already created a ticket for "we need a better way to do this" :) [15:44:11] :D [15:44:12] great [15:44:35] especially, since it seems like WikiSpeech is gonna need something similar as well. [15:45:19] thedj: ok so it no longer fails, but in videojs mode i see no controls [15:45:22] just a black box [15:45:39] MarkTraceur: hmm, so the flaky test seems to be "Adding a new item when almost done". all of the spurious failures in the last two weeks were it [15:45:43] that might be. I don't think i EVER considered Score so far. [15:45:56] i'll open a ticket for that as well then. [15:46:01] failing either "Call 8 (callId 190) is in the right order" or "Call 13 (callId 195) is in the right order" [15:46:27] lemme confirm it still works in kaltura mode [15:46:32] mwembed *shudder* [15:47:30] ok still works under mwembed [15:48:27] (03CR) 10Brion VIBBER: [C: 032] "Note that this still doesn't 100% work right under videojs mode -- controls don't display so you can't play the audio. Works correctly und" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/289197 (https://phabricator.wikimedia.org/T135491) (owner: 10TheDJ) [15:51:41] brion: ticket for videojs Score support was opened [15:52:46] 06Multimedia, 10MediaWiki-Vagrant, 10MediaWiki-extensions-Score: score role for vagrant fails to install timidity, freepats (needed for vorbis generation) - https://phabricator.wikimedia.org/T135517#2301462 (10brion) [15:53:20] woot [15:57:08] (03Merged) 10jenkins-bot: Fix fatal for TimedMediaHandler previews without files. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/289197 (https://phabricator.wikimedia.org/T135491) (owner: 10TheDJ) [15:57:59] ok, so score passes in this option: 'disablecontrols' => 'options,timedText', [15:58:24] which videojs mode interprets as a boolean: [15:58:33] if ( $this->disablecontrols ) { $mediaAttr[ 'controls' ] = false; } [15:58:38] if i'm understanding correctly? [16:08:07] 06Multimedia, 10MediaWiki-extensions-Score, 10TimedMediaHandler, 07Beta-Cluster-reproducible, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Score/TMH PHP fatal on page view in master - https://phabricator.wikimedia.org/T135491#2301492 (10TerraCodes) [16:42:43] (03PS1) 10Bartosz Dziewoński: Bump delays in uw.ConcurrentQueue's "Adding a new item when almost done" test [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289238 [16:42:47] i'll be very sad if this fails [16:43:39] by the way, Git commit messages should really allow multipart data, like emails, so that i would be able to just attach that diagram i drew. [17:06:38] 06Multimedia, 10UploadWizard, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Normalize file extension while uploading file in UploadWizard - https://phabricator.wikimedia.org/T36703#2301751 (10matmarex) 05Open>03Resolved This should be deployed to Commons this week. Please report if you notice any uppercase fil... [17:08:14] 06Multimedia, 10UploadWizard, 07Regression, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): UploadWizard's "Copy title (with automatic numbering)" generates weird numbers instead of sequential ones - https://phabricator.wikimedia.org/T135396#2301754 (10matmarex) 05Open>03Resolved This should be deployed to Com... [17:11:51] 06Multimedia, 10UploadWizard: Increase the limit of 50 uploads at once (maxUploads) - https://phabricator.wikimedia.org/T135085#2301758 (10matmarex) (Nice huge Flickr stream to test with: https://www.flickr.com/photos/plants_of_russian_in_brazil/) [17:20:39] MatmaRex: :-) [17:26:13] ascii art ;) [17:57:22] (03PS8) 10Brion VIBBER: [WIP] Update ogv.js to 1.1.1-alpha.7 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288345 (https://phabricator.wikimedia.org/T135098) [17:59:04] 06Multimedia, 10MediaWiki-Vagrant, 10MediaWiki-extensions-Score, 13Patch-For-Review: score role for vagrant fails to install timidity, freepats (needed for vorbis generation) - https://phabricator.wikimedia.org/T135517#2301982 (10brion) 05Open>03Resolved a:03brion \o/ [17:59:39] > then I gave up [17:59:47] My life in a single clause. [18:18:44] (03CR) 10MarkTraceur: [C: 032] Bump delays in uw.ConcurrentQueue's "Adding a new item when almost done" test [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289238 (owner: 10Bartosz Dziewoński) [18:20:36] (03Merged) 10jenkins-bot: Bump delays in uw.ConcurrentQueue's "Adding a new item when almost done" test [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/289238 (owner: 10Bartosz Dziewoński) [18:22:39] brion: i'm considering deprecating disablecontrols [18:23:30] brion: i mean class .= " mwscore" + css ... problem solved right ? [18:24:32] brion: there are only 3 options for disablecontrols, hardly anyone even knows about them (i documented them only last week). and it seems to have been specifically designed for Score. [18:24:38] Sounds feasible [18:24:42] Heh [18:25:10] I think it's mostly to disable showing that detail link for the file [18:25:23] If there's no file ref er just shouldn't shoe one... Right? [18:25:33] indeed. [18:25:43] no source to link back to. [18:26:26] but i'd like someone to mwgrep the database to find how often it is used inside wikitext. [18:26:50] or can we do that on toollabs these days ? [18:30:59] 06Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10Reading-Web-Backlog: mw.Title.newFromImg does not handle fullsize images - https://phabricator.wikimedia.org/T134860#2302172 (10MBinder_WMF) [18:32:18] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer, 10Reading-Web-Backlog: MediaViewer intermittent image loading errors (2015 Oct-Dec) - https://phabricator.wikimedia.org/T115563#2302209 (10MBinder_WMF) [18:34:11] 06Multimedia, 06Commons, 10MediaWiki-extensions-GWToolset, 10MediaWiki-extensions-MultimediaViewer, and 2 others: Include templates into the multimedia vagrant role - https://phabricator.wikimedia.org/T596#2302268 (10MBinder_WMF) [19:35:46] (i'm going to sleep early today and skip the hangout. see you tomorrow) [19:43:09] 06Multimedia, 06Commons, 10MediaWiki-File-management: Exclude redundant srcset attribute values (e.g. same url) - https://phabricator.wikimedia.org/T135550#2302731 (10Krinkle) [19:52:24] I think i'm gonna change the TMH phab project icon.. To something with a chisel and a mountain or something... :) [20:46:17] (03PS1) 10TheDJ: Fix the disablecontrols option for videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/289308 (https://phabricator.wikimedia.org/T135516) [21:43:25] (03PS1) 10TheDJ: Allow transform callers to add a classname [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/289318 (https://phabricator.wikimedia.org/T135501) [21:45:10] *@#%($*&!#$%((*#$%!&(@#%!& [21:45:13] my god.. [21:45:30] let's add a class for a skin to the html structure.. [21:46:19] let's when we load the JS, remove that classname, and use a different classname, for no apparent reason [21:59:57] I forgot that I have a thing starting soon/now, so I can't attend the standup either. prtksxna you're on your own mate [22:09:57] prtksxna: so does this happen often. That you have to hangout with yourself ;)