[00:16:11] (03PS1) 10Bartosz Dziewoński: uw.DescriptionsDetailsWidget: Remove any "Remove" buttons when clearing items [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/288138 (https://phabricator.wikimedia.org/T134180) [00:16:19] 06Multimedia, 10UploadWizard, 13Patch-For-Review: "Remove" buttons for descriptions are duplicated when there are multiple descriptions and you use the "Copy metadata" feature - https://phabricator.wikimedia.org/T134180#2283608 (10matmarex) p:05Triage>03Normal a:03matmarex [05:03:35] 06Multimedia, 06Commons, 10Wikimedia-General-or-Unknown: An error occurred while uploading large file on Commons - https://phabricator.wikimedia.org/T134787#2283850 (10Krassotkin) @matmarex OK. Sorry. Thank you! [11:11:03] brion: did you know this project ? https://github.com/kazuki/video-codec.js [11:29:22] MarkTraceur: looking good, I'm working on debian packaging at the moment [12:20:09] gilles: Nice :) [12:21:17] MarkTraceur: Its becoming hard to use the markup generated by the traditinal gallery [12:21:36] It is adding style attributes to a bunch of elements and setting widths on them [12:23:40] It does not make sense to refactor the widths out of it and put it in the JS because then all galleries will get a FOUC [12:24:55] It has also have a bunch of things that aren't causing problems but we don't really need it [12:33:34] (03CR) 10TheDJ: [C: 032] Add replay button to video.js player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/286761 (owner: 10TheDJ) [12:44:11] (03Merged) 10jenkins-bot: Add replay button to video.js player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/286761 (owner: 10TheDJ) [12:57:31] I am not able to disable my cache, I have debug=true and the hard refreshing the browser too [12:58:30] I have $wgMainCacheType = CACHE_NONE; too :// [13:57:53] thedj: neat! Didn't have the encoders when I last looked i think [14:06:18] (03PS1) 10TheDJ: Move activation of replaybutton into the config [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288202 [14:10:41] brion: the demo is really nice. [14:12:26] (03CR) 10TheDJ: [C: 032] Move activation of replaybutton into the config [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288202 (owner: 10TheDJ) [14:24:47] (03Merged) 10jenkins-bot: Move activation of replaybutton into the config [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288202 (owner: 10TheDJ) [14:29:49] (03PS7) 10TheDJ: [WIP] OOjs UI based popup for playing small videojs thumbnails [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/285075 (https://phabricator.wikimedia.org/T133500) [14:33:24] (03CR) 10jenkins-bot: [V: 04-1] [WIP] OOjs UI based popup for playing small videojs thumbnails [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/285075 (https://phabricator.wikimedia.org/T133500) (owner: 10TheDJ) [14:36:36] (03PS2) 10TheDJ: Very simple info button for video.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288122 (https://phabricator.wikimedia.org/T132493) [14:41:21] (03CR) 10jenkins-bot: [V: 04-1] Very simple info button for video.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288122 (https://phabricator.wikimedia.org/T132493) (owner: 10TheDJ) [14:44:35] prtksxna: You might need to clear localStorage (ah, mediawiki) [14:45:19] prtksxna: As for galleries, is there no way to override the widths and styles in a getAttributes() method or something? [14:45:39] (sorry about today, people, but I have woken up late and I may need to adjust my schedule a bit) [15:17:10] 06Multimedia, 06Commons, 10Wikimedia-General-or-Unknown: An error occurred while uploading large file on Commons - https://phabricator.wikimedia.org/T134787#2285433 (10matmarex) 05Open>03Resolved [15:34:08] hello. [15:35:50] MarkTraceur: got some time for code reviews today? these should all be simple: https://gerrit.wikimedia.org/r/286444 https://gerrit.wikimedia.org/r/288138 (UW) https://gerrit.wikimedia.org/r/287771 (MW core) [15:36:35] MarkTraceur: prtksxna: also, i want both of you guys to look at https://gerrit.wikimedia.org/r/287103 ("Refactor upload dialog to make it configurable") :) [15:37:10] MarkTraceur: Methods exist for some of the widths, but it sets it to autopx :P [15:39:18] Always [15:39:25] Sorry, MatmaRex: Always [15:47:08] OK how quickly can I make eggs [15:57:57] Ten minutes for three overeasy eggs and a pot of coffee. Not bad if I do say so myself. [16:05:23] MarkTraceur++ for cooking [16:05:49] I try. [16:06:04] The eggs could have been a bit firmer. [16:36:06] 06Multimedia, 06Commons, 10MediaWiki-Uploading: Commons UploadWizard rejects all uploads with false error message after a certain number of uploads - https://phabricator.wikimedia.org/T121896#2285691 (10matmarex) 05Open>03Resolved This should no longer be a problem, with both of the subtasks fixed. There... [16:37:20] 06Multimedia, 06Commons, 10MediaWiki-Uploading, 05MW-1.27-release-notes, 05WMF-deploy-2016-05-03_(1.27.0-wmf.23): Commons UploadWizard rejects all uploads with false error message after a certain number of uploads - https://phabricator.wikimedia.org/T121896#2285696 (10matmarex) [16:43:40] tagging ogv.js 1.1.0 [16:59:13] (03PS5) 10Brion VIBBER: Update ogv.js to 1.1.0 release [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/286307 (https://phabricator.wikimedia.org/T134104) [16:59:30] (03PS6) 10Brion VIBBER: Update ogv.js to 1.1.0 release [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/286307 (https://phabricator.wikimedia.org/T134104) [17:00:12] (03CR) 10Brion VIBBER: "Ok, since testing so far has not revealed any more regressions I've tagged and released 1.1.0, and updated this patch. Ready to merge. :)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/286307 (https://phabricator.wikimedia.org/T134104) (owner: 10Brion VIBBER) [17:13:43] (03CR) 10Jforrester: [C: 031] "No issues from some quick testing of mine; TheDJ, do you want to merge?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/286307 (https://phabricator.wikimedia.org/T134104) (owner: 10Brion VIBBER) [17:20:09] (03CR) 10Brion VIBBER: "Note I still see intermittent seek-related bugs but they're a lot less bad than before, so I'd like to get the current state merged before" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/286307 (https://phabricator.wikimedia.org/T134104) (owner: 10Brion VIBBER) [17:24:07] (03CR) 10Brion VIBBER: "Browser video controls are visible on the pre-popup small video in Safari Tech Preview -- looks like the 'controls' attribute is not getti" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/285075 (https://phabricator.wikimedia.org/T133500) (owner: 10TheDJ) [17:39:42] brion: i'll merge after CREDIT. And also release an update of the videojs plugin etc. [17:39:59] \o/ [17:40:35] James_F: so it looks like vips is not used for jpegs in production, which is why the 4:2:0 subsampling works there :) [17:41:05] brion: Ha. Not at all? That'd… I guess explain. :-) [17:41:16] James_F: yeah just png and tiff [17:41:39] In that case can we marked as Resolved? [17:43:42] James_F: no, at least not on the bug that's vips-specific [17:43:50] that should stay open until it's implemented [17:44:02] but we might remove a blocker state if anything was blocking on that for production usage [17:44:06] Yeah. [17:45:04] 06Multimedia, 06Commons, 10MediaWiki-File-management, 06Performance-Team, 07User-notice: Use Chroma subsampling for image thumbnails (save 17% bandwidth and save memory on mobile) - https://phabricator.wikimedia.org/T122242#2286073 (10Jdforrester-WMF) [17:45:56] 06Multimedia, 06Commons, 10MediaWiki-File-management, 06Performance-Team, 07User-notice: Use Chroma subsampling for image thumbnails (save 17% bandwidth and save memory on mobile) - https://phabricator.wikimedia.org/T122242#1899257 (10Jdforrester-WMF) 05Open>03Resolved a:03Jdforrester-WMF Turns out... [17:49:42] \o/ [17:53:41] 06Multimedia, 06Commons, 10MediaWiki-File-management, 06Performance-Team, 07User-notice: Use Chroma subsampling for image thumbnails (save 17% bandwidth and save memory on mobile) - https://phabricator.wikimedia.org/T122242#2286114 (10Gilles) Not sure in what sense you mean that. VIPs generates JPEG thum... [17:53:56] thedj: my calendar shows the CREDIT showcase as tomorrow [17:54:48] 06Multimedia, 06Commons, 10MediaWiki-File-management, 06Performance-Team, 07User-notice: Use Chroma subsampling for image thumbnails (save 17% bandwidth and save memory on mobile) - https://phabricator.wikimedia.org/T122242#2286118 (10brion) Ah, so JPEGs *of* TIFFs, not JPEGs of JPEGs. [17:56:04] brion: oh.. F [17:56:19] brion: they also changed the DAY this time. [17:57:09] duh [17:57:24] * thedj gets coffee [17:59:43] :P [18:07:38] 06Multimedia, 06Commons, 10MediaWiki-File-management, 06Performance-Team, 07User-notice: Use Chroma subsampling for image thumbnails (save 17% bandwidth and save memory on mobile) - https://phabricator.wikimedia.org/T122242#2286170 (10brion) Ok, so that one also shows as 4:2:0: ``` jpeg:sampling-fac... [18:16:37] * thedj checks WP:VP/T to see how many people alsee is gathering to lynch James_F [18:17:04] oh it's fram. [18:18:39] (03CR) 10Paladox: [C: 031] "Ive also tested and works. Its more stable then ogv 1.0." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/286307 (https://phabricator.wikimedia.org/T134104) (owner: 10Brion VIBBER) [18:19:15] * thedj ponders why source switching isn't working.. [18:19:54] (03CR) 10MaxSem: [C: 032] Update ogv.js to 1.1.0 release [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/286307 (https://phabricator.wikimedia.org/T134104) (owner: 10Brion VIBBER) [18:21:56] ah it does. good. well i guess i'll just wait for the merge then :) [18:28:44] (03Merged) 10jenkins-bot: Update ogv.js to 1.1.0 release [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/286307 (https://phabricator.wikimedia.org/T134104) (owner: 10Brion VIBBER) [18:29:13] woohoooooo [18:45:35] so right. tomorrow, i have a 18:00, a 20:00 and a 22:00 mediawiki meeting... [18:45:53] it's almost like work. [18:59:05] :) [18:59:12] (03PS1) 10TheDJ: Remove fallback content of video/audio tag [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288249 (https://phabricator.wikimedia.org/T133671) [18:59:28] oh damn. parser tests ... [19:04:22] (03CR) 10jenkins-bot: [V: 04-1] Remove fallback content of video/audio tag [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288249 (https://phabricator.wikimedia.org/T133671) (owner: 10TheDJ) [19:25:45] I am declining the standup because I have to be in the suburbs at 6 [19:25:55] But I have no useful update anyway because today was filled with meetings. [19:26:04] I will be lucky to get two hours of coding in. [19:27:13] * James_F too. [19:29:23] I wonder why James is going to the suburbs. [19:41:37] MarkTraceur: Do you want to mull over the gallery related messages I left you? [19:44:45] prtksxna: I haven't looked at the gallery code recently...is there a particular problem or is it more of an architectural thing? [19:46:02] I wouldn't say its an architectural thing [19:46:16] prtksxna: It's just you need to override more than expected? [19:46:29] Just that we'll have to override the toHTML method in the traditional gallery [19:46:33] MarkTraceur: Yes [19:46:35] Which is a pain [19:46:39] OK [19:46:53] Not a pain, but quite a bit of replication [19:46:56] prtksxna: And it's not worth it, you think, to first pull toHTML into several different methods so we can only override what we need? [19:47:10] I think that would be the way to go [19:47:17] That's what I would do :) [19:47:27] So for now I am overriding it completely to understand what parts I need [19:47:35] Sounds good [19:47:41] And will then break toHTML only as much as I need [19:47:53] Cool [19:47:55] I take it this will all be one patch, rather than trying to create an API with no users [19:48:07] Core reviewers take a dim view of unused abstractions [19:48:34] MarkTraceur: Yeah! Or 2 dependent patches, just to make review easier [19:48:49] I'd go with everything at once. [19:49:02] MarkTraceur: Cool, that makes it simpler [19:49:30] MarkTraceur: Do you have any fixes for the cache problem I am running into? I've had to vagrant reload a million times today [19:53:11] prtksxna: I think I said you may need to clear localStorage [19:53:15] But I'm not sure. [19:53:40] (03PS2) 10TheDJ: Remove fallback content of video/audio tag [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288249 (https://phabricator.wikimedia.org/T133671) [20:05:37] MarkTraceur: Oh yeah! Sorry, I forgot you said that. [20:07:06] prtksxna: It's okay, sometimes I forget things I say too. [20:07:19] Like for example "hey lindseyanne let's meet every other week on Wednesdays" [20:07:22] totally forgot about that [20:07:36] Oh, she stood me up. No harm no foul. [20:13:48] :D [20:16:19] (03CR) 10MarkTraceur: [C: 032] mw.UploadWizardUpload: Remove unused function #acceptDeed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/286444 (owner: 10Bartosz Dziewoński) [20:21:48] MatmaRex: Where does this.$group come from in the details patch? [20:21:52] 288138. [20:22:03] MarkTraceur: GroupElement mixin [20:22:09] Ah. [20:22:21] it's also used in the constructor of that class [20:22:26] Ooookay [20:23:22] Yeah if I hadn't left off an 's' I would have seen it. [20:23:43] (03CR) 10MarkTraceur: [C: 032] uw.DescriptionsDetailsWidget: Remove any "Remove" buttons when clearing items [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/288138 (https://phabricator.wikimedia.org/T134180) (owner: 10Bartosz Dziewoński) [20:26:45] (03Merged) 10jenkins-bot: mw.UploadWizardUpload: Remove unused function #acceptDeed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/286444 (owner: 10Bartosz Dziewoński) [20:26:50] (03Merged) 10jenkins-bot: uw.DescriptionsDetailsWidget: Remove any "Remove" buttons when clearing items [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/288138 (https://phabricator.wikimedia.org/T134180) (owner: 10Bartosz Dziewoński) [20:54:58] 06Multimedia, 10UploadWizard: "Remove" buttons for descriptions are duplicated when there are multiple descriptions and you use the "Copy metadata" feature - https://phabricator.wikimedia.org/T134180#2286832 (10matmarex) 05Open>03Resolved [21:28:02] 06Multimedia, 06Commons, 10UploadWizard: Commons's message 'mwe-upwiz-license-cc-subhead' is broken - https://phabricator.wikimedia.org/T134049#2287169 (10matmarex) [21:29:58] 06Multimedia, 06Commons, 10UploadWizard: Commons's message 'mwe-upwiz-license-cc-subhead' is broken - https://phabricator.wikimedia.org/T134049#2253460 (10Jdforrester-WMF) We can fix the message with `{{` instead? [21:32:55] 06Multimedia, 06Commons, 10UploadWizard: Commons's message 'mwe-upwiz-license-cc-subhead' is broken - https://phabricator.wikimedia.org/T134049#2287179 (10matmarex) jqueryMsg doesn't support HTML entities, either. [22:14:33] (03Abandoned) 10Paladox: Update dependencies for MwEmbedSupport [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/182094 (owner: 10Paladox) [22:26:21] (03PS3) 10TheDJ: Output width and height attribs for