[11:30:20] 6Multimedia, 10Beta-Cluster-Infrastructure, 6Commons, 10MediaWiki-File-management: Thumbnail generation should happen via the same setup in the beta cluster and in production (tracking) - https://phabricator.wikimedia.org/T84950#2168051 (10Tgr) Video also seems broken ([[http://commons.wikimedia.beta.wmfla... [13:42:52] 6Multimedia, 10UploadWizard: make chunked uploads deafult rather than opt-in - https://phabricator.wikimedia.org/T131496#2168763 (10Matanya) [14:07:27] > more than a year [14:07:35] matanya: It's been a sight more time than that :) [14:08:27] Either way it sounds good to me, removes more weird gates in the UW upload code [14:08:49] Pretty sure all of our browser deprecations have removed any possible technical barriers to the change [14:10:02] 6Multimedia, 10UploadWizard: make chunked uploads deafult rather than opt-in - https://phabricator.wikimedia.org/T131496#2168971 (10MarkTraceur) p:5Triage>3Normal Seems like a good idea to me! I like the idea of more people being able to upload more things, more easily. And the recent changes to the browse... [14:11:06] (03PS1) 10Zfilipin: WIP testing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/280913 (https://phabricator.wikimedia.org/T128190) [14:11:30] MarkTraceur: i am working on my british understatement :) [14:14:08] 6Multimedia, 10UploadWizard: make chunked uploads deafult rather than opt-in - https://phabricator.wikimedia.org/T131496#2168763 (10Jdforrester-WMF) James approved. [14:19:14] (03PS1) 10Reedy: Enable chunked uploading by default [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/280915 (https://phabricator.wikimedia.org/T131496) [14:19:20] matanya: ^ [14:19:41] thanks Reedy [14:21:37] MarkTraceur: feel free to merge this :) [14:22:15] My goodness. [14:22:33] Reedy: I was thinking we would take out the code that handled non-chunked uploads at the same time [14:22:43] #effort [14:22:52] Well, that's why we're a team :) [14:23:06] We as in me? :P [14:23:10] I wonder how much it's used [14:23:36] includes/specials/SpecialUploadWizard.php: if ( $config['enableChunked'] === 'opt-in' ) { [14:23:36] includes/specials/SpecialUploadWizard.php: $config['enableChunked'] = (bool)$this->getUser()->getOption( 'upwiz-chunked' ); [14:23:36] resources/mw.UploadWizardUpload.js: if ( mw.UploadWizard.config.enableChunked ) { [14:23:37] resources/transports/mw.FormDataTransport.js: * @param {Object} [config.enableChunked] [14:23:37] resources/transports/mw.FormDataTransport.js: if ( this.config.enableChunked && file.size > chunkSize ) { [14:23:37] tests/qunit/transports/mw.FormDataTransport.test.js: function createTransport( enableChunked, chunkSize ) { [14:23:39] tests/qunit/transports/mw.FormDataTransport.test.js: enableChunked = ( enableChunked === undefined ) ? false : enableChunked; [14:23:41] tests/qunit/transports/mw.FormDataTransport.test.js: enableChunked: enableChunked, [14:23:44] UploadWizard.config.php: 'enableChunked' => false, [14:23:46] UploadWizardHooks.php: if ( UploadWizardConfig::getSetting( 'enableChunked' ) === 'opt-in' ) { [14:23:50] Not too bad [14:24:14] Dependant patch? Or amend? [14:25:00] MarkTraceur: ^ [14:25:38] Reedy: Amend away [14:26:49] inb4 two hundred people using Firefox 8 complain they can no longer upload donated GLAM materials because of the change [14:26:57] * James_F grins. [14:28:53] 6Multimedia, 6Commons, 10Internet-Archive, 10MediaWiki-Uploading, 13Patch-For-Review: Upload by URL doesn't work well for large files: HTTP request timed out. - https://phabricator.wikimedia.org/T118887#2169058 (10Dereckson) The issue was briefly discussed on #wikimedia-operations channel and @brion high... [14:30:44] (03PS2) 10Reedy: Chunked Upload is always enabled. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/280915 (https://phabricator.wikimedia.org/T131496) [14:31:17] Hoo boy. [14:31:44] 6Multimedia, 10UploadWizard, 13Patch-For-Review, 7user-notice: Make chunked uploads default rather than opt-in - https://phabricator.wikimedia.org/T131496#2169079 (10Jdforrester-WMF) [14:32:49] (03CR) 10jenkins-bot: [V: 04-1] Chunked Upload is always enabled. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/280915 (https://phabricator.wikimedia.org/T131496) (owner: 10Reedy) [14:32:56] Fuck you too jenkins [14:33:27] 14:31:37 775 | WARNING | Global $wgLang is never used. [14:33:27] 14:31:37 | | (MediaWiki.VariableAnalysis.UnusedGlobalVariables) [14:34:12] (03PS3) 10Reedy: Chunked Upload is always enabled. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/280915 (https://phabricator.wikimedia.org/T131496) [14:36:20] (03CR) 10Jforrester: [C: 04-1] ":-P" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/280915 (https://phabricator.wikimedia.org/T131496) (owner: 10Reedy) [14:36:37] (03CR) 10jenkins-bot: [V: 04-1] Chunked Upload is always enabled. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/280915 (https://phabricator.wikimedia.org/T131496) (owner: 10Reedy) [14:38:01] stupid qunit [14:38:47] (03PS4) 10Reedy: Always use Chunked Upload rather than allow users to opt in. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/280915 (https://phabricator.wikimedia.org/T131496) [14:40:10] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading, 5MW-1.27-release-notes, 5WMF-deploy-2016-04-05_(1.27.0-wmf.20): Kill 'emptyfile' error code in favor of 'empty-file' - https://phabricator.wikimedia.org/T130484#2169127 (10matmarex) 5Open>3Resolved [14:42:46] (03CR) 10jenkins-bot: [V: 04-1] Always use Chunked Upload rather than allow users to opt in. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/280915 (https://phabricator.wikimedia.org/T131496) (owner: 10Reedy) [14:43:51] Reedy: Jenkins has been such a joker this week. [14:44:55] He's a dick [14:45:05] There's probably some little edge case that I've broken removing some of the JS [15:00:31] I'll take a look at it...but I might go to the coffee shop first [15:24:04] Reedy: there's probably a test case for whatever you removed [16:13:01] MatmaRex: Yeah, there is [16:13:06] I removed the dependant code... [16:34:09] Reedy is just doing this so he can axe another preference. [16:34:12] Typical. [16:35:16] > TypeError: file.slice is not a function [16:35:25] Reedy: phantomjs must not support fileapi. :P [16:35:34] So it's not my fault? [16:35:35] ;) [16:35:44] I just made it exercise some code it wasn't exercising before? ;) [16:35:49] aka your tests suck [16:36:08] Oh, no, you need to create a slice function in the fake file probably [16:36:21] qunit doesn't use real files, just fake file-like objects [16:36:39] And yeah, that probably should have been checked before [16:39:33] Checking with debug=true on localhost. [16:40:20] Ooh, no, it looks like now it's using chunks where it shouldn't [16:43:21] OK, got it. [16:44:16] (03CR) 10MarkTraceur: [C: 04-1] "Found the test failure." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/280915 (https://phabricator.wikimedia.org/T131496) (owner: 10Reedy) [17:11:02] 6Multimedia, 6Commons, 6Design-Research-Backlog, 10UploadWizard, 7Voice & Tone: Review UploadWizard UX for "fatal user errors" - https://phabricator.wikimedia.org/T77820#830918 (10Capt_Swing) Thanks for the information, @Jdforrester-WMF. It sounds like this isn't (currently) a research request from a pro... [17:11:13] 6Multimedia, 6Commons, 10UploadWizard, 7Voice & Tone: Review UploadWizard UX for "fatal user errors" - https://phabricator.wikimedia.org/T77820#2169679 (10Capt_Swing) [17:38:23] i really can't get myself to do anything today. [17:40:52] Aw MatmaRex. [19:03:16] (03CR) 10TheDJ: "this was jenkins testing right ? can it be abandoned ?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/250951 (owner: 10Paladox) [19:07:17] (03CR) 10TheDJ: [C: 032] Remove double normalization of audio player width [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/278574 (owner: 10TheDJ) [19:08:31] (03Abandoned) 10Paladox: PLEASE REVIEW - DO NOT MERGE [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/250951 (owner: 10Paladox) [19:09:43] (03CR) 10TheDJ: [C: 032] Allow audio player to be larger than 220px [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/278573 (https://phabricator.wikimedia.org/T56370) (owner: 10TheDJ) [19:14:58] (03Merged) 10jenkins-bot: Remove double normalization of audio player width [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/278574 (owner: 10TheDJ) [19:18:37] (03Merged) 10jenkins-bot: Allow audio player to be larger than 220px [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/278573 (https://phabricator.wikimedia.org/T56370) (owner: 10TheDJ) [19:48:42] (03CR) 10TheDJ: [C: 032] Add the videojs-ogvjs Tech module [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260963 (https://phabricator.wikimedia.org/T119048) (owner: 10TheDJ) [19:51:22] 6Multimedia, 6Commons, 10Internet-Archive, 10MediaWiki-Uploading, 13Patch-For-Review: Upload by URL doesn't work well for large files: HTTP request timed out. - https://phabricator.wikimedia.org/T118887#2170273 (10Yann) It should be mentioned that most free videos available on the Net are not under a fre... [19:54:29] 6Multimedia, 6Commons, 10Internet-Archive, 10MediaWiki-Uploading, 13Patch-For-Review: Upload by URL doesn't work well for large files: HTTP request timed out. - https://phabricator.wikimedia.org/T118887#2170276 (10Dereckson) I beg to differ, we have currently on the site-request project an increase of re... [19:55:59] (03CR) 10Paladox: [C: 031] "@TheDJ you need to re c+2 again please." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260963 (https://phabricator.wikimedia.org/T119048) (owner: 10TheDJ) [20:09:30] (03CR) 10TheDJ: [C: 032] Add the videojs-ogvjs Tech module [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260963 (https://phabricator.wikimedia.org/T119048) (owner: 10TheDJ) [20:13:02] 6Multimedia, 10MediaWiki-Uploading, 7Blocked-on-Multimedia: "Categories" item gets duplicated in basic upload form at Commons - https://phabricator.wikimedia.org/T131382#2170294 (10matmarex) 5Open>3Invalid Unfortunately this is Commons-specific code and not something we (#multimedia) maintain. Previously... [20:16:40] (03Merged) 10jenkins-bot: Add the videojs-ogvjs Tech module [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260963 (https://phabricator.wikimedia.org/T119048) (owner: 10TheDJ) [20:21:27] 6Multimedia, 10MediaWiki-Uploading, 7Blocked-on-Multimedia: "Categories" item gets duplicated in basic upload form at Commons - https://phabricator.wikimedia.org/T131382#2165466 (10TheDJ) HotCat was recently changed (T103285) to listen to wikipage.content, but on the upload page, we trigger mw.hook wikipage.... [20:59:24] (03PS2) 10Paladox: Update videojs to 5.8.7 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/280499 [21:03:44] (03CR) 10jenkins-bot: [V: 04-1] Update videojs to 5.8.7 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/280499 (owner: 10Paladox) [21:04:19] (03PS3) 10Paladox: Update videojs to 5.8.7 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/280499 [21:07:11] (03PS4) 10Paladox: Update videojs to 5.8.7 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/280499 [21:22:56] 6Multimedia, 10Beta-Cluster-Infrastructure, 6Commons, 10MediaWiki-File-management: Thumbnail generation should happen via the same setup in the beta cluster and in production (tracking) - https://phabricator.wikimedia.org/T84950#2170538 (10greg) >>! In T84950#2168051, @Tgr wrote: > Video also seems broken... [21:28:00] 6Multimedia, 6Commons, 6Community-Advocacy, 6Editing-Department, and 2 others: Commons and testwiki used as video hoster by Wikipedia Zero - https://phabricator.wikimedia.org/T129845#2170562 (10Gunnex) The "Angola Facebook Case" is covered now by "Globo" (the largest mass media group of Latin America) and...