[02:34:42] 6Multimedia, 10UploadWizard, 7Technical-Debt: Make removeUpload and removeMatchingUploads etc. into UploadWizardUpload and UploadWizardUploadList, respectively - https://phabricator.wikimedia.org/T291#2125194 (10matmarex) [02:38:14] 6Multimedia, 10UploadWizard: Provide modal tool to other teams (VE, Flow, Mobile) - https://phabricator.wikimedia.org/T77571#2125196 (10matmarex) [02:38:16] 6Multimedia, 10MediaWiki-General-or-Unknown, 7Epic, 5MW-1.26-release, 13Patch-For-Review: Be able to embed an upload dialog so that other extensions (e.g. WikiEditor, VisualEditor) can provide it to users - https://phabricator.wikimedia.org/T91717#2125197 (10matmarex) [02:44:00] 6Multimedia, 10UploadWizard: Enable cross-wiki uploads (from Enwiki to Commons) - https://phabricator.wikimedia.org/T77572#2125202 (10matmarex) [02:44:02] 6Multimedia, 10MediaWiki-General-or-Unknown, 7Epic, 5MW-1.26-release, 13Patch-For-Review: Be able to embed an upload dialog so that other extensions (e.g. WikiEditor, VisualEditor) can provide it to users - https://phabricator.wikimedia.org/T91717#2125203 (10matmarex) [02:46:00] 6Multimedia, 10UploadWizard, 7Technical-Debt: Separate interface code from other upload functions - https://phabricator.wikimedia.org/T77568#2125207 (10matmarex) 5Open>3declined This task doesn't really have enough information to be useful for anything now. [02:46:14] 6Multimedia, 10UploadWizard, 7Technical-Debt: Separate interface code from other upload functions - https://phabricator.wikimedia.org/T77568#2125209 (10matmarex) 5declined>3Invalid [03:20:57] (03PS1) 10Bartosz Dziewoński: uw.controller.Upload: Remove unused 'prevent-close' event [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277710 [03:20:59] (03PS1) 10Bartosz Dziewoński: mw.UploadWizard: Remove unused method #removeEmptyUploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277711 [03:21:01] (03PS1) 10Bartosz Dziewoński: uw.controller.Upload: Only reset failed uploads when we really mean to retry them [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277712 [03:21:03] (03PS1) 10Bartosz Dziewoński: uw.controller.Step: Emit 'load' earlier, so that mw.UploadWizard#removeErrorUploads works [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277713 [03:21:05] (03PS1) 10Bartosz Dziewoński: mw.UploadWizardUpload: Disentangle JPEG metadata from filling uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277714 [03:21:23] (03CR) 10Bartosz Dziewoński: "This gets fixed for real in https://gerrit.wikimedia.org/r/277714." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/234530 (https://phabricator.wikimedia.org/T92801) (owner: 10Bartosz Dziewoński) [03:25:00] (03CR) 10jenkins-bot: [V: 04-1] mw.UploadWizardUpload: Disentangle JPEG metadata from filling uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277714 (owner: 10Bartosz Dziewoński) [03:27:14] (03PS2) 10Bartosz Dziewoński: mw.UploadWizardUpload: Disentangle JPEG metadata from filling uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277714 [07:57:06] 6Multimedia, 10MediaWiki-Gallery, 7Design: Provide an auto-rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T128429#2125449 (10Prtksxna) The current gallery in mediawiki has a bunch of modes, I was wondering if we can re-use them in a way that keeps gallery creation prett... [09:01:46] 6Multimedia, 10MediaWiki-Gallery, 7Design: Provide an auto-rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T128429#2125532 (10Prtksxna) This could work to replace single images as well. For example in the [[ https://en.wikipedia.org/wiki/British_Museum#Growth_and_change_... [09:49:48] 6Multimedia, 10MediaWiki-Gallery, 7Design: Provide an auto-rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T128429#2125586 (10Prtksxna) Clicking an image inside a gallery could open a Commons style (see F3613972) MultimediaViewer with the thumbnails of the images in the... [11:42:03] 6Multimedia, 10MediaWiki-Gallery, 7Design: Provide an auto-rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T128429#2125879 (10Prtksxna) And as @Pginer-WMF pointed out, it would be helpful to have a thumbnail view, especially for larger galleries.{F3642827} [13:30:14] Looks like it's time for a code review rampage [13:31:12] hiho MarkTraceur [13:31:21] Hey MatmaRex [13:32:21] (03CR) 10MarkTraceur: [C: 032] uw.controller.Upload: Remove unused 'prevent-close' event [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277710 (owner: 10Bartosz Dziewoński) [13:32:53] (03CR) 10MarkTraceur: [C: 032] mw.UploadWizard: Remove unused method #removeEmptyUploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277711 (owner: 10Bartosz Dziewoński) [13:35:22] (03CR) 10MarkTraceur: [C: 032] uw.controller.Upload: Only reset failed uploads when we really mean to retry them [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277712 (owner: 10Bartosz Dziewoński) [13:35:51] 6Multimedia, 10MediaWiki-Gallery, 7Design: Provide an auto-rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T128429#2126030 (10Jdforrester-WMF) I like the ideas in T128429#2125449 and T128429#2125586 a bunch. :-) I'm not so sure about blurring into re-implementing (or, f... [13:36:06] (03CR) 10MarkTraceur: [C: 032] uw.controller.Step: Emit 'load' earlier, so that mw.UploadWizard#removeErrorUploads works [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277713 (owner: 10Bartosz Dziewoński) [13:38:04] (03CR) 10MarkTraceur: [C: 032] mw.UploadWizardUpload: Disentangle JPEG metadata from filling uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277714 (owner: 10Bartosz Dziewoński) [13:38:10] Wow, that's an awesome win [13:40:58] (03Merged) 10jenkins-bot: uw.controller.Upload: Remove unused 'prevent-close' event [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277710 (owner: 10Bartosz Dziewoński) [13:41:09] (03Merged) 10jenkins-bot: mw.UploadWizard: Remove unused method #removeEmptyUploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277711 (owner: 10Bartosz Dziewoński) [13:54:28] (03Merged) 10jenkins-bot: uw.controller.Upload: Only reset failed uploads when we really mean to retry them [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277712 (owner: 10Bartosz Dziewoński) [13:54:31] (03Merged) 10jenkins-bot: uw.controller.Step: Emit 'load' earlier, so that mw.UploadWizard#removeErrorUploads works [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277713 (owner: 10Bartosz Dziewoński) [13:54:59] Good times [13:55:01] One more? [13:55:49] Go go go! [13:56:50] :o [14:03:52] (03Merged) 10jenkins-bot: mw.UploadWizardUpload: Disentangle JPEG metadata from filling uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277714 (owner: 10Bartosz Dziewoński) [14:04:15] Good refactoring things, yay [14:04:26] Now...where was I before the plague hit [14:11:43] MarkTraceur: Metrics stuff? [14:11:59] Pretty sure I was still banging my head against the core upload dialog [14:12:03] * James_F can't remember either. [14:12:08] Oh, fun. [14:20:50] Not really [14:20:58] Who wrote this crap anyway [14:55:36] so MatmaRex prtksxna James_F during the week I was laid up and/or on vacation I tried to keep up, but I think might have failed. What should I take to SoS? [14:56:15] MarkTraceur: Not sure. "Hey!"? [14:56:33] Sounds good [15:00:54] MarkTraceur: i don't think we need anything from anyone. we might want to let people know we're going to do another upload dialog A/B test [15:01:05] K, I'll say that then [15:01:16] MarkTraceur: but no idea when. i think it's you and prtksxna handling this one. ;) [15:48:58] 6Multimedia, 10UploadWizard: Suggest nearby categories based on EXIF latitude/longitude - https://phabricator.wikimedia.org/T130120#2126402 (10Nicolas_Raoul) [19:13:54] (03PS1) 10Bartosz Dziewoński: Consistently pass config in uw.controller.Step subclasses [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277846 [19:13:56] (03PS1) 10Bartosz Dziewoński: uw.controller.Step: Refactor simultaneous transitions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277847 (https://phabricator.wikimedia.org/T92809) [19:13:59] MarkTraceur: this one's big. ^ [19:14:05] Yeeees [19:14:33] i'm wondering if there's some sensible way to add some tests for ConcurrentQueue [19:14:58] (03CR) 10MarkTraceur: [C: 032] Consistently pass config in uw.controller.Step subclasses [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277846 (owner: 10Bartosz Dziewoński) [19:14:59] but it's hard to test for the same reason why it would be really good for it to have tests [19:15:50] Oh, huh. [19:15:52] (03CR) 10jenkins-bot: [V: 04-1] uw.controller.Step: Refactor simultaneous transitions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277847 (https://phabricator.wikimedia.org/T92809) (owner: 10Bartosz Dziewoński) [19:15:57] Uh oh. [19:16:12] I guess jenkins managed to test it anyway, huh [19:16:35] 6Multimedia, 10ArchCom-RfC, 6Commons, 10MediaWiki-File-management, and 13 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#2127221 (10GWicke) > What problem would such a VCL rule solve? We need both a good long-term API design, as... [19:16:48] hmm, Details#transitionAll had tests. but i expected them to pass [19:16:57] bah, i forgot to fix a class name [19:18:06] (03PS2) 10Bartosz Dziewoński: uw.controller.Step: Refactor simultaneous transitions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277847 (https://phabricator.wikimedia.org/T92809) [19:18:21] should pass existing tests now, unless i made something too asynchronous [19:19:46] (03CR) 10jenkins-bot: [V: 04-1] uw.controller.Step: Refactor simultaneous transitions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277847 (https://phabricator.wikimedia.org/T92809) (owner: 10Bartosz Dziewoński) [19:28:26] 6Multimedia, 10ArchCom-RfC, 6Commons, 10MediaWiki-File-management, and 13 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#2127267 (10GWicke) [19:30:18] 6Multimedia, 10ArchCom-RfC, 6Commons, 10MediaWiki-File-management, and 13 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#1800774 (10GWicke) [19:30:32] wow, how many freaking projects does that task have [19:31:54] 17 I guess [19:32:12] MatmaRex: Tests still failing? Is it a false positive? [19:49:09] (03CR) 10jenkins-bot: [V: 04-1] Consistently pass config in uw.controller.Step subclasses [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277846 (owner: 10Bartosz Dziewoński) [19:49:51] MarkTraceur: dunno, but i'll find out. it worked in practice for me [19:52:09] 6Multimedia, 10ArchCom-RfC, 6Commons, 10MediaWiki-File-management, and 13 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#2127370 (10GWicke) [19:52:46] 6Multimedia, 10ArchCom-RfC, 6Commons, 10MediaWiki-File-management, and 13 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#1811983 (10GWicke) [19:54:34] 6Multimedia, 10ArchCom-RfC, 6Commons, 10MediaWiki-File-management, and 13 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#2127384 (10GWicke) [19:58:33] 6Multimedia, 10ArchCom-RfC, 6Commons, 10MediaWiki-File-management, and 13 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#2127391 (10GWicke) I have updated the task description to more clearly separate out use cases and requirement... [20:03:47] 6Multimedia, 10ArchCom-RfC, 6Commons, 10MediaWiki-File-management, and 13 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#2127396 (10GWicke) [20:04:22] (03PS3) 10Bartosz Dziewoński: uw.controller.Step: Refactor simultaneous transitions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277847 (https://phabricator.wikimedia.org/T92809) [20:04:36] 6Multimedia, 10ArchCom-RfC, 6Commons, 10MediaWiki-File-management, and 13 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#1842437 (10GWicke) [20:06:09] (03CR) 10jenkins-bot: [V: 04-1] uw.controller.Step: Refactor simultaneous transitions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277847 (https://phabricator.wikimedia.org/T92809) (owner: 10Bartosz Dziewoński) [20:12:40] (03PS4) 10Bartosz Dziewoński: uw.controller.Step: Refactor simultaneous transitions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277847 (https://phabricator.wikimedia.org/T92809) [20:12:42] ughhh. [20:14:21] (03CR) 10jenkins-bot: [V: 04-1] uw.controller.Step: Refactor simultaneous transitions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277847 (https://phabricator.wikimedia.org/T92809) (owner: 10Bartosz Dziewoński) [20:15:55] goddam [20:16:07] maybe i should try this stuff locally [20:16:11] instead of assuming it's sane [20:27:00] what would be the purpose of JenkinsBot then ... [20:27:08] don't make him unemployed [20:39:09] (03PS5) 10Bartosz Dziewoński: uw.controller.Step: Refactor simultaneous transitions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277847 (https://phabricator.wikimedia.org/T92809) [20:40:54] (03CR) 10jenkins-bot: [V: 04-1] uw.controller.Step: Refactor simultaneous transitions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277847 (https://phabricator.wikimedia.org/T92809) (owner: 10Bartosz Dziewoński) [20:42:18] eh [20:42:37] this would be easier if i could run individual tests locally, but they fail if they don't run in order, which takes ages… [20:42:42] "unit" tests [20:43:29] (03PS6) 10Bartosz Dziewoński: uw.controller.Step: Refactor simultaneous transitions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277847 (https://phabricator.wikimedia.org/T92809) [20:43:35] sixth time the charm [20:48:41] unit tests that fail if they do not run in the sequence specified. sounds like trouble [20:50:11] (03CR) 10Bartosz Dziewoński: [C: 032] "False failure (looks like a race condition of OOjs UI update in mediawiki/core and mediawiki/vendor)." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277846 (owner: 10Bartosz Dziewoński) [20:51:14] rillke: i know, right? i really don't feel like debugging this now [20:51:25] (03Merged) 10jenkins-bot: Consistently pass config in uw.controller.Step subclasses [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277846 (owner: 10Bartosz Dziewoński) [22:11:02] (03PS1) 10Bartosz Dziewoński: Use local this.config rather than mw.UploadWizard.config where we need to [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277901 [22:11:09] rillke: there, i ended up debugging it a bit. ^ :D [22:13:47] (03CR) 10jenkins-bot: [V: 04-1] Use local this.config rather than mw.UploadWizard.config where we need to [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277901 (owner: 10Bartosz Dziewoński) [22:14:12] great [22:19:45] (03PS2) 10Bartosz Dziewoński: Use local this.config rather than mw.UploadWizard.config where we need to [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/277901 [22:33:44] 6Multimedia, 10ArchCom-RfC, 6Commons, 10MediaWiki-File-management, and 13 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#2127797 (10RobLa-WMF) Discussed in {E148}. Releve 3:00 PM Minutes: https://tools.... [22:36:03] MatmaRex: Yeah, the UW "unit" tests were never really that [22:36:27] Probably most of them should be deleted, I went on a spree pretty early on in my attempts to make the thing bug-proof [22:36:31] Obviously it's more of a hindrance now [22:36:44] And as we all know, hubris is no way to run a software project [22:37:04] Make something bug-proof and someone will build a better bug [23:01:44] Do we have MatmaRex and James_F|Away joining us? [23:01:51] (|away so I guess just MatmaRex?) [23:02:30] yeah [23:53:29] 6Multimedia, 10UploadWizard: Special:UploadWizard spins forever on IE 6 and other grade-C browsers - https://phabricator.wikimedia.org/T130167#2128097 (10matmarex) [23:54:03] 6Multimedia, 10UploadWizard: Special:UploadWizard spins forever on IE 6 and other grade-C browsers - https://phabricator.wikimedia.org/T130167#2128118 (10matmarex) [23:54:05] 6Multimedia, 10UploadWizard, 7Technical-Debt: Remove support for browsers not supporting HTML5 File API from UploadWizard - https://phabricator.wikimedia.org/T126763#2128117 (10matmarex)