[11:59:10] MarkTraceur: I haven't been able to do any work today and wont be able to attend the meeting tomorrow :( [11:59:27] MarkTraceur: I should be back to my normal self tomorrow though [14:19:36] brion: it would be thorougly appreciated if you and/or cscott could look at the parsertests etc for TMH [14:19:49] thedj: ah will do [14:19:54] i've been so caught up in The Troubles, sorry [14:20:00] yeah I know... [14:20:19] last thing any of us needed [14:20:39] * brion git-update's [14:33:45] ok lemme poke those patches [14:40:17] * brion pokes parserTests with a stick and holds nose just in case [14:41:44] haha [14:42:02] right, you need to test with phpunit btw. [14:42:44] or well. both methods likely. But phpunit parsertests are what jenkins is using, which definetly needs to work. [14:43:11] took me ages to figure out that we actually have two runners, and both use different environments... [14:50:56] (03CR) 10Brion VIBBER: [C: 04-1] "Looks good so far, running now to double-check..." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/262926 (https://phabricator.wikimedia.org/T126723) (owner: 10TheDJ) [14:54:20] yeah the double runners is "fun" :D [14:54:39] adding the 'transcode' table to the dupes for parserTests... [14:56:42] ok now runs with thta runner, lemme test under phpunit [14:57:15] (03PS7) 10Brion VIBBER: Add parser tests for TMH output [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/262926 (https://phabricator.wikimedia.org/T126723) (owner: 10TheDJ) [14:58:35] wow, I didn't even know about the ParserTestTables hook. [15:01:56] yeah it probably shoulda been a variable [15:02:01] no idea why we did it as a hook [15:02:07] s/we/probably me/ [15:02:31] i think i've got the right phpunit command line now.... /me waits a bit for churn [15:03:19] prtksxna: OK! We'll talk to you at the next meeting. Feel better. [15:03:27] we should have a make parser option... [15:03:31] * thedj files a ticket for that. [15:03:36] And now I'm the last Multimedia team member standing. [15:03:46] thedj: yeah classic way was to use --regex option but labeling on the items is inconsistent [15:03:57] or else explicitly choose to run one file... but not sure you can do that via phpunit easily [15:05:32] thedj, MarkTraceur : that reminds me once things calm down and we have time to talk -- i'm hoping to spin up a multimedia working group (via archcom) to make sure we're talking about & moving forward on media-related RfCs and patches and not letting things languish [15:06:00] brion: I'm on board.. [15:06:01] brion: I'm game. [15:06:04] awesome [15:06:09] i'll write up more notes later in the week [15:06:13] you know, if i'm still employed [15:06:22] brion: Probably invite yurik to it, too. [15:06:25] spiff [15:06:46] brion: Well I can't let them fire you now, you have to start a working group. [15:06:54] haha [15:07:03] brion: meh, otherwise we'll start that MediaWiki Foundation after all :) [15:07:19] Who will be our ED? Is Sue available? [15:07:49] I was thinking Pavel Richter, just for kicks. [15:08:10] does feel like the tests run slower via phpunit than via the classic parser test runner [15:08:37] they do. a whole lot. there is a ticket about that somewhere... [15:08:55] ok man debugging phpunit performance sounds like something i do not want to do at 7am on a monday [15:08:56] later :D [15:09:04] https://phabricator.wikimedia.org/T41473 [15:09:59] * brion wanders off to start some bacon in the meantime [15:10:40] i spent a week setting up apache/php/xdebug/phpunit/IDE in order to step through the phpunit parser tests and figure out why they were crashing (as in no error, just segfault). [15:13:13] not something i want to do too often :) [15:13:54] heh "ok 1337 - ParserTest_Parser__extraParserTests::testMediaWikiTestCaseParentSetupCalled" [15:14:01] my tests are super 1337 d00d [15:14:10] rofl [15:14:31] (03CR) 10Brion VIBBER: [C: 032] "Ok LGTM and runs on both runners now, approving." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/262926 (https://phabricator.wikimedia.org/T126723) (owner: 10TheDJ) [15:15:10] (03PS2) 10Brion VIBBER: Correct parser test with tidy config [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/272329 (https://phabricator.wikimedia.org/T122787) (owner: 10TheDJ) [15:18:50] (03CR) 10Brion VIBBER: "Hm, this one fails for me. Is a specific config needed in the tests?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/272329 (https://phabricator.wikimedia.org/T122787) (owner: 10TheDJ) [15:19:41] ah oh i see i think [15:19:55] thedj: that needs the core tweak right? anything dependent on that or is that ready to go too? [15:20:15] brion: it needs the tidy change [15:20:23] great lemme test those together [15:23:31] (03Merged) 10jenkins-bot: Add parser tests for TMH output [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/262926 (https://phabricator.wikimedia.org/T126723) (owner: 10TheDJ) [15:24:59] (03CR) 10Brion VIBBER: [C: 032] "As noted on IRC this needed the dependent change, already linked up. :) Merging that. Approving here, hopefully jenkins will understand th" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/272329 (https://phabricator.wikimedia.org/T122787) (owner: 10TheDJ) [15:26:41] brion: awesomeness. Now take care the rest of this day would you please ? [15:26:48] <3 [15:40:50] (03Merged) 10jenkins-bot: Correct parser test with tidy config [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/272329 (https://phabricator.wikimedia.org/T122787) (owner: 10TheDJ) [15:42:46] 6Multimedia, 6Commons, 10MediaWiki-File-management, 7Easy, and 2 others: Greyscale pngs without gAMA chunk rendered with incorrect contrast - https://phabricator.wikimedia.org/T106516#2051229 (10Ahecht) While we're waiting for someone else to take this up, a workaround on a per-image basis is to download t... [16:40:17] (03CR) 10Florianschmidtwelzow: [C: 04-1] "needs rebase." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/272273 (https://phabricator.wikimedia.org/T127608) (owner: 10Ori.livneh) [18:00:35] 6Multimedia, 6Commons, 10MediaWiki-File-management: Viewing metadata for deleted files and old revisions - https://phabricator.wikimedia.org/T19370#2052031 (10Meno25) [18:10:32] 6Multimedia, 6Commons, 10MediaWiki-File-management: Allow Special:FileDuplicateSearch to match against previously deleted images - https://phabricator.wikimedia.org/T16171#2052103 (10Meno25) [18:21:51] 6Multimedia, 6Commons, 10MediaWiki-File-management: Links on commons upload summaries do not link to commons - https://phabricator.wikimedia.org/T12863#2052166 (10Meno25) [19:13:32] 6Multimedia, 6Commons, 10MediaWiki-File-management: Image file extension should not be part of the name - https://phabricator.wikimedia.org/T6421#2052426 (10Meno25) [19:22:53] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7Crosswiki, 7JavaScript: Do an analysis (SWOT, cost, whatever) of the benefits and losses of the cross-wiki-upload-function - https://phabricator.wikimedia.org/T121013#2052462 (10Gunnex) Well, I'll continue my check — but the current interim results are IMHO... [20:13:35] https://commons.wikimedia.org/wiki/Commons:Village_pump#Google_has_opened_an_API_for_image_recognition is an interesting idea [23:25:11] MarkTraceur: Is we is meeting? [23:25:29] James_F: What, now? I have nothing on my calendar... [23:25:46] MarkTraceur: In 35 minutes' time. [23:25:51] I'm now free for it, but have nothing to say. [23:25:55] Yeah, we're meeting then [23:26:08] Well, actually, prtksxna said he'd miss it. MatmaRex is on "vacation". [23:26:16] If you have nothing to say it'll be a pretty boring meeting [23:26:24] Kill it then? [23:26:24] (Only you can do so.) [23:26:29] lindseyanne: Want to suffer through a very boring 2 minute meeting? [23:26:31] * James_F coughs about SPOFs. [23:26:45] MarkTraceur: Idle five hours, possibly not online. [23:26:49] Argh. [23:27:05] James_F: Guests have been able to edit the event for a while actually [23:27:50] MarkTraceur: And yet I can't. Odd. [23:27:55] Very [23:36:11] James_F: I'll just reply "no" to the event and tell lindseyanne and yourself and TrevorParscal that we are cancelling.