[00:03:55] Aha! [00:03:56] MarkTraceur: I am magic. [00:05:41] MarkTraceur: en, es, ja, de, ru, fr, it, pl, pt, zh, nl, tr, ar, id, sv, fa, ko, cs, fi, he [00:06:00] MarkTraceur: Top 20 Wikipedias by page views. [00:15:14] James_F: You should really email me that [00:15:40] MarkTraceur: sendmail -t "That" -r "mark@wikimedia.org" [00:17:44] (Done.) [00:18:29] That might not be the right mark. [00:18:48] Yeah yeah. [01:53:02] 6Multimedia, 10ArchCom-RfC, 6Commons, 10MediaWiki-File-management, and 11 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#2021369 (10RobLa-WMF) a:3brion Per T125865 and the [2016-02-10 ArchCom meeting](https://www.mediawiki.org/w... [04:37:42] 6Multimedia, 10UploadWizard, 7Technical-Debt: Kill moveFileInputToCover - https://phabricator.wikimedia.org/T126712#2021582 (10matmarex) 3NEW a:3matmarex [04:37:56] 6Multimedia, 10UploadWizard, 7Technical-Debt: Kill moveFileInputToCover - https://phabricator.wikimedia.org/T126712#2021592 (10matmarex) [05:15:50] (03CR) 10Legoktm: [C: 032] Use CanonicalNamespaces hook instead of SetupAfterCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/270127 (https://phabricator.wikimedia.org/T90282) (owner: 10TheDJ) [05:27:18] (03Merged) 10jenkins-bot: Use CanonicalNamespaces hook instead of SetupAfterCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/270127 (https://phabricator.wikimedia.org/T90282) (owner: 10TheDJ) [08:15:25] 6Multimedia, 10UploadWizard: Selection of second language for description in UW has a usability issue - https://phabricator.wikimedia.org/T121196#2021713 (10matmarex) >>! In T121196#2006759, @Herzi.Pinki wrote: > But compared to the normal html dropdown, the behavior is different (and worse IMHO): in normal ht... [08:24:59] 6Multimedia, 10UploadWizard: Selection of second language for description in UW has a usability issue - https://phabricator.wikimedia.org/T121196#2021721 (10matmarex) Hmm, does the search bar at the bottom actually pop up when you just type "eng"? It's not supposed to (and it doesn't for me using Firefox on Wi... [10:11:36] (03PS5) 10TheDJ: Add parser tests for TMH output [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/262926 (https://phabricator.wikimedia.org/T126723) [10:17:50] (03CR) 10jenkins-bot: [V: 04-1] Add parser tests for TMH output [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/262926 (https://phabricator.wikimedia.org/T126723) (owner: 10TheDJ) [11:31:24] 6Multimedia, 10UploadWizard: When uploading many files at once, thumbnails do not appear and can't be shown manually for stashed files - https://phabricator.wikimedia.org/T126728#2021999 (10matmarex) 3NEW a:3matmarex [11:38:31] 6Multimedia, 10UploadWizard: When some files are chosen, and you try to upload one of them twice, the "Continue" button disappears - https://phabricator.wikimedia.org/T126729#2022018 (10matmarex) 3NEW a:3matmarex [14:58:06] (03PS2) 10Bartosz Dziewoński: Define required 'defaults' field in licensing config, correct the code using it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/264697 (https://phabricator.wikimedia.org/T65494) [14:58:08] (03PS2) 10Bartosz Dziewoński: Sort language names for the dropdown case-insensitively [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/268322 (https://phabricator.wikimedia.org/T121625) [14:58:10] (03PS2) 10Bartosz Dziewoński: Allow 'descriptionlang' to be provided without 'description' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/266296 [14:58:28] (03PS1) 10Bartosz Dziewoński: Add a comment about $( '' ).prop( 'disabled' ) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/270291 [14:58:30] (03PS1) 10Bartosz Dziewoński: UploadWizardUploadInterface: Remove some broken dead code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/270292 [14:58:32] (03PS1) 10Bartosz Dziewoński: UploadWizardUpload: Stop processing after encountering a duplicate [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/270293 (https://phabricator.wikimedia.org/T126729) [14:58:34] (03PS1) 10Bartosz Dziewoński: UploadWizardUploadInterface: Hide the "Show thumbnail" button only after showing thumbnail [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/270294 (https://phabricator.wikimedia.org/T126728) [14:58:36] (03PS1) 10Bartosz Dziewoński: [WIP] Move "Add files" functionality from UWUploadInterface to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/270295 (https://phabricator.wikimedia.org/T126712) [14:59:29] MarkTraceur: morning. would be nice if you carved out some time within next few days to review these ;) they should be trivial, except the last one [15:00:00] I can do zat! [15:01:54] (03CR) 10jenkins-bot: [V: 04-1] Allow 'descriptionlang' to be provided without 'description' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/266296 (owner: 10Bartosz Dziewoński) [15:03:00] screw you, Jenkins. it's fine, you liar. [15:17:23] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset, 5Patch-For-Review: Have mediawiki-codesniffer linting on GWToolset - https://phabricator.wikimedia.org/T125554#2022434 (10JeanFred) 5Open>3Resolved a:3JeanFred Since CodeSniffer is executed via Composer, no need to further configure Jenkins. Cl... [15:20:28] (03PS1) 10TheDJ: Fix method signature of getBitRate [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/270300 [15:24:41] (03CR) 10jenkins-bot: [V: 04-1] Fix method signature of getBitRate [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/270300 (owner: 10TheDJ) [15:32:52] (03CR) 10TheDJ: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/270300 (owner: 10TheDJ) [15:38:36] (03CR) 10TheDJ: [C: 032] Fix method signature of getBitRate [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/270300 (owner: 10TheDJ) [15:50:02] (03Merged) 10jenkins-bot: Fix method signature of getBitRate [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/270300 (owner: 10TheDJ) [16:46:38] (03CR) 10MarkTraceur: [C: 032] Define required 'defaults' field in licensing config, correct the code using it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/264697 (https://phabricator.wikimedia.org/T65494) (owner: 10Bartosz Dziewoński) [16:48:48] i think i'm going to call it a day early tonight too. [16:49:05] maybe after filing some UW-perf-related tasks for next week [16:50:20] (03CR) 10MarkTraceur: "Is descriptionlang supposed to prevent descriptions in other languages from being added? For some reason I only get the one language when " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/266296 (owner: 10Bartosz Dziewoński) [16:50:26] MatmaRex: ^^ [16:50:28] Quickly [16:51:47] um, no, it's not [16:52:08] Maybe my en template is weird. [16:52:24] if it's problematic, you can probably rebase the rest of the stack on master, i don't think anything depends on this [16:54:52] Maybe. I don't think it's your patch, though. I think my install is messed up somehow [16:55:20] 6Multimedia, 10UploadWizard, 5Patch-For-Review: When uploading many files at once, thumbnails do not appear and can't be shown manually for stashed files - https://phabricator.wikimedia.org/T126728#2022729 (10matmarex) p:5Triage>3Normal [16:55:33] 6Multimedia, 10UploadWizard, 5Patch-For-Review, 7Technical-Debt: Kill moveFileInputToCover - https://phabricator.wikimedia.org/T126712#2022735 (10matmarex) p:5Triage>3High [16:58:48] (03Merged) 10jenkins-bot: Define required 'defaults' field in licensing config, correct the code using it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/264697 (https://phabricator.wikimedia.org/T65494) (owner: 10Bartosz Dziewoński) [16:59:00] (03CR) 10MarkTraceur: [C: 032] Allow 'descriptionlang' to be provided without 'description' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/266296 (owner: 10Bartosz Dziewoński) [17:01:27] (03Merged) 10jenkins-bot: Allow 'descriptionlang' to be provided without 'description' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/266296 (owner: 10Bartosz Dziewoński) [17:01:52] Funny. [17:04:46] 6Multimedia, 10UploadWizard, 7Technical-Debt: Remove support for browsers not supporting HTML5 File API from UploadWizard - https://phabricator.wikimedia.org/T126763#2022770 (10matmarex) 3NEW [17:05:03] 6Multimedia, 10UploadWizard, 7Technical-Debt: Remove IE8 workarounds from UploadWizard - https://phabricator.wikimedia.org/T123220#2022778 (10matmarex) (Related: {T126763}.) [17:08:44] 6Multimedia, 10UploadWizard: Preview thumbnails show images in wrong orientation (rotation) - https://phabricator.wikimedia.org/T43964#2022814 (10matmarex) 5Open>3Resolved [17:09:00] 6Multimedia, 10UploadWizard: Preview thumbnails show images in wrong orientation (rotation) - https://phabricator.wikimedia.org/T43964#444320 (10matmarex) Presumed fixed, except for the part described in T110802. [17:10:36] 6Multimedia, 10UploadWizard, 7Technical-Debt: Remove support for browsers not supporting HTML5 File API from UploadWizard - https://phabricator.wikimedia.org/T126763#2022849 (10matmarex) [17:10:38] 6Multimedia, 10UploadWizard, 7Technical-Debt: Refactor UploadWizard to be maintainable - https://phabricator.wikimedia.org/T96906#2022848 (10matmarex) [17:11:35] 6Multimedia, 10UploadWizard, 5Patch-For-Review, 7Technical-Debt: Kill moveFileInputToCover - https://phabricator.wikimedia.org/T126712#2021582 (10matmarex) [17:11:52] 6Multimedia, 10UploadWizard, 7Technical-Debt: Move the interface for adding new files to a new UI class and refactor things around it - https://phabricator.wikimedia.org/T89855#1047116 (10matmarex) Hmm, I think I implemented a large part of this with T126712. [17:20:13] 6Multimedia, 10UploadWizard: Clean up possible refactor-related regressions - https://phabricator.wikimedia.org/T96907#2022939 (10matmarex) [17:20:17] 6Multimedia, 10UploadWizard: "Maximum number of concurrent upload" isn't respected - https://phabricator.wikimedia.org/T92809#2022937 (10matmarex) 5Resolved>3Open Definitely not fixed. [17:20:26] 6Multimedia, 10UploadWizard: "Maximum number of concurrent upload" isn't respected - https://phabricator.wikimedia.org/T92809#2022940 (10matmarex) a:5MarkTraceur>3matmarex [17:20:36] 6Multimedia, 10UploadWizard: "Maximum number of concurrent upload" isn't respected - https://phabricator.wikimedia.org/T92809#1120744 (10matmarex) p:5Low>3High [17:21:07] 6Multimedia, 10UploadWizard: "Maximum number of concurrent upload" isn't respected - https://phabricator.wikimedia.org/T92809#1120744 (10matmarex) [17:21:09] 6Multimedia, 10UploadWizard, 7Performance: UploadWizard UI performance abysmal when adding many files to upload at once - https://phabricator.wikimedia.org/T121901#2022944 (10matmarex) [17:23:44] MarkTraceur: hmm, is https://phabricator.wikimedia.org/T94161 a wontfix? i vaguely recall you saying we're scraping these [17:24:49] 6Multimedia, 6Commons, 10UploadWizard: Displaying the stashed file as a thumbnail in UploadWizard fails with an 503 - https://phabricator.wikimedia.org/T90599#2022973 (10matmarex) [17:24:49] MatmaRex: Yeah, I'm going to replace them with a JS-based thing once releng people get back to me [17:24:52] 6Multimedia, 6Commons, 10UploadWizard: Trying to upload causes wikimedia to return a - https://phabricator.wikimedia.org/T90233#2022974 (10matmarex) [17:24:55] marxarelli|afk: How are we looking on that? [17:26:24] 6Multimedia, 10UploadWizard: Clean up possible refactor-related regressions - https://phabricator.wikimedia.org/T96907#1229067 (10matmarex) [17:26:28] 6Multimedia, 10UploadWizard, 7Browser-Tests: Fix failed UploadWizard browsertests Jenkins job - https://phabricator.wikimedia.org/T94161#2022984 (10matmarex) 5Open>3declined a:3matmarex Mark says that nobody cares and that we're going to use something new for browser tests soon. Pretty sure the old one... [17:39:18] 6Multimedia, 10UploadWizard: Only load thumbnails of files visible on-screen in "Upload" step - https://phabricator.wikimedia.org/T126777#2023048 (10matmarex) 3NEW a:3matmarex [17:40:10] 6Multimedia, 10UploadWizard: Build UWUploadInterface DOM detached from the document, then attach all at once - https://phabricator.wikimedia.org/T126778#2023056 (10matmarex) 3NEW a:3matmarex [17:41:17] 6Multimedia, 10UploadWizard: UWDetails objects are being constructed from scratch twice for each uploads: once when stashes, once when moving to Details step - https://phabricator.wikimedia.org/T126780#2023075 (10matmarex) 3NEW a:3matmarex [17:42:36] 6Multimedia, 10UploadWizard: Build UWUploadInterface DOM detached from the document, then attach all at once - https://phabricator.wikimedia.org/T126778#2023089 (10matmarex) [17:42:37] (03PS6) 10TheDJ: Add parser tests for TMH output [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/262926 (https://phabricator.wikimedia.org/T126723) [17:42:38] 6Multimedia, 10UploadWizard: UWDetails objects are being constructed from scratch twice for each uploads: once when stashes, once when moving to Details step - https://phabricator.wikimedia.org/T126780#2023088 (10matmarex) [17:42:40] 6Multimedia, 10UploadWizard: Only load thumbnails of files visible on-screen in "Upload" step - https://phabricator.wikimedia.org/T126777#2023090 (10matmarex) [17:42:42] 6Multimedia, 10UploadWizard, 7Performance: UploadWizard UI performance abysmal when adding many files to upload at once - https://phabricator.wikimedia.org/T121901#2023087 (10matmarex) [17:42:56] Be louder MatmaRex [17:43:05] i'm just getting started [17:43:27] i've written down a dozen tasks and i'm now just copying and pasting, mostly [17:51:54] MatmaRex: Tsk. :-) [17:52:09] MatmaRex: How dare you be on top of things?! ;-) [17:52:11] 6Multimedia, 10OOjs-UI, 10UploadWizard: OOjs UI performance issues affecting UploadWizard - https://phabricator.wikimedia.org/T126787#2023167 (10matmarex) 3NEW a:3matmarex [17:52:31] Oh oh oh! [17:52:32] Bug! [17:52:43] 6Multimedia, 10OOjs-UI, 10UploadWizard: OOjs UI performance issues affecting UploadWizard - https://phabricator.wikimedia.org/T126787#2023177 (10matmarex) [17:52:46] Oh gosh [17:52:56] In UW the "copy details" thing won't do it for the deed step. [17:52:59] Is this intentional, unintentional but known, or unknown? [17:53:07] James_F: Intentional. [17:53:19] 6Multimedia, 10OOjs-UI, 10UploadWizard: OOjs UI performance issues affecting UploadWizard - https://phabricator.wikimedia.org/T126787#2023183 (10matmarex) [17:53:21] James_F: If you want to copy the license to the other uploads, you should have done that in the deed step [17:53:47] MarkTraceur: Not possible if you can't use the deed step because it's a custom special licence. [17:53:55] Uhhh [17:53:56] Christ. [17:54:07] Or at least, that's what it appeared to me. [17:54:22] I was doing it last night in a rush and I might have been wrong, and it was the edgiest of edge cases. [17:54:23] James_F: Wait, so how do you enter the license exactly? [17:54:43] MarkTraceur: Deed > Not me > Other > This wikitext. [17:54:55] + Source and Author. [17:55:46] I was creating https://commons.wikimedia.org/wiki/Category:Notifications_icons and so each of them has a custom 'derived from' licence (plus {{wikimedia trademark}}). [17:55:46] Fun times. [17:56:52] James_F: Why can't you do that on the deed step? Oh, because each is different? [17:57:04] Hmm [17:57:05] Yeah. [17:57:16] I think that's too edge case even for UW [17:57:16] 6Multimedia, 10UploadWizard, 7Performance: UploadWizard UI performance abysmal when adding many files to upload at once - https://phabricator.wikimedia.org/T121901#2023203 (10matmarex) [17:57:22] So I need to have the start of a shared value, and then over-ride it for each. [17:57:24] As I said, edge case. [17:57:27] * James_F nods [17:57:31] We found the line, guys [17:57:57] Woohoo. [18:00:00] ok, so https://phabricator.wikimedia.org/T121901 is going to be my next week. ;) [18:00:21] and i'm gone for today. see you folks~ [18:15:16] MatmaRex: nice investigation work on that one btw. [18:26:21] :o :D [20:34:57] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset, 5Patch-For-Review: Convert GWToolset to use extension registration - https://phabricator.wikimedia.org/T87928#2023994 (10JeanFred) 5Open>3Resolved Done :) [21:06:15] Damn it [21:06:23] Deploying things to labs shouldn't be difficult [21:06:38] I'm like 90% of the way to giving up, and just deploying it all by hand [21:08:36] :-( [21:09:09] James_F: I really hate puppet [21:09:27] MarkTraceur: Aye. [21:11:35] OK no fuck it this has been delayed long enough [22:06:22] Uhhh [22:06:30] OK that's a weird error [22:07:18] No, it's not [22:11:06] OK, I have the editor up, but the files don't save. [22:11:14] I'm going to run home and try to finish this bad boy [22:32:41] Argh no dice, I'm getting called away a bit early. First thing on Tuesday it'll go up. [23:57:13] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset, 7Beta-Cluster-reproducible: GWToolset causes fatal error on beta cluster - https://phabricator.wikimedia.org/T126830#2024609 (10hashar) 3NEW