[00:07:24] I am definitely not feeling well. I am going back to sleep. [01:23:03] 6Multimedia, 10MediaWiki-Special-pages: Implement 'newbies' mode for Special:NewFiles - https://phabricator.wikimedia.org/T122354#2010485 (10matmarex) [01:23:08] 6Multimedia, 6Commons, 10MediaWiki-Recent-changes, 15User-Josve05a: Allow filtering based on tag on Special:NewFIles - https://phabricator.wikimedia.org/T124214#2010487 (10matmarex) [01:23:43] 6Multimedia, 6Commons, 10MediaWiki-Recent-changes, 15User-Josve05a: Allow filtering based on tag on Special:NewFIles - https://phabricator.wikimedia.org/T124214#1949315 (10matmarex) [01:23:45] 6Multimedia, 10MediaWiki-Special-pages: Implement 'newbies' mode for Special:NewFiles - https://phabricator.wikimedia.org/T122354#1902125 (10matmarex) [03:29:12] 6Multimedia, 10ArchCom-RfC, 6Commons, 10MediaWiki-File-management, and 9 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#2010660 (10RobLa-WMF) @GWicke: how would you like to move forward on this? This seems like a natural candidat... [10:40:48] 6Multimedia, 10UploadWizard, 10Wikimedia-General-or-Unknown: Cannot upload large JPG file with Upload Wizard: "The upload succeeded, but the server could not get a preview thumbnail." - https://phabricator.wikimedia.org/T126293#2011015 (10Aklapper) [10:41:20] 6Multimedia, 10UploadWizard, 10Wikimedia-General-or-Unknown: Cannot upload 12MB JPG file with Upload Wizard: "The upload succeeded, but the server could not get a preview thumbnail." - https://phabricator.wikimedia.org/T126293#2011019 (10Aklapper) [12:04:45] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset, 5Patch-For-Review, 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): Run JShint on GWToolset - https://phabricator.wikimedia.org/T125573#2011131 (10JeanFred) 5Open>3Resolved [14:45:08] James_F|Away: FYI https://phabricator.wikimedia.org/T111718#2010949 I'll probably spend some time working on a Thumbor extension or five. [14:45:23] It'll be better than trying to rewrite the useless MediaDevilry thing [15:33:58] gilles: On that note, do you know if there is documentation on how to create Thumbor plugins? I only see documentation of existing plugins currently. [16:04:26] * MarkTraceur wanders through our existing plugins repository [16:05:53] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10TimedMediaHandler, and 3 others: Improve interface for MediaHandlers to add JavaScript - https://phabricator.wikimedia.org/T60478#2011674 (10phuedx) [16:24:01] MarkTraceur: Cool. [16:39:48] Having some trouble getting this to work, sadly [16:52:04] I blame shooting stars. [17:07:10] Grr headache persists [17:07:15] I thought it was better last night [17:08:16] I might have to disappear for a few hours to try and recover. We'll see. [17:58:38] today has accidentally turned out to be a SQL optimization day for me. [18:15:12] MatmaRex: Sorry to hear that. [19:29:40] 6Multimedia, 10UploadWizard: New language dropdown at Special:UploadWizard makes selection very tedious - https://phabricator.wikimedia.org/T121971#2012261 (10Jdforrester-WMF) [20:36:11] MarkTraceur: not that I know of, I just figured it out by looking at existing ones [20:37:11] you can look at mine, I've made some of every possible kind (app extension, handler, filter, optimizer, loader, storage) https://phabricator.wikimedia.org/diffusion/THMBREXT/browse/master/wikimedia_thumbor/ [20:37:38] in fact it's probably a good idea for you to write them on that same repo [20:44:57] gilles: Yeah, that's what I've been doing [20:45:06] I tried writing a filter one but it doesn't seem to be working [20:46:04] have you installed it to your python environment and added its class name to the thumbor config? [20:46:15] Yeah [20:46:53] gilles: I did python setup.py and added FILTERS = [ 'wikimedia_thumbor.filters.flip' ] to the thumbor.conf, then passed thumbor.conf into the server with -c [20:47:48] add -l debug if you aren't running it in debug mode [20:47:57] Er, not filters, filter. OK, checking. [20:48:02] if it can't find the class it should yell [20:48:35] we can do a quick call if you want, I might be more helpful if you share your screen [20:48:53] It found the class I guess [20:48:56] Uhhh, sec [20:56:23] gilles: Can I push to the Phabricator repository, or what's the magic there [20:57:03] arc diff? then when your patch is accepted we'll see if you can arc land [20:58:20] Fun times [20:58:50] if you're in the Repository-Admins group you can push, otherwise I can make a special policy that includes you. but I'm not sure that arc-landing an accepted patch requires that right [20:59:18] I guess we should try first without changing the policy to see what the volunteer experience would be [21:05:52] gilles: Well, submitted I think [21:05:59] https://phabricator.wikimedia.org/D118 [21:06:01] yeah, I've left a small concern [21:06:10] Ah, cool [21:06:52] gilles: I don't amend, right, because Phabricator isn't stupid [21:06:53] usually I tick the "done" box, send the updated commit with arc diff and then submit the "comment" and phabricator figures out that my update is what fixed the concern [21:07:00] it's up to you [21:07:06] it can be multiple commits or not, doesn't matter [21:07:41] I usually merge them with rebase when it's tiny changes like that, keep the history cleaner when the commit are eventually pushed [21:08:05] but it's totally cool to have multi-commit diffs, arc doesn't care [21:08:34] "rTHMBREXT" what happened to four-letter callsigns? :( [21:08:38] it will automatically add new ones on a branch already sent through arc, afaik. you need to pass an extra parameter if you want the newer commit to be a diff of its own [21:09:18] MatmaRex: I didn't get that memo, last I heard of callsigns we weren't going to rely on them. but you need to set one anyway [21:11:02] I don't care either way, we can change it, but I don't think I can do that from the phab UI [21:11:20] short of starting a new repo and starting over, I guess [21:12:34] MarkTraceur: it's accepted, what does "arc land" give you now? [21:13:54] if it doesn't work I guess landing might be my job as reviewer with the equivalent of +2 rights. I guess that part of the workflow is still for us to figure out [21:13:57] Let's see! [21:14:16] No, it says I don't have the right access rights [21:14:34] ok, I'll give you them. with people who reviewed my stuff if felt nicer to be able to land myself [21:16:23] set this up the "wiki way", join the Thumbor project and that'll let you arc land there [21:16:24] https://phabricator.wikimedia.org/project/members/1672/ [21:16:39] KK [21:16:52] Neat~! [21:16:57] OK, off to fly [21:39:31] OK, this looks like it's pretty much set for my purposes I think [21:39:43] Turns out you can duplicate filters as much as you want [21:39:44] do filters work in order? [21:39:49] I believe so [21:39:52] cool [21:40:02] I might do the POST thing later, but I doubt I'll need it [21:40:27] don't you need a crop filter too? [21:40:30] I will need to do some conversion because thumbor expects (left, top, right, bottom) instead of (top, left, width, height) [21:40:37] gilles: Submitted as https://phabricator.wikimedia.org/D119 [21:40:41] ah, cool [21:40:49] So I can start working on stuff locally at least [21:41:08] Hopefully it makes sense to deploy Thumbor and ImageTweaks at or around the same time [21:43:59] is thumbor giving you the image back all you need? or will you also need thumbor to "save" the result to swift or whatever? [21:44:22] Well, it'll get saved, but the API can do that [21:44:36] I have a magic UploadFromHTTPRequest class (or something) that will do the work [21:44:55] sounds better to keep thumbor dumb in that respect, yeah [21:44:56] And it needs to be saved as a File: not a thumbnail, for this [21:45:02] yep [21:45:24] so imho it sounds like you should have your own thumbor instance(s), configured differently [21:45:47] because the thumbnail instances will have to store things in swift, etc. at first [21:46:09] Probably [21:46:18] they can run on the same physical machines, but I think it would be cleaner to do have the same instances do those very different tasks [21:46:21] And yeah, one instance would probably do it to start, this is going to be a betafeature [21:46:37] Plus that way we only need the crop/flip plugins on that instance [21:46:45] *to not have [21:46:53] yeah, exactly [21:47:01] the config for thumbnails is huge [21:48:03] what you need is actually way simpler to deploy on labs/prod [21:48:26] stock thumbor, those two tiny plugins and off you go [21:49:44] you can add those two new filters to the vagrant thumbor role, btw [21:49:49] Neat. [21:49:58] I don't use Vagrant so it doesn't matter to me [22:14:12] Looks like the API works. Now to get ImageTweaks to use it... [22:28:25] Woot, OK, I have enough for a demo on labs [22:28:39] So that'll happen tomorrow. [22:28:47] * MarkTraceur makes sure James_F|Away and prtksxna see that [22:54:10] MarkTraceur: But did you? [22:55:22] James_F: Yup [22:58:23] MarkTraceur: But *did* you? [23:04:42] No. [23:09:47] * James_F grins. [23:21:51] prtksxna: One thing I'll need is an OOUI popup to give the image a new title, I guess. I'm faking it for now. [23:22:07] I'll polish up the rest of this patch and upload it tomorrow so you can work on it [23:46:27] Meh [23:46:37] MarkTraceur: I have a clashing meeting now. [23:46:53] James_F: So it'll be me, lindseyanne, and MatmaRex? [23:47:09] Maybe. [23:47:32] Well gosh. [23:47:42] We might actually get something out of the meeting this time. [23:48:01] :-P