[01:11:28] 6Multimedia, 10MediaWiki-Change-tagging, 10MediaWiki-Uploading: Tagging file uploads with change tags is difficult bordering on impossible - https://phabricator.wikimedia.org/T121874#1907571 (10matmarex) [04:03:45] OH-: I'm using Brackets now, it's already got JSHint in it. Lots of conventions not followed. [04:04:38] Yes, there is a file called .jshintrc that lists the rules that we despise and hate with all our soul and wish not to follow [04:04:45] (among other things) [04:04:55] Not sure if your IDE detected it [04:05:05] It did. 51 errors [04:05:26] Here's an example: [04:05:27] Unexpected space between '(' and 'info'. EFFP.getCaption = function ( info ) { [04:06:12] Waidaminut... [04:06:21] Sorry my bad, it did not [05:26:40] (03PS7) 10JadeMaveric: Remove uploader's name from MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) [05:32:57] (03CR) 10JadeMaveric: "Fixed!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [05:33:34] (03CR) 10JadeMaveric: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [05:35:06] (03CR) 10JadeMaveric: "It's that supposed to make jenkins check stuff?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [05:35:18] (03CR) 10JadeMaveric: "*isn't" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [06:37:10] (03CR) 10JadeMaveric: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [09:24:18] (03CR) 10JadeMaveric: "hmmm... isn't that how it's done?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [16:51:15] (03CR) 10Gergő Tisza: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [16:54:36] (03CR) 10Gergő Tisza: "The problem with recheck (or running tests in general) is that it means running untrusted (unreviewed) code on the continuous integration " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [17:15:31] (03CR) 10Gergő Tisza: [C: 032] "The tests work for me locally, and apparently for Jenkins as well." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [17:18:15] (03Merged) 10jenkins-bot: Remove uploader's name from MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [17:45:33] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7JavaScript, and 2 others: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool (A/B test of different upload interfaces) - https://phabricator.wikimedia.org/T120867#1908354 (10matmarex) Alright, I disabled the test for now. All... [19:19:34] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/261420 [19:32:57] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/261463 [19:41:55] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/261486 [19:48:22] (03CR) 10Addshore: [C: 032] build: Updating development dependencies [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/261463 (owner: 10Legoktm) [19:49:02] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/261508 [19:51:01] (03CR) 10Addshore: [C: 032] build: Updating development dependencies [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/261420 (owner: 10Legoktm) [19:56:38] (03CR) 10Addshore: [C: 032] build: Updating development dependencies [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/261486 (owner: 10Legoktm) [19:59:05] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261537 [19:59:32] (03CR) 10Paladox: [C: 031] build: Updating development dependencies [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261537 (owner: 10Legoktm) [20:03:11] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/261548 [20:14:44] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/261463 (owner: 10Legoktm) [20:17:16] (03CR) 10Addshore: [C: 032] build: Updating development dependencies [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/261508 (owner: 10Legoktm) [20:28:34] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/261420 (owner: 10Legoktm) [20:34:12] (03CR) 10Addshore: [C: 032] build: Updating development dependencies [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261537 (owner: 10Legoktm) [20:34:48] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/261486 (owner: 10Legoktm) [20:39:09] (03CR) 10Addshore: [C: 032] build: Updating development dependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/261548 (owner: 10Legoktm) [20:47:04] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/261508 (owner: 10Legoktm) [21:07:59] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261537 (owner: 10Legoktm) [21:14:34] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/261548 (owner: 10Legoktm) [21:22:35] 6Multimedia, 6Commons, 10MediaWiki-File-management, 7Tracking: GIF Issues (tracking) - https://phabricator.wikimedia.org/T18456#1908885 (10BGerstle-WMF)