[00:04:15] (03PS1) 10Jdlrobson: Add integration tests to each commit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260881 [00:06:43] (03CR) 10jenkins-bot: [V: 04-1] Add integration tests to each commit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260881 (owner: 10Jdlrobson) [00:11:51] (03PS2) 10Jdlrobson: Add integration tests to each commit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260881 (https://phabricator.wikimedia.org/T113620) [00:15:35] (03CR) 10jenkins-bot: [V: 04-1] Add integration tests to each commit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260881 (https://phabricator.wikimedia.org/T113620) (owner: 10Jdlrobson) [00:18:33] (03PS3) 10Jdlrobson: Add integration tests to each commit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260881 (https://phabricator.wikimedia.org/T113620) [00:20:38] (03CR) 10jenkins-bot: [V: 04-1] Add integration tests to each commit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260881 (https://phabricator.wikimedia.org/T113620) (owner: 10Jdlrobson) [00:44:41] (03PS4) 10Jdlrobson: Add integration tests to each commit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260881 (https://phabricator.wikimedia.org/T113620) [00:55:32] (03CR) 10jenkins-bot: [V: 04-1] Add integration tests to each commit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260881 (https://phabricator.wikimedia.org/T113620) (owner: 10Jdlrobson) [01:29:36] (03PS1) 10Neonowy: Use OO.ui.confirm() for the confirmation dialog in ext.tmh.transcodetable [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260892 (https://phabricator.wikimedia.org/T117078) [01:30:37] (03PS1) 10Bartosz Dziewoński: uw.controller.Details: Correct indentation, avoid Function#bind when not needed, tweak comments [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/260893 [02:32:31] o/ [03:51:08] Does userInfo stand for the uploader info or any user's info? (in mmv.js) [03:52:22] the uploader [03:52:48] Thanks. Then how is the author accessed? [03:59:13] the author cannot be linked to a user account [04:00:10] it might be a name of a famous 17th century painter, a flickr username, whatever [04:00:30] But what if (s)he has a wiki account [04:03:26] we don't care [04:04:08] Couldn't we have a system where we could link to the artist relevant wiki page. If he is that famouse [04:04:10] https://gerrit.wikimedia.org/r/#/c/260221/ was an attempt to handle the special case where the author is the uploader, but even that turned out to be more trouble than it was worth [04:04:12] *famous [04:05:18] we could, it's https://commons.wikimedia.org/wiki/Commons:Structured_data [04:05:27] maybe by next GCI it will be up :) [04:06:22] currently, the author property is a HTML string [04:06:45] which might be a link to a Wikipedia article, or a Commons user page [04:07:16] but it would be very hard for the software to find out whether it really is [04:08:43] makes sense. How would you get the software to automatically find out which person we're talking about? [04:08:55] eg: If i said - King Henry of England [04:09:53] My guess is you'd have to check other references in the image disc. and try to find links from there [04:12:37] if I remove a script from extensions.json, am I practically disabling it? [04:17:32] JadeMaveric: I wouldn't, that's my point :) [04:18:22] Which question are you referring to? The first one? (That's what I'm gonna assume) [04:18:31] yes [04:18:43] natural language processing is hard [04:19:00] wikis tend to rely on manual labor instead [04:19:06] I'm trying to understand it, it's hard, but it's also exciting [04:19:50] ie. have same way by which editors can tell, who the author is, in some machine-identifiable way, and then leave it to the editors to fill out that data [04:20:09] that's the structured data project but it's rather far away [04:20:34] check out https://www.wikidata.org/ if you want to get an idea of it [04:22:38] https://commons.wikimedia.org/wiki/Template:Author identifies the author with a wikidata link so that machines can reason about it [04:22:54] but today it's only used on a fraction of the images [04:23:42] for your other question, yes [04:28:43] https://www.mediawiki.org/wiki/Manual:$wgResourceModules and https://www.mediawiki.org/wiki/Manual:Extension_registration#Attributes is the relevant documentation, although I don't think you need any of it for your task [04:29:03] and we tend to be pretty bad at writing beginner-friendly documentation :( [04:29:38] I managed to get the uploaderName to disappear. Now I'm working on stopping the data from being accessed in the first place [04:50:44] what does i18n/qqq.json do? [04:51:16] (03PS1) 10PranavK: Make "Upload anyway" link a OOjs UI button [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/260900 (https://phabricator.wikimedia.org/T114221) [04:51:20] That file is documentation for each message [04:51:43] (03CR) 10jenkins-bot: [V: 04-1] Make "Upload anyway" link a OOjs UI button [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/260900 (https://phabricator.wikimedia.org/T114221) (owner: 10PranavK) [04:51:44] The good folks at translatewiki.net translate the messages from English to other languages [04:51:55] qqq.json tells them what the message is and what parameters it takes [04:52:13] I thought that was en.json [04:52:52] en.json is the English message that is displayed [04:53:02] qqq.json is an English-language description of what the message is [04:53:11] for example, say you have a Save button that has the message "Save" [04:53:26] So en is displayed. qqq is for the translators (not displayed to end user) [04:53:29] If you gave that to a translator, it would be confusing because they don't know the context [04:53:47] but qqq would be something like "Text displayed on save button" which is much better [04:53:50] Yes [04:54:40] (03PS2) 10PranavK: Make "Upload anyway" link a OOjs UI button [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/260900 (https://phabricator.wikimedia.org/T114221) [04:55:15] OH-: makes sense. Cool chemical formula, very misleading [04:55:30] :) [04:57:20] tgr: Is there any plan to use the 'user' APIs in MultiViewer. Or should I remove them completely, now that I've removed the uploader's name [04:57:36] How come uploader is not part of the dictionary [04:57:53] it's not used for anything else [04:58:05] No plans to use it either [04:58:10] in the future [04:58:22] no, good riddance :) [04:58:47] it was only used to show the uploader message in a gender-correct way [04:59:08] which is not actually needed by most languages so the code ended up rather complex [04:59:44] okay, then I'll disable/remove scripts like mmv.ui.reuse.embed [05:00:27] are you sure that's the right script? [05:02:48] hmm... what function does mediawiki.user perform? It's listed as a dependency [05:04:28] it's a collection of a bunch of different things [05:04:43] no idea which one it is used for [05:04:52] you can just grep for it [05:05:05] we tend to alias mediawiki as mw [05:14:34] I disabled that script. nothing bad has happened. But the test image I'm using doesn't have any artist info. [05:35:13] JadeMaveric: "nothiung bad hs happened" is not the most reliable method ever :) [05:35:57] you said InstantCommons was not working, right? [05:36:15] Gotcha ;), undid that it apparently it affects if there are multiple images [05:36:20] yes, it's not working [05:36:39] that would be the easy way of testing images with complex metadata [05:36:49] let me look into that [06:07:46] Is this a problem? : [06:08:16] My vagrant server shows 'Uploaded: ' [06:08:45] The wiki server shows 'Created: ' [06:09:37] Other than that, everything's the same. The console is clean, no *visible* errors. [06:09:52] I still wish I had something proper to test on [06:15:02] that's probably not an error [06:15:17] testing with local files is complicated [06:16:04] I can help you set it up if it comes to that, but testing with Commons files would be easier [06:18:34] I need to take a break. I'll comeback in about 30 min [12:27:52] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7JavaScript, 7Voice & Tone: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool (A/B test of different upload interfaces) - https://phabricator.wikimedia.org/T120867#1903246 (10Pginer-WMF) Thanks for sharing the preliminary r... [13:39:21] 6Multimedia, 6Commons, 10MediaWiki-File-management: Allow CSV file downloads - https://phabricator.wikimedia.org/T122358#1903332 (10Aklapper) [13:53:20] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: "HTTP request timed out" for large files - https://phabricator.wikimedia.org/T86024#1903348 (10Aklapper) p:5Unbreak!>3High > Because of that bug we have GLAM partners stuck in their upload processes. More information welcome. [14:02:21] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: "HTTP request timed out" for large files - https://phabricator.wikimedia.org/T86024#1903374 (10Kelson) >>! In T86024#1903348, @Aklapper wrote: >> Because of that bug we have GLAM partners stuck in their upload processes. > > More information welcome.... [14:18:06] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7JavaScript, 7Voice & Tone: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool (A/B test of different upload interfaces) - https://phabricator.wikimedia.org/T120867#1903378 (10Yann) Many users do not understand what "own" wo... [14:20:46] how can I access mw.user? It's listed as a dependency in extensions.json [14:44:03] (03CR) 10Jdlrobson: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260881 (https://phabricator.wikimedia.org/T113620) (owner: 10Jdlrobson) [15:12:21] (03PS5) 10Jdlrobson: Add integration tests to each commit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260881 (https://phabricator.wikimedia.org/T113620) [15:15:38] (03CR) 10jenkins-bot: [V: 04-1] Add integration tests to each commit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260881 (https://phabricator.wikimedia.org/T113620) (owner: 10Jdlrobson) [15:20:35] (03PS1) 10JadeMaveric: Remove uploader's name from MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) [15:21:11] (03CR) 10jenkins-bot: [V: 04-1] Remove uploader's name from MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [15:21:27] (03CR) 10Jdlrobson: "LocalSettings.php no longer seems to be applying.... weird" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260881 (https://phabricator.wikimedia.org/T113620) (owner: 10Jdlrobson) [15:21:35] (03CR) 10Jdlrobson: "check experimental" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260881 (https://phabricator.wikimedia.org/T113620) (owner: 10Jdlrobson) [16:20:07] (03PS1) 10Bartosz Dziewoński: mw.UploadWizardDetails: Correctly pass raw mw.Message, not escaped text [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/260933 [16:20:09] (03PS1) 10Bartosz Dziewoński: mw.GroupProgressBar: Remove unused parameter [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/260934 [16:20:11] (03PS1) 10Bartosz Dziewoński: Avoid double-escaping [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/260935 [16:23:51] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Thanks for working on this! It's a pity you haven't tested this change, some of the problems I'm pointing out would be obvious." (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/260900 (https://phabricator.wikimedia.org/T114221) (owner: 10PranavK) [16:27:08] 6Multimedia, 10UploadWizard, 7Easy, 3Google-Code-In-2015, 7Technical-Debt: Use OO.ui.alert() for the assorted error message dialogs in UploadWizard - https://phabricator.wikimedia.org/T117079#1903525 (10Sn1per) a:3Sn1per [16:38:46] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Thanks for working on this! I left some comments inline (click the filename "resources/ext.tmh.transcodetable.js" to view them). I probabl" (033 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260892 (https://phabricator.wikimedia.org/T117078) (owner: 10Neonowy) [16:50:10] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10Structured-Multimedia-Data, 10Wikidata: Provide a way to curate and fetch titles (short descriptions) for media files - https://phabricator.wikimedia.org/T122381#1903535 (10matmarex) I think the word you're looking for is "caption". :) [16:50:20] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10Structured-Multimedia-Data, 10Wikidata: Provide a way to curate and fetch titles (short descriptions) for media files - https://phabricator.wikimedia.org/T122381#1903537 (10matmarex) [17:18:03] 6Multimedia, 10MediaWiki-General-or-Unknown, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review: Show determinate progress bar for the image upload in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115861#1903543 (10Pginer-WMF) > The bar not being labelled. I... [18:08:32] OH-: My patch failed the jshint test. What am I supposed to do? https://gerrit.wikimedia.org/r/260931 [18:09:03] So, click on 'jshint' [18:09:08] and go to Console Output [18:09:13] find where there are errors and fix them [18:09:30] You can also run the tests on your own machine to save time [18:10:39] Did that, console output makes no sense. [18:10:47] wait, check that. I found something [18:11:26] You found it? "15:21:09 resources/mmv/mmv.js: line 689, col 13, 'viewer' is defined but never used." [18:11:36] Yes. [18:11:55] I've got to start up vagrant to commit. Oh, Merry Christmas btw [18:12:07] You too. Vagrant isn't required to commit [18:12:18] the files should be stored on your local machine and "shared" to the VM [18:12:35] I know, but Niharika told me that could mess up my vm [18:12:49] Also, I highly recommend installing jshint on your machine so you can run the tests at home, which is a lot faster than waiting for Zuul/jenkins [18:13:08] Do you have node.js installed on your machine? [18:13:27] http://jshint.com/install/ [18:14:10] No, I've only just learnt JavaScript. The basics from Codecademy and ProcessingJS from KhanAcademy [18:14:30] So I'm not sure where node and jshint fit in. I know what they are though [18:15:03] jshint checks code to make sure it is styled right [18:15:20] node.js is software that runs javascript code as a program, to oversimplify it [18:15:41] rather than, say, in a browser [18:15:49] So I can develop my own applications. [18:16:01] Well, in this case you aren't using node.js to develop your own apps [18:16:09] jshint is built on node.js and requires it to run [18:16:28] jshint makes sure code looks nice so it is easier for the next person down the road to modify. [18:18:29] (03PS2) 10JadeMaveric: Remove uploader's name from MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) [18:19:00] (03CR) 10jenkins-bot: [V: 04-1] Remove uploader's name from MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [18:24:37] (03PS3) 10JadeMaveric: Remove uploader's name from MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) [18:25:03] (03CR) 10jenkins-bot: [V: 04-1] Remove uploader's name from MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [18:26:40] I think you may have gone a little too far with removing 'viewer' :P [18:26:52] I know. :| [18:27:18] You only have to remove it from functions where it isn't used [18:27:41] * JadeMaveric yawns [18:27:44] Go back to Patch 1 [18:27:55] git review -d 260931,1 [18:34:23] you ther? [18:44:28] ping JadeMaveric, what's your time zone? [18:57:58] +5:30 [18:58:05] Sorry, my mom wanted to use the PC [18:58:24] ah, no problem. Thought you went to bed [18:58:37] Can you run the git review command above? [18:58:41] It's christmas, (I'm waiting for Santa :p) [18:58:57] yes, I cna [18:59:00] *can [18:59:21] what does the 260931,1 stand for? [18:59:34] On your Gerrit patch: https://gerrit.wikimedia.org/r/#/c/260931/ [18:59:40] The number at the end of the URL is the ID [18:59:59] You want to re-download your first Patch set [19:00:03] and the ',' stands for patch number [19:00:07] yes [19:00:41] So just 260931 would be more most recent? [19:00:49] or the first? [19:01:42] 260931 is your patch ID. it doesn't change unless you upload a different patch [19:01:49] Patch set 1 is the first patch set [19:02:08] You removed too many 'viewer's starting in Patch 2, so you should start back from Patch 1 [19:03:01] I got an error on that git review: [19:03:16] The following command failed with exit code 1 "git checkout -b review/jademaveric/T59308-patch1 FETCH_HEAD" [19:03:35] Can you paste the full log? [19:04:27] Enter passphrase for key '/home/vagrant/.ssh/id_rsa': [19:04:52] Downloading refs/changes/31/260931/1 from gerrit [19:04:53] Enter passphrase for key '/home/vagrant/.ssh/id_rsa': [19:05:00] Traceback (most recent call last): [19:05:06] File "/usr/local/bin/git-review", line 11, in [19:05:11] In a pastebin please so you don't overload the IRC server [19:05:25] kk, It's very small though [19:05:59] http://ur1.ca/ocxco [19:06:26] Try 'git stash' and then run the git review command [19:06:36] git review wants to download your old patchset and make it a new branch [19:06:55] what does stash do? [19:06:59] but you have local changes in mmv.js that haven't been committed (you probably don't need them since you're starting over from Patch 1) [19:07:03] save the changes? [19:07:11] so git stash temporarily "hides" the changes so you can switch branchse [19:07:21] you can always get them back (in this case we probably don't but just in case) [19:08:03] I've got to get more familiar with git [19:10:22] After this is done, I'm going to try to get the license to scroll in smoothly. [19:10:44] Currently it just 'jumps' back to the right [19:14:29] (03PS4) 10JadeMaveric: Remove uploader's name from MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) [19:15:20] OH-: Yay, it worked. Thanks. [19:15:25] Cheers [19:15:48] But how did the previous guy (or girl) manage to get it reviewed? [19:16:09] I never touched the viewer variables, they were already there [19:17:08] Because In MMVP.fetchSizeIndependentLightboxInfo (mmv.js), you remove the _use_ of viewer, but you left the declaration of viewer intact [19:17:23] Thus, viewer was declared but not used (effectively useless) [19:17:30] This is a Bad Thing (tm) [19:17:59] Before your patch, viewer was declared and used, so jshint did not complain [19:18:23] kk. I beginning to like JShint [19:18:28] *I'm [19:19:02] Can I add more reviewers? [19:19:07] Again, I highly recommend installing JSHint locally [19:19:16] You should probably add your task mentor as a reviewer [19:19:28] I will, both [19:20:17] How do I do the 2nd one? [19:20:52] Under the list of Reviewers, put in their name in the (Name or Email or Group) box [19:20:56] and their email should pop up [19:21:08] then you select them and they should be added [19:21:50] Oh, I didn't see that -- wasn't logged in [19:22:13] Can I add you? [19:22:37] I'm not actually a mentor :P [19:22:59] (psst legend has it I'm actually a student but shhh) [19:23:27] This *is* being logged you know. [19:23:34] Anyway, nighty night [19:27:13] I know, it was a joke [20:28:01] For https://phabricator.wikimedia.org/T117079, what if I kept mw.ErrorDialog, but reimplemented it around OO.ui.alert()? [20:28:21] mw.ErrorDialog seems to have a lot of "default" settings that would have to go into each use if it were completely replaced by OO.ui.alert [21:27:28] (03PS1) 10Sn1per: Refactor mw.ErrorDialog to use OO.ui.alert() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/260945 (https://phabricator.wikimedia.org/T117079) [23:04:34] (03CR) 10Gergő Tisza: "Very nice!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [23:04:48] (03CR) 10Gergő Tisza: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [23:07:27] (03CR) 10jenkins-bot: [V: 04-1] Remove uploader's name from MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260931 (https://phabricator.wikimedia.org/T59308) (owner: 10JadeMaveric) [23:31:25] (03CR) 10Aklapper: "PranavK: Please do set up a development environment (as already discussed in https://gerrit.wikimedia.org/r/#/c/259655/ ) in order to test" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/260900 (https://phabricator.wikimedia.org/T114221) (owner: 10PranavK)