[00:50:45] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 5MW-1.27-release-notes, and 2 others: Properly use language templates in cross-wiki upload - https://phabricator.wikimedia.org/T119691#1840085 (10matmarex) 5Open>3Resolved Fixed and deployed. [00:58:57] Morning o/ [01:09:42] "Morning", prtksxna. :-) [01:31:28] James_F: :) [01:48:41] 6Multimedia, 10MediaWiki-extensions-MwEmbedSupport, 7JavaScript, 5Patch-For-Review, and 2 others: "Uncaught TypeError: Cannot read property 'insertRule' of undefined" from MwEmbedSupport/Spinner.js - https://phabricator.wikimedia.org/T118792#1840285 (10Krinkle) p:5Triage>3Normal a:3TheDJ [04:58:16] James_F|Away: The # in the 
 tag in the oojs and oojs/ui README files is causing formatting issues on the npm docs page https://www.npmjs.com/package/oojs
[04:59:34] 	 James_F|Away: npmjs.com's mardown processor is broken, but maybe we can use an alternative syntax like ``` to avoid the problem?
[05:01:49] 	 James_F|Away: fwiw, it breaks on https://phabricator.wikimedia.org/diffusion/GOJU/ too
[09:20:02] 	 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer: MediaViewer intermittent image loading errors (2015 Oct-Dec) - https://phabricator.wikimedia.org/T115563#1840626 (10Nickispeaki) Thanks, Aklapper!
[10:34:32] 	 I really need to reclaim the C-m shortcut from Gerrit. I always end up submitting the comment, when all I want is a new line.
[11:01:01] 	 (03PS54) 10TheDJ: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) 
[11:03:12] 	 (03PS55) 10TheDJ: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) 
[11:05:57] 	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ)
[11:48:21] 	 6Multimedia, 10MediaWiki-General-or-Unknown, 7Design, 5Patch-For-Review: Show image thumbnail in both steps of mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115860#1841102 (10Pginer-WMF) >>! In T115860#1788142, @Prtksxna wrote: > For just the design of the `SelectFileWidget`...
[13:30:46] 	 6Multimedia, 10UploadWizard, 3DevRel-December-2015: Clean the code review queue of extensions/UploadWizard - https://phabricator.wikimedia.org/T119764#1841287 (10Aklapper) @matmarex, @Marktraceur: Would anybody be willing to take this and reduce this backlog? And if December is already too packed and too sho...
[14:43:18] 	 6Multimedia, 10Ops-Access-Requests, 6operations, 5Patch-For-Review: Give Bartosz access to stat1003 ("researchers" and "statistics-users") - https://phabricator.wikimedia.org/T119404#1841451 (10ArielGlenn) @Trevor, can you sign off please?
[15:03:42] 	 (03Abandoned) 10MarkTraceur: (bug 27995) Added support for screen width upto 800px [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61289 (https://bugzilla.wikimedia.org/27995) (owner: 10Rasel160)
[15:04:25] 	 6Multimedia, 10UploadWizard: UploadWizard: Layout should not overflow on 800px wide window - https://phabricator.wikimedia.org/T29995#1841480 (10MarkTraceur)
[15:05:25] 	 6Multimedia, 10UploadWizard: UploadWizard: Layout should not overflow on 800px wide window - https://phabricator.wikimedia.org/T29995#325947 (10MarkTraceur) I abandoned the patch for this, because it was so unmaintained for so long. In the future, this might mean a restructuring of the Wizard to have a more mo...
[15:08:10] 	 (03Abandoned) 10MarkTraceur: add support for more types of flickr URLs to upload wizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/54897 (owner: 10Rjain)
[15:09:31] 	 tgr|away: You were mentoring the OSM project in UploadWizard, right? Is there any chance that will get worked on again later, or is it OK if we nix it for now?
[15:10:04] 	 tgr|away: I just opened 7 tabs with patches that have been untouched since January of 2014
[15:10:11] 	 It's bringin' down our average
[15:10:24] 	 (and also people are starting to whine about it https://phabricator.wikimedia.org/T119764)
[15:11:53] 	 (03Abandoned) 10MarkTraceur: Add HTML5 drag and drop support [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/3808 (https://bugzilla.wikimedia.org/9133) (owner: 10Drecodeam)
[15:14:30] 	 6Multimedia, 10MediaWiki-Uploading, 5Patch-For-Review: Drag and drop uploading - https://phabricator.wikimedia.org/T11133#1841502 (10MarkTraceur) I'm not currently sure how I want to approach this particular bug.  The patch that I just abandoned was old, crusty, and frankly a little lackluster.  With the Upl...
[15:22:27] 	 6Multimedia, 10UploadWizard, 3DevRel-December-2015: Clean the code review queue of extensions/UploadWizard - https://phabricator.wikimedia.org/T119764#1841515 (10MarkTraceur) I'm working through the older patches now, I'm waiting on @Tgr's response to whether I can abandon the OSM patches, they're not going...
[15:23:06] 	 (03Abandoned) 10MarkTraceur: WIP move most of the upload step stuff into controller.Upload [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/154341 (owner: 10MarkTraceur)
[15:23:40] 	 (03Abandoned) 10MarkTraceur: Move duplicate error handling to the wizard class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/185237 (owner: 10MarkTraceur)
[15:23:58] 	 (03CR) 10MarkTraceur: "Sorry, 254913" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/185237 (owner: 10MarkTraceur)
[15:24:38] 	 (03Abandoned) 10MarkTraceur: Move setUploadFilled into the file step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/199749 (https://phabricator.wikimedia.org/T93888) (owner: 10MarkTraceur)
[15:25:02] 	 (03Abandoned) 10MarkTraceur: [WIP] Move upload handling to the step objects [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/199985 (https://phabricator.wikimedia.org/T93895) (owner: 10MarkTraceur)
[15:28:04] 	 6Multimedia, 10UploadWizard, 3DevRel-December-2015: Clean the code review queue of extensions/UploadWizard - https://phabricator.wikimedia.org/T119764#1841522 (10MarkTraceur)
[15:28:38] 	 6Multimedia, 10UploadWizard, 3DevRel-December-2015: Clean the code review queue of extensions/UploadWizard - https://phabricator.wikimedia.org/T119764#1835242 (10MarkTraceur) @MatmaRex I'm going to need you to review the more recent UW patches to finish the refactor that I started, whenever you get a chance
[15:30:33] 	 prtksxna: BRB, need pepsi
[15:37:44] 	 Hi MatmaRex, I called on you to help with the UW review queue
[15:38:03] 	 hello
[15:38:28] 	 yeah, i was going to respond on that task, but got distracted…
[16:10:40] 	 OK James_F
[16:11:06] 	 James_F: We have https://github.com/prtksxna/ImageEditor which is suitable-ish for inclusion in whatever website you want
[16:11:29] 	 Except for a few minor details like bugs remaining in the crop tool and no way to actually save the image. We're working on it.
[16:12:00] * James_F nods.
[16:12:04] 	 Hmm.
[16:12:07] 	 James_F: The question is, is it worth the (hopefully small) effort to make this a library, or should we insert MediaWiki's tentacles into it and avoid having to support Yet Another Community
[16:12:10] 	 "Bugs".
[16:12:24] 	 James_F: And assuming the answer is "yay library", where should it live, GitHub or Gerrit?
[16:12:33] 	 Do you mean the UI as a library, or the transformational code?
[16:12:39] 	 (Or the combo?)
[16:12:50] 	 James_F: This is just the UI, the transformations are mostly Caman's
[16:12:58] 	 I think the crop tool is ours
[16:13:19] 	 Or maybe it was flip.
[16:13:37] 	 Oh, I wouldn't bother making the UI a library, just have it as an extension.
[16:13:42] 	 Too much effort.
[16:13:55] 	 (Hooking into ResourceLoader as a library? Eww.)
[16:14:38] 	 K.
[16:14:42] 	 prtksxna: We have our answer!
[16:15:11] 	 James_F: I figured having a tool for editing images and getting a save-able image as a result might be a nice library for Someone, Somewhere, but whatever
[16:15:15] 	 Also, it should probably use OOUI icons for the interface where possible…
[16:15:37] 	 I haven't even delved into the code, we'll get to that
[16:15:55] 	 It's using OOUI, but the icons are local even for the undo/redo which we have in OOUI.
[16:15:59] 	 It looks nice. :-)
[16:16:02] 	 James_F: Yeah, it should. But I didn't have icons that matched it, so I changed all of them.
[16:16:06] 	 Will fix that
[16:16:15] 	 prtksxna: Fair.
[16:16:24] 	 Are we thinking of adding other controls?
[16:16:43] 	 James_F: Zoom
[16:16:49] 	 James_F: Nothing else for now https://www.mediawiki.org/wiki/Extension:ImageTweaks/UI
[16:17:02] 	 marktraceur: I guess  you can make the phab project now
[16:17:12] 	 prtksxna: Not lighten/darken?
[16:17:14] 	 prtksxna: I think all we need for zoom is to scale images that are too big down to the canvas size
[16:17:16] * James_F nods.
[16:17:23] 	 I don't think that needs to be a tool
[16:17:33] 	 James_F: Not yet. 
[16:17:37] 	 Filters would be nice but I'm not sure what Caman has or what Commons wants
[16:17:52] 	 Oh dear.
[16:17:54] 	 prtksxna: I thiiiink there's already an ImageTweaks project, let me check
[16:17:58] 	 Instagram filters for Commons?
[16:18:03] 	 Caman has filters. Pretty easy to make your own too.
[16:18:12] 	 Instragram?? NO! 
[16:18:14] 	 PONIES!
[16:18:21] 	 …and glitter
[16:18:42] 	 I was wrong, sigh
[16:18:43] 	 But for that we should probably use Fabric.js instead of Caman :P
[16:19:11] * James_F laughs, shudders.
[16:19:17] 	 marktraceur: crop is caman too. We only restore the canvas directly on undo.
[16:19:35] 	 How does it perform with large images?
[16:20:02] 	 James_F: That is my cue to head to bed.
[16:20:22] * James_F laughs.
[16:20:43] 	 James_F: I haven't tested it yet. Will let you know when I do. Can't test it till zoom in/out is done.
[16:20:51] 	 Cool.
[16:21:00] 	 (-, – )…zzZZ good night o/
[17:32:08] 	 marktraceur: later as in at some distant unspecified point in the future, yes
[17:32:29] 	 but feel free to abandon or -1 those patches if they are in the way
[17:32:41] 	 Not really in the way, but people are starting to talk.
[17:33:28] 	 (03Abandoned) 10MarkTraceur: Embedding Static Map to UploadWizard [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/141920 (https://bugzilla.wikimedia.org/56612) (owner: 10Inchikutty)
[17:33:39] 	 (03Abandoned) 10MarkTraceur: Embeds leaflet map based on OSM data to UploadWizard [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/141987 (https://bugzilla.wikimedia.org/56612) (owner: 10Inchikutty)
[17:33:46] 	 (03Abandoned) 10MarkTraceur: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/142301 (https://bugzilla.wikimedia.org/56612) (owner: 10Inchikutty)
[17:33:53] 	 (03Abandoned) 10MarkTraceur: Improves zoom; enables drag on map [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/144151 (owner: 10Inchikutty)
[17:33:59] 	 (03Abandoned) 10MarkTraceur: Adds OSM parameter to coordinate template [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/144324 (https://bugzilla.wikimedia.org/56612) (owner: 10Inchikutty)
[17:34:05] 	 (03Abandoned) 10MarkTraceur: [WIP]Add unit tests to mw.GeoMap.js and some fixes [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/155511 (https://bugzilla.wikimedia.org/56612) (owner: 10Inchikutty)
[17:34:14] 	 (03Abandoned) 10MarkTraceur: [WIP] Embedding Static Map to UploadWizard [extensions/UploadWizard] (osm3) - 10https://gerrit.wikimedia.org/r/184869 (https://phabricator.wikimedia.org/T58612) (owner: 10Inchikutty)
[17:34:22] 	 {{done}}
[18:20:22] 	 marktraceur: https://gerrit.wikimedia.org/r/#/c/141979/ too?
[18:23:17] 	 (03Abandoned) 10MarkTraceur: Adds leaflet scripts to UploadWizard [extensions/UploadWizard] (osm2) - 10https://gerrit.wikimedia.org/r/141979 (https://bugzilla.wikimedia.org/56612) (owner: 10Inchikutty)
[18:23:22] 	 My bad
[18:24:12] 	 marktraceur: Is https://gerrit.wikimedia.org/r/#/c/47837/ do-able?
[18:24:21] 	 marktraceur: It's a pretty simple patch…
[18:25:23] 	 Maybe.
[18:25:29] 	 I left it in anyway
[18:25:47] 	 I can blindly rebase it in terms of code, but I can't test it without bother.
[18:25:49] 	 Want me to try?
[18:26:11] 	 Do or do not, there is no try
[18:26:31] 	 If it rebases cleanly then it's probably fine
[18:26:33] 	 :-P
[18:26:37] 	 Not that I'm going to merge it
[18:26:39] 	 It'll be manual.
[18:26:40] 	 That would be crazy!
[18:26:45] 	 Oh, well
[18:26:52] 	 It edits UploadWizard.i18n.php
[18:26:56] 	 Which is the first clue. ;-)
[18:27:00] 	 Ah, yeah
[18:48:31] 	 6Multimedia, 10UploadWizard, 3DevRel-December-2015: Clean the code review queue of extensions/UploadWizard - https://phabricator.wikimedia.org/T119764#1842362 (10matmarex)
[18:52:42] 	 6Multimedia, 10UploadWizard, 3DevRel-December-2015: Clean the code review queue of extensions/UploadWizard - https://phabricator.wikimedia.org/T119764#1842381 (10matmarex) Most of the old changesets, now abandoned, are either part of @marktraceur's refactoring (and either are no longer applicable to current...
[18:53:54] 	 (03Abandoned) 10Bartosz Dziewoński: Add details to Composer file [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/254604 (https://phabricator.wikimedia.org/T119248) (owner: 10Samwilson)
[18:54:41] 	 6Multimedia, 10UploadWizard, 3DevRel-December-2015: Clean the code review queue of extensions/UploadWizard - https://phabricator.wikimedia.org/T119764#1842387 (10matmarex)
[18:55:08] 	 6Multimedia, 10UploadWizard, 3DevRel-December-2015: Clean the code review queue of extensions/UploadWizard - https://phabricator.wikimedia.org/T119764#1842389 (10MarkTraceur) p:5Triage>3High
[18:58:18] 	 prtksxna: OK, I weaseled some details out of Commons, we're using the {{derived from}} template for now
[18:58:23] 	 Pain in the ass but at least it works
[18:58:54] 	 So I should be set to integrate that library of yourn as soon as it has the necessary features
[19:04:38] 	 (03PS8) 10Jforrester: Add flickr templates to uploads from flickr. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/47837 (https://phabricator.wikimedia.org/T45408) (owner: 10Nischayn22)
[19:04:57] 	 6Multimedia, 6Commons, 10MediaWiki-File-management, 10Parsoid, and 4 others: Use content hash based image / thumb URLs - https://phabricator.wikimedia.org/T66214#1842421 (10Anomie)
[19:05:21] 	 (03CR) 10Jforrester: "PS8: Serious rebase. Not tested." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/47837 (https://phabricator.wikimedia.org/T45408) (owner: 10Nischayn22)
[19:06:16] 	 (03CR) 10jenkins-bot: [V: 04-1] Add flickr templates to uploads from flickr. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/47837 (https://phabricator.wikimedia.org/T45408) (owner: 10Nischayn22)
[19:10:32] 	 Fail
[19:11:15] 	 6Multimedia, 6Commons, 10MediaWiki-File-management, 10Parsoid, and 4 others: Use content hash based image / thumb URLs - https://phabricator.wikimedia.org/T66214#1842439 (10Anomie) This doesn't really **block** T89971, but if the sort of thing being discussed here happens then one of the more nebulous bits...
[19:11:26] 	 6Multimedia, 6Editing-Department, 10WikiEditor, 7I18n: "Select a file" and "No file is selected" are not translated in the Uploading dialog in the wikitext editor - https://phabricator.wikimedia.org/T119984#1842441 (10Jdforrester-WMF)
[19:16:24] 	 6Multimedia, 6Editing-Department, 10WikiEditor, 7I18n: "Select a file" and "No file is selected" are not translated in the Uploading dialog in the wikitext editor - https://phabricator.wikimedia.org/T119984#1842457 (10matmarex) OOjs UI code uses `OO.ui.msg()` to produce localised messages. Within MediaWiki...
[19:22:03] 	 6Multimedia, 6Editing-Department, 10WikiEditor, 7I18n: "Select a file" and "No file is selected" are not translated in the Uploading dialog in the wikitext editor - https://phabricator.wikimedia.org/T119984#1842507 (10Jdforrester-WMF)
[19:22:47] 	 Oh, oops.
[19:26:52] 	 (03PS9) 10Jforrester: Add flickr templates to uploads from flickr [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/47837 (https://phabricator.wikimedia.org/T45408) (owner: 10Nischayn22)
[19:27:04] 	 The qqq was terrible.
[19:27:08] 	 Now a bit improved.
[19:30:27] 	 (03PS56) 10TheDJ: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) 
[19:34:44] 	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ)
[19:41:16] 	 6Multimedia, 6Editing-Department, 10WikiEditor, 7I18n: "Select a file" and "No file is selected" are not translated in the Uploading dialog in the wikitext editor - https://phabricator.wikimedia.org/T119984#1842630 (10matmarex) This is neither a WikiEditor or a Multimedia problem. This is a VisualEditor pr...
[19:42:50] 	 MatmaRex: No, it's a problem in RL.
[19:42:58] 	 MatmaRex: Or rather, ResourcesOOUI.php.
[19:42:59] 	 James_F: no, it's not.
[19:43:06] 	 and neither that.
[19:43:14] 	 VE does the right thing.
[19:43:20] 	 MW's use of OOUI doesn't.
[19:43:22] 	 yes, because it has the right code.
[19:43:22] 	 That's the issue.
[19:43:28] 	 unlike mediawiki.
[19:43:30] 	 Indeed.
[19:43:33] 	 So MW needs fixing.
[19:43:38] 	 i've already debugged it.
[19:43:41] 	 I know.
[19:43:45] 	 I've already read it.
[19:43:46] 	 lib/ve/src/init/ve.init.Platform.js
[19:43:50] 	 OO.ui.msg = this.getMessage.bind( this );
[19:43:54] 	 Yup.
[19:43:55] 	 this is the line that makes it work
[19:44:14] 	 Needs to be live on all pages from ResourcesOOUI.php.
[19:44:39] 	 i mean, if you don't want me to clean up the VE code afterwards, that's fine by me…
[19:44:44] 	 I'd like that.
[19:44:57] 	 But the problem Amir is seeing is not in VE, it's in the WikiEditor.
[19:45:18] 	 but the root cause is not in WikiEditor.
[19:45:25] 	 Nor is it in VE.
[19:45:31] 	 you don't add a task to "Commons" project just because you're seeing it on Commons.
[19:45:34] 	 Err.
[19:45:42] 	 Actually, yes, that's exactly how that project is used.
[19:45:46] 	 But that's a poor example.
[19:45:49] 	 heh.
[19:45:56] 	 well, its description says not to ues it like that. :P
[21:09:40] 	 6Multimedia, 10MediaWiki-General-or-Unknown, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Show determinate progress bar for the image upload in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115861#1842879 (10Volker_E) I'm with @Pginer-WMF on the position and size of the p...
[23:21:17] 	 (03PS57) 10TheDJ: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) 
[23:23:59] 	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ)
[23:28:21] 	 (03CR) 10Bartosz Dziewoński: [C: 04-1] Create arrow steps in JavaScript (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255418 (https://phabricator.wikimedia.org/T96918) (owner: 10MarkTraceur)
[23:36:43] 	 (03PS58) 10TheDJ: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) 
[23:38:48] 	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ)
[23:48:08] 	 (03PS59) 10TheDJ: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) 
[23:51:00] 	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ)
[23:56:09] 	 Morning o/