[00:50:00] marktraceur: I just realized that we'll have to do zoom-in/out too [00:50:43] prtksxna: Like, thumbnailing? [00:50:54] Because we do that already [00:51:25] marktraceur: Not as a tool to edit the image, but to fit it in the window that you're editing in [00:51:59] prtksxna: Oh, hm, I guess so [09:32:59] 6Multimedia, 10UploadWizard: UploadWizard previews don't respect final rotation - https://phabricator.wikimedia.org/T110788#1830702 (10Liuxinyu970226) [13:54:48] 6Multimedia, 10UploadWizard: Upload Wizard Code Review Backlog - https://phabricator.wikimedia.org/T77457#1831221 (10Aklapper) @MarkTraceur: Do you know?: > All patches are abandoned or merged. What is left to do here? [14:44:20] 6Multimedia, 6Commons, 10UploadWizard, 7Testme: Unable to upload image - https://phabricator.wikimedia.org/T109580#1831341 (10Aklapper) @Ancheta_Wis: Could you please answer the last comment? [14:45:08] hey marktraceur. [14:52:03] Hi prtksxna, what's up? [14:52:25] marktraceur: I want to discuss some ImageTweaks stuff. Do you have time to get on hangout? [14:54:21] prtksxna: Yup! [14:54:53] marktraceur: Now? [14:55:22] Yeah, one sec, setting it up [15:12:18] James_F|Away: So prtksxna points out that this experimental extension will be an Editor for images, and will be Visual, so we're going to need you to rename some repositories for us [15:14:04] 6Multimedia, 10UploadWizard: UploadWizard does not set filename for stash upload AJAX request - https://phabricator.wikimedia.org/T87555#1831419 (10MarkTraceur) p:5High>3Low This is an old-ish bug that I'm not convinced we have enough information to replicate - examples? Steps to reproduce? Which browsers... [15:15:05] 6Multimedia, 10UploadWizard: Explain UploadWizard funnel better - https://phabricator.wikimedia.org/T77891#1831422 (10MarkTraceur) p:5High>3Low Currently low priority, to be re-prioritized as we shift our focus towards data again. [15:15:26] :D :D [15:16:58] 6Multimedia, 10UploadWizard: Fix UW funnel error logging for new Firefogg error - https://phabricator.wikimedia.org/T77843#1831426 (10MarkTraceur) 5Open>3declined a:3MarkTraceur I'm not convinced this is actually a problem, if we have phantom Firefogg errors appearing in other bugs I will happily revisit... [15:20:21] 6Multimedia, 10UploadWizard: Investigate if there is a low-effort way to recover entered details when the upload process has to be restarted - https://phabricator.wikimedia.org/T77826#1831433 (10MarkTraceur) p:5High>3Normal Let's fix the illness, not the symptoms - but also, this will probably take some do... [15:20:53] 6Multimedia, 6Commons, 10UploadWizard: Understand better why people repeat the upload process so often - https://phabricator.wikimedia.org/T77825#1831436 (10MarkTraceur) p:5High>3Low Multimedia team not focusing on data right now, maybe re-prioritize later. [15:24:37] 6Multimedia, 10UploadWizard: Poll for success on publishfailed error - https://phabricator.wikimedia.org/T77824#1831441 (10MarkTraceur) 5Open>3declined a:3MarkTraceur Hm. It looks like publishfailed is used in two places. * When an exception is thrown somewhere in the publish job, in an async publish (... [15:24:38] 6Multimedia, 10UploadWizard, 7Epic: Improve upload funnel survival rate - https://phabricator.wikimedia.org/T85555#1831445 (10MarkTraceur) [15:25:07] 6Multimedia, 10UploadWizard: Fix ApiUpload::dieUsage error reporting - https://phabricator.wikimedia.org/T77823#1831447 (10MarkTraceur) p:5High>3Normal [15:26:59] 6Multimedia, 6Commons, 10UploadWizard: Review and improve UploadWizard-related API error messages - https://phabricator.wikimedia.org/T77821#1831457 (10MarkTraceur) Most of these are caught now. publishfailed is not one that I have seen in the wild, and you can see my close note on T77824 for more on that. I... [15:27:12] 6Multimedia, 10UploadWizard, 7Tracking: Improve UploadWizard UX (tracking) - https://phabricator.wikimedia.org/T96911#1831461 (10MarkTraceur) [15:27:13] 6Multimedia, 6Commons, 6Reading-Infrastructure-Team, 10UploadWizard, and 2 others: Address technical issues responsible for funnel drop-offs in UploadWizard - https://phabricator.wikimedia.org/T91652#1831462 (10MarkTraceur) [15:27:16] 6Multimedia, 6Commons, 10UploadWizard: Review and improve UploadWizard-related API error messages - https://phabricator.wikimedia.org/T77821#1831459 (10MarkTraceur) 5Open>3declined a:3MarkTraceur [15:27:56] 6Multimedia, 6Commons, 6Design Research Backlog, 10UploadWizard: Review UploadWizard UX for "fatal user errors" - https://phabricator.wikimedia.org/T77820#1831465 (10MarkTraceur) Adding design research as they might want to look into this at some point. [15:28:04] 6Multimedia, 6Commons, 6Design Research Backlog, 10UploadWizard: Review UploadWizard UX for "fatal user errors" - https://phabricator.wikimedia.org/T77820#1831467 (10MarkTraceur) p:5High>3Normal [15:28:15] OK this is ridiculous [15:29:22] Hush now. [15:36:00] (03PS1) 10Zfilipin: Upgrade browser tests to the latest version of mediawiki_selenium Ruby gem [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/255395 (https://phabricator.wikimedia.org/T99659) [15:37:37] (03CR) 10jenkins-bot: [V: 04-1] Upgrade browser tests to the latest version of mediawiki_selenium Ruby gem [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/255395 (https://phabricator.wikimedia.org/T99659) (owner: 10Zfilipin) [15:38:31] MatmaRex: You're doing GCI right? Do you have room for one more? https://phabricator.wikimedia.org/T77538 [15:39:05] James_F|Away: Hey I found you something to do ;) https://phabricator.wikimedia.org/T77537 [15:50:12] marktraceur: probably! [15:51:11] (no hangouts today and the rest of the week, right?) [15:51:48] marktraceur: or, you know, you could totally mentor something yourself. [15:59:56] I'm a little burned out on the whole mentoring gig, not going to lie [16:04:25] (03CR) 10Zfilipin: "Chrome job is green: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-chrome" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/255395 (https://phabricator.wikimedia.org/T99659) (owner: 10Zfilipin) [16:04:41] (03CR) 10Zfilipin: "Will investigate failing rake job." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/255395 (https://phabricator.wikimedia.org/T99659) (owner: 10Zfilipin) [16:10:50] marktraceur: Meh. [16:19:20] James_F: Indeed [16:26:10] (03PS2) 10Zfilipin: Upgrade browser tests to the latest version of mediawiki_selenium Ruby gem [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/255395 (https://phabricator.wikimedia.org/T99659) [16:29:41] marktraceur: BTW, you invited LA to the hangout tomorrow (which isn't happening) and not to the recurring invite. [16:30:16] James_F: I fixed that today I believe [16:33:58] (03CR) 10Hashar: [C: 032] Upgrade browser tests to the latest version of mediawiki_selenium Ruby gem [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/255395 (https://phabricator.wikimedia.org/T99659) (owner: 10Zfilipin) [16:36:57] (03Merged) 10jenkins-bot: Upgrade browser tests to the latest version of mediawiki_selenium Ruby gem [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/255395 (https://phabricator.wikimedia.org/T99659) (owner: 10Zfilipin) [16:47:26] marktraceur: OK. [16:49:47] MatmaRex: FYI I want to attack T96918 Move UI creation into JavaScript [16:49:56] I don't think you're working on that but I wanted to check [16:52:13] marktraceur: no, not at the moment [17:02:16] (03CR) 10Hashar: "running at https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-chrome-sauce/265" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/255395 (https://phabricator.wikimedia.org/T99659) (owner: 10Zfilipin) [17:26:41] CamanJS is a pain to install via npm. It has dependencies on cairo (and thus xquartz) for non-browser image manipulation :\ [17:26:56] Bower was simple enough, but I don't want to use it [17:34:21] :/ [17:35:12] prtksxna: Do we need npm? We can just distribute a version without the non-browser stuff, if that's available [17:37:02] marktraceur: We don't need npm. I was thinking of going just the npm way instead of bower+grunt. [17:37:19] The bower one is browser-only. [17:41:28] Oh, I see what you mean [17:41:34] prtksxna: Why do we need either, is my question [17:41:54] marktraceur: Just for the standalone repo [17:42:03] prtksxna: Ahhh, sure [17:42:04] marktraceur: It'd be nice in the extension too, right? [17:42:09] Hmm [17:42:30] marktraceur: At least for caman, we don't need an explicit npm depency on oojs/ui [17:42:46] So [17:42:58] I want to say we have a precedent for using bower in an extension [17:43:01] Flow or something [17:43:12] If you're consistent with How They Do It™ that's fine [17:44:17] marktraceur: Hm, I don't see bower anywhere… https://github.com/wikimedia/?utf8=%E2%9C%93&query=bower+only%3Asources+ [17:44:59] Shoot, you got me there [17:45:04] I wonder what I was thinking about. [17:45:21] > gyp info it worked if it ends with ok [17:45:26] > gyp ERR! not ok [17:45:31] :P [17:45:48] Heh [17:47:34] marktraceur: https://www.npmjs.com/package/caman-dist-only [17:47:35] \o/ [17:47:46] Whoop whoop [17:47:50] > dist folder only to avoid dependency issues when browser only is desired [17:48:11] Bloody right [18:01:33] (03PS1) 10MarkTraceur: Create arrow steps in JavaScript [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255418 [18:02:38] (03PS2) 10MarkTraceur: Create arrow steps in JavaScript [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255418 (https://phabricator.wikimedia.org/T96918) [18:04:18] (03CR) 10jenkins-bot: [V: 04-1] Create arrow steps in JavaScript [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255418 (https://phabricator.wikimedia.org/T96918) (owner: 10MarkTraceur) [18:07:28] Fuck you Jenkins [18:50:38] (03PS1) 10MarkTraceur: Move remainder of UI creation into JS [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255424 (https://phabricator.wikimedia.org/T96918) [18:52:18] (03CR) 10jenkins-bot: [V: 04-1] Move remainder of UI creation into JS [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255424 (https://phabricator.wikimedia.org/T96918) (owner: 10MarkTraceur) [18:54:27] (03PS3) 10MarkTraceur: Create arrow steps in JavaScript [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255418 (https://phabricator.wikimedia.org/T96918) [18:54:33] (03PS2) 10MarkTraceur: Move remainder of UI creation into JS [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255424 (https://phabricator.wikimedia.org/T96918) [18:56:38] (03CR) 10jenkins-bot: [V: 04-1] Move remainder of UI creation into JS [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255424 (https://phabricator.wikimedia.org/T96918) (owner: 10MarkTraceur) [18:58:02] I deserved that [19:08:01] Hm [19:08:19] MatmaRex: I don't think there's anything standing in the way of people going backwards to past steps anymore. I'm going to try this. [19:08:24] It's going to be glorious [19:23:50] Hm. A little trickier than previously expected. [19:24:01] Oh, herp, I'm not on my Super Special Awesome branch. [19:35:11] (03PS52) 10Paladox: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [19:35:58] (03CR) 10Paladox: "Updated videojs to 5.2.3 it fixes a npm deperecated warning for one of the dependency's." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [20:05:14] gilles: I haven't really checked anything in that bug is good advice given our usecase, I just assume the vips author probably knows much more then I do about thumbnailing images [20:06:32] bawolff: right, it's very easy to switch to resize if we need to [20:06:47] just change the .shrink( to .resize( in my patch basically :) [20:07:28] sounds good. It probably makes sense to not mess around with the thumbnailing algorithm, at the same time as messing around with how we implement [20:13:27] in the new architecture it will be a lot easier to switch algos/engines and try things out [20:13:54] I'm trying to set up the proxy engine right now, which will replicate the "use vips/don't use vips" logic we have in VipsScaler [20:14:06] it will be a good spot for A/B testing, perf measurement, etc. [20:14:28] also doing this in python and outside of mediawiki helps a lot... [20:28:15] gilles: Do you have a rollout plan? [20:28:29] do it live? :P [20:28:31] nope, not yet [20:28:43] I'm still writing all the moving parts on VM right now [20:29:10] OK cool [20:29:31] We're thinking about maybe doing some/most of the image editing on the frontend, but eventually I'll be itching for an API [20:31:36] gilles: Personally, I hope we'll eventually always do vips. [20:35:16] is there another streaming solution for giant pngs and tiffs? [20:39:09] something interesting about thumbor is that by default it uses PIL, which we might not have tried before [20:39:41] which uses libjpeg libtiff and the like directly, without going through IM/GM [20:40:50] opencv is also an option [20:41:18] plenty of new possibilities to try since most things have python bindings [20:46:26] streaming solutions sound nice, with those multi-gb tiff files [22:13:15] 6Multimedia, 10UploadWizard: UploadWizard does not set filename for stash upload AJAX request - https://phabricator.wikimedia.org/T87555#1832624 (10Tgr) I don't remember what this was about, but seems like it was fixed in the subtasks.