[03:16:32] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Logging: Missing page id in the recentchanges list of https://commons.wikimedia.org/ for some upload logevents. - https://phabricator.wikimedia.org/T118433#1800253 (10Krenair) Looking at the code... Does this seem to depend on whether it's an... [03:19:08] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Logging: Missing page id in the recentchanges list of https://commons.wikimedia.org/ for some upload logevents. - https://phabricator.wikimedia.org/T118433#1800258 (10LinJin) This happens only in recent 8 hours, so I do not think it depends on... [03:22:15] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Logging: Missing page id in the recentchanges list of https://commons.wikimedia.org/ for some upload logevents. - https://phabricator.wikimedia.org/T118433#1800260 (10Krenair) rMW8e1f6d55067f1c1ca62a5d516a75e0b24017db9b looks like it may be re... [03:26:33] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Logging: Missing page id in the recentchanges list of https://commons.wikimedia.org/ for some upload logevents. - https://phabricator.wikimedia.org/T118433#1800264 (10Krenair) https://gerrit.wikimedia.org/r/#/c/251670/ [06:03:15] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10Parsoid, and 4 others: Use content hash based image / thumb URLs - https://phabricator.wikimedia.org/T66214#1800366 (10intracer) [09:45:56] (03PS4) 10Bartosz Dziewoński: Split off uw.OtherDetailsWidget from UploadWizardDetails (and OOUI-ize) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251488 (https://phabricator.wikimedia.org/T96917) [09:45:58] (03PS9) 10Bartosz Dziewoński: Split off uw.LocationDetailsWidget from UploadWizardDetails (and OOUI-ize) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251291 (https://phabricator.wikimedia.org/T96917) (owner: 10MarkTraceur) [09:46:00] (03PS5) 10Bartosz Dziewoński: Split off uw.TitleDetailsWidget from UploadWizardDetails (and OOUI-ize) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251182 (https://phabricator.wikimedia.org/T96917) [09:46:02] (03PS4) 10Bartosz Dziewoński: Split off uw.CategoriesDetailsWidget from UploadWizardDetails (improve warnings) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251180 (https://phabricator.wikimedia.org/T96917) [09:46:04] (03PS5) 10Bartosz Dziewoński: Split off uw.DescriptionsDetailsWidget from UploadWizardDetails (and OOUI-ize) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251181 (https://phabricator.wikimedia.org/T96917) [09:46:06] (03PS4) 10Bartosz Dziewoński: Split off uw.DateDetailsWidget from UploadWizardDetails (introduce uw.DetailsWidget) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251179 (https://phabricator.wikimedia.org/T96917) [10:22:35] (03PS1) 10Bartosz Dziewoński: ut.TitleDetailsWidget: Restore blacklist error message details [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/252663 [12:06:01] 6Multimedia, 10UploadWizard: Use OOUI 'required' indicator for required fields - https://phabricator.wikimedia.org/T117833#1800767 (10matmarex) a:3matmarex [12:54:32] (03PS1) 10Bartosz Dziewoński: UploadWizardCampaign: Fix PHP warning when checking buttons [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/252679 [13:00:25] 6Multimedia, 10UploadWizard, 7Performance: Campaigns API call is very, very slow - https://phabricator.wikimedia.org/T56465#1800836 (10matmarex) It does seem resolved these days. [13:00:37] 6Multimedia, 10UploadWizard, 7Performance: Campaigns API call is very, very slow - https://phabricator.wikimedia.org/T56465#1800837 (10matmarex) 5Open>3Resolved a:3yuvipanda [13:03:33] 6Multimedia, 10UploadWizard: Revision history of campaign pages is lacking title - https://phabricator.wikimedia.org/T56012#1800842 (10matmarex) a:5Snhkicker>3None Doesn't seem like it's being worked on. [13:04:18] 6Multimedia, 10UploadWizard, 7Easy, 3Google-Code-In-2015: Revision history of campaign pages is lacking title - https://phabricator.wikimedia.org/T56012#1800844 (10matmarex) [13:06:02] 6Multimedia, 6Commons, 10MediaWiki-File-management, 6Performance-Team, 7Performance: Thumbnail urls should be versioned and sent with Expires headers - https://phabricator.wikimedia.org/T19577#1800845 (10intracer) [13:32:05] 6Multimedia, 10UploadWizard: Upload Wizard Campaigns should support adding a custom drop-down selector - https://phabricator.wikimedia.org/T114298#1800863 (10matmarex) Apparently they already do… but it's not documented. [13:32:32] 6Multimedia, 10UploadWizard: Upload Wizard Campaigns should support adding a custom drop-down selector - https://phabricator.wikimedia.org/T114298#1800865 (10matmarex) 5Open>3Resolved a:3matmarex Documented in https://www.mediawiki.org/w/index.php?title=Extension:UploadWizard/Campaigns&diff=1937280&oldid... [13:41:42] o/ [13:42:32] hi~ [13:43:20] I feel like I've been out forever :( [13:43:26] Anything anyone needs me to do? [13:47:34] 6Multimedia, 10UploadWizard: Campaigns: Boolean type parameters and target field - https://phabricator.wikimedia.org/T54879#1800881 (10matmarex) While checkboxes are not currently available, we have a 'select' type, which you could use (just give it two options, "Yes" and "No" or something). It has existed for... [13:48:00] prtksxna: i'm sure something could be found if you're bored… :) [13:48:49] :P [14:05:43] (03PS1) 10Bartosz Dziewoński: UploadWizardCampaign: Enable tidy when parsing [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/252688 (https://phabricator.wikimedia.org/T55822) [15:17:47] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Campaigns 'title' key lets you mess with page layout - https://phabricator.wikimedia.org/T55822#1800961 (10matmarex) a:3matmarex [15:24:44] 6Multimedia, 10UploadWizard: Custom campaigns should produce an extra newline - https://phabricator.wikimedia.org/T55638#1800967 (10matmarex) Looks like this has been fixed in 5c11db38d387a07339473effdb2199b9ae9a83e3. [15:24:59] 6Multimedia, 10UploadWizard, 7Tracking: UploadWizard: Wiki Loves Monuments contest issues (tracking) - https://phabricator.wikimedia.org/T39144#1800973 (10matmarex) [15:25:00] 6Multimedia, 10UploadWizard: Custom campaigns should produce an extra newline - https://phabricator.wikimedia.org/T55638#1800968 (10matmarex) 5Open>3Resolved a:3kai.nissen [15:25:20] 6Multimedia, 10UploadWizard: Custom campaigns should produce an extra newline - https://phabricator.wikimedia.org/T55638#587796 (10matmarex) [15:45:48] prtksxna: I think we have two goals in rotation now, and one of them is still all on my computer [15:46:00] So if you want to help MatmaRex with UploadWizard... [15:47:01] Then again you might have been out too long for me, too, you were working on the upload dialog goal and I forgot we even had that one [15:55:00] 6Multimedia, 10VisualEditor: While uploading image, clicking on "Try again" allows renaming the filename, even though it previously complained about it - https://phabricator.wikimedia.org/T115944#1801057 (10Jdforrester-WMF) [15:55:06] 6Multimedia, 10MediaWiki-General-or-Unknown, 10VisualEditor: Show not logged in error before uploading to stash in mw.Upload.BookletLayout - https://phabricator.wikimedia.org/T115866#1801059 (10Jdforrester-WMF) [15:55:19] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 7Design: Insert image in content immediately after it's uploaded, skipping the "General settings" step - https://phabricator.wikimedia.org/T115865#1801060 (10Jdforrester-WMF) [15:55:30] 6Multimedia, 10VisualEditor: "A file with name "$1" already exists in the shared file repository, and cannot be overwritten" shows up while trying to rename a file with single letter which is different from standard format - https://phabricator.wikimedia.org/T115946#1801061 (10Jdforrester-WMF) [15:57:52] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Logging, 5Patch-For-Review: Missing page id in the recentchanges list of https://commons.wikimedia.org/ for some upload logevents. - https://phabricator.wikimedia.org/T118433#1801084 (10Jdforrester-WMF) p:5Triage>3High a:3aaron [16:23:24] marktraceur: two campaigns code patches: https://gerrit.wikimedia.org/r/252679 https://gerrit.wikimedia.org/r/252688 - should be trivial [16:30:13] Ooh, interesting [16:30:59] (03CR) 10MarkTraceur: [C: 032] UploadWizardCampaign: Fix PHP warning when checking buttons [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/252679 (owner: 10Bartosz Dziewoński) [16:31:22] (03CR) 10MarkTraceur: [C: 032] UploadWizardCampaign: Enable tidy when parsing [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/252688 (https://phabricator.wikimedia.org/T55822) (owner: 10Bartosz Dziewoński) [16:31:28] bd [16:32:29] (03Merged) 10jenkins-bot: UploadWizardCampaign: Fix PHP warning when checking buttons [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/252679 (owner: 10Bartosz Dziewoński) [16:33:10] (03Merged) 10jenkins-bot: UploadWizardCampaign: Enable tidy when parsing [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/252688 (https://phabricator.wikimedia.org/T55822) (owner: 10Bartosz Dziewoński) [16:56:54] Almost poured salt in my coffee [16:56:58] Reasons I need coffee [16:59:04] heh, I remember those bugs [17:10:01] legoktm: there's still the one where '<' turns into \u00asdf on save [17:10:39] legoktm: i know what causes it, but i'm not sure if we can just flip the switch that makes them not be escaped this way, because there are some ambiguous XSS warnings :P [17:17:37] * @warning Do not use this option for JSON that could end up in inline scripts. [17:17:37] * - HTML5, §4.3.1.2 Restrictions for contents of script elements [17:17:37] * - XML 1.0 (5th Ed.), §2.4 Character Data and Markup [17:17:37] * [17:17:52] can it end up in an inline script? o.O [17:19:43] No [17:19:46] Pretty sure no [17:20:13] I feel like csteipp would have hurt Yuvi if that were the case [17:23:09] legoktm: probably not, but i really don't feel like verifying that [18:21:58] (03Abandoned) 10Gilles: [WIP] Natural scrolling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150561 (owner: 10Gilles) [18:22:05] (03Abandoned) 10Gilles: [WIP] Add PNG fallbacks for SVG background images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/159468 (owner: 10Gilles) [18:31:01] (03PS2) 10Bartosz Dziewoński: uw.TitleDetailsWidget: Restore blacklist error message details [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/252663 [18:31:03] (03PS5) 10Bartosz Dziewoński: Split off uw.OtherDetailsWidget from UploadWizardDetails (and OOUI-ize) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251488 (https://phabricator.wikimedia.org/T96917) [18:31:05] (03PS10) 10Bartosz Dziewoński: Split off uw.LocationDetailsWidget from UploadWizardDetails (and OOUI-ize) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251291 (https://phabricator.wikimedia.org/T96917) (owner: 10MarkTraceur) [18:31:07] (03PS6) 10Bartosz Dziewoński: Split off uw.TitleDetailsWidget from UploadWizardDetails (and OOUI-ize) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251182 (https://phabricator.wikimedia.org/T96917) [18:31:09] (03PS5) 10Bartosz Dziewoński: Split off uw.CategoriesDetailsWidget from UploadWizardDetails (improve warnings) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251180 (https://phabricator.wikimedia.org/T96917) [18:31:11] (03PS6) 10Bartosz Dziewoński: Split off uw.DescriptionsDetailsWidget from UploadWizardDetails (and OOUI-ize) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251181 (https://phabricator.wikimedia.org/T96917) [18:31:13] (03PS5) 10Bartosz Dziewoński: Split off uw.DateDetailsWidget from UploadWizardDetails (introduce uw.DetailsWidget) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251179 (https://phabricator.wikimedia.org/T96917) [18:31:13] hmm. [18:31:21] i think i accidentally rebased again. :P [18:31:35] Oops. [18:33:44] Gosh MatmaRex [18:56:44] marktraceur: Got confirmation that next week's branch (wmf.7) will happen as normal, then a week off for Thanksgiving, so wmf.8 on 1 December. We'll take the three weeks of Christmas/New Year/MW Developer Summit off, and do wmf.11 on 12 January. Laid out https://www.mediawiki.org/wiki/MediaWiki_1.27/Roadmap [19:08:04] Cool [20:05:38] brion: is there anything you want me to review that I missed ? [20:06:01] thedj: not off the top of my head... gonna try to get through gerrit later today and review some of your stuff :D [20:06:25] i actually didn't get too much further myself honestly [20:06:34] so prolly not much in there. [20:06:53] spend last week dealing with async JS loading breakages in core. [20:07:02] heh fun [20:07:09] oh yeah the FOUC on login page? [20:07:23] prefs. i gave up on login page. couldn't figure it out. [20:07:30] ugh [20:17:07] brion: right, so actually, i have the opus file extension changes that could use a review [20:17:31] whee [20:17:59] being: https://phabricator.wikimedia.org/T42193 [20:18:37] 'sounds legit' :D lemme test [20:19:06] oh and: https://gerrit.wikimedia.org/r/#/c/247833/ and https://gerrit.wikimedia.org/r/#/c/248404/ have been changed [20:19:18] * brion starts cranking up vagrant updates [20:19:35] whee! [20:19:37] * thedj will work on images in parseroutput objects [20:38:59] (03CR) 10Brion VIBBER: [C: 04-1] "'File extension ".opus" does not match the detected MIME type of the file (application/ogg).' :(" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248704 (https://phabricator.wikimedia.org/T42193) (owner: 10TheDJ) [20:40:01] brion: you need the core patch in the same ticket [20:40:07] aho [20:40:12] best to label those in the commit msg too :D [20:40:15] lemme amend the commit log [20:41:01] (03PS2) 10Brion VIBBER: Add opus to accepted file extensions [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248704 (https://phabricator.wikimedia.org/T42193) (owner: 10TheDJ) [20:41:09] (03PS3) 10TheDJ: Add opus to accepted file extensions Depends on: I3e03522 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248704 (https://phabricator.wikimedia.org/T42193) [20:41:19] whoops [20:41:26] haha [20:42:45] (03PS4) 10Brion VIBBER: Add opus to accepted file extensions Depends on: I7c3cba909 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248704 (https://phabricator.wikimedia.org/T42193) (owner: 10TheDJ) [20:42:55] ok i think we sorted it out now ;) [20:42:56] lemme retest [20:45:34] wut Call to undefined method UploadBase::getMaxPhpUploadSize() [20:45:55] ah i have a funky UW [20:45:58] lemme ... disable that [20:48:44] ok seems working [20:49:03] but ... i notice i can rename an mp3 file to '.opus' or '.ogg' and it just uploads :D this is an existing bug i think though [20:50:02] wait ... now i'm just confused [20:50:05] * brion arrrrghs [20:50:36] ok now it seems fine, i'm not sure how i broke it before :D [20:55:00] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10TimedMediaHandler, 5Patch-For-Review: Support for Opus audio format - https://phabricator.wikimedia.org/T42193#1801926 (10Paladox) [20:58:23] ok i'm merging the core patch ... [20:59:27] (03CR) 10Brion VIBBER: [C: 032] "Ok with the dependency this works. :) In the future we might want increased file integrity checks like making sure an '.opus' file has opu" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248704 (https://phabricator.wikimedia.org/T42193) (owner: 10TheDJ) [20:59:31] aaaand the other [20:59:53] they should also fail over safely if they get mismatched in production by accident somehow [20:59:58] eg it won't crash anything :) [21:12:48] wow, sometimes you find stuff... [21:13:40] "manualthumb' [21:13:40] * brion waits for gate-and-submit jobs......... [21:13:45] oh god [21:13:53] moar options [21:14:11] never knew you could specify your own thumb for a file.. [21:14:35] which then is not tracked in the imagelink table apparently :) [21:14:41] heh [21:15:04] 'responsive image' crop variants for various display area sizes would be awesome though [21:15:10] but ... should not be separate image references, probably :D [21:16:52] right, so my idea is as follows: [21:17:26] Linker:makeThumbLinkObj, officially deprecate it, which it already was unofficially... [21:18:12] Linker:makeThumbLink2, officially deprecate it in favor of makeThumbLinkForParser and makeThubmLinkForOutputPage [21:18:45] and then have makeThumbLinkForParser when called from parser output, and makeThubmLinkForOutputPage called from imagepages and the like... [21:18:51] hmm, why separate ForParser and ForOutputPage? [21:18:55] (03Merged) 10jenkins-bot: Add opus to accepted file extensions Depends on: I7c3cba909 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248704 (https://phabricator.wikimedia.org/T42193) (owner: 10TheDJ) [21:19:13] i'd think one that creates a ParserOutput and then append to either a ParserOutput or an OutputPage [21:19:31] you can't append to a parseroutput though. [21:20:11] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10TimedMediaHandler, and 3 others: Support for Opus audio format - https://phabricator.wikimedia.org/T42193#1802060 (10brion) 5Open>3Resolved Ok this is merged. :D Should go out next week or the week after (I'm a little vague on deployment schedules t... [21:20:15] you can concat parseroutputs into a final page. [21:20:30] thedj: ah yes.... i'm thinking we should change that :D [21:20:31] but parseroutput += stringbuilder [21:20:36] != [21:21:14] do we have assumptions that a parseroutput should be immutable already? [21:21:26] or would it be safe to turn it into a glorified stringbuilder :D [21:21:49] i'm concerned about tossing parseroutput objects around for microstrings.. that can't be efficient. [21:22:21] and parseroutput is usually cached, it will make it confusing to know what is and what is not cached if we use it as a string builder [21:22:48] legit enough [21:23:07] though for images we already create a bunch of objects (FileStore, File, MediaHandler, Title, etc) [21:24:02] maybe back to the idea of a common interface we can stick on both Parser and OutputPage for "here's some html and possible some modules and other metadata to append"? [21:24:50] then we only need one function and can pass either a Parser we're working with or an OutputPage, or an explicitly stringbuilder-like object if we're doing something funky [21:27:32] or we don't centralize the module addition. just keep it inside the Parser and the specific pages that need it... [21:28:05] an no, we can't.. [21:28:10] damn it. [21:28:25] there is just too much logic inside Linker.php... [21:29:43] there's a lot of moving parts yeah [21:29:56] little options that i think belong in parser land really [21:30:04] well, in formatter-land [21:30:12] ideally parsing and formatting would be separate steps consistently ;) [21:33:42] so what if we make a ThumbnailFormatter, that shares the interface for 'addMetadata' and friends as well then ? [21:33:53] aho [21:34:24] so we would have MediaTransformOutput, forwarding to ThumbnailFormatter/Output whatever, forwarding to parseroutput, forwarding to output. [21:34:37] and potentially skipping parserout [21:34:44] i kinda like that :D [21:35:26] * thedj too... [21:35:31] * thedj will experiement [21:35:53] awesome :D [23:42:38] 6Multimedia, 6Commons, 10MediaWiki-File-management, 6Parsing-Team: Semantic media roles - https://phabricator.wikimedia.org/T103624#1802590 (10GWicke) Also related: {T118520}