[02:07:37] <wikibugs>	 6Multimedia, 10TimedMediaHandler, 10Wikimedia-Video: OGV popup player doesn't work on Firefox in Windows 10 - https://phabricator.wikimedia.org/T117373#1772474 (10brion) The top video on https://en.wikipedia.org/wiki/Wikipedia:Five_million_articles plays in Firefox 41 on Windows 10 for me. It defaults to the...
[06:23:36] <wikibugs>	 6Multimedia, 10MediaWiki-Gallery, 10MediaWiki-Interface, 7JavaScript, 5Patch-For-Review: Gallery doesn't resize caption on window resize - https://phabricator.wikimedia.org/T91075#1772656 (10Fomafix) a:3Fomafix
[11:24:18] <prtksxna>	 Trying to setup another instance of mediawiki so that I can test Foreign* stuff
[12:44:38] <prtksxna>	 Setting up another instance of vagrant isn't as straight forward as I remember the first one being
[12:44:42] <prtksxna>	 Or maybe that was too long ago
[12:50:43] <prtksxna>	 ＼(｀0´)／
[13:29:52] <MatmaRex>	 hi
[13:36:43] <wikibugs>	 6Multimedia, 10UploadWizard: UploadWizard fails to show error if in multiple uploads, an individualized license is left blank - https://phabricator.wikimedia.org/T70082#1773333 (10matmarex) a:3matmarex
[13:37:09] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: mw.UploadWizardDeed: Do not assume that deed is always set [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/249893 (https://phabricator.wikimedia.org/T70082) 
[13:39:50] <wikibugs>	 6Multimedia, 10UploadWizard: Extension detection block upload on some valid files - https://phabricator.wikimedia.org/T74751#1773345 (10matmarex) This is actually a problem (or perhaps intentional limitation) of the action=upload API. Trying to stash a file named "test.com.jpg":  `{"error":{"code":"filetype-ba...
[13:40:52] <wikibugs>	 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: Extension detection blocks upload of some valid files - https://phabricator.wikimedia.org/T74751#1773348 (10matmarex)
[13:49:37] <wikibugs>	 6Multimedia, 10UploadWizard: Take out inline author field from license release message(s) - https://phabricator.wikimedia.org/T113977#1773417 (10matmarex) p:5Normal>3Lowest Eh, I'm not sure if we should do this. It might be weird from i18n perspective, but it matches how the input is actually shown in the...
[13:50:17] <wikibugs>	 6Multimedia, 10UploadWizard: UploadWizard silently skips invalid photos during Flickr upload - https://phabricator.wikimedia.org/T62026#1773422 (10matmarex)
[13:53:17] <wikibugs>	 6Multimedia, 10UploadWizard: Upload Wizard rejects valid license templates - https://phabricator.wikimedia.org/T67229#1773430 (10matmarex) 5Open>3Resolved a:3matmarex This check was removed entirely in ebdc2934701363521c97c6c803b821349a18d7b2.
[13:56:37] <wikibugs>	 6Multimedia, 10UploadWizard: Take out inline author field from license release message(s) - https://phabricator.wikimedia.org/T113977#1773450 (10siebrand) I don't think it's bad i18n. It's a nice in-context solution for a field that I think could be used more often. Possibly this should be done more often.  So...
[13:57:24] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Remove unused config options [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/250423 
[13:57:54] <wikibugs>	 6Multimedia, 10UploadWizard: Take out inline author field from license release message(s) - https://phabricator.wikimedia.org/T113977#1773451 (10matmarex) 5Open>3declined a:3matmarex Right. Thanks!
[13:58:19] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Follow-up cleanup: https://gerrit.wikimedia.org/r/#/c/250423/" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/158589 (owner: 10Gilles)
[13:59:05] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Remove dead code dealing with 'unknown' language [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/250424 
[14:15:13] <wikibugs>	 6Multimedia, 10UploadWizard, 7Easy, 3Google-Code-In-2015: Change popups informing about user choosing non-existent categories to use the warning system - https://phabricator.wikimedia.org/T117119#1773501 (10matmarex)
[14:34:52] <wikibugs>	 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: Extension detection blocks upload of some valid files - https://phabricator.wikimedia.org/T74751#1773558 (10Anomie) >>! In T74751#1773345, @matmarex wrote: > This is actually a problem (or perhaps intentional limitation) of the action=upload API.  The API...
[14:42:47] <wikibugs>	 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: Extension detection blocks upload of some valid files - https://phabricator.wikimedia.org/T74751#1773582 (10Anomie) BTW, the checking of all extensions was added in [[https://www.mediawiki.org/wiki/Special:Code/MediaWiki/6660|r6660]], with the comment "Enh...
[14:44:58] <marktraceur>	 Gooood morning team!
[14:45:11] <marktraceur>	 prtksxna, MatmaRex: What did I miss?
[14:45:27] <MatmaRex>	 hi there, slacker
[14:45:55] <marktraceur>	 Heh
[14:45:58] <MatmaRex>	 nothing particularly exciting. you have a lot of UW changes to review, though :D
[14:46:04] <marktraceur>	 Ooh, fun times
[14:46:28] <MatmaRex>	 and you'll have more when i'm done with https://phabricator.wikimedia.org/T96917 , i want to have something fairly complete before i submit it for review
[14:46:51] <MatmaRex>	 the diff is at something like +1000 -1500 lines currently, across three commits. :P
[14:47:50] <marktraceur>	 <3
[14:47:59] <marktraceur>	 As long as it works, review volume is something I can rationalize
[14:50:12] <MatmaRex>	 marktraceur: also, pray tell, how does one set up an upload campaign locally? i'm going to need to OOUI-ize the campaign-provided fields at some point too ;)
[14:50:51] <marktraceur>	 I think there's a documentation for that
[14:53:16] <marktraceur>	 https://www.mediawiki.org/wiki/Extension:UploadWizard/Campaigns
[14:55:19] <prtksxna>	 MatmaRex: marktraceur o/
[14:55:26] <prtksxna>	 The meeting time shifted!
[14:55:47] <marktraceur>	 Oh god
[14:56:25] <prtksxna>	 I still haven't been able to configure the other wiki. How have you guys set it up? Two vagrants?
[14:56:40] <marktraceur>	 I think that's the same meeting time I attended before I left
[14:56:45] <prtksxna>	 Hm, I should have dinner now instead of after the meeting :\
[14:56:54] <marktraceur>	 prtksxna: I tried setting up a wiki farm on my laptop, it was unsuccessful
[14:57:00] <marktraceur>	 Ooh, good plan, breakfast though
[14:57:02] <prtksxna>	 DST?
[14:57:22] <marktraceur>	 Yeah, US changed its timezone again
[14:57:28] <marktraceur>	 We're cowboys, what can I say
[14:57:32] <prtksxna>	 MatmaRex: How did you test https://gerrit.wikimedia.org/r/#/c/249567/?
[14:57:33] <prtksxna>	 :P
[14:57:38] <prtksxna>	 brb
[15:06:30] <MatmaRex>	 prtksxna: i set up http://www.telerik.com/fiddler to map requests for resources of en.wikipedia.beta.wmflabs.org and instead load them from my local files
[15:07:27] <MatmaRex>	 so i can run modified JS code against beta and production wikis (but production is more annoying, since it's HTTPS and things complain when i proxy it)
[15:09:13] <wikibugs>	 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: Extension detection blocks upload of some valid files - https://phabricator.wikimedia.org/T74751#1773724 (10matmarex) 5Open>3declined a:3matmarex Hmm, thanks for investigating. I guess this is a WONTFIX then.
[15:15:20] <MatmaRex>	 http://pastebin.com/vD6w0fpF https://dl.dropboxusercontent.com/u/10983006/tmp/fiddler.png
[15:48:23] <wikibugs>	 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 5Patch-For-Review: Re-enable Media Viewer from a File Page - https://phabricator.wikimedia.org/T77625#1773892 (10zeljkofilipin)
[16:14:21] <wikibugs>	 6Multimedia, 10Browser-Tests, 6Commons, 10UploadWizard: UploadWizard API tests failing on beta Commons due to login problem - https://phabricator.wikimedia.org/T89272#1773991 (10zeljkofilipin) 5Open>3Resolved a:3zeljkofilipin The job is green now, resolving. Please reopen if needed.
[16:22:55] <wikibugs>	 6Multimedia, 10Browser-Tests, 10UploadWizard: Links broken in UploadWizard-api-commons.wikimedia.beta.wmflabs.org job error report - https://phabricator.wikimedia.org/T66119#1774022 (10zeljkofilipin) Is this still a problem, or can this task be resolved?
[16:27:48] <wikibugs>	 6Multimedia, 10Browser-Tests, 10UploadWizard: Run UploadWizard API tests after mediawiki/core - https://phabricator.wikimedia.org/T65105#1774044 (10zeljkofilipin) 5Open>3declined a:3zeljkofilipin I do not remember the context for this task any more. If you care about it, please reopen it and provide th...
[16:33:27] <prtksxna>	 Thanks MatmaRex. Maybe I should set this up instead.
[16:34:11] <wikibugs>	 6Multimedia, 10MediaWiki-File-management, 6Performance-Team: ThumbnailRender job spam due to HTTP 500s - https://phabricator.wikimedia.org/T106740#1774071 (10demon)
[16:35:27] <wikibugs>	 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading, 5Patch-For-Review: Non-alphanumeric characters in wgDBname break file uploads - https://phabricator.wikimedia.org/T46066#1774072 (10demon)
[18:01:28] * marktraceur looks at MatmaRex's open patches list
[18:01:34] <marktraceur>	 That doesn't *seem* like a lot of review
[18:03:02] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "It is, indeed, unused." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/248907 (owner: 10Bartosz Dziewoński)
[18:03:33] <MatmaRex>	 it could be worse, i s'pose.
[18:04:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused method mw.UploadWizardUploadInterface.prototype.setPreview [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/248907 (owner: 10Bartosz Dziewoński)
[18:04:56] <marktraceur>	 You killed pubsub! Again! Yay! Again!
[18:05:02] <marktraceur>	 I'm getting tired of killing pubsub
[18:05:12] <marktraceur>	 Finally I can review it instead of watching my patch die slowly
[19:40:29] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Actually display a link to existing file with the same name [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/250484 
[19:40:31] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Make mw.DestinationChecker more reusable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/250485 
[19:40:40] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "Some thoughts about removing some entanglement between UWU and UWUI, else looks OK, testing now" (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/248908 (https://phabricator.wikimedia.org/T51988) (owner: 10Bartosz Dziewoński)
[19:41:29] <marktraceur>	 MatmaRex: One of my standing goals for UW is to remove references to "this.wizard" from UWU, and "this.upload" from UWUI
[19:41:42] <marktraceur>	 So when I see a chance to do it, I go for it :)
[19:42:42] <marktraceur>	 Looks like it's working fine though
[19:44:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make mw.DestinationChecker more reusable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/250485 (owner: 10Bartosz Dziewoński)
[19:45:15] <grrrit-wm>	 (03PS2) 10MarkTraceur: mw.FormDataTransport: Get progress notifications for the whole file [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/248923 (https://phabricator.wikimedia.org/T89194) (owner: 10Bartosz Dziewoński)
[19:45:23] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] mw.FormDataTransport: Get progress notifications for the whole file [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/248923 (https://phabricator.wikimedia.org/T89194) (owner: 10Bartosz Dziewoński)
[19:45:57] <MatmaRex>	 looking
[19:47:08] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] mw.UploadWizardDetails: We must call every valid() function [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/249892 (owner: 10Bartosz Dziewoński)
[19:49:37] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] mw.UploadWizardDeed: Do not assume that deed is always set [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/249893 (https://phabricator.wikimedia.org/T70082) (owner: 10Bartosz Dziewoński)
[19:50:44] <marktraceur>	 Uhhhh
[19:50:58] <marktraceur>	 Where did the license tags config variable become unused?
[19:52:35] <MatmaRex>	 when gilles killed that feature of checking
[19:53:11] <marktraceur>	 Oh righ.
[19:53:18] <marktraceur>	 I repressed it
[19:53:54] <marktraceur>	 RIP wikibugs
[19:59:10] <MatmaRex>	 marktraceur: hmm, so you're saying UploadWizardUpload is supposed to own a UploadWizardUploadInterface, and not the other way?
[19:59:53] <marktraceur>	 MatmaRex: That's the theory, anyway.
[19:59:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: mw.FormDataTransport: Get progress notifications for the whole file [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/248923 (https://phabricator.wikimedia.org/T89194) (owner: 10Bartosz Dziewoński)
[20:00:10] <marktraceur>	 At least that's the theory I've operated under for two years and change
[20:01:08] <MatmaRex>	 wouldn't changing it to be the other way be better? we could maybe swap UWU for mw.Upload at some point.
[20:01:17] <marktraceur>	 Hmm
[20:01:28] <MatmaRex>	 (while keeping UWUI code mostly unchanged)
[20:01:49] <marktraceur>	 MatmaRex: I can see the wisdom in that, but I think either way could work in theory
[20:02:53] <MatmaRex>	 yeah
[20:03:49] <marktraceur>	 I guess for now I will remain agnostic on the matter and Just Merge It
[20:07:52] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "I got talked down." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/248908 (https://phabricator.wikimedia.org/T51988) (owner: 10Bartosz Dziewoński)
[20:08:07] <marktraceur>	 I think it needs a rebaserization though.
[20:08:10] <MatmaRex>	 i don't feel very strongly about it, but i do think UI owning the Upload makes more sense
[20:08:16] <MatmaRex>	 naaah, it should merge.
[20:08:47] <marktraceur>	 It certainly makes sense in the context of our larger ecosystem of upload code
[20:09:10] <marktraceur>	 i.e. the larger ecosystem that we fabricated in the past few months
[20:12:52] <marktraceur>	 BRB need additional caffeine
[20:14:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Get rid of pubsub once and for all [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/248908 (https://phabricator.wikimedia.org/T51988) (owner: 10Bartosz Dziewoński)
[20:14:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: mw.UploadWizardDetails: We must call every valid() function [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/249892 (owner: 10Bartosz Dziewoński)
[20:14:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: mw.UploadWizardDeed: Do not assume that deed is always set [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/249893 (https://phabricator.wikimedia.org/T70082) (owner: 10Bartosz Dziewoński)
[20:25:09] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Make mw.DestinationChecker more reusable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/250485 
[20:25:26] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Make mw.DestinationChecker more reusable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/250485 
[20:55:53] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Remove unused config options [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/250423 (owner: 10Bartosz Dziewoński)
[20:56:18] <marktraceur>	 MatmaRex: Are those still set in wmf config or were we just relying on the defaults?
[20:56:33] <MatmaRex>	 hm, i haven't checked
[20:57:08] <MatmaRex>	 don't seem to be
[20:57:09] <marktraceur>	 It shouldn't matter, but good to clean up when you can
[20:57:11] <marktraceur>	 OK!
[20:57:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused config options [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/250423 (owner: 10Bartosz Dziewoński)
[21:53:41] <wikibugs>	 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: Extension detection blocks upload of some valid files - https://phabricator.wikimedia.org/T74751#1775654 (10Gilles) 5declined>3Open It should be optional, or a default that can be turned off. Protecting weakly secured mediawiki installs shouldn't mean...
[21:55:35] <wikibugs>	 6Multimedia, 10MediaWiki-Uploading: Filename extension detection blocks upload of some valid files - https://phabricator.wikimedia.org/T74751#1775657 (10matmarex)
[23:10:45] <wikibugs>	 6Multimedia, 10TimedMediaHandler, 10Wikimedia-Video: OGV popup player doesn't work on Firefox in Windows 10 - https://phabricator.wikimedia.org/T117373#1775940 (10Pine) 5Open>3Invalid a:3Pine I think he was able to get the video to play on the Commons page. There haven't been other reports of users exp...