[00:32:06] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): MediaViewer intermittent image loading errors (2015 Oct) - https://phabricator.wikimedia.org/T115563#1764485 (10Cumboto) Hi, I could see the image (Bernini. "La tentación de St. Teresa... [01:39:29] 6Multimedia, 10MediaWiki-extensions-VipsScaler: vips not rendering some tiffs properly to png - https://phabricator.wikimedia.org/T116947#1764579 (10Bawolff) >>! In T116947#1763578, @Bawolff wrote: > Also appears to be somewhat of a regression. Bug is not apparent on vips-7.38.5. At least locally. I wasn't te... [01:50:02] (03CR) 10Krinkle: [C: 032] Use __DIR__ instead of dirname( __FILE__ ) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/248858 (owner: 10Bartosz Dziewoński) [01:59:20] (03Merged) 10jenkins-bot: Use __DIR__ instead of dirname( __FILE__ ) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/248858 (owner: 10Bartosz Dziewoński) [01:59:23] (03Merged) 10jenkins-bot: Fix CodeSniffer 'MediaWiki.ControlStructures.IfElseStructure.SpaceBeforeElse' warnings [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/248859 (owner: 10Bartosz Dziewoński) [01:59:25] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/248555 (owner: 10Legoktm) [04:59:14] 6Multimedia, 10MediaWiki-extensions-VipsScaler, 5Patch-For-Review: vips not rendering 16-bit greyscale tiffs properly to png - https://phabricator.wikimedia.org/T116947#1764727 (10Bawolff) [07:32:54] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): MediaViewer intermittent image loading errors (2015 Oct) - https://phabricator.wikimedia.org/T115563#1764811 (10Gilles) >>! In T115563#1764292, @Tgr wrote: > @Gilles would you be OK wit... [12:29:32] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): MediaViewer intermittent image loading errors (2015 Oct) - https://phabricator.wikimedia.org/T115563#1765074 (10Cumboto) I would ask you to remove me from your mailing list. So far I ha... [14:37:54] 6Multimedia, 6Commons: A new panoramic viewer for commons - https://phabricator.wikimedia.org/T105789#1765311 (10Qgil) @dschwen, is there any work left here? Does the Commons community know about this gadget? [14:56:25] 6Multimedia, 6Commons: A new panoramic viewer for commons - https://phabricator.wikimedia.org/T105789#1765338 (10dschwen) Quim, there is some work left, namely supporting arbitrarily high resolution panos. I had a blocking task I was waiting for for a few months, but that got resolved a while ago. The ball is... [15:14:19] 6Multimedia, 10MediaWiki-File-management, 10TimedMediaHandler, 10Wikimedia-Video, and 2 others: Improve interface for MediaHandlers to add JavaScript - https://phabricator.wikimedia.org/T60478#1765387 (10brion) I think we have an interface of that nature -- it's the ParserOutput class. :) Do we just need a... [15:26:39] 6Multimedia, 10MediaWiki-File-management, 10TimedMediaHandler, 10Wikimedia-Video, and 2 others: Improve interface for MediaHandlers to add JavaScript - https://phabricator.wikimedia.org/T60478#1765432 (10brion) I think we could extend MediaTransformOutput so in addition to keeping the toHtml() method which... [16:49:01] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): MediaViewer intermittent image loading errors (2015 Oct) - https://phabricator.wikimedia.org/T115563#1765700 (10Aklapper) @Cumboto: If you'd like to remove yourself from the subscribers... [17:48:24] 6Multimedia, 6Commons, 10MediaWiki-File-management: Commons file: Exception encountered, of type "Exception" - https://phabricator.wikimedia.org/T117066#1765889 (10Thgoiter) 3NEW [17:52:10] 6Multimedia, 10MediaWiki-Extension-Requests, 6Wiktionary: Audio pronunciation: Automatic text-to-speech to convert IPA to sound - https://phabricator.wikimedia.org/T33221#1765909 (10Qgil) [17:52:38] 6Multimedia, 10MediaWiki-Extension-Requests, 6Wiktionary: IPA or SAMPA module - https://phabricator.wikimedia.org/T2224#1765911 (10Qgil) [19:11:32] 6Multimedia, 10UploadWizard, 7Easy, 3Google-Code-In-2015: Use OO.ui.confirm() for the confirmation dialog in uw.controller.Details.prototype.valid - https://phabricator.wikimedia.org/T117077#1766132 (10matmarex) 3NEW [19:13:21] 6Multimedia, 10UploadWizard, 7Easy, 3Google-Code-In-2015: Use OO.ui.confirm() for the confirmation dialog in uw.controller.Details.prototype.valid - https://phabricator.wikimedia.org/T117077#1766151 (10matmarex) [19:15:53] 6Multimedia, 10UploadWizard, 7Easy, 3Google-Code-In-2015: Use OO.ui.alert() for the assorted error message dialogs in UploadWizard - https://phabricator.wikimedia.org/T117079#1766164 (10matmarex) 3NEW [19:37:20] 6Multimedia, 10MediaWiki-File-management: Include at least some EXIF metadata in resized pictures - https://phabricator.wikimedia.org/T20871#1766247 (10Amitie_10g) According to [[ https://commons.wikimedia.org/wiki/Commons:Village_pump/Copyright#Exif_copyright_messages_not_preserved_in_thumbnails |this thread... [19:58:51] 6Multimedia, 6Commons, 10MediaWiki-File-management: Commons file: Exception encountered, of type "Exception" - https://phabricator.wikimedia.org/T117066#1766351 (10Tgr) ``` 2015-10-29 19:58:17 mw1210 commonswiki exception ERROR: [bb4f3777] /wiki/File:Georg_August_Samuel_von_Nassau-Idstein.jpg Exception fro... [20:06:59] 6Multimedia, 6Commons, 10MediaWiki-File-management, 7Wikimedia-log-errors: Commons file: Exception encountered, of type "Exception" - https://phabricator.wikimedia.org/T117066#1766396 (10Tgr) [20:19:55] 6Multimedia, 6Commons, 10MediaWiki-File-management, 7Wikimedia-log-errors: Commons file: Exception encountered, of type "Exception" - https://phabricator.wikimedia.org/T117066#1766454 (10Tgr) The direct cause is https://gerrit.wikimedia.org/r/#/c/246719/ / T115514. Seems to have something to do with __MAGI... [20:32:28] 6Multimedia, 6Commons, 10MediaWiki-File-management, 7Wikimedia-log-errors: Commons file: Exception encountered, of type "Exception" - https://phabricator.wikimedia.org/T117066#1766494 (10Tgr) ``` tgr@terbium:~$ mwscript eval.php --wiki=commonswiki > $mwa = MagicWord::getDoubleUnderscoreArray(); > var_dump(... [21:12:52] 6Multimedia, 10MediaWiki-File-management: Include at least some EXIF metadata in resized pictures - https://phabricator.wikimedia.org/T20871#1766766 (10Stefan2) Various common licences state that you must include any copyright notices when using a work. GFDL 1.3 states: > You may copy and distribute the Docum... [21:32:56] 6Multimedia, 10MediaWiki-File-management: Include at least some EXIF metadata in resized pictures - https://phabricator.wikimedia.org/T20871#1766784 (10Bawolff) >If Mediawiki removes EXIF, Mediawiki complicates things for users who wish to use verbatim copies of files on the Interne [IANAL] Regardless of Exif... [21:34:33] (03CR) 10Hashar: "check experimental" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/249846 (owner: 10L10n-bot) [21:39:30] 6Multimedia, 6Commons, 6Editing-Department, 10Possible-Tech-Projects, and 2 others: Allow uploading of 3D files to Wikimedia Commons - https://phabricator.wikimedia.org/T3790#1766799 (10Bawolff) > Ping @Bawolff as a potential co-mentor? /me doesn't really want to commit to being a mentor for this round. (... [21:41:10] (03PS5) 10Bartosz Dziewoński: Get rid of pubsub once and for all [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/248908 (https://phabricator.wikimedia.org/T51988) [21:41:12] (03PS1) 10Bartosz Dziewoński: mw.UploadWizardDetails: We must call every valid() function [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/249892 [21:41:14] (03PS1) 10Bartosz Dziewoński: mw.UploadWizardDeed: Do not assume that deed is always set [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/249893 [21:43:23] 6Multimedia, 6Commons, 10MediaWiki-File-management, 5Patch-For-Review, 7Wikimedia-log-errors: Commons file: Exception encountered, of type "Exception" - https://phabricator.wikimedia.org/T117066#1766816 (10Tgr) It's a `PREG_BAD_UTF8_ERROR` apparently. [21:48:16] 6Multimedia, 6Commons, 10MediaWiki-File-management, 5Patch-For-Review, 7Wikimedia-log-errors: Commons file: Exception encountered, of type "Exception" - https://phabricator.wikimedia.org/T117066#1766830 (10Bawolff) That's interesting. It should be pretty impossible to put invalid utf8 into a wikipage. I... [21:49:27] 6Multimedia, 6Commons, 10MediaWiki-File-management, 5Patch-For-Review, 7Wikimedia-log-errors: Commons file: Exception encountered, of type "Exception" - https://phabricator.wikimedia.org/T117066#1766842 (10Bawolff) /me also wonders what happened to our nice error handler that displayed prettily in the skin. [21:54:50] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/249897 [21:57:54] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/249897 (owner: 10Hashar) [22:02:02] 6Multimedia, 6Commons, 10MediaWiki-File-management, 5MW-1.27-release-notes, and 4 others: Commons file: Exception encountered, of type "Exception" - https://phabricator.wikimedia.org/T117066#1766922 (10Bawolff) >>! In T117066#1766830, @Bawolff wrote: > That's interesting. It should be pretty impossible to... [22:05:48] 6Multimedia, 6Commons, 10MediaWiki-File-management, 5MW-1.27-release-notes, and 4 others: Commons file: Exception encountered, of type "Exception" - https://phabricator.wikimedia.org/T117066#1766929 (10Tgr) Why is `Parser->doDoubleUnderscore` even called on the metadata table? [22:07:20] 6Multimedia, 6Commons, 10MediaWiki-File-management, 5MW-1.27-release-notes, and 4 others: Commons file: Exception encountered, of type "Exception" - https://phabricator.wikimedia.org/T117066#1766940 (10Bawolff) For historical reasons, MW's exif handling is extremely nutty. The entire metadata table gets r... [22:08:03] tgr: In this case, its not even my fault! It was horrible like that before I even touched the metadata code ;) [22:40:55] 6Multimedia, 10UploadWizard, 7Easy, 3Google-Code-In-2015: Add a warning about choosing a date in the future - https://phabricator.wikimedia.org/T117117#1767063 (10matmarex) 3NEW [22:44:48] 6Multimedia, 10UploadWizard, 7Easy, 3Google-Code-In-2015: Change popups informing about user choosing non-existent categories to warning systems - https://phabricator.wikimedia.org/T117119#1767085 (10matmarex) 3NEW [22:54:21] 6Multimedia, 10UploadWizard: TitleBlacklist complete error messages are utterly hopeless in UploadWizard - https://phabricator.wikimedia.org/T117121#1767138 (10matmarex) 3NEW [22:54:45] 6Multimedia, 6Commons, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Commons' TitleBlacklist messages are messy and not parseable by jqueryMsg - https://phabricator.wikimedia.org/T115259#1767147 (10matmarex) [22:54:47] 6Multimedia, 10UploadWizard: TitleBlacklist complete error messages are utterly hopeless in UploadWizard - https://phabricator.wikimedia.org/T117121#1767146 (10matmarex) [22:55:24] 6Multimedia, 6Commons: Commons' TitleBlacklist messages are messy and not parseable by jqueryMsg - https://phabricator.wikimedia.org/T115259#1719278 (10matmarex) [23:14:47] bawolff: isn't https://gerrit.wikimedia.org/r/#/c/249724/1/includes/media/DjVu.php an XML bomb vulnerability? [23:15:50] tgr: The user isn't in control of the xml, so you shouldn't be able to specify doctypes for recursive entities [23:16:30] I see [23:16:51] if you mean the billion laughs thing [23:17:09] Someone could just upload a djvu file with a crap ton of metadata in it though [23:18:50] although for good measure, it should probably disable all those scary bits of xml [23:19:15] 6Multimedia, 6Commons, 6Editing-Department, 10Possible-Tech-Projects, and 2 others: Allow uploading of 3D files to Wikimedia Commons - https://phabricator.wikimedia.org/T3790#1767245 (10Tgr) > I would be willing to give advice to the student unofficially though if they run into anything tricky Isn't that... [23:28:46] 6Multimedia, 10MediaWiki-File-management: Media file metadata should be sanitized to be valid UTF-8 before inclusion in page - https://phabricator.wikimedia.org/T117129#1767271 (10Tgr) 3NEW [23:29:01] 6Multimedia, 10MediaWiki-File-management: Media file metadata should be sanitized to be valid UTF-8 before inclusion in page - https://phabricator.wikimedia.org/T117129#1767281 (10Tgr) [23:30:40] 6Multimedia, 10MediaWiki-File-management: Media file metadata should be sanitized to be valid UTF-8 before inclusion in page - https://phabricator.wikimedia.org/T117129#1767285 (10Bawolff) Specificly, it looks like the Exif code isn't validating things. Some of the other metadata pieces run UtfNormal\Validator... [23:30:43] 6Multimedia, 10MediaWiki-File-management: Media file metadata should not be parsed - https://phabricator.wikimedia.org/T117130#1767286 (10Tgr) 3NEW [23:31:11] 6Multimedia, 6Commons, 10MediaWiki-File-management, 5MW-1.27-release-notes, and 4 others: Commons file: Exception encountered, of type "Exception" - https://phabricator.wikimedia.org/T117066#1767294 (10Tgr) 5Open>3Resolved a:3Tgr Exception ugliness is T117128. Lack of UTF sanitization of the metadata... [23:31:22] 6Multimedia, 10MediaWiki-File-management: Media file metadata should not be parsed - https://phabricator.wikimedia.org/T117130#1767302 (10Bawolff) One nice thing though, is this makes it easy to see that there's no possible XSS in any of the metadata handlers. [23:33:52] 6Multimedia, 10MediaWiki-File-management: Media file metadata should not be parsed - https://phabricator.wikimedia.org/T117130#1767322 (10Tgr) Maybe it should be sanitized but not parsed? [23:57:35] 6Multimedia, 10MediaWiki-File-management, 7Easy, 7I18n, and 2 others: Display file format of preview if different format from original file - https://phabricator.wikimedia.org/T58546#1767394 (10jrbs)