[00:12:49] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): MediaViewer intermittent image loading errors (2015 Oct) - https://phabricator.wikimedia.org/T115563#1760298 (10Jdlrobson) [04:46:15] 6Multimedia, 10Wikimedia-SVG-rendering: SVG server-side rendering renders some arrowheads backwards. - https://phabricator.wikimedia.org/T116824#1760870 (10Nagle) This turns out to be a known bug in Google Chrome. See https://code.google.com/p/chromium/issues/detail?id=450368 Firefox, Inkscape, and LibreOffic... [06:30:28] 6Multimedia, 10Wikimedia-SVG-rendering: SVG server-side rendering renders some arrowheads backwards. - https://phabricator.wikimedia.org/T116824#1760946 (10Nagle) More info: This problem occurs when one Bezier handle at the end of a line has zero length. This is unusual, but should work. A path like this: ```... [11:46:36] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [13:29:03] (03CR) 10Brion VIBBER: "couple inline notes on RL setup" (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [14:05:44] (03PS1) 10TheDJ: Convert ext.tmh.transcodetable to OOjs UI [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/249397 (https://phabricator.wikimedia.org/T116867) [14:05:52] thedj: Ooh. [14:20:30] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Tarball-Backports, and 7 others: InstantCommons broken by switch to HTTPS - https://phabricator.wikimedia.org/T102566#1761834 (10saper) Question: wouldn't that be possible to ship the certificate as a parameter to `$wgForeignXXXRepos` and not... [14:23:08] (03CR) 10Jforrester: Convert ext.tmh.transcodetable to OOjs UI (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/249397 (https://phabricator.wikimedia.org/T116867) (owner: 10TheDJ) [15:38:53] (03PS47) 10Paladox: Add extensions.json, empty PHP entry point [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210176 (https://phabricator.wikimedia.org/T87981) [15:38:54] James_F: figured i'd give it a try [15:38:54] had to wait half 15mins for something to finish building :) [15:39:03] :-) [16:00:34] 6Multimedia, 10MediaWiki-File-management, 10TimedMediaHandler, 10Wikimedia-Video, 7Technical-Debt: Improve interface for MediaHandlers to add JavaScript - https://phabricator.wikimedia.org/T60478#1762152 (10TheDJ) [16:36:05] 6Multimedia, 10MediaWiki-File-management, 10TimedMediaHandler, 10Wikimedia-Video, 7Technical-Debt: Improve interface for MediaHandlers to add JavaScript - https://phabricator.wikimedia.org/T60478#1762315 (10TheDJ) How about: ``` MediaTransformOutput\getJsConfigVars() MediaTransformOutput\getModules() Me... [17:23:09] 6Multimedia, 10MediaWiki-File-management, 10TimedMediaHandler, 10Wikimedia-Video, 7Technical-Debt: Improve interface for MediaHandlers to add JavaScript - https://phabricator.wikimedia.org/T60478#1762532 (10Bawolff) >>! In T60478#1762315, @TheDJ wrote: > How about: > > ``` > MediaTransformOutput\getJsCo... [17:41:15] (03PS1) 10Amire80: Improve the spelling of multimediaviewer-errorreport-privacywarning [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/249449 [18:01:42] (03PS2) 10TheDJ: Convert ext.tmh.transcodetable to OOjs UI [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/249397 (https://phabricator.wikimedia.org/T116867) [18:12:52] 6Multimedia, 10MediaWiki-extensions-VipsScaler: vips not rendering some tiffs properly to png - https://phabricator.wikimedia.org/T116947#1762719 (10Bawolff) [18:37:50] 6Multimedia, 6Commons, 6Editing-Department, 10MediaWiki-API, and 2 others: Provide a well-performing API to rotate an image - https://phabricator.wikimedia.org/T35186#1762783 (10Steinsplitter) [18:38:16] 6Multimedia, 6Commons, 6Editing-Department, 10MediaWiki-API, and 2 others: Provide a well-performing API to rotate an image - https://phabricator.wikimedia.org/T35186#1762785 (10Steinsplitter) [18:54:23] 6Multimedia, 10MediaWiki-extensions-VipsScaler: vips not rendering some tiffs properly to png - https://phabricator.wikimedia.org/T116947#1762828 (10Bawolff) Its probably related to the tiff being 16bit. Probably there is a bug in converting that to 8 bit png. Probably could be fixed by adding an explicit conv... [19:37:17] (03CR) 10Brion VIBBER: Convert ext.tmh.transcodetable to OOjs UI (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/249397 (https://phabricator.wikimedia.org/T116867) (owner: 10TheDJ) [19:39:50] (03CR) 10TheDJ: Convert ext.tmh.transcodetable to OOjs UI (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/249397 (https://phabricator.wikimedia.org/T116867) (owner: 10TheDJ) [19:44:06] (03CR) 10Brion VIBBER: Convert ext.tmh.transcodetable to OOjs UI (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/249397 (https://phabricator.wikimedia.org/T116867) (owner: 10TheDJ) [20:41:49] (03PS3) 10TheDJ: Convert ext.tmh.transcodetable to OOjs UI [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/249397 (https://phabricator.wikimedia.org/T116867) [20:53:10] (03CR) 10Jforrester: [C: 031] Convert ext.tmh.transcodetable to OOjs UI [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/249397 (https://phabricator.wikimedia.org/T116867) (owner: 10TheDJ) [20:59:13] (03CR) 10Brion VIBBER: [C: 032] "dialog so preeeetttyyyyy" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/249397 (https://phabricator.wikimedia.org/T116867) (owner: 10TheDJ) [21:00:59] one less part of jquery ui :) [21:01:21] whoo [21:02:09] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): MediaViewer intermittent image loading errors (2015 Oct) - https://phabricator.wikimedia.org/T115563#1763450 (10Jdlrobson) [21:02:43] we should do the popup video transform dialog too, looks like it should be pretty straightforward [21:02:53] Yay. [21:02:57] yeah, probably doable. [21:03:04] though i'd love to replace that with integrating into MMV [21:03:04] thedj: hmm, that will create a new WindowManager and append it to DOM every time the link/button is clicked? shouldn't it just use one? [21:03:11] * James_F ponders writing a WIP patch that deletes jQuery UI from MW core just as a stake in the ground. [21:03:14] (nitpicking me, i know) [21:03:25] James_F is a stake holder [21:03:27] MatmaRex: hmmm i thought that was a singleton [21:03:32] * James_F grins. [21:03:38] oh. i missed that... [21:03:39] MatmaRex: if you need me to undo that +2 for now lemme knwo :D [21:03:44] no, no, it works [21:03:51] presumably. no reason why it wouldn't, i didn't test it :D [21:04:16] well it does work :D [21:04:20] Lol stake holder [21:04:26] but you can technically have multiple WindowManagers [21:04:47] (VE uses a slightly customized one to display mini-dialogs inside the toolbar, e.g. the Ctrl+F one) [21:05:00] funnnn [21:05:08] Because magic. [21:05:11] * thedj visualizes James_F with a stake + in a LotR setting... [21:05:24] I wrote that on the whiteboard in the office. [21:05:32] Vampire holding a wooden stake. [21:05:47] No-one understood until I wrote "stakeholder" underneath. [21:05:51] * James_F pouted. [21:06:27] yeah looking at https://www.mediawiki.org/wiki/OOjs_UI/Windows/Window_managers it should be fine [21:06:42] no need to keep a dedicated WM around in this case, i think [21:06:51] Minor memory leak for people doing pathological actions is minor. [21:06:56] hehe [21:07:03] i'll keep it in mind for next time [21:07:05] will the WM garbage-collect or does it add DOM resources? [21:07:14] yeah. it would be better to use a single one, or clean it up (manager.$element.remove()) after the windows are closed [21:07:16] MatmaRex: Maybe MW should instantiate a WindowManager on each page? [21:07:21] but i don't care enough to submit a patch [21:07:33] MatmaRex: (Once we're running OOUI on every page, maybe.) [21:07:56] mw.util.primaryWindowManager [21:07:59] :) [21:08:02] ok, easy to clean it up manually then for now [21:08:04] James_F: i was thinking we should have a OO.ui.alert() convenience method that would keep a WindowManager around and open MessageDialogs in it [21:08:19] or, you know, the holy trinity. alert(), confirm(), prompt() [21:08:40] simply returning a promise that is resolved when the dialog closes [21:09:38] MatmaRex: Ha. [21:10:03] MatmaRex: Won't that be a bit messy if e.g. the host integration needs them to have an odd z-index or whatever? [21:10:36] yes, there are these ugly corner cases [21:10:44] which is why i was just thinking and not implementing :D [21:10:55] I mean, fine for MediaWiki, but not so much for e.g. WordPress or whomever. [21:10:57] Yeah. :-) [21:11:05] We could make these all in mw.widgets [21:11:18] Not for VE, but for other people. [21:13:26] brion: hmm, not sure about also doing it for MwEmbed... [21:13:43] brion: i mean, the only reason i would consider would be fore it to be less ugly.... [21:13:50] yes less ugly++ ;) [21:14:08] :-) [21:14:35] brion: We don't have a slider widget in OOUI yet, so fully dumping jQuery.UI for OOUI from TMH might take some time. [21:14:52] nah, that would be a wasted effort [21:14:55] videoJS ! [21:14:59] James_F: yeah the player interface depends on some crud [21:15:05] but th edialog should be easy to switch [21:15:14] * James_F nods. [21:15:19] thedj: That too. [21:22:27] (03Merged) 10jenkins-bot: Convert ext.tmh.transcodetable to OOjs UI [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/249397 (https://phabricator.wikimedia.org/T116867) (owner: 10TheDJ) [21:27:40] 6Multimedia, 10MediaWiki-extensions-VipsScaler: vips not rendering some tiffs properly to png - https://phabricator.wikimedia.org/T116947#1763576 (10Bawolff) Hmm. Some of the 16bit tiff files don't seem affected by this. For example: https://commons.wikimedia.org/wiki/File:Stephenson_grand_army_republic_monume... [21:28:55] 6Multimedia, 10MediaWiki-extensions-VipsScaler: vips not rendering some tiffs properly to png - https://phabricator.wikimedia.org/T116947#1763578 (10Bawolff) Also appears to be somewhat of a regression. Bug is not apparent on vips-7.38.5. At least locally. [21:43:12] 6Multimedia, 10MediaWiki-General-or-Unknown, 10VisualEditor: Show not logged in error before uploading to stash in mw.Upload.BookletLayout - https://phabricator.wikimedia.org/T115866#1763636 (10matmarex) https://gerrit.wikimedia.org/r/249567 should help with the first part of that. [21:43:59] (03CR) 10Legoktm: Add extensions.json, empty PHP entry point (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210176 (https://phabricator.wikimedia.org/T87981) (owner: 10Paladox) [21:48:20] 6Multimedia, 10MediaWiki-File-management, 10TimedMediaHandler, 10Wikimedia-Video, 7Technical-Debt: Improve interface for MediaHandlers to add JavaScript - https://phabricator.wikimedia.org/T60478#1763671 (10TheDJ) While playing with this, I suddenly become aware again of the fact that the Linker is basic... [21:53:45] yuck linker... [21:57:26] Linker might be crazy inside, but it's nice and simple to use for simple things from the outside [21:57:28] unlike Parser! [22:00:37] Linker used to not be a mess of static crap [22:00:46] but arguably it made even less sense before [22:26:12] right... [22:26:54] and then we get to TablePager, which also just concats strings... [22:30:15] 6Multimedia, 10MediaWiki-File-management, 10TimedMediaHandler, 10Wikimedia-Video, 7Technical-Debt: Improve interface for MediaHandlers to add JavaScript - https://phabricator.wikimedia.org/T60478#1763930 (10TheDJ) This same problem also exists in TablePager [22:32:04] thedj: TablePager has a getBodyOutput() method which returns a ParserOutput object with the required modules associated [22:32:18] (i happen to know this because i wrote it) [22:32:35] (the ParserOutput does not actually come from the Parser, but who cares) [22:34:27] (03CR) 10Paladox: Add extensions.json, empty PHP entry point (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210176 (https://phabricator.wikimedia.org/T87981) (owner: 10Paladox) [22:36:20] Maybe we need a new interface CanEmitModules, for things that have a function to emit various module type things, and anything that implements that could be passed to some method of outputPage (or ParserOutput) [22:40:13] MatmaRex: it 'fills' a parseroutput [22:40:22] with an html string. [22:40:42] but that's basically too late, since my fragment is a small part of that html string [22:41:31] fixable, but not tonight :) [22:42:16] huh. My debug log makes it look like vips is sharpening the image before shrinking it, not after. That doesn't sound right [22:43:27] no it is. otherwise the aliasing affects of the shrinking will soften out everything [22:43:43] and you can't recover the detail from that [22:44:54] I wonder if it will run into the max temp filesize limit when doing that to large tiffs [22:45:29] Also, it seems to be sharpening even when I disable sharpening [22:47:35] oh, there's a convolution step both before and after. I get it [22:50:13] never mind, there was uncomitted changes in my repo from like a year ago [22:50:18] * bawolff was confusing himself [22:54:20] thedj: The sharpen step is indeed after the shrink step. So if that's wrong, we're doing it wrong [22:58:03] Maybe we need a new interface CanEmitModules, <-- yes [23:00:03] 6Multimedia, 10MediaWiki-File-management, 10TimedMediaHandler, 10Wikimedia-Video, and 2 others: Improve interface for MediaHandlers to add JavaScript - https://phabricator.wikimedia.org/T60478#1764156 (10TheDJ) > legoktm: Maybe we need a new interface CanEmitModules [23:00:29] er, bawolff said that [23:00:51] ah, you edited :) [23:01:24] If you take credit, there's no way for me to be tricked into actually implementing that, so its all good ;) [23:19:25] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): MediaViewer intermittent image loading errors (2015 Oct) - https://phabricator.wikimedia.org/T115563#1764260 (10Krinkle) Still happening frequently, also at wikitech, e.g. 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): MediaViewer intermittent image loading errors (2015 Oct) - https://phabricator.wikimedia.org/T115563#1764292 (10Tgr) @Krinkle that's probably unrelated. What configuration does wikitech... [23:41:32] (03CR) 10Gergő Tisza: [C: 032] Improve the spelling of multimediaviewer-errorreport-privacywarning [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/249449 (owner: 10Amire80) [23:45:38] 6Multimedia, 10MediaWiki-extensions-VipsScaler: vips not rendering some tiffs properly to png - https://phabricator.wikimedia.org/T116947#1764339 (10Bawolff) vips im_clip2fmt in.v out.png 2 seems to fix issue. [23:46:39] (03Merged) 10jenkins-bot: Improve the spelling of multimediaviewer-errorreport-privacywarning [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/249449 (owner: 10Amire80)