[00:20:57] (03PS1) 10Jforrester: .gitignore: Add vendor/ and composer.lock [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247487 [00:20:59] (03PS1) 10Jforrester: build: Upgrade jscs from v1.8.0 to v2.1.0 but disable failing rules [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247488 [00:21:01] (03PS1) 10Jforrester: build: Re-enable all whitesapce-related jscs rules and fix them [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247489 [00:22:03] (03CR) 10Legoktm: [C: 032] .gitignore: Add vendor/ and composer.lock [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247487 (owner: 10Jforrester) [00:22:04] (03CR) 10Legoktm: [C: 032] .gitignore: Add vendor/ and composer.lock [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247487 (owner: 10Jforrester) [00:22:06] (03CR) 10Jforrester: "In Ib1eccc2852 I show the easier way of fixing this, by disabling the failing rules at first and then enabling rules a few at a time in su" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/244891 (owner: 10Paladox) [00:22:07] (03CR) 10Jforrester: "In Ib1eccc2852 I show the easier way of fixing this, by disabling the failing rules at first and then enabling rules a few at a time in su" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/244891 (owner: 10Paladox) [00:22:16] Thanks legoktm. :-) [00:23:28] (03Merged) 10jenkins-bot: .gitignore: Add vendor/ and composer.lock [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247487 (owner: 10Jforrester) [01:24:12] 6Multimedia, 10MediaWiki-Uploading: Why must stashed files belong to users? - https://phabricator.wikimedia.org/T115822#1737232 (10Tgr) >>! In T115822#1733615, @matmarex wrote: > Special:Upload shouldn't try stashing files when you're anonymous, I guess. Does it even work (when you are logged in)? The purpos... [05:01:09] 6Multimedia, 10MediaWiki-General-or-Unknown, 7Design: Make it easier to select today in mw.widgets.DateInputWidget - https://phabricator.wikimedia.org/T115863#1737318 (10Prtksxna) >>! In T115863#1735973, @matmarex wrote: > M53 has some ideas which I've never gotten 'round to implementing (and, to be honest,... [05:02:09] 6Multimedia, 10MediaWiki-General-or-Unknown, 7Design: Make it easier to select today in mw.widgets.DateInputWidget - https://phabricator.wikimedia.org/T115863#1737319 (10Prtksxna) In the context of improving `mw.ForeignStructuredUpload.BookletLayout` we could use the `lastModifiedDate` of the file to pre-fil... [07:20:29] 6Multimedia, 10MediaWiki-Uploading: Why must stashed files belong to users? - https://phabricator.wikimedia.org/T115822#1737396 (10Reedy) Yeah, it seemed to be working with the PDF from T115813. I think it failed, as the pdf was taking a long time to process, and when I went back to the tab, it'd lost session... [07:24:38] I never understand how VE is doing most of the things that it does :\ [09:07:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [09:21:17] 6Multimedia, 10MediaWiki-General-or-Unknown, 6WMF-Legal, 7Design: Figure out if the description of the image can be used as the caption on-wiki - https://phabricator.wikimedia.org/T115864#1737610 (10Esanders) The main issue I had with this is that often the description is not suitable as a caption. Either... [09:21:51] 6Multimedia, 10VisualEditor, 7Design: Insert image in content after it's uploaded - https://phabricator.wikimedia.org/T115865#1737611 (10Esanders) [09:23:45] 6Multimedia, 10VisualEditor, 7Design: Insert image in content after it's uploaded - https://phabricator.wikimedia.org/T115865#1734858 (10Esanders) Removed "use image description as caption" as that is a matter for the parent bug. I agree we shouldn't have the image metadata page, but currently the upload fl... [09:24:44] 6Multimedia, 10MediaWiki-General-or-Unknown, 6WMF-Legal, 7Design: Figure out if the description of the image can be used as the caption on-wiki - https://phabricator.wikimedia.org/T115864#1737615 (10Esanders) To avoid taking the user to the advance image settings page we could incorporate the caption field... [09:32:46] 6Multimedia, 10MediaWiki-General-or-Unknown, 6WMF-Legal, 7Design: Figure out if the description of the image can be used as the caption on-wiki - https://phabricator.wikimedia.org/T115864#1737648 (10Esanders) [09:35:18] 6Multimedia, 10VisualEditor, 7Design: Insert image in content after it's uploaded - https://phabricator.wikimedia.org/T115865#1737654 (10Esanders) [09:40:28] 6Multimedia, 10VisualEditor, 7Design: Insert image in content after it's uploaded - https://phabricator.wikimedia.org/T115865#1737696 (10Esanders) So I've marked this as blocked by T53032 but our case is slightly simpler because we're dealing with a new image so we know the description won't contain a bunch... [10:47:31] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer: MediaViewer intermittent image loading errors (2015 Oct) - https://phabricator.wikimedia.org/T115563#1737772 (10Aklapper) [11:02:00] 6Multimedia, 6Commons, 10MediaWiki-Uploading: 413 Request Entity Too Large error when uploading new version of file on Commons - https://phabricator.wikimedia.org/T115984#1737829 (10Aklapper) I'm afraid that's "expected" though the error message could be way more descriptive. Only 100 MB uploads are supporte... [11:02:22] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Cryptic "413 Request Entity Too Large" error when uploading new version of >100MB file on Commons - https://phabricator.wikimedia.org/T115984#1737832 (10Aklapper) p:5High>3Triage [11:03:12] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Cryptic "413 Request Entity Too Large" error when uploading new version of >100MB file on Commons - https://phabricator.wikimedia.org/T115984#1737837 (10Aklapper) [[ https://www.mediawiki.org/wiki/Phabricator/Project_management#Setting_task_priorities | Resetting... [11:45:01] (03CR) 10Bartosz Dziewoński: [C: 032] build: Upgrade jscs from v1.8.0 to v2.1.0 but disable failing rules [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247488 (owner: 10Jforrester) [11:46:07] (03Merged) 10jenkins-bot: build: Upgrade jscs from v1.8.0 to v2.1.0 but disable failing rules [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247488 (owner: 10Jforrester) [12:09:03] (03PS1) 10TheDJ: Do not throw errors on audio-only MP4 files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247548 (https://phabricator.wikimedia.org/T115197) [13:08:45] 6Multimedia, 10MediaWiki-General-or-Unknown, 7Design: Make it easier to select today in mw.widgets.DateInputWidget - https://phabricator.wikimedia.org/T115863#1738056 (10Pginer-WMF) >>! In T115863#1737319, @Prtksxna wrote: > In the context of improving `mw.ForeignStructuredUpload.BookletLayout` we could use... [13:20:01] 6Multimedia, 10UploadWizard, 7Easy: Clarify wording in dialog about unsupported file types which mentions Firefox and Firefogg - https://phabricator.wikimedia.org/T116003#1738075 (10Aklapper) [13:20:43] 6Multimedia, 10UploadWizard, 7Easy: Clarify wording in dialog about unsupported file types which mentions Firefox and Firefogg - https://phabricator.wikimedia.org/T116003#1738081 (10Aklapper) [13:25:25] 6Multimedia, 10MediaWiki-General-or-Unknown, 7Design: Make it easier to select today in mw.widgets.DateInputWidget - https://phabricator.wikimedia.org/T115863#1738084 (10Prtksxna) >>! In T115863#1738056, @Pginer-WMF wrote: > That is definitely a good idea. In essence my proposal was about facilitate the date... [13:26:01] 6Multimedia, 10MediaWiki-General-or-Unknown, 7Design: mw.ForeignStructuredUpload.BookletLayout's DateInputWidget should have better default value - https://phabricator.wikimedia.org/T115863#1738085 (10Prtksxna) [13:27:03] 6Multimedia, 10UploadWizard, 7Easy: Clarify wording in dialog about unsupported file types which mentions Firefox and Firefogg - https://phabricator.wikimedia.org/T116003#1738093 (10Vatadoshu) [13:28:52] 6Multimedia, 10UploadWizard: Upload of PDF file fails with "" and "Failed to load resource: the server responded with a status of 503 (Service Unavailable)" - https://phabricator.wikimedia.org/T116004#1738098 (10KartikMistry) 3NEW [13:38:12] 6Multimedia, 10UploadWizard: Upload of PDF file fails with "" and "Failed to load resource: the server responded with a status of 503 (Service Unavailable)" - https://phabricator.wikimedia.org/T116004#1738114 (10Aklapper) What's the file size? [13:50:07] MatmaRex: Mind taking a look at https://gerrit.wikimedia.org/r/#/c/247563 [13:50:25] Just want to confirm that this is the right way to go about it [13:51:25] ha, that was quick. let's look [13:52:28] 6Multimedia, 10UploadWizard: Upload of PDF file fails with "" and "Failed to load resource: the server responded with a status of 503 (Service Unavailable)" - https://phabricator.wikimedia.org/T116004#1738139 (10KartikMistry) @Aklapper 60M [13:52:33] MatmaRex: Also,http://i.imgur.com/9AzJ3Lc.png, OUCH! [13:56:25] (っ˘ڡ˘ς) MatmaRex I'll brb - dinner [13:57:14] aight [14:01:36] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Cryptic "413 Request Entity Too Large" error when uploading new version of >100MB file on Commons - https://phabricator.wikimedia.org/T115984#1738166 (10Mrjohncummings) Is there a way around this issue? A way to overwrite the file without using the 'Upload a new... [14:03:33] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Cryptic "413 Request Entity Too Large" error when uploading new version of >100MB file on Commons - https://phabricator.wikimedia.org/T115984#1738177 (10Aklapper) >>! In T115984#1738166, @Mrjohncummings wrote: > Is there a way around this issue? https://commons.... [14:21:53] * marktraceur waves [14:37:11] o/ [14:37:47] pginer: Do I need to do any prep for today's design meeting? Or should I just show the current workflow, and point everyone to the tracking task? [14:50:26] The jQuery > OOjs > jQuery dialog switch looks ugly [14:50:57] James_F|Away: Can we have "Migrate WE to OOjs UI" as a quarterly goal too :P [15:02:50] 6Multimedia, 10MediaWiki-General-or-Unknown, 7Design, 5Patch-For-Review: mw.ForeignStructuredUpload.BookletLayout's DateInputWidget should have better default value - https://phabricator.wikimedia.org/T115863#1738428 (10Prtksxna) a:3Prtksxna [15:09:08] prtksxna: No. [15:09:33] prtksxna: But Krenair is working on using OOUI in WE right now too, so you two should chat. :-) [15:10:03] umm, not exactly [15:31:07] MatmaRex: Joining us? [15:31:20] argh, yes [15:43:33] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Cryptic "413 Request Entity Too Large" error when uploading new version of >100MB file on Commons - https://phabricator.wikimedia.org/T115984#1738627 (10Bawolff) >Only 100 MB uploads are supported There's a bug on Special:Upload where the wrong limit is displaye... [15:44:09] 6Multimedia, 10VisualEditor, 7Design, 5Patch-For-Review: Add hover state to VE when image file in being dragged onto in for uploading - https://phabricator.wikimedia.org/T115859#1738633 (10Esanders) The above patch uses the branch node drop markers we use when dragging images around internally. We can add... [15:55:36] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Cryptic "413 Request Entity Too Large" error when uploading new version of >100MB file on Commons - https://phabricator.wikimedia.org/T115984#1738662 (10Mrjohncummings) Hi Bawolff Thanks so much for a solution, it took 1 minute to set up and worked perfectly :)... [16:50:36] Unable to access phabricator and etherpad while tethering :\ [17:24:01] 6Multimedia, 10MediaWiki-General-or-Unknown, 7Design: Surface both search and upload in a better way (not tabs maybe) - https://phabricator.wikimedia.org/T116044#1739078 (10Prtksxna) 3NEW a:3Nirzar [17:31:17] 6Multimedia, 10UploadWizard: Tooltip messages about non-existent categories in category selector in UploadWizard can get "stuck on" sometimes - https://phabricator.wikimedia.org/T115636#1739152 (10matmarex) a:3matmarex [17:53:57] Grrr node get your shit together [17:54:42] I just came full circle from the express docs, which say "you need to use bodyParser", then to the body-parser docs which say "you should use formidable" to the formidable docs which say "this is already built in to express" [17:54:46] WHO IS LYING [17:54:49] WHO [17:55:26] I guess in express 3.x it was integrated [17:55:33] I hate people who write documentation [18:01:18] (03CR) 10Brion VIBBER: Do not throw errors on audio-only MP4 files (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247548 (https://phabricator.wikimedia.org/T115197) (owner: 10TheDJ) [18:16:40] (03CR) 10Brion VIBBER: [C: 032] "lgtm!" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/196883 (owner: 10TheDJ) [18:19:23] (03Merged) 10jenkins-bot: Improve TMH styling [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/196883 (owner: 10TheDJ) [18:36:46] (03CR) 1020after4: "This is a big chunk to review and gerrit is not friendly, so this might take a while" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247294 (owner: 10Paladox) [18:44:57] (03CR) 10Paladox: "Ok." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247294 (owner: 10Paladox) [18:48:03] (03PS7) 10Paladox: Add php code sniffer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247294 [18:48:23] (03CR) 10Paladox: "Rebased." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247294 (owner: 10Paladox) [18:49:20] (03PS8) 10Paladox: Add php code sniffer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247294 [18:53:13] marktraceur: wanna merge some stuff? https://gerrit.wikimedia.org/r/243985 https://gerrit.wikimedia.org/r/246233 https://gerrit.wikimedia.org/r/246234 [18:53:19] Ooh I love merging stuff [18:55:25] (03CR) 10MarkTraceur: [C: 032] Do not double-escape help tooltips (hints) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/243985 (https://phabricator.wikimedia.org/T113615) (owner: 10Bartosz Dziewoński) [18:55:27] (03CR) 10jenkins-bot: [V: 04-1] Do not double-escape help tooltips (hints) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/243985 (https://phabricator.wikimedia.org/T113615) (owner: 10Bartosz Dziewoński) [18:55:34] .escape() is the bane of my life [18:55:35] Wait what [18:55:53] Useless tests? [18:56:03] Rebase. [18:56:20] 6Multimedia, 10MediaWiki-Uploading, 10VisualEditor: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1739678 (10awight) 3NEW [18:56:53] (03CR) 10MarkTraceur: [C: 032] Use $().text() when we want text [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/246233 (owner: 10Bartosz Dziewoński) [18:56:53] 6Multimedia, 10MediaWiki-Uploading, 10VisualEditor: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1739687 (10awight) [18:57:27] grr [18:58:12] (03Merged) 10jenkins-bot: Use $().text() when we want text [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/246233 (owner: 10Bartosz Dziewoński) [18:58:26] 6Multimedia, 10MediaWiki-Uploading, 10VisualEditor: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1739692 (10awight) Trying another time, I get the first error, then a second one: > Error: Filename not included in file data. Also, here's a stack trace from the fir... [18:58:41] (03PS2) 10Bartosz Dziewoński: Do not double-escape help tooltips (hints) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/243985 (https://phabricator.wikimedia.org/T113615) [18:58:52] (03CR) 10MarkTraceur: [C: 032] "Can't believe I never saw this. Augh." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/246234 (owner: 10Bartosz Dziewoński) [18:58:59] (03CR) 1020after4: [C: 031] "I have some nitpicky concerns, but overall it's mostly white-space changes. I don't have any strong objections." (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247294 (owner: 10Paladox) [18:59:35] (03CR) 10MarkTraceur: [C: 032] Do not double-escape help tooltips (hints) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/243985 (https://phabricator.wikimedia.org/T113615) (owner: 10Bartosz Dziewoński) [18:59:50] (03CR) 1020after4: Add php code sniffer (037 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247294 (owner: 10Paladox) [18:59:52] Good stuff [19:00:07] (03Merged) 10jenkins-bot: Don't create DOM nodes only to get their HTML [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/246234 (owner: 10Bartosz Dziewoński) [19:01:01] (03Merged) 10jenkins-bot: Do not double-escape help tooltips (hints) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/243985 (https://phabricator.wikimedia.org/T113615) (owner: 10Bartosz Dziewoński) [19:01:15] (03PS2) 10Bartosz Dziewoński: build: Re-enable all whitespace-related jscs rules and fix them [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247489 (owner: 10Jforrester) [19:01:18] (03CR) 10jenkins-bot: [V: 04-1] build: Re-enable all whitespace-related jscs rules and fix them [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247489 (owner: 10Jforrester) [19:03:32] (03PS3) 10Bartosz Dziewoński: build: Re-enable all whitespace-related jscs rules and fix them [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247489 (owner: 10Jforrester) [19:05:06] (03CR) 10Bartosz Dziewoński: [C: 032] build: Re-enable all whitespace-related jscs rules and fix them [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247489 (owner: 10Jforrester) [19:06:28] (03Merged) 10jenkins-bot: build: Re-enable all whitespace-related jscs rules and fix them [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247489 (owner: 10Jforrester) [19:07:04] 6Multimedia, 6Commons, 10MediaWiki-Categories, 10VisualEditor: Local categories rather than Commons's are prompted in the upload media dialog - https://phabricator.wikimedia.org/T116075#1739739 (10Jdforrester-WMF) p:5Triage>3Normal a:3Prtksxna [19:07:21] 6Multimedia, 6Commons, 10MediaWiki-Categories, 10VisualEditor: Local categories rather than Commons's are prompted in the upload media dialog - https://phabricator.wikimedia.org/T116075#1739747 (10Whatamidoing-WMF) https://www.mediawiki.org/wiki/Category:Mediawiki_Manual is a local category. [19:07:42] 6Multimedia, 10MediaWiki-Uploading, 10VisualEditor: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1739750 (10Jdforrester-WMF) 5Open>3Invalid a:3Jdforrester-WMF Gadget bugs aren't tracked in Phab. [19:08:36] (03PS33) 10Bartosz Dziewoński: Update grunt-jscs to version 2.1.0 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/244891 (owner: 10Paladox) [19:09:13] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1739756 (10Jdforrester-WMF) p:5Triage>3Low [19:09:21] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1739763 (10Jdforrester-WMF) This'll need Legal to re-approve the text. [19:15:06] 6Multimedia, 10VisualEditor: "A file with name "$1" already exists in the shared file repository, and cannot be overwritten" shows up while trying to rename a file with single letter which is different from standard format - https://phabricator.wikimedia.org/T115946#1739815 (10Jdforrester-WMF) p:5Triage>3N... [19:15:37] (03PS34) 10Bartosz Dziewoński: Fix some JSCS errors [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/244891 (owner: 10Paladox) [19:15:39] 6Multimedia, 10VisualEditor: While uploading image, clicking on "Try again" allows renaming the filename, even though it previously complained about it - https://phabricator.wikimedia.org/T115944#1739826 (10Jdforrester-WMF) p:5Triage>3Low [19:16:18] (03CR) 10Bartosz Dziewoński: [C: 032] "I reviewed this and removed broken changes. Feel free to submit more corrections in separate patches (but test them, since the ones you tr" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/244891 (owner: 10Paladox) [19:17:05] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 7Design: Insert image in content immediately after it's uploaded, skipping the "General settings" step - https://phabricator.wikimedia.org/T115865#1739839 (10Jdforrester-WMF) [19:17:23] (03Merged) 10jenkins-bot: Fix some JSCS errors [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/244891 (owner: 10Paladox) [19:17:49] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Cannot select date from calendar inside Media upload dialog when the browser window is resized in a way that it overlaps with the calendar - https://phabricator.wikimedia.org/T115939#1739843 (10Jdforrester-WMF) p:5Triage>3Low [19:18:46] 6Multimedia, 10VisualEditor, 7Design, 5Patch-For-Review: Make it clear in VE (hover state?) when a media file is being dragged in that shows it will do something - https://phabricator.wikimedia.org/T115859#1739854 (10Jdforrester-WMF) p:5Triage>3Normal [19:19:44] (03PS1) 10TheDJ: iframe: Fix module position warning [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247640 [19:19:49] brion: ^^ [19:20:00] whee [19:20:31] found it when i dom inspected :) [19:25:18] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Tooltip in UploadWizard shows HTML entity number for apostrophe - https://phabricator.wikimedia.org/T113615#1739887 (10matmarex) 5Open>3Resolved This change will be deployed to Commons next week, on Wednesday, 28 October 2015, per https://www.mediawiki.org/... [19:25:38] brion: the style change... that's now going out on the same train as the loader changes right ? [19:26:10] (03CR) 10Paladox: "Ok sorry and thanks." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/244891 (owner: 10Paladox) [19:26:34] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: If the user Saves an upload, but does not then insert it, reset the form correctly - https://phabricator.wikimedia.org/T115380#1739889 (10Jdforrester-WMF) p:5Triage>3Low [19:28:07] thedj: yep [19:28:47] (03CR) 10Brion VIBBER: [C: 032] iframe: Fix module position warning [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247640 (owner: 10TheDJ) [19:29:21] (03PS1) 10Bartosz Dziewoński: Remove erroneous spaces inside rather than outside strings [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247641 [19:29:44] thedj: looks like i'm going to meet with some folks at brightcove about videojs next weekish :D feel free to add things to ask them about on the task https://phabricator.wikimedia.org/T116064 [19:30:27] brion: yeah reedy already pinged me. see last comments of the video.js ticket [19:30:34] great [19:30:57] brion: I'm poking Phil to see if he's a Wikipedia or similar account so he can subscribe to the ticket :P [19:31:05] ah thx [19:31:28] (03Merged) 10jenkins-bot: iframe: Fix module position warning [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247640 (owner: 10TheDJ) [19:32:29] brion: hmm, maybe we should set something up with them around the dev summit as well. [19:33:05] *nod* [19:33:19] i'll be in SF for a week for sure, so a hack day meetup or something might be interesting [19:33:27] \o/ [19:34:17] I actually know 2 people at BC now [19:34:20] One based in London though [19:39:56] (03CR) 10Paladox: Add php code sniffer (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247294 (owner: 10Paladox) [19:46:03] (03PS9) 10Paladox: Add php code sniffer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247294 [19:46:26] (03CR) 10Paladox: "Ok done. And thanks for reviewing it." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247294 (owner: 10Paladox) [19:46:33] om nom nom [19:46:39] lunchtimes, bbl [19:56:55] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer: MediaViewer intermittent image loading errors (2015 Oct) - https://phabricator.wikimedia.org/T115563#1739975 (10Aklapper) [20:00:35] (03CR) 10Jforrester: [C: 032] Remove erroneous spaces inside rather than outside strings [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247641 (owner: 10Bartosz Dziewoński) [20:01:41] (03Merged) 10jenkins-bot: Remove erroneous spaces inside rather than outside strings [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247641 (owner: 10Bartosz Dziewoński) [21:01:51] 6Multimedia, 6Commons, 10MediaWiki-extensions-WikimediaEvents, 10Wikimedia-General-or-Unknown, and 4 others: Add a change Tag to media uploaded through the cross-wiki upload tool - https://phabricator.wikimedia.org/T115328#1740145 (10matmarex) 5Resolved>3Open Turned out that this did not quite work bec... [21:04:12] 6Multimedia, 6Commons, 10MediaWiki-extensions-WikimediaEvents, 10Wikimedia-General-or-Unknown, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Add a change Tag to media uploaded to Commons through the cross-wiki upload tool - https://phabricator.wikimedia.org/T115328#1740157 (10matmarex) [21:12:23] (03PS37) 10Paladox: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [21:12:55] (03CR) 10Paladox: "Rebased since it showed can merge as no." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [21:14:56] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [21:16:53] (03PS38) 10Paladox: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [21:18:39] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [21:18:50] (03PS39) 10Paladox: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [21:20:21] (03CR) 10Paladox: "Removed loading MwEmbedModules folder, I think it was causing the test to fail. I will revert if the test still fail, But should have been" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [21:20:57] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 7Verified-in-Phase0, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Switching between "Upload" and "Search" tabs in the upload dialog clears state of the upload form - https://phabricator.wikimedia.org/T115059#1740171 (10Ryasmeen) [21:21:17] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1740173 (10matmarex) Eh, why? Legal only approved the legalese, not all the other text. We could just change "under a different license" to... [21:22:50] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Give guidance in the new upload form, to prevent the most common errors - e.g. bad file titles - https://phabricator.wikimedia.org/T116086#1740176 (10Quiddity) 3NEW [21:22:53] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1740183 (10matmarex) p:5Low>3High I don't think this is low priority, it's a pretty glaring mistake we have somehow all overlooked. I th... [21:23:06] (03CR) 10Paladox: "Test passes please revert if I should not have removed it, But it shoulden have load that folder since we are switching to videojs." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [21:25:51] 6Multimedia, 10VisualEditor, 5MW-1.26-release, 5Patch-For-Review, and 3 others: The drop down for categories in Upload image dialog opens too slowly, even sometimes after moving to the next field - https://phabricator.wikimedia.org/T114945#1740188 (10Ryasmeen) [21:27:16] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5MW-1.26-release, and 3 others: Trying to upload image under blacklisted title in the upload image dialog throws error "" - https://phabricator.wikimedia.org/T114940#1740191 (10Ryasmeen) [21:29:10] 6Multimedia, 10MediaWiki-Uploading, 10VisualEditor: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1740195 (10matmarex) 5Invalid>3Open If you got "Error: Filename not included in file data.", then that's not from the gadget, but from our code. Can you still rep... [21:29:51] 6Multimedia, 10VisualEditor, 5MW-1.26-release, 7Verified-in-Phase0, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Previously added Categories and Date value for another image remains selected while trying to upload a new image - https://phabricator.wikimedia.org/T114947#1740197 (10Ryasmeen) [21:30:31] 6Multimedia, 10VisualEditor, 5MW-1.26-release, 7Verified, and 2 others: The checkbox for "This is my own work" remains selected for the next time user tries to upload an image - https://phabricator.wikimedia.org/T114936#1740199 (10Ryasmeen) [21:34:05] 6Multimedia, 10VisualEditor, 5MW-1.26-release, 7Verified, and 2 others: The date-picker in Upload image dialog does not close after selecting a date, requires clicking somewhere else to close it - https://phabricator.wikimedia.org/T114942#1740207 (10Ryasmeen) [21:44:51] 6Multimedia, 10MediaWiki-Uploading, 10VisualEditor: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1740228 (10matmarex) Hmm… any chance that your file was last modified on Thursday, 1 January 1970, or that Firefox would think so? [21:52:53] (03PS1) 10Jforrester: build: Enable three more minor jscs rules [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247733 [21:52:55] (03PS1) 10Jforrester: build: Enable jscs rule 'requireVarDeclFirst' and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247734 [21:52:57] (03PS1) 10Jforrester: build: Enable jscs-jsdoc's 'checkAnnotations' rule and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247735 [21:52:59] (03PS1) 10Jforrester: build: Enable jscs-jsdoc's 'requireReturnTypes' rule and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247736 [21:53:01] (03PS1) 10Jforrester: build: Enable jscs-jsdoc's 'requireParamTypes' rule and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247737 [21:53:03] (03PS1) 10Jforrester: build: Enable jscs-jsdoc's 'requireNewlineAfterDescription' rule and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247738 [21:53:05] (03PS1) 10Jforrester: Enable jscs-jsdoc's remaining rules and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247739 [21:56:38] 6Multimedia, 10MediaWiki-Uploading, 10VisualEditor: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1740277 (10matmarex) a:5Jdforrester-WMF>3matmarex [21:59:38] (03CR) 10Bartosz Dziewoński: [C: 04-1] build: Enable three more minor jscs rules (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247733 (owner: 10Jforrester) [22:00:49] MatmaRex: You're no fun. [22:01:01] i'm horrible. [22:01:16] MatmaRex: You're also wrong. [22:01:18] I think. [22:01:24] var newstr = ( +m2 + i + 1 ) + ''; [22:01:33] Take the numbers m2, i and 1, sum them. [22:01:37] Then convert to a string. [22:01:55] var newstr = String( m2 + i + 1 ); [22:02:07] Take the items m2, i and 1, sum them. [22:02:10] Then convert to a string. [22:02:12] ? [22:02:23] James_F: but m2 is a string there. [22:02:38] Sure, but +1 on it converts it to a number before stringification, right? [22:03:03] Also, why did you start in the middle of the stack? :-) [22:03:09] Oh, wait, it isn't. [22:03:11] Ignore me. [22:04:36] James_F: i started with that one because it said "minor" ;) [22:05:41] (03PS2) 10Jforrester: build: Enable three more minor jscs rules [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247733 [22:05:47] * James_F grins. [22:06:00] 6Multimedia, 6Commons, 10MediaWiki-Categories, 10VisualEditor: Local categories rather than Commons's are prompted in the upload media dialog - https://phabricator.wikimedia.org/T116075#1740309 (10matmarex) a:5Prtksxna>3matmarex Woooow this is incredibly super stupid. @prtksxna is probably not around... [22:06:08] 6Multimedia, 6Commons, 10MediaWiki-Categories, 10VisualEditor: Local categories rather than Commons's are prompted in the upload media dialog - https://phabricator.wikimedia.org/T116075#1740311 (10matmarex) p:5Normal>3High [22:06:56] MatmaRex: Merge all my things! Don't focus on user-damaging bugs! ;-) [22:07:07] i can do both! [22:07:31] * James_F laughs. [22:07:43] Merge https://gerrit.wikimedia.org/r/247733 and I'll rebase the stack. [22:08:22] James_F: heh, for a second i thought the second change in https://gerrit.wikimedia.org/r/#/c/247733/2/resources/mw.UploadWizardDetails.js,cm is also not okay [22:08:27] it changes the logic slightly [22:08:30] but the result is the same [22:08:42] It does, but I did so intentionally. [22:09:20] (03CR) 10Bartosz Dziewoński: [C: 032] build: Enable three more minor jscs rules [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247733 (owner: 10Jforrester) [22:10:27] (03Merged) 10jenkins-bot: build: Enable three more minor jscs rules [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247733 (owner: 10Jforrester) [22:10:42] Woo. [22:12:32] (03PS2) 10Jforrester: Enable jscs-jsdoc's remaining rules and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247739 [22:12:34] (03PS2) 10Jforrester: build: Enable jscs-jsdoc's 'requireNewlineAfterDescription' rule and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247738 [22:12:36] (03PS2) 10Jforrester: build: Enable jscs-jsdoc's 'requireParamTypes' rule and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247737 [22:12:38] (03PS2) 10Jforrester: build: Enable jscs-jsdoc's 'requireReturnTypes' rule and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247736 [22:12:40] (03PS2) 10Jforrester: build: Enable jscs-jsdoc's 'checkAnnotations' rule and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247735 [22:12:42] (03PS2) 10Jforrester: build: Enable jscs rule 'requireVarDeclFirst' and make pass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/247734 [22:16:58] 6Multimedia, 10MediaWiki-Uploading, 10VisualEditor: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1740364 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Low [22:31:01] James_F: do you think we could resolve https://phabricator.wikimedia.org/T116046 before tomorrow's deployment? which way would you prefer? [22:34:01] MatmaRex: I like the re-arrangement. [22:34:09] (03PS1) 10Brion VIBBER: Work in progress support for .m4a audio-only files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247750 (https://phabricator.wikimedia.org/T116094) [22:34:33] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1740422 (10Jdforrester-WMF) Re-arrangement means no need to re-validate it with Legal, so +1. [22:35:47] James_F: it gets kind of heavy. but i think prateek and pau have some task already about the first step in that dialog, so they can figure it out later. [22:35:52] text-heavy* [22:36:19] Sure, but eh [22:39:25] (03CR) 10Brion VIBBER: [C: 032] "lgtm; further mp4 audio file work elsewhere (see T116094)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247548 (https://phabricator.wikimedia.org/T115197) (owner: 10TheDJ) [22:42:04] (03Merged) 10jenkins-bot: Do not throw errors on audio-only MP4 files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/247548 (https://phabricator.wikimedia.org/T115197) (owner: 10TheDJ) [22:51:26] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1740496 (10Whatamidoing-WMF) Rearranging is totally fine with me. Naming the license would be fine with me. Even just a CC-BY-SA 4.0 icon... [22:52:07] MatmaRex: Adding the icon would be nice too if you feel up to it. :-) [22:53:25] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1740498 (10Whatamidoing-WMF) One more thought: Aren't the licenses different on some projects, e.g., Wikinews? Naming it in the text, e.... [22:53:38] MatmaRex: The basic CC icon is in OOUI. [22:53:45] James_F: oh? nice [22:53:48] James_F: probably tomorrow [22:54:12] Kk. [22:55:33] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1740504 (10Jdforrester-WMF) >>! In T116046#1740498, @Whatamidoing-WMF wrote: > One more thought: Aren't the licenses different on some proj...