[01:57:41] marktraceur: So, puzzler for you – how in JS does VE access a list of allowed MIME types and file extensions that are allowed on the 'target' wiki (i.e., Commons)? [02:06:58] 6Multimedia, 5Patch-For-Review: Make filerepoinfo usable for uploading, rewrite ForeignUpload to use that - https://phabricator.wikimedia.org/T114765#1707688 (10Jdforrester-WMF) [02:07:00] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1707687 (10Jdforrester-WMF) [02:08:02] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#428525 (10Jdforrester-WMF) [02:09:53] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1707695 (10Jdforrester-WMF) VE's drop handler needs a list of allowed file extensions on the target remote wiki. You can get... [02:11:06] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1707698 (10Jdforrester-WMF) p:5Low>3High [09:13:53] (03PS13) 10Paladox: Move hooks from hooks file to Main php file [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/229470 [13:34:48] 6Multimedia, 10UploadWizard, 7Easy: "Remove" button for individual files in the upload step should be a OOjs UI button - https://phabricator.wikimedia.org/T114222#1708661 (10AbdealiJK) a:5TasneemLo>3None [14:08:42] G'morning team [14:08:51] Er, prtksxna [14:08:54] Good morning prtksxna. [14:09:14] Good evening marktraceur. [14:09:19] tzag! [14:19:16] James_F: marktraceur Do I need to attend the QR? Is it over BLUEJEANS this time? [14:22:07] 6Multimedia, 10MediaWiki-API, 10MediaWiki-File-management: API file deletion doesn't return the log id - https://phabricator.wikimedia.org/T114893#1708792 (10Anomie) 3NEW a:3Anomie [14:25:48] prtksxna: You don't (and I'd advise against unless you're incredibly bored), it is. [14:27:10] James_F: I had traded places with cscott(?) last time just to be able to attend the multimedia part last time. But I don't think I'll go through the process of installing blue jeans. [14:27:19] * James_F nods. [14:27:40] I'm assuming it's going to be run with BlueJeans, but now I think about it, I don't know for sure. [14:30:26] James_F: I assume I should be there, though. And I hope I don't need any setup for BlueJeans [14:30:37] marktraceur: Yes, and umm maybe? [14:30:53] I've only ever sat in a room with BlueJeans installed on a different device. [14:31:26] Hrm. [14:31:38] Want to do a test now? [14:31:41] I'll install too. [14:33:15] Oh. [14:33:16] Hmm. [14:33:23] Apparently I need an account to start a session. [14:33:30] And I can't create it for myself. [14:33:33] Useful [14:33:51] marktraceur: Never mind, then. :-( [14:39:20] The calendar entry has a hangouts link… [14:40:53] prtksxna: They all do. [14:41:07] Oh, right. [14:47:14] Remember the "all-staff mixer" that was held at Thirsty Bear and had a hangout? [14:47:21] Sorely disappointing. [15:02:38] Since when do we require stuff[ 0 ] instead of stuff[0] [15:02:42] jscs is bitching at me [15:02:52] marktraceur: A few months ago. [15:02:58] marktraceur: Which repo? [15:03:07] core. [15:04:12] marktraceur: Oh, yeah, I finally got that rule not-disabled there a few weeks ago. [15:04:14] marktraceur: Sorry. [15:08:15] No problem [15:08:20] Just didn't know we did that. [15:08:28] But now I do! [15:20:45] marktraceur: Also, we need to get https://gerrit.wikimedia.org/r/#/c/243993/ merged and the config written soon. :-) [15:22:41] I've been responding to stuff [15:22:54] We can demo it on beta commons if VE lives there [15:26:32] marktraceur: Argh. [15:26:40] marktraceur: Only if I remembered to set the config patch. [15:26:42] Whoops. [15:27:10] $wgRemoteUploadTarget needs to be set to 'wikimediacommons'? [15:28:54] James_F: No, I think 'shared' [15:29:02] Unless you're changing the name of the repo on beta too [15:29:22] Or just set it to 'local' on Commons and then we can demo it locally [15:29:46] http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&meta=filerepoinfo [15:30:18] wikimediacommons in that list is the real commons, 'shared' is betacommons [15:31:33] James_F: Meeting, or are you busy preparing [15:31:41] marktraceur: And private wikis should be 'default'? [15:31:47] marktraceur: Am busy writing a config patch. :-) [15:32:09] You don't need to set it for wikis that will upload to 'local' [15:32:27] So actually, no config required, set enwikibeta to 'shared' to demo it for commonsbeta [15:32:29] Isn't the default 'default'? [15:32:40] Not 'local'? [15:33:54] No, changed it [15:34:04] Not in master. [15:34:18] Which is running on the cluster, and will be in 24 minutes when we demo this. [15:34:58] Mrrr [15:36:07] $wgRemoteUploadTarget = 'commons.wikimedia.beta.wmflabs.org'; should work I believe [15:36:18] marktraceur: https://gerrit.wikimedia.org/r/244181 [15:36:52] Beta Commons won't insert itself as 'shared'? [15:37:30] James_F: Do we want to demo this in production or on beta? [15:37:48] marktraceur: Beta uses prod config unless you over-ride. [15:38:00] Also, your patch depends on my patch which is not merged and won't be in 22 minutes when we demo this [15:38:14] Well, half of it depends on my patch. [15:38:22] Which one? [15:38:41] Use 'default' not 'local'? [15:38:54] No, the array structure [15:39:06] It's a single string for the host until now [15:39:12] Yes. [15:39:17] Hence 'commons.wikimedia.beta.wmflabs.org' [15:39:26] It needs to be set to the URL? [15:39:30] OK. [15:39:32] Until my patch is merged yes. [15:39:41] And probably should put that in the beta config, not in prod. [15:39:45] Just a guess [15:39:46] Yeah. [15:39:47] That bit. [15:41:08] But I'm not sure if that config necessarily gets passed in to our code without the new patch... [15:41:15] Fixing. [15:41:15] The old system was a clusterfuck [15:41:18] Yeah. [15:41:34] Hopefully MatmaRex or prtksxna is staring at my code now and we can just use the new system. [15:41:41] marktraceur: Like https://gerrit.wikimedia.org/r/244181 ? [15:42:14] i am [15:42:34] Neato. [15:42:46] MatmaRex: No pressure. :-) [15:42:49] me too, not sure if I'll be much help though [15:42:59] We'll need the config live in mw-config (if only for Labs) to demo, though. [15:43:13] James_F: 'local' still won't work, but that's probably fine [15:43:20] marktraceur: OK. [15:43:22] Change to 'default' for the old system [15:43:35] Let me set up a patch for the new system too [15:44:01] Cool. [15:44:57] marktraceur: [17:43] anomie: hey, i'm planning to merge https://gerrit.wikimedia.org/r/#/c/243993/ in 5 minutes or so, do you see any reason not to? [15:44:58] marktraceur: [17:44] MatmaRex: There's still a discussion going on at https://gerrit.wikimedia.org/r/#/c/243993/2/includes/api/ApiQueryFileRepoInfo.php line 103. [15:45:47] marktraceur: If we're going to deploy https://gerrit.wikimedia.org/r/#/c/244181/ it's now or never… No pressure. :-) [15:45:54] marktraceur: hmm, can we undo that last change in this file? [15:47:15] MatmaRex: Yeah, pull that out [15:47:20] Or I can in a sec [15:50:52] marktraceur: i left one more comment on https://gerrit.wikimedia.org/r/243993 [15:51:36] Urgh [15:52:10] Fixed, pulled out the change to getProps [15:54:37] Oh, wait, herp [15:54:42] marktraceur: hmm. will the 'canUpload' be included in the props now? :/ [15:55:28] Fixed. [15:55:32] That was my 'herp' [15:55:52] marktraceur: Sadly it's GHang again. [15:56:02] Ah well [15:56:20] alright, let's ship it [15:56:30] Awesome. [15:56:40] it works for the 'local' case at least, i don't have multiple wikis set up locally to test [15:56:47] MatmaRex: We'll test it in beta. :) [15:56:49] so i really hope that works too [15:57:22] * prtksxna looks at IRC excitedly [16:06:51] 6Multimedia, 10Structured-Multimedia-Data, 10Wikidata: Finalize high-level API - https://phabricator.wikimedia.org/T585#1709202 (10hoo) [16:07:26] Argh [16:07:28] Code update [16:07:29] Hurry [16:08:12] James_F: We should be good. [16:08:36] We maybe need to delay the demo a few minutes. [16:28:29] prtksxna: you can join the hangout, btw [16:28:57] you're not losing much though… [16:32:29] MatmaRex: :) [16:38:23] Messages disappeared from en.wikipedia.beta.wmflabs.org? [16:39:46] Yeah, I have no idea why [16:47:40] OK...so now it works with debug=false [16:47:45] Messages are...sort of back [16:47:53] And it doesn't upload to commons beta [16:48:23] God damn it [16:51:30] Oh, because...yeah. [16:51:34] Got some defaults to play with. [16:53:36] If we had to demo from a local copy…https://www.youtube.com/watch?v=r-DMfaqOBb4&t=10 [17:02:56] https://www.youtube.com/watch?v=r-DMfaqOBb4&t=10 , even [17:42:50] 6Multimedia, 10MediaWiki-File-management, 10MobileFrontend, 7Performance: Explore lazy-loading WebP thumbnails to supporting browsers (eg Android Chrome) - https://phabricator.wikimedia.org/T114791#1709579 (10Jdlrobson) p:5Triage>3Normal [18:13:12] marktraceur: So… is https://phabricator.wikimedia.org/T114765 fixed? I see there was follow-up. :-) [18:21:32] Working on it... [18:21:47] Gonna test that my followup worked. [18:22:06] It's still using local for some reason. [18:22:38] did we end up deploying James_F's config patch? [18:23:05] No, we deployed mine [18:24:26] Did you re-write mine? [18:24:39] I wrote a different one [18:24:48] Ah, no. [18:24:51] Abandoned. [18:29:56] marktraceur: i should be able to upload from en.wikipedia.beta.wmflabs.org to commons.wikimedia.beta.wmflabs.org? [18:30:41] MatmaRex: Should be, but marktraceur said it wasn't working yet. [18:38:54] XMLHttpRequest cannot load https://commons.wikimedia.org/w/api.php?action=query&format=json&origin=http%3A%2F%2Fen%2Ewikipedia%2Ebeta%2Ewmflabs%2Eorg&meta=userinfo%7Ctokens. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'null' is therefore not allowed access. The response had HTTP status code 403. [18:38:54] load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=sQ8du77j:13225 mw.Api error: http Object {xhr: Object, textStatus: "error", exception: ""} [18:39:03] obviously it won't work if the wikis are not configured… [18:39:15] MatmaRex: … shouldn't be pointed at Commons. [18:39:16] oh wait [18:39:21] Beta Commons please. [18:39:26] why is that still prod commons, yes. [18:40:34] Especially for testing. [18:40:35] Oh! [18:40:57] marktraceur: Does the new tool tag uploads with a Tag? It should, so we can track it (and fix things that break). [18:41:45] marktraceur: (Tag not category, please.) [18:42:22] oh, i see the issue. [18:42:30] beta is STILL SERVING OLD CODE. [18:42:37] didn't i report that like a year ago? [18:43:00] https://integration.wikimedia.org/ci/view/Beta/ [18:43:02] How old? [18:43:04] i guess now is a great time to spend a couple of hours setting up a local testing environemtn for this [18:43:10] rather than fixing shit [18:43:24] James_F: too old [18:43:28] in debug mode, i mean [18:43:30] Code should be at worst 10 minutes old. [18:43:31] it's still broken [18:43:40] Well then, patience. [18:44:23] this is https://phabricator.wikimedia.org/T90983 [18:44:38] by "patience" you mean "check in a month, maybe it'll work then"? [18:48:02] i should've gotten used to this by now, eh [18:48:05] heyo, there's this commit that is spamming production and holding up the train: https://phabricator.wikimedia.org/rOMWCb15a5cba3d1a1a570dbc7ba8bb14578cda3f636f [18:48:19] can someone confirm if we can simply revert it? marktraceur isn't at the keyboard at the moment [18:48:49] greg-g: yes, you can revert it [18:49:31] greg-g: (i guess it should suffice to change `if ( $wmgForeignUploadTargets )` to `if ( isset( $wmgForeignUploadTargets ) )` ?) [18:49:56] I prefer reverts not fixing forward, in these situations, where the commiter is not around [18:50:17] :) [18:52:43] greg-g: Can revert, yes [18:52:48] Or add isset, trivial fix [18:53:13] I have a revert ready, but since mukunda hasn't responded yet, you have time [18:54:41] marktraceur: i'm debugging ForeignUpload, btw. [18:55:03] MatmaRex: It's gotta be a beta issue. [18:55:29] it's not [18:55:32] the code's broken [18:55:45] Really? How? [18:56:07] or i'm misunderstanding what it's trying to do [18:56:30] marktraceur: new mw.ForeignUpload() - that should just upload to the default shared repo, or locally if no shared repo is available? [18:56:36] Yup [18:56:41] But it's not? [18:56:50] I mean, I know it's not, I see it using local still [18:56:53] marktraceur: the `repo.name === upload.target` check will never pass because target is undefined [18:57:07] I thought I added it in. [18:57:31] Pretty sure I did. [18:59:05] i'll submit a patch [18:59:10] All right [19:00:44] marktraceur: and, what is the format of $wgForeignUploadTargets supposed to be? [19:01:05] MatmaRex: array( 'reponame' => true, 'otherreponame' => true ) [19:01:31] marktraceur: well, the code expects array( 'reponame', 'otherreponame' ). [19:01:45] it checks for .length and [0] and in_array(). [19:01:48] ...hm [19:01:58] That would certainly break it then [19:02:04] * marktraceur facepalms at self [19:02:28] i'll document the working format ;) [19:03:00] * James_F grins. [19:03:02] Both the JS and the PHP expect that? [19:03:03] Yay documentation. [19:03:08] yes [19:03:21] you actually even documented it that way [19:08:18] Of course I did, my scatterbrainedness knows no bounds [19:08:27] So config change? [19:08:34] marktraceur: hold on [19:08:47] i'm going through the code we touched today and finding bugs :P [19:09:12] marktraceur: releng reverted your config change, so that's one thing less for us to handle :P [19:13:58] 6Multimedia, 10MediaWiki-API, 10MediaWiki-File-management, 5MW-1.27-release-notes, and 2 others: API file deletion doesn't return the log id - https://phabricator.wikimedia.org/T114893#1709888 (10Anomie) 5Open>3Resolved [19:32:53] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1709956 (10Jdforrester-WMF) [19:32:55] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, and 3 others: Way in VisualEditor to initiate Commons file uploading, and insert image on completion - https://phabricator.wikimedia.org/T40030#1709955 (10Jdforrester-WMF) 5Open>3Resolved [19:46:51] whoooaaaoaoao, amazing, it worked. http://commons.wikimedia.beta.wmflabs.org/wiki/File:Matmarex-test-image.png [19:47:08] <3 [19:47:22] marktraceur: https://gerrit.wikimedia.org/r/244258 [19:47:27] So we can stop worrying for now? :) [19:48:21] marktraceur: after i confirm that it also still works locally :D [19:49:36] Heh, yeah [19:50:51] redspace issue [19:54:24] Lookin' good [19:54:31] Test on beta (again) and we'll see where we are [19:55:06] Looks like beta scap might be slowing down again... [19:55:28] it worked for me on beta (i have a local proxy set up so that i can serve JS files from master with any wiki) and locally too [19:56:34] marktraceur: to test on beta without such hacks, we'll still need the config patch again. [19:58:25] marktraceur: when we're sure it all works, i'll backport the whole shebang to 1.26, since that currently has a broken verison [20:00:12] Shouldn't the new version work using commons, the first remote repo? Oh, no, because it's not configured. Argh. [20:04:33] marktraceur: is anything remaining to do with https://phabricator.wikimedia.org/T114765 now? [20:04:40] marktraceur: also, can you do the config change? [20:07:19] +1. [20:16:48] Sure [20:16:53] MatmaRex: I think it's done. [20:17:26] 6Multimedia, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Make filerepoinfo usable for uploading, rewrite ForeignUpload to use that - https://phabricator.wikimedia.org/T114765#1710162 (10matmarex) 5Open>3Resolved [20:17:28] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1710163 (10matmarex) [20:17:41] Gosh. [20:20:47] let's finish this and i'm off for today [20:21:01] i see rummana filed a dozen tasks about the upload interface [20:21:14] guess what i'll be doing tomorrow [20:22:03] MatmaRex: Not sure I'll be able to deploy it now, though. Might need to send James_F to SWAT it. [20:22:11] Which he can do [20:22:44] Sure. [20:23:36] IN fact I see no reason not to have him do that [20:23:52] Especially since I have to leave in an hour [20:24:03] -ish [20:24:34] :-) [20:24:36] Does it work yet? [20:24:50] Including the no errors if we put your config in prod? [20:24:53] :-) [20:25:52] Yup [20:26:05] That was fixed with the last config change, so the config now just needs to be the correct structure [20:26:12] Should be no errors either way [20:31:23] Kk. [20:33:23] It's nice to know it'll be mostly sorted now. [20:35:26] :-) [20:37:22] marktraceur: Also, https://gerrit.wikimedia.org/r/244331 from edsanders means we'll have drag-and-drop too. [20:37:30] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1710267 (10Jdforrester-WMF) [20:41:17] Neat. [20:43:15] Works like a charm [20:43:17] I love it [20:43:25] I will never use it, but I love it. [20:55:20] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1710348 (10Jdforrester-WMF) [22:10:38] hola [22:13:29] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#1710817 (10Jdforrester-WMF) a:3Esanders [22:13:37] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, and 2 others: VisualEditor: Initiate file upload by drag-and-drop - https://phabricator.wikimedia.org/T40031#428525 (10Jdforrester-WMF)