[01:19:33] James_F: Ooh, I like green. [01:19:46] marktraceur: You like merging? :-) [01:19:52] Maybe. [01:19:54] Now is not the time [01:20:01] :-( [01:20:06] I have to set up VE to test it... [01:20:09] Today or not green. :-( [01:20:14] It's a single vagrant commant. [01:20:17] Err. Command. [01:20:18] I was about to say [01:20:23] You know my feelings about Vagrant. [01:20:32] That it's great? [01:20:35] Sure. [01:20:40] I can merge it early tomorrow. [01:20:58] That means no time to do final testing before the cut. But OK. [01:24:08] Testing on mw.org. [01:24:21] And I can test for however much time there is between merge and cut. [01:24:35] For now, I'm sitting here trying to figure out why the JS won't load. [01:25:48] marktraceur: :-) [01:26:31] Got it. [01:26:34] No CSS still. So weird. [01:26:40] Maybe Vector got deleted for some stupid reason [01:26:45] I blame ResourceLoader. [01:27:27] Probably [01:27:44] Fixed. [01:27:48] Silly Vector. [01:27:55] Not, Silly Mark? [01:33:11] Porque no los dos? [01:33:44] Anyway, it looks OK, can't test it locally for some reason, I thought someone said we could configure it for localhost [01:49:45] 6Multimedia, 10UploadWizard, 5Patch-For-Review, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1), 7user-notice: Upload from Flickr only fetches the first 50 items of a set - https://phabricator.wikimedia.org/T44979#1704356 (10Liuxinyu970226) [05:56:28] (03PS2) 10Florianschmidtwelzow: Use mediawiki.widgets.CategorySelector module for CategorySelector [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/243713 (https://phabricator.wikimedia.org/T108733) [08:35:35] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1704700 (10Aklapper) @555: Thanks for your comment. Tasks in Phabricator have a specific technical sc... [09:15:35] 6Multimedia, 10MediaWiki-General-or-Unknown, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Improve error handling UX in the mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T114130#1704778 (10Prtksxna) What is the reason for putting a `:` be... [10:19:18] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1704854 (10Aklapper) As the first file is 254MB, I enabled [[ https://commons.wikimedia.org/wiki/Speci... [11:56:22] 6Multimedia, 10UploadWizard, 7Easy: mwe-upwiz-tooltip-skiptutorial not parsed but shown in plain form - https://phabricator.wikimedia.org/T55540#1705089 (10matmarex) [11:57:23] 6Multimedia, 10MediaWiki-General-or-Unknown, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Improve error handling UX in the mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T114130#1705094 (10matmarex) [12:59:55] 6Multimedia, 10Wikimedia-General-or-Unknown: Implement International Image Interoperability Framework (IIIF) prototype service on Wikimedia labs - https://phabricator.wikimedia.org/T89552#1705345 (10Nemo_bis) >>! In T89552#1040458, @Tgr wrote: > IIPImage [[ http://iipimage.sourceforge.net/2014/12/iiif | claims... [14:57:10] Right [14:57:20] MatmaRex: Have you looked at the VE patch? Any thoughts? [14:57:39] I couldn't get it to do upload-to-localhost, but maybe I missed something [14:59:11] Holy shit it worked [14:59:23] This is some very dark magic. [15:00:31] hi marktraceur. i didn't yet, but i was going to [15:01:06] i see Krenair has posted some well-deserved criticism of the mw.Upload system [15:01:25] Where's that? [15:01:33] see your gerrit mail [15:01:54] only the script path bit is really ForeignUpload's fault, I think [15:02:04] Yeah, I saw that [15:02:18] I think that's pretty quick to fix [15:02:41] I don't think we should have a default target, by the way [15:03:00] Might require us to add objects to that $wgRemoteUploadTarget array...maybe not super-quick [15:03:08] Krenair: Oh? [15:03:37] callers should specify which to use, otherwise pick the first one on the list [15:03:51] not a hardcoded default in ForeignUpload [15:03:58] Hm. OK, sure, makes sense [15:04:11] But then you just push the decision to the callers [15:04:16] although I have a feeling you need to call the local API to get the list :/ [15:04:30] Worse, you need server-side config. [15:04:43] There's not really a system around uploading to another wiki, we're just building it now [15:05:07] you just need to reuse bits of the existing foreign file repository system don't you? [15:05:12] Mostly yes [15:05:26] But the FFRs aren't all API-based, whereas this must be [15:05:34] There's no API endpoint URL for shared DB FFRs [15:05:52] uhhh. [15:06:10] And here's where Krenair says "yes but why wouldn't you just have a local API endpoint for uploading to the foreign repositories" [15:06:21] no [15:07:26] https://en.wikipedia.org/w/api.php?action=query&meta=filerepoinfo&friprop=apiurl|name|displayname [15:07:58] apiurl not even allowed anymore, wonder why it's in the example... [15:08:57] https://meta.wikimedia.org/w/api.php?action=query&meta=filerepoinfo [15:09:01] I was just looking at this [15:09:13] You build the API url from scriptDirUrl [15:09:22] I think the docs for that module are outdated [15:09:31] Probably. [15:09:36] We wrote it for MMV, I think. [15:09:45] We use it in VE [15:10:40] Although it looks like that may be broken [15:12:09] Fantastic. [15:14:42] Looks like we missed our goals for the quarter, but ah well [15:14:59] I'll rewrite ForeignUpload et al. to use the filerepoinfo stuff [15:18:38] Actually I think it might not be broken, because we fall back to using scriptDirUrl [15:20:04] on my local wiki you can actually query friprop=apiurl as well [15:20:10] Weird. [15:20:20] Recent fix, maybe? [15:21:33] it's actually part of the default there [15:28:35] Which is weird because the default is constructed based on the values passed back by getinfo [15:30:27] it gets all info and sets the defaults to the fields that it knows about? [15:30:46] Yup [15:30:59] :/ [15:31:01] Silly, right? Why bother having friprop if the default is * [15:31:06] I don't know what I was thinking [15:31:19] That said, I have no better default on my brain. [15:31:38] Argh Krenair you made me late for the meeting [15:32:25] (03PS1) 10Devirk: Gender support added to Multimediaviewer-text-embed-credit-text-tbls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/243938 [15:34:41] 6Multimedia: Make filerepoinfo usable for uploading, rewrite ForeignUpload to use that - https://phabricator.wikimedia.org/T114765#1705637 (10MarkTraceur) 3NEW a:3MarkTraceur [15:35:46] Did we set $wgRemoteUploadTarget in any config files? Would it be terrible to change its name and structure so soon after merging? [15:38:01] I'm assuming it's fine. [15:38:09] now is probably the least bad time to do it [15:38:13] Yeah. [15:43:38] (03PS1) 10Prtksxna: i18n: Remove unused messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/243941 [15:46:16] Hmm, now I think about it, this probably should be loaded into JS config vars, not an API call [15:49:21] Ah, no, I'm just making things overly complex. [15:59:12] Krenair: I think I'm going to remove the "get all props then return all of them" stuff. I'll just take all the props and hard-code them for now. [15:59:28] cool [15:59:52] (03CR) 10Bartosz Dziewoński: [C: 032] i18n: Remove unused messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/243941 (owner: 10Prtksxna) [16:00:58] But "all" is still the default for now [16:01:22] (03Merged) 10jenkins-bot: i18n: Remove unused messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/243941 (owner: 10Prtksxna) [16:03:47] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1705704 (10Rillke) >>! In T94562#1704854, @Aklapper wrote: > Sigh, so much for trying to reproduce or... [16:12:15] (03CR) 10Jforrester: [C: 032] Use mediawiki.widgets.CategorySelector module for CategorySelector [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/243713 (https://phabricator.wikimedia.org/T108733) (owner: 10Florianschmidtwelzow) [16:15:06] Oh marktraceur, when will you learn [16:21:02] (03Merged) 10jenkins-bot: Use mediawiki.widgets.CategorySelector module for CategorySelector [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/243713 (https://phabricator.wikimedia.org/T108733) (owner: 10Florianschmidtwelzow) [16:30:27] I almost forgot about the bloody legal messages again. [16:30:36] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1705779 (103BRBS) Well, if that is the case, I think that someone more tech savy could run the code wr... [16:31:09] So now...we're setting the target in LocalSettings, or defaulting to the current wiki [16:31:40] marktraceur: Tsk. [16:31:40] And we have a legal message for "wikimediacommons" which isn't the name of the file repo [16:31:53] It's "shared" on the cluster [16:32:03] And we have a legal message for "default" which isn't the name of the local repo [16:32:09] It's "local", which is the new default [16:32:18] So I guess s/default/local/ fine [16:32:23] * James_F nods. [16:32:27] But s/wikimediacommons/shared/ is stupid [16:32:47] I feel like the answer honestly should be the other way around, applied to the settings on the cluster [16:33:32] Yeah. [16:33:35] Define in mw-config instead? [16:48:02] (03PS1) 10Paladox: Support vorbis in vp9 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/243951 [16:48:34] Yup [16:49:38] (03PS2) 10Prtksxna: Add link to alternative upload methods in #contentSub [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/226038 (https://phabricator.wikimedia.org/T104009) [16:51:03] 6Multimedia, 6Commons, 10UploadWizard, 5Patch-For-Review: Create uploadwizard-summary-footer - https://phabricator.wikimedia.org/T104009#1705834 (10Prtksxna) [17:12:07] (03CR) 10Gergő Tisza: [C: 04-1] "It doesn't make sense to replace the uploader name with "him"/"her". If you are trying to add gender support because it's needed by some n" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/243938 (owner: 10Devirk) [17:34:44] (03CR) 10Steinsplitter: [C: 031] "looks ok for me. (code not testes)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/226038 (https://phabricator.wikimedia.org/T104009) (owner: 10Prtksxna) [18:23:53] (03CR) 10Brion VIBBER: [C: 04-2] "Premise of this patch is false." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/243951 (owner: 10Paladox) [18:25:35] (03Abandoned) 10Paladox: Support vorbis in vp9 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/243951 (owner: 10Paladox) [18:27:25] (03CR) 10Paladox: "Would we have to do another vp9 option with vorbis" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/243951 (owner: 10Paladox) [18:28:56] (03PS3) 10Paladox: Enable opus support in TimedMediaHandler by default [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/238826 [18:33:40] (03CR) 10Paladox: Add extensions.json, empty PHP entry point (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210176 (https://phabricator.wikimedia.org/T87981) (owner: 10Paladox) [18:37:39] (03PS40) 10Paladox: Add extensions.json, empty PHP entry point [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210176 (https://phabricator.wikimedia.org/T87981) [18:46:45] 6Multimedia, 10MediaWiki-File-management, 10MobileFrontend, 7Performance: Explore lazy-loading WebP thumbnails to supporting browsers (eg Android Chrome) - https://phabricator.wikimedia.org/T114791#1706333 (10brion) 3NEW [18:47:32] 6Multimedia, 10MediaWiki-File-management: Support optimized WebP thumbnails as alternative to JPEG, PNG - https://phabricator.wikimedia.org/T27611#291901 (10brion) [18:55:49] 6Multimedia, 10MediaWiki-File-management, 10MobileFrontend, 7Performance: Explore lazy-loading WebP thumbnails to supporting browsers (eg Android Chrome) - https://phabricator.wikimedia.org/T114791#1706377 (10Jdlrobson) Websites such as BBC news / Facebook send a low res image