[00:01:03] marktraceur: if you're curious, i spent most of today figuring out https://phabricator.wikimedia.org/T114134 . [06:05:06] 6Multimedia, 10MediaWiki-File-management, 7Performance: Remote file thumb generation blocks serving a page - https://phabricator.wikimedia.org/T114098#1696219 (10Nemo_bis) >>! In T114098#1695567, @Tgr wrote: > IIRC enabling `transformVia404` will break thumbnailing due to T27958 Do you mean thumbnailing of... [06:08:02] 6Multimedia, 10MediaWiki-File-management: thumb.php should work with ForeignAPIRepo - https://phabricator.wikimedia.org/T27958#1696221 (10Nemo_bis) >>! In T27958#312920, @TheDJ wrote: > I'm guessing the idea here is that for ForeignAPIrepo, you want to use the local thumb.php script to generate thumbnails on t... [06:26:52] 6Multimedia, 10MediaWiki-File-management, 7Performance: Remote file thumb generation blocks serving a page - https://phabricator.wikimedia.org/T114098#1696238 (10Tgr) Ah, ok, I missed the point of that code block. That should work, although it's fragile if you don't run the same MediaWiki version as Commons... [06:33:27] 6Multimedia, 6Commons, 10UploadWizard, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1), 7user-notice: Make categories more required-looking - https://phabricator.wikimedia.org/T51710#1696250 (10Nemo_bis) >>! In T51710#1667265, @matmarex wrote: > https://commons.wikimedia.org/wiki/Commons:Village_pump/Proposals#Cat... [07:03:15] 6Multimedia, 10MediaWiki-File-management: thumb.php should work with ForeignAPIRepo - https://phabricator.wikimedia.org/T27958#1696278 (10Tgr) Local thumbnail generation might produce different results due to using different tools or having different parameters such as sharpening. Remote generation is more f... [08:05:41] 6Multimedia, 10MediaWiki-File-management, 7Performance: Remote file thumb generation blocks serving a page - https://phabricator.wikimedia.org/T114098#1696365 (10Nemo_bis) >>! In T114098#1696238, @Tgr wrote: > Ah, ok, I missed the point of that code block. That should work, although it's fragile if you don't... [08:49:37] 6Multimedia, 6Commons, 10UploadWizard: Upload wizard: Add bail options - https://phabricator.wikimedia.org/T26762#1696394 (10El_Grafo) [08:52:57] 6Multimedia, 6Commons, 10UploadWizard: Upload wizard: Add bail options - https://phabricator.wikimedia.org/T26762#1696398 (10El_Grafo) [08:52:59] 6Multimedia, 10UploadWizard, 7Tracking: Improve UploadWizard UX (tracking) - https://phabricator.wikimedia.org/T96911#1696397 (10El_Grafo) [09:46:09] My ZNC is still refusing to connect to freenode and oftc :\ [11:26:45] 6Multimedia, 6Discovery, 10UploadWizard, 5Patch-For-Review: Add map widget for coordinate selection - https://phabricator.wikimedia.org/T58612#1696710 (10Aklapper) The patches by Anu/Inchikutty are still awaiting review and are the oldest unreviewed patches for UploadWiazrd. Are there plans to move this f... [12:02:17] MatmaRex: o/ Got a minute? Need some help with error handling stuff. [12:02:54] rakaar: mostly, yeah. what's up? [12:03:06] MatmaRex: See https://gerrit.wikimedia.org/r/#/c/243144/1 [12:04:02] Also, I think I am running into https://phabricator.wikimedia.org/T55576 https://phabricator.wikimedia.org/T49395 [12:05:59] looking [12:07:55] rakaar: yeah, i don't think we can do this any better… for many errors you can just directly use api-error-foo messages, but probably not all [12:08:19] rakaar: we could probably steal a large part of this from UploadWizard [12:08:42] MatmaRex: Yup, doing the api-error- thing from within mw.Upload in https://gerrit.wikimedia.org/r/#/c/242899/ [12:09:15] MatmaRex: UW has its own messages for this and shows them. That is pretty much it… [12:09:37] MatmaRex: I am trying to use the message from core (where available) and running into parsing issues with mw.message [12:09:48] If this is the only way I'll keep adding cases then… [12:10:12] MatmaRex: I just needed someone to check if what I was doing was sane. Any other form of code review is also welcome before I continue :) [12:11:00] rakaar: jquerymsg really falls apart for more complicated things :/ [12:11:51] It is just a parameter. In a link. In wikitext. Ok, I get your point :P [12:13:42] rakaar: i could probably figure it out, but not today [12:16:07] marktraceur: rakaar: i'll be mostly unavailable today, but i'll try to make the meetings. sorry for late notice [12:20:57] MatmaRex: Cool. Thanks :) [13:47:25] 6Multimedia, 10MediaWiki-extensions-GWToolset: Could GWToolset upload faster please? - https://phabricator.wikimedia.org/T114099#1696961 (10Hansmuller) 2500 images/day? This rate is what can be achieved by not uploading through GWToolset, but by running a script (guesstimation), which i can't. Regards, hansmuller [13:53:04] 6Multimedia, 6Commons, 10MediaWiki-API, 10MediaWiki-Uploading, 5Patch-For-Review: Provide a well-performing API to rotate an image - https://phabricator.wikimedia.org/T35186#1696964 (10Steinsplitter) @brion: May i ask what is the status of this? :-) [15:28:56] (03PS6) 10Paladox: Build: Test PHP code quality with mediawiki-codesniffer [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242918 [15:29:19] (03CR) 10Paladox: "Ok done." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242918 (owner: 10Paladox) [15:36:13] marktraceur: I am leaving for dinner now. Will bug you about error handling stuff once I am back (https://gerrit.wikimedia.org/r/#/c/243144/ & https://gerrit.wikimedia.org/r/#/c/242899/) [15:38:48] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, and 2 others: Way in VisualEditor to initiate Commons file uploading, and insert image on completion - https://phabricator.wikimedia.org/T40030#1697313 (10Jdforrester-WMF) [15:39:04] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, and 2 others: Way in VisualEditor to initiate Commons file uploading, and insert image on completion - https://phabricator.wikimedia.org/T40030#428437 (10Jdforrester-WMF) p:5Low>3High [16:05:27] 6Multimedia, 10MediaWiki-File-management, 7Performance: Remote file thumb generation blocks serving a page - https://phabricator.wikimedia.org/T114098#1697396 (10Isarra) >>! In T114098#1696365, @Nemo_bis wrote: > That's an inherent fragility we already have, for instance you can't get thumbs of remote files... [16:45:09] marktraceur: o/ [16:45:50] marktraceur: Need review for https://gerrit.wikimedia.org/r/#/c/242899/ I think it covers everything now. [16:46:25] oops, wrong link https://gerrit.wikimedia.org/r/#/c/243144 [17:01:56] rakaar: On it. [17:01:59] 2:) [17:14:20] rakaar: I swear Krinkle has told me in the past not to use jquery's html() and to use append() instead. [17:14:27] I'm not 100% sure on that. [17:14:40] marktraceur: Do you know any language apart from hi? I am trying to re-write 'filename-bad-prefix' using Hindi as an example… [17:14:57] French a bit [17:15:03] rakaar: What's the text? [17:15:39] marktraceur: Using html because running mw.message().parse(). Even if I append I'll have to use html() somewhere. [17:15:43] marktraceur: In that scenario you were appending an object node by reference, not html, in which case .html() is just a strange shortcut to .empty( delete the thing that is already empty).append( parse( try to parse an object that is already an object ) ). [17:15:55] :) .html() is okay for parsing html. [17:16:04] Krinkle: My bad, thanks, I'm glad I asked [17:16:21] Also I'm glad we could both look back on that memory so vividly [17:17:30] rakaar: It looks like you added jquery.msg as a dependency unnecessarily? Or is that needed for .parse() even if you're not using it on a jquery thing [17:17:53] marktraceur: I think its needed for parse, let me check. [17:18:06] K. [17:18:07] * Krinkle goes back to hide in the bushes [17:18:13] Yep https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Message-method-parse [17:18:57] marktraceur: Good ol' times :) [17:23:00] 6Multimedia, 10MediaWiki-File-management, 7Performance: Remote file thumb generation blocks serving a page - https://phabricator.wikimedia.org/T114098#1697647 (10Nemo_bis) >>! In T114098#1697396, @Isarra wrote: > Why is that a problem? If people actually care about these formats on their local sites it's usu... [17:23:08] marktraceur: The qqq is Used as warning in [[Special:Upload]]. Parameters:\n* $1 - prefix\nSee also:\n* {{msg-mw|fileexists}}\n* {{msg-mw|filepageexists}}\n* {{msg-mw|fileexists-extension}}\n* {{msg-mw|fileexists-thumbnail-yes}}\n* [17:23:13] marktraceur: No French either :\ [17:23:26] rakaar: What languages *does* it have? [17:23:59] marktraceur: I am just going to go check in an older revision that has en [17:24:22] OK. [17:26:16] rakaar: Just a documentation comment [17:26:25] 6Multimedia, 10MediaWiki-File-management, 7Performance: Remote file thumb generation blocks serving a page - https://phabricator.wikimedia.org/T114098#1697669 (10Isarra) Except that example is just some filetypes. Wouldn't this potentially apply to all files? That seems much more significant. [17:26:28] Weird, this message was removed from en, but not qqq [17:27:20] marktraceur: Woohoo! [17:27:58] * rakaar is stupid [17:28:42] It was there all along :| [17:33:41] marktraceur: If mw.Upload loads some messages, and mw.Upload.BookletLayout uses those messages, should I explicitly make it load them too? [17:44:48] Ehhhh. [17:44:58] I would say "yes" but I feel like many other people would say "no" [17:45:22] I'm almost certain I've been bit on the ass by taking out a dependency from one thing only to have something that used *that* as a dependency fall over [17:45:31] Similar theory with messages [17:45:36] But to each their own [17:46:20] I'll just put strings in the JS instead :P [17:48:43] Sounds good to me. [17:48:45] Wait a minute [17:50:47] :D [17:59:30] marktraceur: Its done! [18:00:02] * rakaar should probably un-ignore the gerrit bot before he becomes it [18:10:39] prtksxna: this is awkward [18:30:07] 6Multimedia, 10MediaWiki-File-management, 6Performance-Team, 7Performance: Thumbnail urls should be versioned and sent with Expires headers - https://phabricator.wikimedia.org/T19577#1698048 (10Gilles) [18:33:02] marktraceur: Any chance you'll be able to look at the patch before I head to bed (now-ish)? [18:33:28] 6Multimedia, 10MediaWiki-File-management, 6Performance-Team: Investigate PNG metadata in thumbnails - https://phabricator.wikimedia.org/T114518#1698065 (10Gilles) 3NEW a:3Gilles [18:33:39] 6Multimedia, 10MediaWiki-File-management: Optimize thumbs right after creation - https://phabricator.wikimedia.org/T111633#1698072 (10Gilles) a:5Gilles>3None [18:34:18] 6Multimedia, 10MediaWiki-File-management, 7Performance: Remote file thumb generation blocks serving a page - https://phabricator.wikimedia.org/T114098#1698075 (10Bawolff) >>! In T114098#1697669, @Isarra wrote: > Except that example is just some filetypes. Wouldn't this potentially apply to all files? That se... [18:47:01] 6Multimedia, 6Discovery, 10UploadWizard, 5Patch-For-Review: Add map widget for coordinate selection - https://phabricator.wikimedia.org/T58612#1698124 (10Tgr) I plan to review it once the map service is enabled on Commons. Legal issues around using an external service were probably the most problematic par... [19:23:36] prtksxna: Sorry, was afk for a bit. I'll look at 'er now. [19:28:18] marktraceur: If it could be merged ASAP that'd be smashing. [19:32:05] James_F: OK then [19:32:23] :-) [19:35:37] Done [19:35:55] edsanders: How are we doing on a VE integration patch thinger [19:36:27] it's sitting there using the foreign upload booklet [19:36:54] https://gerrit.wikimedia.org/r/#/c/240116/ [19:42:49] Cool beans [19:42:59] I will likely task MatmaRex with reviewing that [19:43:13] But that means we're on track! Woohoo [19:55:37] 6Multimedia, 10MediaWiki-File-management, 7Performance: Remote file thumb generation blocks serving a page - https://phabricator.wikimedia.org/T114098#1698352 (10Tgr) >>! In T114098#1698075, @Bawolff wrote: > It would also break all cached pages in Wikipedia, and break all hotlinked images on commons (hotlin... [20:11:40] (03PS1) 10MarkTraceur: Prevent form submission without debug mode [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/243239 (https://phabricator.wikimedia.org/T113968) [20:11:51] 6Multimedia, 5Patch-For-Review: Stop form from submitting and turn validate debug mode off - https://phabricator.wikimedia.org/T113968#1698386 (10MarkTraceur) a:3MarkTraceur [20:15:16] (03PS1) 10MarkTraceur: Remove superfluous ExceptionFlow event class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/243240 (https://phabricator.wikimedia.org/T113780) [20:15:18] I'm helpiiiing [20:15:31] 6Multimedia, 10UploadWizard, 5Patch-For-Review, 7Technical-Debt: Remove UploadWizardExceptionFlowEvent EventLogging schema - no longer necessary - https://phabricator.wikimedia.org/T113780#1698394 (10MarkTraceur) a:3MarkTraceur [20:29:48] 6Multimedia, 10MediaWiki-General-or-Unknown, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Improve error handling UX in the mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T114130#1698410 (10Jdforrester-WMF) Sufficiently complete? [20:29:53] marktraceur: Woo. [20:31:18] (03CR) 10Jforrester: [C: 031] Remove superfluous ExceptionFlow event class (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/243240 (https://phabricator.wikimedia.org/T113780) (owner: 10MarkTraceur) [20:33:31] leBop@31 [20:37:08] 6Multimedia, 10MediaWiki-File-management, 6Performance-Team: Investigate PNG metadata in thumbnails - https://phabricator.wikimedia.org/T114518#1698473 (10Bawolff) At the very least, the useless crap from http://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html should be removed (Can b... [20:40:53] 6Multimedia, 10MediaWiki-File-management: Optimize thumbs right after creation - https://phabricator.wikimedia.org/T111633#1698482 (10Bawolff) People at commons say that zopfli gets better results then pngcrush (But is slow enough you might not want to do it during thumbnail generation, but in some async fashion) [21:19:47] (03PS33) 10Paladox: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [21:21:15] (03CR) 10Paladox: "Rebased and updated videojs to 5.0 stable release." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [21:36:55] 6Multimedia, 10MediaWiki-File-management, 6Performance-Team: Investigate PNG metadata in thumbnails - https://phabricator.wikimedia.org/T114518#1698667 (10Tgr) From T20871 it seems all structured metadata is stripped and the commons URL is added in a comment. You could save a couple bytes by using {#mediawi...