[00:09:59] (03PS1) 10Jforrester: Only depend upon the DateInputWidget, not all of mediawiki.widgets [extensions/UploadWizard] (REL1_26) - 10https://gerrit.wikimedia.org/r/242415 [00:11:29] (03CR) 10jenkins-bot: [V: 04-1] Only depend upon the DateInputWidget, not all of mediawiki.widgets [extensions/UploadWizard] (REL1_26) - 10https://gerrit.wikimedia.org/r/242415 (owner: 10Jforrester) [00:33:58] 6Multimedia, 10MediaWiki-extensions-GWToolset: Could GWToolset upload faster please? - https://phabricator.wikimedia.org/T114099#1687924 (10Bawolff) @Hansmuller : Just to clarify - How many images are you wanting to upload, what timeframe do you want to do it in, and what rate would you like to have? ----- >... [01:44:36] (03CR) 10Jforrester: [C: 031] Use a less fragile check to detect whether TitleBlacklist is installed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242392 (owner: 10Legoktm) [03:36:37] James_F|Away: ...they aren't? [06:26:02] 6Multimedia: Improve error handling UX in the mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T114130#1688355 (10matmarex) a:3matmarex [06:26:18] 6Multimedia, 10MediaWiki-General-or-Unknown: Improve error handling UX in the mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T114130#1685394 (10matmarex) [07:20:27] 6Multimedia, 6Commons, 10UploadWizard: 587 MB file to upload, chunked upload failed at assembling state - https://phabricator.wikimedia.org/T112698#1688397 (10matmarex) Sorry, I do not have access to things myself, and I did not have time to go poking people. I think the only thing I can do now is to try to... [09:09:59] (03PS1) 10Bartosz Dziewoński: Remove hacks from 063cc6bc, no longer needed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242496 [09:10:20] (03CR) 10Bartosz Dziewoński: [C: 04-2] "Do not merge until translations are exported." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242496 (owner: 10Bartosz Dziewoński) [09:40:05] 6Multimedia, 10UploadWizard, 7Easy: Remove mw.UtilitiesTime.js, use the Moment library instead of mw.seconds2Measurements() method - https://phabricator.wikimedia.org/T114219#1688585 (10matmarex) 3NEW [09:44:22] 6Multimedia, 10UploadWizard, 7Easy: "Upload anyway" link next to file which has duplicates on the wiki should be a OOjs UI button - https://phabricator.wikimedia.org/T114221#1688620 (10matmarex) 3NEW [09:45:51] 6Multimedia, 10UploadWizard, 7Easy: "Remove" button for individual files in the upload step should be a OOjs UI button - https://phabricator.wikimedia.org/T114222#1688628 (10matmarex) 3NEW [09:57:53] 6Multimedia, 6Commons, 10UploadWizard: 587 MB file to upload, chunked upload failed at assembling state - https://phabricator.wikimedia.org/T112698#1688652 (10Inaki-LL) Ok Ok, I am trying to convert it into a smaller version. However, any move to figure out current problems will be much appreciated. Thanks... [10:32:43] (03PS1) 10Bartosz Dziewoński: Remove direct dependencies on 'jquery.ui.widget' and 'jquery.ui.core' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242505 [11:10:44] (03PS1) 10Bartosz Dziewoński: Remove unused function 'prefillLicense' littered with 'XXX' comments [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242511 [11:40:56] 6Multimedia, 10UploadWizard: When using UploadWizard, thumbnails fail to appear or files are missing on the "Release rights" webpage - https://phabricator.wikimedia.org/T97770#1688848 (10TasneemLo) I just tested this with firefox 41.0 and I can't seem to be able to reproduce this [12:41:05] 6Multimedia, 10UploadWizard: When using UploadWizard, thumbnails fail to appear or files are missing on the "Release rights" webpage - https://phabricator.wikimedia.org/T97770#1688955 (10Jacklee) I am still experiencing this transiently. The error message is: "The upload succeeded, but the server could not get... [14:26:57] morning marktraceur [14:34:18] Morning! [14:34:22] What's up, MatmaRex [14:34:30] And also good morning prtksxna [14:35:14] i got up early today and did some cleanup work [14:35:54] I see [14:35:58] now i'm going to be getting things backported/deployed [14:36:06] and then… https://phabricator.wikimedia.org/T114130 i guess? [14:36:13] all's well apart from that. :P [14:36:32] OK, MatmaRex, I think prtksxna said he could work on 114130 [14:36:46] And it seems like it needs to be part of the same patch, so that makes sense to me [14:36:58] Don't want to have people stepping on each other's toes [14:37:40] oh. yeah, if he's working on it, then i'll leave it be [14:38:19] 6Multimedia, 10MediaWiki-General-or-Unknown: Improve error handling UX in the mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T114130#1689385 (10matmarex) a:5matmarex>3Prtksxna Prateek wanted to work on it, apparently? [14:40:21] I offered him help if he can't get it done [14:43:47] Yep, working on T114130 [15:11:10] (03CR) 10Jforrester: "recheck" [extensions/UploadWizard] (REL1_26) - 10https://gerrit.wikimedia.org/r/242415 (owner: 10Jforrester) [15:32:51] James_F: Meeting? :D [15:40:53] MatmaRex: Brief note re: text OOUI patch - the inline text inputs for the license deed are no longer inline, if you have a way to make that inline that's good, but I'm planning on doing a follow-up to make them not inline anyway [15:41:42] marktraceur: i was actually thinking that inline would be perfectly fine in that particular case. i've gotta look to see what you've done with them [15:42:02] it might be difficult to find good wording otherwise? [15:43:23] Maybe. [15:43:30] marktraceur: Added phab tickets [15:43:44] MatmaRex: If you decide that's OK, and that OOUI will happily do it for us, then feel free to close the ticket [15:48:12] MatmaRex: ON a scale of one to ten, how irritated will Krinkle be when I merge https://gerrit.wikimedia.org/r/234176 [15:48:54] marktraceur: he shouldn't be irritated and instead merge the followup where i fixed his comment [15:49:02] OK then. [15:49:12] {{done}} [15:49:53] marktraceur: I don't think we need to add the doc.wikimedia link, I don't see it in any of the 1.26 notes [15:50:10] prtksxna: OK, maybe say "documentation for mw.Upload" and similar [15:50:20] marktraceur: Just "See documentation for mw.Upload and its subclasses…" should be enought [15:50:25] * prtksxna nods [15:53:12] Wait, prefillLicense isn't used? Weird. [15:53:31] I feel like it might have just gotten lost in a refactor, but also, nobody seems to be missing it. [15:53:49] (03CR) 10MarkTraceur: [C: 032] Remove unused function 'prefillLicense' littered with 'XXX' comments [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242511 (owner: 10Bartosz Dziewoński) [15:55:42] (03CR) 10MarkTraceur: [C: 032] Remove direct dependencies on 'jquery.ui.widget' and 'jquery.ui.core' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242505 (owner: 10Bartosz Dziewoński) [15:55:51] (03CR) 10Jforrester: [C: 031] "Feels like progress even if it isn't. :-)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242505 (owner: 10Bartosz Dziewoński) [15:56:02] :D [15:57:18] Just one dependency away from no jQuery UI! ;-) [15:57:42] Yes, but it's selectable [15:57:51] Which means delving into flickr code... [15:58:16] I guess I already asked mooeypoo about her image selector code, I guess it might be portable [15:59:08] MatmaRex: I feel like I came up with a new reason to not merge https://gerrit.wikimedia.org/r/240586 but now I don't remember what it is. Should I go ahead? [15:59:12] Yeah. [15:59:14] * James_F shudders on your behalves. [15:59:16] It should be. [15:59:20] mw-widget style. [15:59:30] marktraceur: it has a soft dependency that is not yet merged [15:59:44] (soft, as in, shouldn't throw exceptions, but it'll look silly) [15:59:50] Oh, right, the one that prtksxna had lots of opinions on [16:00:07] :| [16:00:23] Just questions. [16:00:31] * marktraceur has zero problem with that [16:00:47] prtksxna: Hopefully it's all clear now? [16:01:05] marktraceur: Yep! [16:01:10] Hoorah [16:01:11] rebase and merge? [16:01:28] (03Merged) 10jenkins-bot: Remove unused function 'prefillLicense' littered with 'XXX' comments [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242511 (owner: 10Bartosz Dziewoński) [16:02:15] It's going [16:02:35] Once that merges in core I'll merge the UW patch [16:02:38] Yay ooui [16:02:49] \o/ [16:03:35] Gerrit was showing a label saying, "Not Current", now I understand that I was looking at a different revision, and not that this patch needs to be rebased. [16:04:14] prtksxna: Yeah, but Gerrit rebases for you if it can [16:04:24] Oh, misread. [16:04:29] But also it needed a rebase. [16:08:14] (03Merged) 10jenkins-bot: Remove direct dependencies on 'jquery.ui.widget' and 'jquery.ui.core' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242505 (owner: 10Bartosz Dziewoński) [16:12:37] marktraceur: I can't find any error where 'trying again' can help. Do you know of any that might? [16:14:14] marktraceur: Also, there are a bunch of $warnings, but they aren't very different from errors in our case, in that we don't want to suppress them (do we?). So, is there value in getting rid of Upload.State.WARNING completely? [16:17:05] bloody goddamn scap taking ages [16:17:52] * prtksxna hands MatmaRex a squishable cheese sandwich [16:19:41] prtksxna: Mostly trying again is good for warnings only [16:20:12] Warnings are useful information that the user might choose to use to end the session, but they can be overridden. [16:20:18] Errors are usually not recoverable. [16:22:33] marktraceur: I can't find any error where 'trying again' can help. Do you know of any that might? <-- s/error/warning [16:22:57] marktraceur: For example, we don't really want someone to go ahead with a badfilename, or upload an existing file, do we? [16:27:15] No, it's not just "try again" but also "ignore warning" or "try again...with the new data that I just input" [16:31:44] marktraceur: So, dismiss, change stuff, and try again, not a try again like this - https://phabricator.wikimedia.org/F2646397 [16:31:52] brb dinner [16:34:33] prtksxna: Yeah, that's probably not helpful...unless it's, like, a 503 or something [16:59:14] 6Multimedia: Date-time formats in MWTimestamp don't support timezone specifiers - https://phabricator.wikimedia.org/T114270#1689983 (10Galorefitz) 3NEW a:3Galorefitz [17:00:57] 6Multimedia: Date-time formats in MWTimestamp don't support timezone specifiers - https://phabricator.wikimedia.org/T114270#1689992 (10Galorefitz) [17:00:59] 6Multimedia, 10MediaWiki-File-management, 7Easy, 5Patch-For-Review: PNG metadata extractor doesn't properly convert dates - https://phabricator.wikimedia.org/T58064#1689991 (10Galorefitz) [17:01:23] (03CR) 10MarkTraceur: [C: 032] "Dependency merged. Let's do this thing." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240586 (https://phabricator.wikimedia.org/T112764) (owner: 10Bartosz Dziewoński) [17:01:56] 6Multimedia: Date-time formats in MWTimestamp don't support timezone specifiers - https://phabricator.wikimedia.org/T114270#1689983 (10Galorefitz) [17:03:00] (03Merged) 10jenkins-bot: Replace jquery.mwCoolCats with mediawiki.widgets.CategorySelector [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240586 (https://phabricator.wikimedia.org/T112764) (owner: 10Bartosz Dziewoński) [17:03:07] :o [17:03:26] Yaaaay. [17:03:45] i'm gonna go close all the bugs that fixed [17:04:07] …and probably clock out for today. i woke up early :P [17:04:26] Fun times [17:06:16] 6Multimedia, 10UploadWizard, 7Tracking: Improve UploadWizard UX (tracking) - https://phabricator.wikimedia.org/T96911#1690015 (10matmarex) [17:06:17] 6Multimedia, 10UploadWizard: Categories marked as not existing when copy/pasted - https://phabricator.wikimedia.org/T49052#1690016 (10matmarex) [17:06:19] 6Multimedia, 10UploadWizard: Clarify that the (each) category field doesn't accept a list of categories - https://phabricator.wikimedia.org/T39124#1690019 (10matmarex) [17:06:21] 6Multimedia, 10UploadWizard: Replace CoolCats with mw.widgets.CategorySelector - https://phabricator.wikimedia.org/T112764#1690011 (10matmarex) 5Open>3Resolved [17:06:23] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Category adder should have "X" to remove additional categories - https://phabricator.wikimedia.org/T39128#1690018 (10matmarex) [17:06:25] 6Multimedia, 10UploadWizard: UploadWizard: Implement interface like HotCat for suggesting categories - https://phabricator.wikimedia.org/T42076#1690017 (10matmarex) [17:07:59] 6Multimedia, 10UploadWizard: Clarify that the (each) category field doesn't accept a list of categories - https://phabricator.wikimedia.org/T39124#1690022 (10matmarex) 5Open>3Invalid a:3matmarex The UI was changed with T112764 and this is no longer relevant. (See screenshots there.) [17:08:26] RIP bugs [17:08:26] 6Multimedia, 10UploadWizard: Categories marked as not existing when copy/pasted - https://phabricator.wikimedia.org/T49052#1690030 (10matmarex) 5Open>3Resolved a:3matmarex This has been corrected with the new UI we switched to per T112764. (See screenshots there.) [17:08:58] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Category adder should have "X" to remove additional categories - https://phabricator.wikimedia.org/T39128#1690036 (10matmarex) 5Open>3Resolved a:3matmarex This has been corrected with the new UI we switched to per T112764. (See screenshots there.) [17:09:29] pow. [17:19:08] FFS James_F :P [17:21:27] ? [17:21:34] What did I do now? [17:22:27] Quarterly things [17:22:34] I'm just kidding, it's fine [17:23:30] I'd hate to have a big red box on the screen just because of Flickr uploads. [17:23:47] I wonder how much work it would take to finish that off... [17:25:10] marktraceur: we can pretend that selectable doesn't count. [17:25:17] there's no direct replacement in OOUI. [17:25:26] Ha. [17:25:28] Yet. [17:25:56] MatmaRex: Not OOUI core, but there's the dialog in VE for selecting files [17:26:08] Which we should make an mw.widget. [17:26:12] Or whatever. [17:26:12] And how. [17:26:39] marktraceur: but that's for selecting only one file. [17:26:52] and here we display up to 500 files and allow the user to select any number of them. [17:26:58] Hm. [17:27:00] I see what you mean [17:27:11] Needs fixing up, then. :-) [17:27:28] although the current jquery.ui.selectable interface is also way clunky, with the dragging thing [17:28:07] we could probably replace it with a huge table of checkboxes, that have checkboxShiftClick applies to them, with little if any loss of functionality. [17:28:19] but i don't even know who uses flickr upload, or if they at all do. [17:28:21] Heh [17:28:45] MatmaRex: I believe there are categories that could answer this question, but also, I know only admins are allowed to do uploads from Flickr [17:28:59] Let's not waste too much time on it. [17:29:16] Sold [17:29:37] * marktraceur unilaterally declares goal met [17:30:01] Hmm. [17:30:13] https://phabricator.wikimedia.org/T114221 [17:30:17] https://phabricator.wikimedia.org/T114222 [17:30:28] https://phabricator.wikimedia.org/T96914 [17:30:38] Etc. [17:30:58] James_F: Not every part of the code is OOUI, but the interface elements are...actually hold up [17:31:05] 6Multimedia, 10UploadWizard, 7Easy: "Remove" button for individual files in the upload step should be a OOjs UI button - https://phabricator.wikimedia.org/T114222#1690108 (10Jdforrester-WMF) [17:31:07] 6Multimedia, 10UploadWizard, 7Easy: "Upload anyway" link next to file which has duplicates on the wiki should be a OOjs UI button - https://phabricator.wikimedia.org/T114221#1690109 (10Jdforrester-WMF) [17:31:08] 6Multimedia, 10UploadWizard, 7Epic: Migrate UploadWizard UI elements to OOjs UI - https://phabricator.wikimedia.org/T96914#1690107 (10Jdforrester-WMF) [17:31:09] Text widgets still not merged [17:31:09] James_F: https://phabricator.wikimedia.org/T96914 should have its blockers removed and be closer, they aren't blockers. [17:31:18] Oh, OK. [17:31:22] * James_F undoes. [17:31:32] 6Multimedia, 10OOjs-UI, 10UploadWizard: Use OOUI datepicker input widget in UploadWizard - https://phabricator.wikimedia.org/T97426#1690111 (10Jdforrester-WMF) [17:31:34] 6Multimedia, 10UploadWizard, 7Epic: Migrate UploadWizard UI elements to OOjs UI - https://phabricator.wikimedia.org/T96914#1229248 (10Jdforrester-WMF) [17:31:39] 6Multimedia, 10UploadWizard: Replace CoolCats with mw.widgets.CategorySelector - https://phabricator.wikimedia.org/T112764#1690116 (10Jdforrester-WMF) [17:31:41] 6Multimedia, 10UploadWizard: Pull CSS out into several different LESS files based on what is used where - https://phabricator.wikimedia.org/T98785#1690118 (10Jdforrester-WMF) [17:31:43] 6Multimedia, 10UploadWizard, 5WMF-deploy-2015-09-22_(1.26wmf24), 7user-notice: Replace jquery dialogs in UploadWizard with OOUI dialogs - https://phabricator.wikimedia.org/T112117#1690117 (10Jdforrester-WMF) [17:31:45] 6Multimedia, 10UploadWizard: Move UI creation into JavaScript - https://phabricator.wikimedia.org/T96918#1690119 (10Jdforrester-WMF) [17:31:47] 6Multimedia, 10UploadWizard, 7Epic: Migrate UploadWizard UI elements to OOjs UI - https://phabricator.wikimedia.org/T96914#1229248 (10Jdforrester-WMF) [17:31:50] MatmaRex: Closed as what? Fixed? Invalid? [17:31:54] James_F: the other two tasks are not about jquery.ui things, which is AFAIK what we committed to killing [17:32:00] Kk. [17:32:00] James_F: fixed! [17:32:13] MatmaRex: Do you want to mark it as such, then? :-) [17:32:26] James_F: i'd actually leave those two for GCI students :D [17:32:52] yeah, doing [17:33:13] MatmaRex: Sure, that's why I put them in "Next up". [17:34:03] There's no GCI 2015 tag, yet. [17:34:56] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Migrate text fields in UploadWizard to OO.ui.TextInputWidget - https://phabricator.wikimedia.org/T113371#1690136 (10matmarex) [17:34:57] 6Multimedia, 10UploadWizard: Replace CoolCats with mw.widgets.CategorySelector - https://phabricator.wikimedia.org/T112764#1690137 (10matmarex) [17:34:59] 6Multimedia, 10OOjs-UI, 10UploadWizard: Use OOUI datepicker input widget in UploadWizard - https://phabricator.wikimedia.org/T97426#1690139 (10matmarex) [17:35:01] 6Multimedia, 10UploadWizard, 7Epic: Migrate UploadWizard UI elements to OOjs UI - https://phabricator.wikimedia.org/T96914#1690135 (10matmarex) [17:35:09] James_F: these are the real blockers [17:35:23] So https://phabricator.wikimedia.org/T113371 still needs to be done. [17:35:29] (i can't find a task for changing buttons from jquery.ui to OOUI, i think we did it without a task) [17:35:41] yeah. let's review that one. [17:35:46] Go go go. :-) [17:36:11] "Complete; ancillary tools like Flickr uploading yet to be transitioned" is a fine outcome. [17:36:54] marktraceur: grumble, https://gerrit.wikimedia.org/r/#/c/212842/ somehow needs rebase already. [17:38:04] MatmaRex: It's also apparently failing qunit, not sure why off the top of my head [17:46:24] ehhh, we've also broken master… [17:46:37] Uncaught TypeError: mw.widgets.CategorySelector is not a function [17:46:41] needs more dependencies [17:46:45] Oh noes. [17:47:18] Oh, bah. [17:47:21] I blame me. [17:47:24] Sorry. [17:47:52] https://gerrit.wikimedia.org/r/#/c/242383/ was wrong. [17:47:55] (03PS1) 10Bartosz Dziewoński: Add missing dependency on mediawiki.widgets [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242622 [17:48:11] Psychically wrong. [17:48:35] (03CR) 10Jforrester: [C: 032] "Whoops." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242622 (owner: 10Bartosz Dziewoński) [17:48:46] (03CR) 10MarkTraceur: [C: 032] Add missing dependency on mediawiki.widgets [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242622 (owner: 10Bartosz Dziewoński) [17:54:13] (03Merged) 10jenkins-bot: Add missing dependency on mediawiki.widgets [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242622 (owner: 10Bartosz Dziewoński) [17:55:14] I should maybe go and get lunch. [18:07:51] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs rebase against CategorySelector." (0318 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) (owner: 10MarkTraceur) [18:08:10] James_F: marktraceur: after cursory review i must say that has no chance of working right, sorry. [18:08:24] That's not good. [18:08:38] (03CR) 10Bartosz Dziewoński: "Also, why are we moving a massive chunk of code between files in this commit :/" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) (owner: 10MarkTraceur) [18:08:46] James_F: How do I see https://gerrit.wikimedia.org/r/#/c/240116/? Insert > Media > ? [18:09:19] prtksxna: Yeah. It adds a tab to the media insertion dialog. [18:10:03] James_F: I don't see it. Might be a cache issue. [18:10:14] Hmm. [18:10:19] prtksxna: edsanders is the expert. [18:11:36] James_F: marktraceur: if you need something demoable, then we need a smaller patch, that updates only the fields you're likely to see in a usual case [18:12:00] or just give up and get it done in a week or so [18:12:23] edsanders: Is this what I am supposed to see https://phabricator.wikimedia.org/F2646503? I am trying to see https://gerrit.wikimedia.org/r/#/c/240116/. [18:12:35] that patch is massive and it still missed things, like the custom license input, or upload-from-flickr URL field. [18:15:00] MatmaRex: OK, I can rewrite it...maybe one field at a time? [18:15:46] Doesn't make a lot of sense I guess [18:16:18] MatmaRex: Is it just a matter of missing some of the fields, or is there something more fundamentally wrong with the patch? [18:16:19] we could, should be easier to keep track of things [18:16:47] (I will hop on IRC from the restaurant, BRB) [18:17:14] marktraceur: not fundamentally, but it needs a few days of QA and bugfixing. i just left 18 comments on it after just reading it :/ [18:17:33] (and briefly testing the common cases) [18:18:17] i'm sure that there's a ton of code in there that is still trying to use the now-nonexistent HTML inputs, by querying with $(id) [18:18:27] and which is just failing without exceptions, because jquery [18:31:20] Bloody hell. Okay. [18:32:04] It may be that I assumed past-Mark had done a more thorough job than his WIP tag indicated. [18:32:52] :-) [18:34:17] MatmaRex: I could have sworn that I ca [18:34:37] ught a bunch of issues and had a successful upload or two run without issue [18:34:42] Bloodp phones [18:50:50] marktraceur: yeah, it does mostly work [18:51:20] just not quite [18:51:41] How many '$(' calls are there? [18:52:00] Too many [18:52:19] Not trivial to audit them, then. [18:52:47] See e.g. my jquery audit patches. [18:52:52] Which were awful. [18:53:59] The whole copy metadata system relies on queries for element IDs [18:57:23] Lovely. :-( [18:59:33] I suppose our shift towards an MVCy system could fix that, but we're not there yet. For quite a while. [19:33:03] The way bookletlayout and dialog are structured one can never really come out of an error :S [19:34:22] Also, as we are using the same state variable in mw.Upload for uploadToStash and finishStashUpload, the thing gets stuck. [19:34:24] prtksxna: You mean, all errors are unrecoverable? [19:34:31] Oh. Fun. [19:35:13] James_F: Yes! [19:36:05] We still show a 'Try Again' button that does absolutely nothing. +10 to UX :P [19:38:06] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-RfCs: Provide semantic wiki-configurable styles for media display - https://phabricator.wikimedia.org/T90914#1690692 (10cscott) @Tgr `lang` is somewhat problematic; see {T60920} -- it's not consistent with how the spec defines lang and so prevents native... [19:42:54] prtksxna: Whoops. [19:44:18] marktraceur: https://gerrit.wikimedia.org/r/242655 [19:48:06] 6Multimedia, 10UploadWizard: Upload Wizard Campaigns should support adding a custom drop-down selector - https://phabricator.wikimedia.org/T114298#1690728 (10Base) 3NEW [19:50:03] 6Multimedia, 10UploadWizard: Upload Wizard Campaigns should support making description in a specified language mandatory - https://phabricator.wikimedia.org/T114299#1690738 (10Base) 3NEW [19:51:52] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-RfCs: Provide semantic wiki-configurable styles for media display - https://phabricator.wikimedia.org/T90914#1690753 (10brion) re: lang attribute on SVGs -- this would probably have to be implemented as a postprocessing step when serving SVGs instead of P... [19:53:00] James_F: so, is there anything you'd like me to do today about the oouification? i have, say, about three hours before it's stupidly late [19:53:20] James_F: or are we accepting that text inputs are not OOUI and hoping that no one notices? [19:53:32] MatmaRex: That seems like it's probably the one. [19:53:39] MatmaRex: But review of prtksxna's patch maybe helpful? [19:54:57] There is no back button (or functionality), only cancel. As we don't wait for the upload to finish before moving to the information form page, in case there was an error in the uploaded file, there is no way to go back and upload a new one. This isn't too bad as there are only two steps, but is still pretty stupid. [19:55:26] Same in FSUD? [19:55:36] yeah, i am just looking at it [19:55:49] Thanks. [19:56:05] prtksxna: maybe we just shouldn't show the next step before the file is actually uploaded? i know i suggested not blocking myself, but it does seem to make everything harder [19:56:22] James_F: FSUBL doesn't change this part of UploadBooklet, so yeah. Fixing. [19:56:28] Fun. [19:56:58] MatmaRex: Its good UX to show it. Isn't it nice to be able to fill in info while the thing gets uploaded? [19:57:26] indeed it is [19:57:33] MatmaRex: I guess what I am saying is that its worth making everything harder. [19:57:44] alright :) [20:20:11] prtksxna: hmm [20:21:06] prtksxna: i think we should make all of our errors in the booklet/dialog not "recoverable". this is apparently as simple as "new OO.ui.Error( 'foo', { recoverable: false } )", and suppresses the "Try again" button [20:21:37] prtksxna: also, when the upload step fails, we should switch back to that form (hopefully that doesn't mess up any internal state too much…) [20:25:13] MatmaRex: Yep, I agree. The only ones that are recoverable by hitting Try Again are 503s (as marktraceur pointed out). [20:26:01] MatmaRex: We can manage the internal state, though I am not sure how much of it we should. If you've already written out a description it'd be mean to clear everything out just because you're going back a step. [20:27:16] prtksxna: as long as we don't kill the widgets (i.e., call renderWhatever() or something), the description should stay there and reappear if you manage to go through the upload step [20:27:42] i think this part should just work [20:27:53] * prtksxna nods [20:27:58] taking care of the mw.Upload object looks a bit worse [20:31:09] MatmaRex: Its getting errors and warning in different formats from different places. I foresee some long switch cases to provide a clean interface for error and warning messages. [20:31:42] :/ [20:35:16] MatmaRex: https://gerrit.wikimedia.org/r/242717 making errors unrecoverable [20:42:41] 6Multimedia, 10UploadWizard: It should be possible to limitate Upload Wizard Campaign custom field input not just by length but by any regexp - https://phabricator.wikimedia.org/T114309#1691012 (10Base) 3NEW [20:47:17] prtksxna: looks sane, but that still doesn't help the user do anything [20:47:31] you still get stuck on the details step, which will never be able to be submitted [20:47:43] i mean, it's an improvement over the current state :D [20:47:53] where you get the same thing, except you can click "Try again" forever [20:48:05] …so actually, let's just merge it [20:51:31] "limitate" [20:51:31] prtksxna: let's finish tomorrow? i'm going to leave soon [20:51:34] What are we merging [20:51:36] MatmaRex: Another match coming up [20:51:56] MatmaRex: Can you wait 2 minutes, I'll sleep after this one [20:52:13] s/,/? [20:52:26] heh, sure [20:54:29] MatmaRex: Thanks :) [20:54:40] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-RfCs: Provide semantic wiki-configurable styles for media display - https://phabricator.wikimedia.org/T90914#1691048 (10violetto) Quick thoughts and some accompanying use cases from the article //Moon// **Small thumbnail ** {F2647041} --- **Medium thum... [20:54:54] MatmaRex: https://gerrit.wikimedia.org/r/#/c/242723/ [20:58:06] Hm, I guess we can do the 'back' instead of 'cancel' thing later, now that it goes back on error. You still can't change your mind about the file you're uploading (without closing the dialog), but at least you can recover. [20:59:06] I'll try and make mw.Upload return useful error message tomorrow. MatmaRex marktraceur, if you know a simple way of doing this I'd love some hints. [20:59:10] yeah, that looks nice [20:59:22] i'm trying to test it, but gerrit is not cooperating [20:59:37] but whatever, it looks like it should work [21:00:36] prtksxna: we'd probably have to fiddle with actions in the dialog a bit. i'm sure edsanders|away would implement that in a heartbeat ;) [21:00:48] prtksxna: good night :) [21:00:59] MatmaRex: Fiddle with the actions for? [21:01:08] MatmaRex: Let's talk tomorrow. Good night! [21:01:12] for a 'back' button [21:01:14] Bye marktraceur James_F o/ [21:01:34] MatmaRex: Ah yes, I am not going to worry about it for now though (useful error messages more important) [21:01:41] yep [21:56:56] Alliance for Open Media really is awesome source [21:56:59] *sauce [22:14:52] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-RfCs: Provide semantic wiki-configurable styles for media display - https://phabricator.wikimedia.org/T90914#1691254 (10Spage) People discussed this in {E68}, see [[ https://tools.wmflabs.org/meetbot/wikimedia-office/2015/wikimedia-office.2015-09-30-21.00... [23:08:24] bawolff: Indeed! [23:08:35] bawolff: If only it covered iDevices magically. [23:09:28] yeah. But even without that, its still such a gigantic step forward I want to do a happy dance [23:11:19] :-)