[00:31:39] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178141 (https://phabricator.wikimedia.org/T76030) (owner: 10Gergő Tisza) [00:31:46] (03PS5) 10Jdlrobson: Add functions to display/remove a warning in the dialogs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178059 (https://phabricator.wikimedia.org/T76030) (owner: 10Gergő Tisza) [00:34:46] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 5Patch-For-Review: Re-enable Media Viewer from a File Page - https://phabricator.wikimedia.org/T77625#1669144 (10Jdlrobson) [00:37:30] (03CR) 10Jdlrobson: [C: 04-1] "Needs a rebase. I can commit to getting this merged if this is important." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187735 (https://phabricator.wikimedia.org/T87943) (owner: 10Gilles) [00:38:00] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173916 (https://phabricator.wikimedia.org/T77253) (owner: 10Gilles) [00:39:37] (03PS3) 10Jdlrobson: Add explicit word-wrap: break-word to textareas [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/234243 (https://phabricator.wikimedia.org/T69835) (owner: 10Thiemo Mättig (WMDE)) [00:44:15] (03CR) 10Jdlrobson: [C: 032] Add explicit word-wrap: break-word to textareas [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/234243 (https://phabricator.wikimedia.org/T69835) (owner: 10Thiemo Mättig (WMDE)) [00:46:50] (03Merged) 10jenkins-bot: Add explicit word-wrap: break-word to textareas [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/234243 (https://phabricator.wikimedia.org/T69835) (owner: 10Thiemo Mättig (WMDE)) [01:47:00] 6Multimedia, 10Sentry, 10UploadWizard, 7Epic, and 2 others: Deploy Sentry (JavaScript error logging) to production, configured to log only UploadWizard - https://phabricator.wikimedia.org/T91649#1669333 (10greg) [01:47:39] 6Multimedia, 10Sentry, 10UploadWizard, 7Epic, and 2 others: Deploy Sentry (JavaScript error logging) to production, configured to log only UploadWizard - https://phabricator.wikimedia.org/T91649#1092287 (10greg) [04:55:11] 6Multimedia, 10Sentry, 10UploadWizard, 7Epic, and 2 others: Deploy Sentry (JavaScript error logging) to production, configured to log only UploadWizard - https://phabricator.wikimedia.org/T91649#1669617 (10Tgr) [05:28:13] (03PS6) 10Gergő Tisza: Slideshow Functionality [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107023 (https://phabricator.wikimedia.org/T60848) (owner: 10Apsdehal) [05:28:15] (03CR) 10jenkins-bot: [V: 04-1] Slideshow Functionality [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107023 (https://phabricator.wikimedia.org/T60848) (owner: 10Apsdehal) [06:42:29] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240586 (https://phabricator.wikimedia.org/T112764) (owner: 10Bartosz Dziewoński) [07:02:50] James_F|Away: We'll be using FSUD and not the normal mw.Upload.Dialog for https://gerrit.wikimedia.org/r/#/c/240116/, eventually, right? [09:01:39] 6Multimedia, 10UploadWizard, 5MW-1.26-release, 5Patch-For-Review, and 2 others: UploadWizard unable to override "similar name"/"same name" detection warning - https://phabricator.wikimedia.org/T48741#1669925 (10AdamCuerden) Thank you so much for this. [10:26:37] (03PS1) 10Zfilipin: Updated watir-webdriver Ruby gem to the latest version [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240670 (https://phabricator.wikimedia.org/T112748) [11:10:08] (03PS3) 10Hashar: build: Bump grunt-jscs from 1.8.0 to 2.1.0 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/235882 (owner: 10Paladox) [11:11:43] (03CR) 10Hashar: [C: 032] build: Bump grunt-jscs from 1.8.0 to 2.1.0 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/235882 (owner: 10Paladox) [11:16:22] (03Merged) 10jenkins-bot: build: Bump grunt-jscs from 1.8.0 to 2.1.0 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/235882 (owner: 10Paladox) [11:47:10] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234912 (owner: 10Paladox) [12:06:49] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 5Patch-For-Review: Update avconv to support opus in ogg files - https://phabricator.wikimedia.org/T53313#1670392 (10McZusatz) [12:12:39] prtksxna: Yeah, edsanders, right? [12:12:59] James_F: I am almost done with refactoring https://gerrit.wikimedia.org/r/#/c/235431/ [12:13:28] * James_F nods. [12:15:33] I only need to track down this weird OOjs UI exception, everything seems to be working [12:15:52] Instead of subclassing the dialog again I'm passing the uploadBooklet as a config now [12:16:20] Neat. [12:41:41] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-RfCs: Provide semantic wiki-configurable styles for media display - https://phabricator.wikimedia.org/T90914#1670526 (10Jdforrester-WMF) Here's a quick stab at a new syntax: `{{#file:Foo.jpg|type=illustration|caption=Hello and welcome to Wikipedia!|altTe... [12:49:08] MatmaRex: Getting this when I used CategorySelector, is this related to a recent change you made? https://phabricator.wikimedia.org/P2086 [12:49:54] prtksxna: grr, yeah, it's something i broke in OOUI. [12:50:14] prtksxna: it's harmless, luckily. you'll just get that error the first time you focus any widget with a dropdown, eh [12:50:38] MatmaRex: Whoops. [12:52:03] MatmaRex: Yeah, everything still seemed to work [12:54:30] MatmaRex: Also, https://gerrit.wikimedia.org/r/#/c/235431/ is ready for review again. [12:54:48] The only thing missing is the actual copy for the notices, marktraceur is working on that [12:56:54] neat [12:57:10] When does https://gerrit.wikimedia.org/r/#/c/238990/ land in mediawiki core? [13:00:21] prtksxna: it landed already, https://gerrit.wikimedia.org/r/#/c/238998/ is not merged yet though [13:00:43] prtksxna: OOUI is updated (almost) every tuesday after the next wmf branch is cut. [13:09:10] prtksxna: James_F: fix is https://gerrit.wikimedia.org/r/240690 [13:13:29] * James_F saw. [13:25:52] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Analyze UploadWizard funnel logs - https://phabricator.wikimedia.org/T95527#1670605 (10BBlack) [13:55:00] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-RfCs: Provide semantic wiki-configurable styles for media display - https://phabricator.wikimedia.org/T90914#1670652 (10cscott) I agree taking over `` would be ambitious, but I'd like to see a long-term strategy that allowed incorporating more of... [14:20:01] > marktraceur is working on that [14:20:02] Oops. [14:20:06] Knew I forgot something [14:20:09] * marktraceur pulls up an etherpad [14:20:53] prtksxna: Do you have a patchset up that has the placeholders? I'd like to know what strings I need to change [14:22:38] > ALL YOUR MEDIA ARE BELONG TO US [14:22:39] Fantastic [14:25:00] * James_F grins. [14:25:11] Commons, you have no time. [14:31:08] prtksxna: I'm changing not-own-work-message to take the wiki name as an argument. [14:31:13] $1 in particular [14:31:27] Also, is there a way to get the terms of use for the current wiki? /me looks [14:35:41] Looks like "probably not", lots of message config stuff [14:35:56] So I guess we can just let them set it via a message [14:36:06] MatmaRex: Wikimedia messages has that. [14:36:08] Err. [14:36:11] marktraceur: ^^ [14:36:12] Meh. [14:36:36] Ahhh. [14:36:52] So I "should" make this general, and then add something more special-er to WikimediaMessages. [14:39:03] Maybe? [14:39:12] But expediency… [14:39:21] 6Multimedia, 10UploadWizard, 5Patch-For-Review, 7user-notice: Make categories more required-looking - https://phabricator.wikimedia.org/T51710#1670832 (10matmarex) [14:40:35] James_F: That's how we got into this mess in the first place! [14:41:23] reaching the goals imagined three months ago shouldn't be a goal by itself… [14:41:26] marktraceur: Not really. We got here by no-one being in charge for too long. [14:41:51] Also yes. [14:41:52] And meeting arbitrary deadlines is a part of staying with the same team in charge for the next quarter. :-) [14:41:59] ^ [14:42:35] MatmaRex: If it makes you feel better, you can have a personal quarterly goal of "not making higher-ups disappointed enough to reshuffle the entire team, again" [14:42:46] And we will all work towards pretty much the same thing. [14:44:25] marktraceur: honestly, i feel that switching up the UI is the least important part of the work i recently did on uploadwizard. [14:44:33] MatmaRex: True! [14:44:53] some of the UI changes are actually real improvements, like the category thing now. others are just different, maybe a bit nicer. [14:45:03] James_F: Seriously though, I feel dirty putting words like "Wikimedia Commons" and "wikimediafoundation.org" into core [14:45:10] Should I ignore those feelings [14:45:19] marktraceur: *cough* wgInstantCommons *cough* [14:45:32] InstantCommons is still different and I'm tired of repeating myself [14:45:46] But OK, we're down the rabbit hole anyway [14:46:07] Yeah. [14:46:11] MatmaRex: I agree, but "a bit nicer" is the relevant metric for design changes [14:46:17] Alongside "more consistent" [14:46:27] Which sounds like one of those phrases that shouldn't be a thing. [14:46:28] And I'm tired of repeating myself that InstantCommons really isn't that different, and should be fixed to not be in core. [14:46:42] well no, "actually easier to use" is the metric relevant to me. [14:46:50] James_F: Sold. Next quarter. :) [14:47:02] I think "More useful for users" should be the metric. :-) [14:47:13] S'pose so. [14:47:23] "a bit nicer" seems like a subset at least [14:47:37] Yeah. [14:47:38] right [14:48:17] marktraceur: hmm, so we're wondering how to put Commons' legal text into the upload dialog thing that we have in MW core? [14:49:17] MatmaRex: Same issue, I guess. [14:49:23] MatmaRex: Yup [14:50:57] prtksxna: Oh, I didn't realize slaporte had given you this text. I have butchered it. I will attempt to convince him of my evil ways. [14:51:52] we already have things like the 'shared-repo-name-wikimediacommons' message, which is cunningly constructed dynamically under the pretense of allowing different repo names… we could do that here somehow [14:54:19] marktraceur: personally, i'll be able to sleep soundly at night if we name the message something clear like 'uploaddialog-legal-text-wikimediacommons', and give the upload dialog (or is it booklet now) an option to override the message name. [14:54:26] like we did with mw.ForeignUpload's targetHost, basically. [14:56:40] i wonder if we should refactor this to have $wg variables for the default target host and legal text message name. [14:56:49] marktraceur: James_F: ^ [14:57:20] Could do. [14:57:34] But they shouldn't even be set to WMF-related defaults in DefaultSettings [14:58:27] They should default to unset, I guess. I dunno. MW-core purity is hard to judge. [14:59:57] MatmaRex: We don't have any way to set the remote repo for uploads yet, do we? I think that could be our one $wg variable and we could do the rest with messages (like the -wikimediacommons ones) [15:02:07] I believe I have enough time to run and get breakfast. BRB... [15:19:32] 6Multimedia, 10UploadWizard: Tooltip in UploadWizard shows HTML entity number - https://phabricator.wikimedia.org/T113615#1670922 (10Beta16) 3NEW [15:27:48] * prtksxna scrolls up [15:33:18] firefox is closed but I can still hear MatmaRex :O [15:33:28] Weird [15:34:46] marktraceur: The ALL YOUR MED… string isn't needed any more I think [15:34:53] Oh, OK. [15:35:20] marktraceur: It shows up at the bottom of the second step. We are now showing all disclaimers in the first step itself. [15:35:37] Right. [15:35:49] Or we could leave it there… [15:36:17] https://etherpad.wikimedia.org/p/legal-text-upload-dialog [15:36:22] My current pass. [15:36:28] They're a bit verbose [15:36:43] More verbose than Stephen's, perhaps, and maybe that's a bad thing? [15:43:14] marktraceur: I think the not-own-work-message could be smaller [15:43:38] Probably. I'm suggesting two possible solutions to their problem, though, so [15:44:38] prtksxna: Does the $wgRemoteUploadTarget and various -nameoftarget messages (like -wikimediacommons) make sense? [15:44:51] I just felt it was too much text for the non-default option in the dialog [15:45:17] Ah. [15:45:32] prtksxna: I agree [15:46:04] prtksxna: Hm, Special:Upload might be disabled on some wikis... [15:46:22] marktraceur: Oh [15:46:35] Does the $wgRemoteUploadTarget and various -nameoftarget messages (like -wikimediacommons) make sense? <-- I don't understand [15:48:07] prtksxna: Instead of assuming that people using FSUD are using Commons (which is what these messages do now), we could use a message that ends in -wikimediacommons and set $wgRemoteUploadTarget to "wikimediacommons" in WMF settings. [15:48:45] prtksxna: And also maybe define some stuff like API URL in a fancy $wgRemoteUploadTargets array that has 'wikimediacommons' => array( ... ) [15:48:55] But that's for another day. [15:48:57] marktraceur: Yes, that makes sense :) [15:49:10] OK. [15:49:17] marktraceur: You already put targetHost that takes this into consideration [15:49:29] Yeah, we just need to add it to the messages too [15:50:03] https://fr.wikinews.org/wiki/Sp%C3%A9cial:T%C3%A9l%C3%A9verser?uselang=en ugh could that be less helpful [15:56:47] (03CR) 10Jdlrobson: [C: 032] "They are failing anyway. Might as well try recent code." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/238971 (https://phabricator.wikimedia.org/T112748) (owner: 10Zfilipin) [15:59:08] (03Merged) 10jenkins-bot: Updated watir-webdriver Ruby gem to the latest version [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/238971 (https://phabricator.wikimedia.org/T112748) (owner: 10Zfilipin) [16:32:11] (03PS1) 10Bartosz Dziewoński: UploadWizardDetails: Remove broken updateCopyMsgs() function [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240736 [16:38:41] marktraceur: Feel free to amend to https://gerrit.wikimedia.org/r/#/c/235431 [16:40:49] (03CR) 10Nikerabbit: [C: 032] UploadWizardDetails: Remove broken updateCopyMsgs() function [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240736 (owner: 10Bartosz Dziewoński) [16:42:25] (03Merged) 10jenkins-bot: UploadWizardDetails: Remove broken updateCopyMsgs() function [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240736 (owner: 10Bartosz Dziewoński) [16:53:02] prtksxna: You think the current text in the pad is decent? [16:59:12] marktraceur: I added an alternative, also etherpad is down for me [17:00:45] How do we figure out is Special:Upload is available? Or do we just ignore that for now? [17:01:06] I mean, $wgEnableUploads [17:16:05] marktraceur: Anything in particular you want me to work on, or should I pick whatever I fancy from next-up? [17:20:53] prtksxna: I'm a firm believer in being master of your own fate [17:21:10] But hang on a tick [17:21:33] prtksxna: Want to take a look at the text fields patch, maybe? [17:21:47] sure [17:21:59] prtksxna: And don't mention the bug: format. :P [17:22:04] https://gerrit.wikimedia.org/r/#/c/212842/4 [17:27:50] (03PS1) 10Paladox: Update i18n messages [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/240760 [17:31:56] (03PS2) 10Paladox: Update i18n messages [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/240760 (https://phabricator.wikimedia.org/T113632) [17:35:48] (03CR) 10Kaldari: [C: 04-1] Add extensions.json, empty PHP entry point (033 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210176 (https://phabricator.wikimedia.org/T87981) (owner: 10Paladox) [17:46:16] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/240760 (https://phabricator.wikimedia.org/T113632) (owner: 10Paladox) [17:48:34] (03PS3) 10Paladox: Update i18n messages [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/240760 (https://phabricator.wikimedia.org/T113632) [17:53:35] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-RfCs: Provide semantic wiki-configurable styles for media display - https://phabricator.wikimedia.org/T90914#1671807 (10Tgr) There is also a quality option for JPEGs and a lossless/lossy option for DjVu; presumably those can be merged into type. `lang` s... [17:54:38] (03CR) 10Kaldari: Allow displaying more than 50 Flickr images at once (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (https://phabricator.wikimedia.org/T44979) (owner: 10Nischayn22) [18:06:41] MatmaRex: The date input widget is so complicated D: [18:08:47] prtksxna: it gets worse after https://gerrit.wikimedia.org/r/238998 :( [18:09:27] it should be easy to actually use, though. [18:10:09] MatmaRex: Yeah, I said that after going through that patch and not understanding much [18:10:19] MatmaRex: I think the 'recheck' is all I can contribute :P [18:11:06] it did get a bit crazy and i have nothing to blame for that but myself, heh [18:11:17] MatmaRex: Which it is, at least in the limited way that FSUD (or should I say FSUBL) uses it. [18:19:42] (03CR) 10Kaldari: Allow displaying more than 50 Flickr images at once (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (https://phabricator.wikimedia.org/T44979) (owner: 10Nischayn22) [18:25:13] James_F: Think we should have a non-wikimediacommons default for these messages? [18:25:46] Like "I agree that I'm not a total moron and I can upload this file legally" "If you are a total moron, or cannot upload this file legally, please close this dialog." [18:29:00] marktraceur: Maybe we should think about what that is. [18:29:26] marktraceur: "I confirm that this file is entirely my own work, and I agree to the terms of the site to which I'm uploading." [18:29:36] I understand that I am uploading this file to $1, that I have permission to do so, and that I am doing so pursuant to the terms of service and licensing policies of $1. [18:29:54] $1 being the name of the target site in all three messages [18:29:54] "pursuant"? [18:30:01] Do you /want/ the user to ignore it? [18:30:10] Heh [18:30:11] If you are not able to upload this file under the policies of $1, please close this dialog and try another method. [18:30:18] Pursuant is a real word, James_F [18:30:24] (03PS7) 10Kaldari: Allow displaying more than 50 Flickr images at once [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (https://phabricator.wikimedia.org/T44979) (owner: 10Nischayn22) [18:30:43] How about "under" like the other message [18:31:16] marktraceur: So is "notwithstanding". [18:32:08] Yes. It is. [18:32:17] marktraceur: "I understand that I am uploading this file to {{#GRAMMAR:$1}}, that I have permission to do so, and that I am doing so following the terms of service and licensing policies of {{#GRAMMAR:$1}}." [18:32:34] (Accusative vs. genitive.) [18:32:37] Oh, gods. [18:33:07] (03CR) 10jenkins-bot: [V: 04-1] Allow displaying more than 50 Flickr images at once [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (https://phabricator.wikimedia.org/T44979) (owner: 10Nischayn22) [18:33:10] "I understand that I am uploading this file to $1, that I have permission to do so, and that I am doing so following that site's terms of service and licensing policies." [18:33:40] "that site" sounds clumsy, though. [18:33:51] the "I have permission to do so" seems superfluous. [18:34:06] Ish [18:34:15] There? [18:34:56] Hm? [18:35:24] "I understand that I am uploading this file to $1. I confirm that I have permission to do so, and that I am doing so following the terms of service and licensing policies there." [18:35:31] Sure. [18:35:51] Also, en-gb: [18:36:16] "I understand that I am uploading this file to $1. I confirm that I have permission so to do, and that I am following the terms of service and licensing policies there in so doing." [18:36:17] ;-) [18:36:17] I think I will take out the permission thing actually [18:36:49] Also, later, s/file/{file|image|video|sound|…} [18:36:51] But later. [18:36:53] OK. [18:47:03] Urgh. OK, I think that looks right. [18:47:14] Some LEGO happening. But I'm not sure what to do about that. [18:47:26] :| [18:48:27] (03PS8) 10Kaldari: Allow displaying more than 50 Flickr images at once [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (https://phabricator.wikimedia.org/T44979) (owner: 10Nischayn22) [18:49:00] legoktm: The remote repository names are stored in messages! I can't do a single goddamn thing about that [18:49:48] yeah :( [18:50:14] We could make it an object. [18:50:24] It only works for JSON-aware things, but… [18:51:02] Here's where James_F says "Later." [18:55:40] prtksxna: Amended. [18:59:33] marktraceur: Again. [18:59:42] marktraceur: I said "later" earlier but you ignored me. :-P [19:00:49] James_F: Well, I mean, this was a different thing that we might do later. [19:00:58] * James_F nods. [19:01:04] Then let's think about it later too? ;-) [19:01:29] And how [19:01:47] * James_F grins. [19:12:46] (03PS9) 10Kaldari: Allow displaying more than 50 Flickr images at once [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (https://phabricator.wikimedia.org/T44979) (owner: 10Nischayn22) [19:14:39] Argh, I missed any chance of getting proper food for lunch [19:14:43] Curse you, time [19:15:51] (03CR) 10Kaldari: [C: 032] Allow displaying more than 50 Flickr images at once [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (https://phabricator.wikimedia.org/T44979) (owner: 10Nischayn22) [19:16:48] wow, a sudden merge [19:16:55] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Upload from Flickr only fetches the first 50 items of a set - https://phabricator.wikimedia.org/T44979#1672204 (10kaldari) @Jarekt: Change is merged. You will now be able to see up to 500 images at a time (which is limited by Flickr's API, not us). [19:17:04] 6Multimedia, 6Commons, 10UploadWizard, 7Tracking: UploadWizard Flickr (tracking) - https://phabricator.wikimedia.org/T45450#1672206 (10kaldari) [19:17:05] (03Merged) 10jenkins-bot: Allow displaying more than 50 Flickr images at once [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (https://phabricator.wikimedia.org/T44979) (owner: 10Nischayn22) [19:17:05] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Upload from Flickr only fetches the first 50 items of a set - https://phabricator.wikimedia.org/T44979#1672205 (10kaldari) 5Open>3Resolved [19:22:17] Uhhh [19:22:19] kald [19:22:20] 6Multimedia, 10UploadWizard, 5Patch-For-Review, 7user-notice: Upload from Flickr only fetches the first 50 items of a set - https://phabricator.wikimedia.org/T44979#1672235 (10Nemo_bis) \o/\o/ [19:22:21] ffs [19:24:27] Did he *self-merge* [19:26:17] 2015-09-24 - 14:16:36 marktraceur: I talked to the folks at Flickr [19:37:04] (03CR) 10Bartosz Dziewoński: "-1" (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (https://phabricator.wikimedia.org/T44979) (owner: 10Nischayn22) [19:41:50] (03CR) 10Raimond Spekking: "i18n review" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/45951 (https://phabricator.wikimedia.org/T44979) (owner: 10Nischayn22) [19:59:05] (03PS12) 10Paladox: Add extension.json, empty PHP entry point [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187735 (https://phabricator.wikimedia.org/T87943) (owner: 10Gilles) [20:09:28] hey marktraceur [20:09:29] https://gerrit.wikimedia.org/r/#/c/240441/ [20:10:18] (03PS2) 10Bartosz Dziewoński: Pass 'verbose: true' to all MessageDialogs to get bigger font size [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240441 [20:10:28] (03PS8) 10Bartosz Dziewoński: Unbreak confirmation of no categories being set [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239418 (https://phabricator.wikimedia.org/T51710) [20:55:48] Hey MatmaRex, on it [20:56:38] (03CR) 10MarkTraceur: [C: 032] Pass 'verbose: true' to all MessageDialogs to get bigger font size [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240441 (owner: 10Bartosz Dziewoński) [20:58:07] (03Merged) 10jenkins-bot: Pass 'verbose: true' to all MessageDialogs to get bigger font size [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240441 (owner: 10Bartosz Dziewoński) [20:59:09] (03PS2) 10Bartosz Dziewoński: Replace jquery.mwCoolCats with mediawiki.widgets.CategorySelector [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240586 (https://phabricator.wikimedia.org/T112764) [20:59:11] (03PS1) 10Bartosz Dziewoński: Correct config documentation mentioning non-existent option [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240890 [20:59:13] (03PS1) 10Bartosz Dziewoński: Remove TODO comment that offers bad advice [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240891 [20:59:15] (03PS1) 10Bartosz Dziewoński: Set a name attribute for the date input field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240892 [20:59:22] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Replace CoolCats with mw.widgets.CategorySelector - https://phabricator.wikimedia.org/T112764#1672604 (10matmarex) Screenshots: | Adding first category | {F2632188} | | Adding another one | {F2632190} | | Warning shown for non-existent category | {F2632195} |... [20:59:43] marktraceur: i think that's it for the categories! [21:00:02] (03CR) 10Paladox: Add extensions.json, empty PHP entry point (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210176 (https://phabricator.wikimedia.org/T87981) (owner: 10Paladox) [21:02:03] (03PS38) 10Paladox: Add extensions.json, empty PHP entry point [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210176 (https://phabricator.wikimedia.org/T87981) [21:04:29] Woohoo! [21:04:56] Should go through tomorrow, then. [21:05:40] marktraceur: no hurry. we still need to push through the category warning thing this week first [21:05:54] Ah, right. [21:06:26] MatmaRex: One response on VPP, nothing too troubling...I guess it's fine [21:06:41] probably. but still. :) [21:08:35] marktraceur: by the way, i was thinking about UploadWizardDetails and how horrible it is, and [21:10:54] marktraceur: i think it would really help if we separated out a class (a OOUI widget) for each of the fields, and each class handled UI, validation and wikitext-getting for itself only, rather than UploadWizardDetails handling everything. [21:12:08] marktraceur: i don't think there's much value in trying to separate the UI (and DOM) from the internal logic here. we should just make sure than the UI reflects the logic, and not *is* the logic, like now. (especially with the $.validator plugin) [21:13:52] (03CR) 10Gergő Tisza: "This is almost done except there is an error that happens on phantomjs only. I'm not working on it anymore, feel free to abandon or take o" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/167419 (https://phabricator.wikimedia.org/T77625) (owner: 10Gergő Tisza) [21:14:29] (03CR) 10Gergő Tisza: "Will pick this up if the parent gets merged." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178141 (https://phabricator.wikimedia.org/T76030) (owner: 10Gergő Tisza) [21:15:17] (03Abandoned) 10Gergő Tisza: [WIP] Always enable on global user pages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/228751 (https://phabricator.wikimedia.org/T105986) (owner: 10Gergő Tisza) [21:17:19] (03CR) 10Gergő Tisza: "This is mostly good but triggers a browser bug on FF. I want to get back to finishing it, uhh, eventually. Feel free to take over though." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 (https://phabricator.wikimedia.org/T110579) (owner: 10Gergő Tisza) [21:19:48] (03CR) 10Gergő Tisza: [C: 04-1] "Needs a rebase and then good to go." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169496 (owner: 10Gergő Tisza) [21:20:24] MatmaRex: Sounds like a decent plan to me [21:21:34] (03CR) 10Gergő Tisza: "Will see if this is easy to fix." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/143099 (owner: 10Gergő Tisza) [21:22:31] (03PS2) 10Gergő Tisza: [WIP] Add position handling to URLs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126153 (https://phabricator.wikimedia.org/T64039) [21:22:34] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add position handling to URLs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126153 (https://phabricator.wikimedia.org/T64039) (owner: 10Gergő Tisza) [21:23:36] (03Abandoned) 10Gergő Tisza: [WIP] Hide overflow in permission text box using $.dotdotdot [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115849 (owner: 10Gergő Tisza) [21:25:33] (03Abandoned) 10Gergő Tisza: [WIP] Add jquery.dotdotdot plugin for truncating text at a given height [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115848 (owner: 10Gergő Tisza) [21:53:56] 6Multimedia, 10UploadWizard: Unescaped messages on Special:UploadWizard - https://phabricator.wikimedia.org/T113669#1672816 (10matmarex) 3NEW a:3matmarex [21:54:32] 6Multimedia, 10MassAction, 10MediaWiki-Internationalization, 10MediaWiki-extensions-GWToolset, and 4 others: Special pages, actions and views whose messages don't escape text - https://phabricator.wikimedia.org/T85864#1672828 (10matmarex) [22:34:12] (03CR) 10Jdlrobson: [C: 031] "Seems to work fine but I don't know this extension well enough at this time to tell whether it's complete." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187735 (https://phabricator.wikimedia.org/T87943) (owner: 10Gilles) [22:41:04] (03CR) 10Jdlrobson: [C: 04-1] "Please be more verbose in the commit message so I can understand the rationale for what you are doing here." (037 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178059 (https://phabricator.wikimedia.org/T76030) (owner: 10Gergő Tisza)