[01:01:38] 6Multimedia, 10MediaWiki-File-management, 6Security, 5MW-1.23-release, and 6 others: thumb.php must html-escape rel404 parameter in error message - https://phabricator.wikimedia.org/T97391#1588261 (10Krenair) CVE-2015-6729 was assigned for the original issue, CVE-2015-6730 for further discoveries upon inte... [01:12:48] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 6Security, 7Security-Extensions, 7Vuln-DoS: Reset of transcode does not queue new transcode - https://phabricator.wikimedia.org/T100211#1588271 (10Krenair) CVE-2015-6735 was assigned for this. [05:48:55] 6Multimedia, 10MediaWiki-extensions-PdfHandler, 6operations: Error creating PDF on Commons: "convert: no decode delegate for this image format" (fixed in GS 9.07) - https://phabricator.wikimedia.org/T50007#1588409 (10Thgoiter) I still see 10 files without thumbnail in http://commons.wikimedia.org/wiki/Catego... [05:51:45] 6Multimedia, 10MediaWiki-File-management: Find a better solution for a "clickable image" on file pages - https://phabricator.wikimedia.org/T73485#1588417 (10Nemo_bis) Providing a link to the original by default is integral to our pursuit of free knowledge. It will not be removed. [06:25:10] 6Multimedia, 10MediaWiki-File-management, 6Performance-Team, 7Swift: Investigate thumbor - https://phabricator.wikimedia.org/T110858#1588430 (10Gilles) 3NEW a:3Gilles [08:16:59] 6Multimedia, 10MediaWiki-DjVu, 10Wikimedia-Media-storage: Some DjVu files not being rendered in commons (showing up as "0 × 0 pixels", despite the file size in MB being nonzero) - https://phabricator.wikimedia.org/T107664#1588538 (10Aklapper) >>! In T107664#1502796, @waldyrious wrote: > I've [asked the uploa... [08:18:09] 6Multimedia, 10MediaWiki-extensions-PdfHandler: Switch to MuPDF for thumbnailing PDFs - https://phabricator.wikimedia.org/T38594#1588542 (10Aklapper) p:5Normal>3Low [08:23:51] 6Multimedia, 10MediaWiki-extensions-PdfHandler, 6operations: Error creating PDF on Commons: "convert: no decode delegate for this image format" (fixed in GS 9.07) - https://phabricator.wikimedia.org/T50007#1588562 (10Aklapper) >>! In T50007#1588409, @Thgoiter wrote: > Is this another bug? Yes - see the erro... [09:39:00] (03PS2) 10Addshore: Fix button config for campaigns to check for a given object reference [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/234567 (https://phabricator.wikimedia.org/T110697) (owner: 10Kai Nissen (WMDE)) [09:39:07] (03CR) 10Addshore: [C: 032] Fix button config for campaigns to check for a given object reference [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/234567 (https://phabricator.wikimedia.org/T110697) (owner: 10Kai Nissen (WMDE)) [09:40:10] (03Merged) 10jenkins-bot: Fix button config for campaigns to check for a given object reference [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/234567 (https://phabricator.wikimedia.org/T110697) (owner: 10Kai Nissen (WMDE)) [10:58:44] (03CR) 10Nemo bis: [C: 04-1] Changed the message for "mwe-upwiz-license-show-recommended" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/232925 (owner: 10Haritha28) [10:59:52] (03CR) 10Nemo bis: "Worse: the commit message is wrong, the bug report says "you are returned to the default license that you chose in your preferences". Henc" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/232925 (owner: 10Haritha28) [13:39:28] 6Multimedia, 10MediaWiki-File-management, 6Security, 5MW-1.23-release, and 6 others: thumb.php must html-escape rel404 parameter in error message - https://phabricator.wikimedia.org/T97391#1589134 (10Ngocdh) Seems that this is an unknown xss vector: /thumb.php?f=!... [14:02:53] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: Report offset in stash mode after warning happened - https://phabricator.wikimedia.org/T110845#1589176 (10Anomie) [15:02:50] (03CR) 10Jforrester: "> Does this sudden interest in PronunciationRecording mean people are looking to get it deployed?" [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/233183 (owner: 10Jforrester) [15:05:23] marktraceur: hi, around? [15:06:29] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/UploadWizard] (wmf/1.26wmf20) - 10https://gerrit.wikimedia.org/r/234553 (https://phabricator.wikimedia.org/T92801) (owner: 10Bartosz Dziewoński) [15:09:40] MatmaRex: I'm here, what's up? [15:10:21] marktraceur: can you verify the swat in a few minutes? i've gotta go out for a bit. thcipriani is swatting on #-operations [15:12:57] (03Merged) 10jenkins-bot: Keep the uploads sorted in the order they were created in initially [extensions/UploadWizard] (wmf/1.26wmf20) - 10https://gerrit.wikimedia.org/r/234553 (https://phabricator.wikimedia.org/T92801) (owner: 10Bartosz Dziewoński) [15:18:40] 6Multimedia, 10MediaWiki-File-management, 6Performance-Team, 7Swift: Investigate thumbor - https://phabricator.wikimedia.org/T110858#1589399 (10Gilles) First important findings: - Thumbor doesn't help with the URL scheme. Its URLs are based on the URL of the original, therefore the solution to this proble... [15:18:57] 6Multimedia, 10MediaWiki-File-management, 6Security, 5MW-1.23-release, and 6 others: thumb.php must html-escape rel404 parameter in error message - https://phabricator.wikimedia.org/T97391#1589401 (10Krenair) >>! In T97391#1589134, @Ngocdh wrote: > Seems that this is an unknown xss vector: > > /thumb.php?... [16:26:23] MatmaRex: Still looks good after any cache would have been cleared [16:26:25] So hoorah. [17:02:17] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: MultimediaViewer gets double buttons after editing file page - https://phabricator.wikimedia.org/T110908#1589682 (10MarkTraceur) 3NEW [17:02:26] wikibugs: NO. Not our problem. [17:03:06] James_F: Do we have a request in to update Herald rules for MMV? [17:11:20] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: MultimediaViewer gets double buttons after editing file page - https://phabricator.wikimedia.org/T110908#1589716 (10matmarex) [17:11:23] 6Multimedia, 6Commons, 10MediaWiki-extensions-MultimediaViewer: "Open in Media Viewer" box appears twice - https://phabricator.wikimedia.org/T110493#1589718 (10matmarex) [17:13:43] 6Multimedia, 6Commons, 10MediaWiki-extensions-MultimediaViewer: "Open in Media Viewer" box appears twice - https://phabricator.wikimedia.org/T110493#1589734 (10MarkTraceur) @tgr yes, I believe this is only after editing, and as far as I can tell it happens every time... [17:14:00] Thanks MatmaRex [17:14:49] hm, who maintains that now, then? [17:18:30] MatmaRex: James_F insists that it's Reading's job. [17:18:51] I am not about to disagree with that. [17:26:53] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler: When relevant codecs aren't available, an inaccurate message recommending "an HTML5 video browser" is displayed - https://phabricator.wikimedia.org/T96219#1589777 (10brion) I believe you'll still get it on older versions of Safari (6.0 and below) and IE (9... [17:31:03] 6Multimedia, 10Beta-Cluster, 10MediaWiki-extensions-TimedMediaHandler, 10Wikimedia-Video: Videoscalers (tmh*) not working in Beta Cluster - https://phabricator.wikimedia.org/T90332#1589795 (10brion) 5Open>3Resolved a:3brion We got this working on Friday. \o/ [17:32:41] 6Multimedia, 10Beta-Cluster, 10MediaWiki-extensions-TimedMediaHandler, 10Wikimedia-Video: Videoscalers (tmh*) not working in Beta Cluster - https://phabricator.wikimedia.org/T90332#1589806 (10Jdforrester-WMF) Woo. [17:34:13] 6Multimedia, 10Wikimedia-General-or-Unknown, 6Wikisource, 6operations: Upgrade Ghostscript to 9.15 or later - https://phabricator.wikimedia.org/T110849#1589813 (10matmarex) I went through the bugs filed under #mediawiki-extensions-pdfhandler and found two more (seems like distinct issues) that I can't repr... [17:35:21] 6Multimedia, 10MediaWiki-extensions-PdfHandler, 6Wikisource: PDF file entirely rendered as a set of blank pages - https://phabricator.wikimedia.org/T110821#1589826 (10matmarex) [17:53:24] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 6operations, 7HHVM, 5Patch-For-Review: Convert tmh100[12] to HHVM and trusty - https://phabricator.wikimedia.org/T104747#1589900 (10brion) [17:55:11] brion: is vp9 in prod yet ? [17:58:08] matanya: No. [17:58:23] matanya: But it is in Beta Cluster. [17:59:03] matanya: See http://en.wikipedia.beta.wmflabs.org/wiki/File:Snowdonia_by_drone.webm (the "WebM 360P" transcode is from VP9 to VP8). [17:59:25] thanks James_F eta for it ? [17:59:34] matanya: "Soon". [17:59:41] when it is ready :) [17:59:50] matanya: Need to work out if the job runner stuff isn't working in Beta Cluster because of VP9 or otherwise. [18:00:05] will i need resubmit all my vids ? [18:00:21] This is VP9 input, not VP9 output. [18:00:40] means ? [18:16:26] marktraceur: can you review and merge https://gerrit.wikimedia.org/r/#/c/233772/ before tomorrow's branch cut? [18:19:06] 6Multimedia, 10MediaWiki-File-management, 6Security, 5MW-1.23-release, and 6 others: thumb.php must html-escape rel404 parameter in error message - https://phabricator.wikimedia.org/T97391#1590030 (10Ngocdh) It was reported to security@wikimedia.org [18:27:24] 6Multimedia, 10MediaWiki-DjVu, 10Wikimedia-Media-storage: Some DjVu files not being rendered in commons (showing up as "0 × 0 pixels", despite the file size in MB being nonzero) - https://phabricator.wikimedia.org/T107664#1590093 (10waldyrious) @Aklapper, no on both counts :( User:Clockery, in particular, se... [18:32:19] (03PS1) 10Bartosz Dziewoński: Help users trying to input a template as upload date [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235052 (https://phabricator.wikimedia.org/T110026) [18:41:52] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 6operations, 7HHVM, 5Patch-For-Review: Convert tmh100[12] to HHVM and trusty - https://phabricator.wikimedia.org/T104747#1590207 (10bd808) [18:45:14] matanya: any vp9 vids you've already uploaded should not require a reupload [18:45:31] thanks brion and the vp8 ones ? [18:45:36] matanya: will just have to re-trigger the transcodes... you can do this manually with the 'reset transcode' links, or wait until my bot gets to them :) [18:45:41] which might be a while :D [18:45:58] matanya: vp8 ones should already work so no upload needed either :D [18:46:24] brion: should work - yes, but isn't vp9 better from our pov ? [18:46:38] and speaking of vp's vp10 was just announced [18:46:46] matanya: for a source file the only real difference it makes is filesize of the original :D [18:47:13] vp9 originals may be smaller, which is a plus at upload time ;) [18:47:13] will we get it in 2020? J/K :) [18:47:32] though it tends to make a smaller difference at high quality settings than the lower qualities we use for transcode output [18:47:39] and bandwidth usage [18:48:00] yeah, vp9 transcodes will use 1/2 the bandwidth of our existing vp8 transcodes :DD [18:48:05] but they will take longer to encode :( [18:48:32] I saw the timeouts on beta cluster [18:48:46] this is a trade-off i am willing to pay [18:48:59] we serve the users and pay the penalty server side [18:49:05] yep! [18:49:19] How many clients do VP8 but not VP9? [18:49:30] Do we need to hold back before converting existing VP8 transcodes to VP9? [18:49:42] James_F: http://caniuse.com/#feat=webm [18:49:58] basically only android stock browser doesn't do vp9 in current version [18:50:08] (well that does vp8, obvs :D) [18:50:36] James_F: and they'll auto-detect, so clients that don't grok vp9 will get the vp8 [18:51:11] So we'll have Ogg Theora, WebM VP8 and WebM VP9 streams all at once? [18:51:30] eventually we could probably turn off the vp8 (at least at higher resolutions) if we have to save space [18:51:32] yep [18:52:01] Ops might not be so happy. :-) [18:52:07] (03PS1) 10Bartosz Dziewoński: Improve OpenStreetMap link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235058 (https://phabricator.wikimedia.org/T1099) [18:52:08] Have we spoken to them about space issues? [18:52:09] disks are cheap :D [18:52:36] Not that cheap. :-P [18:52:48] so far nobody's screamed about using too much space, but i'll be sure ot bring it up [18:52:58] so, firefox 28+ chrome 25+ opera 16+ no IE or safari without plugin [18:53:18] usual stuff [18:53:19] mainly folks worrying about handling of super-large individual files [18:53:32] and if anything, vp9 helps by making the larger transcodes smaller :D [18:56:42] brion: If we were replacing VP8 with VP9 I think Ops would jump for joy, yes. :-) [18:57:13] James_F: they are working on it [18:57:49] brion: Could we bump Android devices to ogv.js and just ship VP9? Or would that be premature? [18:58:01] James_F: we could if we need to :) [18:58:47] brion: Want to write a message to Ops asking how painful the current plan is? I like to avoid surprising people. :-) [19:03:05] James_F: i'm writing such an email right now! :D [19:03:56] Awesome. :-) [19:08:48] MatmaRex: On it. [19:10:21] James_F: sent [19:12:09] Ta. [19:12:55] (03CR) 10MarkTraceur: [C: 032] "Thanks for handling this quickly :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/233772 (https://phabricator.wikimedia.org/T110026) (owner: 10Bartosz Dziewoński) [19:13:22] marktraceur: Woo. [19:13:56] (03Merged) 10jenkins-bot: Redesign switcher between calendar and freeform date inputs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/233772 (https://phabricator.wikimedia.org/T110026) (owner: 10Bartosz Dziewoński) [19:15:22] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Make it clearer that you can use a free-form date in UploadWizard by clicking the button next to the date input - https://phabricator.wikimedia.org/T110026#1590332 (10MarkTraceur) 5Open>3Resolved a:3MarkTraceur Merged rede... [19:20:16] (03CR) 10MarkTraceur: [C: 032] Help users trying to input a template as upload date [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235052 (https://phabricator.wikimedia.org/T110026) (owner: 10Bartosz Dziewoński) [19:21:23] (03Merged) 10jenkins-bot: Help users trying to input a template as upload date [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235052 (https://phabricator.wikimedia.org/T110026) (owner: 10Bartosz Dziewoński) [19:27:10] 6Multimedia, 6Commons, 10MediaWiki-extensions-MultimediaViewer: "Open in Media Viewer" box appears twice - https://phabricator.wikimedia.org/T110493#1590387 (10Redrose64) Have just found that English Wikipedia is affected as well as Commons [19:44:42] MatmaRex: Hmm, I'm still getting the old date-created box-with-a-cog on http://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard – shouldn't it be updated? [19:46:20] James_F: it should. [19:46:31] but beta has been fucked for months. i stopped relying on it [19:46:56] MatmaRex: It claims it's up-to-date. [19:47:02] well duh [19:47:07] who cares what it claims [19:47:17] Oh, hmm, no it doesn't. [19:47:20] it always claims that, yet always serves old files [19:47:23] Have sub-module updates stopped working? [19:49:26] James_F: Beta is not to be trusted, that doesn't mean anything else is broken [19:49:33] Unless you fix beta and still see that things are broken [19:49:45] marktraceur: Sure, but for everything else I work on it's pretty reliable. [19:51:42] James_F: it's reliably broken for me for everything i try to use it for [19:52:15] well, the pure PHP part usually works, i guess. [19:52:19] MatmaRex: :-( It reliably works for VE, WE, watchlist, Echo and Flow in my experience. [19:52:41] Which are the things I'm habitually using/testing. [20:01:38] MatmaRex, marktraceur: Aha, updated now, just BC update being slow. [20:02:45] (03PS1) 10Bartosz Dziewoński: Tweak spacing of checkboxes in metadata copier [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235068 (https://phabricator.wikimedia.org/T110787) [20:06:12] (03CR) 10Jforrester: [C: 031] Tweak spacing of checkboxes in metadata copier [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235068 (https://phabricator.wikimedia.org/T110787) (owner: 10Bartosz Dziewoński) [20:24:21] (03CR) 10MarkTraceur: [C: 032] "Fair enough" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235068 (https://phabricator.wikimedia.org/T110787) (owner: 10Bartosz Dziewoński) [20:24:31] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Excess whitespace around UploadWizard checkboxes - https://phabricator.wikimedia.org/T110787#1590542 (10MarkTraceur) 5Open>3Resolved [20:24:42] Little nitpicky, but OK :) [20:24:53] (I agree with MatmaRex there) [20:25:47] (03Merged) 10jenkins-bot: Tweak spacing of checkboxes in metadata copier [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235068 (https://phabricator.wikimedia.org/T110787) (owner: 10Bartosz Dziewoński) [21:05:28] 6Multimedia, 6Commons, 10MediaWiki-extensions-MultimediaViewer: "Open in Media Viewer" box appears twice - https://phabricator.wikimedia.org/T110493#1590650 (10Tgr) Possibly related to https://gerrit.wikimedia.org/r/#/c/231079 since not much else changed. Do we fire the `postEdit` hook even after a normal edit? [21:11:25] 6Multimedia, 6Commons, 10MediaWiki-extensions-MultimediaViewer: "Open in Media Viewer" box appears twice - https://phabricator.wikimedia.org/T110493#1590658 (10matmarex) We do. Is there a reason you didn't use `wikipage.content` hook? (It is fired after the page is loaded or previewed, after a page is saved... [21:12:38] 6Multimedia, 6Commons, 10MediaWiki-extensions-MultimediaViewer: "Open in Media Viewer" box appears twice - https://phabricator.wikimedia.org/T110493#1590663 (10matmarex) (Generally, `wikipage.content` hook is what you want to use if you were using the document-ready event previously, and now want to effortle... [21:39:14] 6Multimedia, 10MediaWiki-File-management, 6Security, 5MW-1.23-release, and 6 others: thumb.php must html-escape rel404 parameter in error message - https://phabricator.wikimedia.org/T97391#1590768 (10csteipp) @Ngocdh, I documented xss via the f parameter in https://phabricator.wikimedia.org/T97391#1242481 [22:00:27] prtksxna: How's our dialog design stuff going? I think I saw a mockup go by, are we looking OK to start pushing stuff into VE? [22:00:43] I guess ForeignStructuredUpload still isn't merged... [22:01:04] Ugh, "private" [22:01:11] I hate private functions in JS. :P [22:02:23] marktraceur: I know Nirzar was working on this with Prateek. [22:02:27] marktraceur: Some nice stuff coming. [22:04:10] OK then. [23:49:17] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: UploadWizard fails uploading pdf with error message - https://phabricator.wikimedia.org/T94562#1591248 (103BRBS) Hi all, I am running into problems also. I tried, chunked upload directly, also usi... [23:50:58] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Failed 97MB PDF upload to Commons via Chunked Upload: "00994: FAILED: success" - https://phabricator.wikimedia.org/T107704#1591252 (103BRBS) Hi, I believe the error should be similar to this: Since I couldn't publish from that screen, and this is what I got:...