[14:15:08] marktraceur: https://github.com/prtksxna/UploadUI/commit/054bb175c70cb0f9ac7de073a56ff9272fa66af7 [14:15:35] marktraceur: Where should this go in - https://github.com/wikimedia/mediawiki/tree/master/resources/src? [14:16:01] marktraceur: There is no core js or less anymore, just one file for the dialog and the other to setup the link in the sidebar (I guess that won't go into core) [14:17:42] marktraceur: Also, I am not using uploadWithFormData yet :\ Will errors become easier to handle if I do? [14:21:13] prtksxna: You should use mw.Upload, not the API object anymore [14:21:16] It'll look a lot nicer [14:21:35] No error handling as yet, but we can build it into mw.Upload much easier [14:22:58] marktraceur: Are we using it somewhere already? [14:23:12] I wrote some gadgets at the hackathon. [14:23:17] One sec [14:23:26] prtksxna: http://en.wikipedia.beta.wmflabs.org/wiki/User:MarkTraceur/editPageUploadTool.js [14:24:04] prtksxna: See also http://en.wikipedia.beta.wmflabs.org/wiki/User:MarkTraceur/commonsUpload.js for an example of a CommonsUpload model class [14:24:06] marktraceur: Cool, I'll start using this [14:24:19] marktraceur: Should I move it to core? [14:24:23] I did http://en.wikipedia.beta.wmflabs.org/wiki/User:MarkTraceur/commonsUploadDialog.js for the upload-a-file-to-Commons upload dialog [14:24:31] prtksxna: Well...maybe. [14:24:41] prtksxna: You're talking about the stuff you removed, or the stuff that's left? [14:25:03] marktraceur: I am talking about just this one js file https://github.com/prtksxna/UploadUI/blob/master/modules/ext.upload.dialog.js [14:25:16] The setuplink thing is only for testing… [14:25:21] OK, I'm looking at that now...I'd guess core, but I'm going to verify, one sec [14:25:29] marktraceur: Thanks! [14:26:03] prtksxna: I see some UI construction in jQuery, is that avoidable? (we already have one UI framework, shame to introduce a second if we can avoid it) [14:26:36] marktraceur: Just making div's and such, no jQuery UI. Could move to plain old JS, yes. [14:26:45] Yeah, sure, OK, that's fine [14:27:07] I was just wondering why not new FormLayout() or new FieldsetLayout() or whatever, but this is OK for now [14:27:31] But the fields get created later, properly, fantastic [14:28:04] marktraceur: I am using those too, and for some reasons wrapping it all in a div and a panelLayout [14:28:08] prtksxna: I think it's going to be hard to subclass this, but it's a great start, and I bet it looks nicer than what I had :) [14:28:12] Maybe because its getting cold in Goa [14:28:18] Will get rid of it :P [14:29:10] marktraceur: I think I know of a way it could be subclassed, I might be absolutely wrong. I did understand _something_ when we last spoke of it, I'll explain that in the documentation, and if it doesn't make sense we'll figure out something else. [14:29:31] OK, sounds good [14:29:52] prtksxna: I liked the way I was going with my userscripts, maybe we can use that as a baseline, I can try to sketch it out if you'd like [14:30:13] marktraceur: That'd be nice! [14:30:28] OK! [14:30:45] https://etherpad.wikimedia.org/p/upload-tool-class-structure [14:31:46] marktraceur: I saw just one line, and was like, WAT? :P [14:41:24] Forgot how I did things, sigh [14:43:29] I think I sort of get it <-- that should boost anyone's confidence [14:43:29] prtksxna: OK, I think that's approximately what I did [14:43:35] Heh [14:43:41] I think once I take a look at the code a couple of times I'll get it [14:43:45] prtksxna: I'm pullin' for ya, we're all in this together [14:44:10] marktraceur: :) [14:44:17] marktraceur: I'll submit to core only after https://github.com/prtksxna/UploadUI/issues/ [14:44:22] Is that k? [14:45:58] I guess I'm wondering why not start working on a WIP patch in Gerrit [14:46:14] As long as the code is sufficiently generic as to apply to any MediaWiki upload [14:46:34] Its generic enough now, I guess [14:46:53] I'll move to Gerrit then [14:46:55] Like I could probably say something about "description" being a Commons-specific term but I doubt $coreReviewer will care (especially since it will probably be me) [14:47:05] +1 yay gerrit [14:48:47] * prtksxna nods [14:48:56] It goes into the text anyway [14:49:02] I should go make dinner now [14:52:24] And have an OO.ui.Dialog with my friends [14:53:08] * prtksxna doesn't know why he keeps doing this… [15:01:18] prtksxna: Maybe you could pack a picnic and have an OO.ui.FieldLayout [15:01:40] * marktraceur hopes James_F|Away is paying attention. [15:02:47] lololol [15:03:58] Don't feel like cooking, looking at a lot of OO.ui.MenuLayouts now [15:12:02] In other news, I'm sneezing like you wouldn't believe, I might not be useful for a little while here [15:20:57] marktraceur: No dying! [15:33:19] I'll do my beeeest [16:44:16] (03PS7) 10Kai Nissen (WMDE): [UploadWizard] Make button labels and targets configurable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/226522 (https://phabricator.wikimedia.org/T105285) [16:50:52] (03CR) 10Kai Nissen (WMDE): "@MarkTraceur: Thanks for reviewing that quickly, by the way!" (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/226522 (https://phabricator.wikimedia.org/T105285) (owner: 10Kai Nissen (WMDE)) [17:01:07] Hrm [19:06:38] 6Multimedia, 10Continuous-Integration-Infrastructure, 6operations, 5Patch-For-Review: Investigate impact of switching from ffmpeg to libav (ffmpeg is not in Jessie) - https://phabricator.wikimedia.org/T103335#1480470 (10brion) The state of video scaling in Trusty seems to be completely fubar if my testing... [19:18:10] 6Multimedia, 10Continuous-Integration-Infrastructure, 6operations, 5Patch-For-Review: Investigate impact of switching from ffmpeg to libav (ffmpeg is not in Jessie) - https://phabricator.wikimedia.org/T103335#1480526 (10brion) >>! In T103335#1480470, @brion wrote: > The state of video scaling in Trusty see... [19:57:21] 6Multimedia, 10MediaWiki-extensions-CommonsMetadata: data labels in imageinfo API don't make sense - https://phabricator.wikimedia.org/T71914#1480685 (10kaldari) @Tgr: I would suggest changing: * Artist to Author * Credit to FileSource (https://gerrit.wikimedia.org/r/#/c/107368) * ImageDescription to FileDescr... [22:25:05] 6Multimedia, 10Continuous-Integration-Infrastructure, 6operations, 5Patch-For-Review: Investigate impact of switching from ffmpeg to libav (ffmpeg is not in Jessie) - https://phabricator.wikimedia.org/T103335#1481198 (10MoritzMuehlenhoff) >>! In T103335#1480470, @brion wrote: > The state of video scaling i... [23:11:58] 6Multimedia, 10MediaWiki-File-management: Thumbnails no longer rendering for recent local uploads - https://phabricator.wikimedia.org/T106895#1481395 (10GOIII) [23:29:28] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10Sentry, 7Epic, and 2 others: Deploy Sentry (JavaScript error logging) to production, configured to log only UploadWizard - https://phabricator.wikimedia.org/T91649#1481528 (10Tgr) p:5High>3Normal